summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)Author
2016-04-12Avoid reserved identifierStephan Bergmann
Change-Id: I3b1505e788af009a0ff4bb2502883de5bfb45617
2016-04-12Avoid reserved identifierStephan Bergmann
Change-Id: If9c507146855fa23df576d038e9b2f0e3d69ac20
2016-04-12Avoid reserved identifierStephan Bergmann
Change-Id: I8adf61a63e6e6102a44cd18652192fde0a89287a
2016-04-12lp#1566050: prevent cyclic reference zombiesBjoern Michaelsen
regression, likely from 2660d24a07866e083c5135ea263030f3e3a2e729: 1/ Since that change mxAccessible in ScCsvGrid holds a rtl::Reference on a ScAccessibleCsvGrid 2/ Which in turn holds a VclPtr<> (aka a rtl::Reference with lipstick) on the ScCsvControl These are a circular references, making both of them live forever and leak past the point where on LibreOffice close all of Vcl is long gone, when these are dtored. Clearing mxAccessible on disposing should help. Change-Id: Iebb2635ec4ea143e7f0dbfebad2e6141a68e72e8 Reviewed-on: https://gerrit.libreoffice.org/24020 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-12clang-tidy performance-unnecessary-value-param in scNoel Grandin
Change-Id: Ia2255e1e3f7a8834a4b5d2a6bbab2c6dd498d356
2016-04-12cleanup: remove unused com/sun/star/uno includesJochen Nitschke
Sequence.h(xx), Any.h(xx) and Type.h(xx) and remove unused using-declarations from these files. Add a few missing includes provided by them. Change-Id: I6b91b6d1fdf9d0496dd546c0aab9bdcc6831a5d4 Reviewed-on: https://gerrit.libreoffice.org/23805 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-12clang-tidy performance-unnecessary-value-param in xmloffNoel Grandin
Change-Id: I8e6d8e66cdab2e50ee10882e139be29c14ce50f6
2016-04-11clang-tidy performance-unnecessary-value-param in formulaNoel Grandin
Change-Id: I9f90c55f74216c2f3452e5b30d85b304668330b3
2016-04-11tdf#84938 replace #defined constants with enum classJochen Nitschke
replace if constructs with switch remove temp variables tried to squeeze the enum in one of the 3 classes but it doesn't feel right anywhere. ScHeaderFooterContentObj doesn't use it, except for initialzing ScHeaderFooterTextObj. ScHeaderFooterTextData holds it but nothing more. ScHeaderFooterTextObj uses it but always has to get it via ScHeaderFooterTextData.GetPart() Change-Id: I838ebff2e116e24a1c9359d6652bf5b1d30da48a Reviewed-on: https://gerrit.libreoffice.org/23352 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-11tdf#94306 replace boost::noncopyable r.. to sdextJochen Nitschke
... in modules reportdesign to sdext Replace with C++11 delete copy-constructur and copy-assignment. Remove boost/noncopyable.hpp includes. Make some overloaded ctors explicit (most in sd slidesorter). Add deleted copy-assignment in sc/inc/chart2uno.hxx. Change-Id: I21d4209f0ddb00063ca827474516a05ab4bb2f9a Reviewed-on: https://gerrit.libreoffice.org/23970 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-11loplugin:constantparamNoel Grandin
Change-Id: Ie690088d7a7d568703afd22f544628fc8012a7e1
2016-04-10tdf#94429, tdf#92198, tdf#95233: STYLE in conditional formattingMarkus Mohrhard
This is only a quick ugly hack and not a real fix. Basically we need to prevent either using STYLE with more than one parameter in conditional formatting functions or forbid the usage of STYLE completely. In some way the usage of STYLE in conditional formatting means that our current conditional formatting is not yet perfect. STYLE inside of a conditional format is just insane from an evaluation perspective. Change-Id: Ia1cc8c8cc8f00c8d4a055b1c2d128de3e1f8e4fa
2016-04-09coverity#738785 reorg to silence Uninitialized pointer fieldCaolán McNamara
Change-Id: If2225e77215e2a6fb6b9e9dfc6021a2c20babe50
2016-04-09add test case for tdf#96549Markus Mohrhard
Change-Id: I2df85972b92a9caf780ccacec102e6a9cdd652a6 Reviewed-on: https://gerrit.libreoffice.org/23933 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-04-09import all formatting properties for column style, tdf#96549Markus Mohrhard
Change-Id: I782f3ea7cfa9af335bd117b9f4ad6ac9c719115b Reviewed-on: https://gerrit.libreoffice.org/23932 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-04-09add test case for tdf#98554Markus Mohrhard
Change-Id: I7437a1ed8dd915411f6014bc01d4224fe5604f1d
2016-04-09use the better color import method also for databars, tdf#98554Markus Mohrhard
Ideally we would move some of the magic here into the ThemeBuffer class but this requires a lot more test cases. Change-Id: I29adadda6b40cd1863ad3d68554acf7f27c57900
2016-04-09work around Excel theme color bug, tdf#98554Markus Mohrhard
Change-Id: Id0cd37b37394a0759ee6ffccafd8def719c14312
2016-04-08unit test for replacing fragments of shared formula groups, tdf#97897Eike Rathke
Change-Id: If17b0f812c33f338e7ff5af381c1ed17b9965eba
2016-04-08lok context menu: Expose context menuPranav Kant
Change-Id: I0968689630e10f838c075e86357eb36a9a220d0d
2016-04-07coverity#1358119 Uninitialized scalar fieldCaolán McNamara
arguably a false positive seeing as coverity ignores implicit default ctors but not explicit ones Change-Id: Id01f6a2728c197239563081c92275d44869b5d96
2016-04-07add test for tdf#99093Markus Mohrhard
Change-Id: Id47abea42867f418e80a40357baa5f6435ecbdd6
2016-04-07we need the position in the formula converter, tdf#99093Markus Mohrhard
Change-Id: Ic3dd13aa4d4b8190b78f3e6f1cdda844e39cc719 Reviewed-on: https://gerrit.libreoffice.org/23884 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-04-07ScHeaderFooterTextData default ctor had been added in errorStephan Bergmann
...with be3c2ff9233e8d4c5afe9c696cb5a60b24b25efc "tdf#94306 Replace boost::noncopyable with plain C++11 deleted copy ctors" Change-Id: I817b96fea3056f5d9914e5d1c829d07ca9755d34
2016-04-07Resolves: tdf#97897 (re)broadcast if formula groups were splitEike Rathke
DeleteSelection() and DeleteSelectionTab() remove listeners for split formula groups, broadcast change after listeners of new groups have been established. Change-Id: I017e92b5cbc5f866768f3732e9997028c0c065fa
2016-04-07fix indentationMarkus Mohrhard
Change-Id: I1d1f127e10390246c6bf887cb7d847199be4e091 Reviewed-on: https://gerrit.libreoffice.org/23883 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-04-06(re)broadcast, same as in ScDocument::SetString(), tdf#97897 relatedEike Rathke
As with ce28d83912d14bc81c455af64893842de78a8c8d Change-Id: I7cd30509138368d73b43c82d71d520d55417d416
2016-04-06(re)broadcast if value replaces cell of grouped formulas, tdf#97897 relatedEike Rathke
Replacing a grouped formula cell with a different content may lead to the remaining cells of the group not being recalculated if they listen to a range that contains the current position. For example A1: 1 A2: =SUM($A$1:$A1) => 1 A3: =SUM($A$1:$A2) => 2 Enter 2 in A2 => A3 should be 3 but is not recalculated. Loading http://bugs.documentfoundation.org/attachment.cgi?id=122714 of tdf#97897 exhibits that behavior. Change-Id: I10b91e77549a7534143be3d6e3cc03026cdaa764
2016-04-05Resolves: #i126901# CSV import: values with + or - followed by...Damjan Jovanovic
thousand separator and 3 digits (eg. +,123) are imported as a number Do not allow numbers parsed from CVS files when "Detect special numbers" is off, to contain thousand separators before digits, even if after a +/- sign (eg. -,123 or +,789). Treat these as strings instead. Also added unit tests for this. Patch by: me (cherry picked from commit 10458a24f4e6cc311e65fb80ce576fed39937be2) Change-Id: Ic946fc6a11326861f238157ddb651bc5a5b28edd
2016-04-05Resolves; tdf#87120 no keyboard navigation inside floating windowsCaolán McNamara
lets try and treat these the same as we do normal toplevels like dialogs if they popup with GrabFocus. This way focus can be set on widgets inside the floating windows, and so keyboard traversal of widgets etc all works. Change-Id: If447429756cf5d136b9c2e2f62fafb37c167b1ce
2016-04-05Resolves: tdf#98990 accept R1C1 notation entire column/row referencesEike Rathke
... which consist of only C4 or C[3] without a range operator. Change-Id: I1865f0ec4c4fec1101b93b6b40d6f26871a65f07
2016-04-05tdf#94306 Replace boost::noncopyable with plain C++11 deleted copy ctorsSteven Guo
Replaced boost::noncopyable with play C++11 deleted copy ctors in sc/inc/* files. Change-Id: I2e6310f2f2bac673dd3b5d14e80ce80a98795672 Reviewed-on: https://gerrit.libreoffice.org/23059 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-04-04loplugin:constantparam in sfx2Noel Grandin
Change-Id: I9a5a9fd1f4f43e0b7ef13d14979cb231f6aa9d46 Reviewed-on: https://gerrit.libreoffice.org/23801 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-04cppcheck: noExplicitConstructorCaolán McNamara
Change-Id: I68310e2abc8f0ca114adb2b52f82157a0f455202
2016-04-04coverity#708016 Uninitialized scalar fieldCaolán McNamara
Change-Id: I6ec7614eab32f08596f259ef445a999cbb8b69e8
2016-04-04cppcheck:passedByValueNoel Grandin
Change-Id: Ideb62ec1838463f65fc763650294e4fa311567f1 Reviewed-on: https://gerrit.libreoffice.org/23797 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-04tdf#97499 Fixed containers parameters clearing #4tymyjan
Change-Id: I7c96181399f4d7e62d4aceca404b22d68f903513 Reviewed-on: https://gerrit.libreoffice.org/23754 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-04tdf#97499 Fixed containers parameters clearing #3tymyjan
Change-Id: I1c105de7e1df251533179fba77e3797ef1c4e2d4 Reviewed-on: https://gerrit.libreoffice.org/23752 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-02cleanup: remove unused Reference.h(xx) includesJochen Nitschke
and unused using-declarations from Reference.h Change-Id: I297a7ae6044fa329d245ecf08fd5c4cb930f5b19 Reviewed-on: https://gerrit.libreoffice.org/23735 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-04-01we have an empty Sequence anyway, use it; cleanup follow-upEike Rathke
Change-Id: Ie7f3881a24e4bda09785b1d464fd2d2431a04e81
2016-04-01sequence->vector in scNoel Grandin
Change-Id: Iebf0aae6a3141430c43988e91d50f07b1c629e04 Reviewed-on: https://gerrit.libreoffice.org/23698 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-04-01sequence->vector in scNoel Grandin
Change-Id: I23edfbacb9ad0fb11ac8e6f789a73367f043eeda Reviewed-on: https://gerrit.libreoffice.org/23697 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-04-01copy used names to other doc, not only referencing sheet; tdf#56518Eike Rathke
Change-Id: I434663a2ffe9b0565cabcf210c643ec57c7ba07b
2016-04-01early bail out only on same docEike Rathke
... and rename that variable to what it actually does.. Change-Id: Ifd6b9a612d8a8dbc700e42eeb5a732295af283a3
2016-04-01harmonize the nNewSheet handlingEike Rathke
Letting copyRangeName() modify nNewSheet wasn't good and could had lead to a mismatch of sheets between looking up a name and inserting it. Instead, determine the values in adjustRangeName(). Change-Id: I68e8b025a1a1ce81bc4c62a7c0450f1bb661454f
2016-04-01tdf#94306 Replace boost::noncopyable in sc/sourceJochen Nitschke
and sc/workben with C++11 delete copy ctors add default ctors needed missing delete some ctors instead of making them private Change-Id: I0a131f95444ef040e5d580d8326f372b8167e19b Reviewed-on: https://gerrit.libreoffice.org/23717 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-04-01cleanup ScAccessibleSpreadsheet::getSelectedAccessibleColumnsNoel Grandin
use early return Change-Id: I8dea61cb095ae31ad7deb8c4191c5ecf9810d9cd
2016-04-01tdf#97966 Drop 'static' keywordsWastack
Including no keywords from extern "C" blocks Change-Id: I87f2ed75888b51ec9e0cb75566bf7c2351b479b4 Reviewed-on: https://gerrit.libreoffice.org/23675 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-04-01re-enable copying global names to other docsEike Rathke
Change-Id: Ide022525decbbec1fb4a498074752615786daab4
2016-03-31unit test for copying nested names during copying sheetEike Rathke
Change-Id: Id165e7e2ce229949b919424338a4938e15aaab4d
generated by cgit (git 2.34.1) at 2025-01-27 13:32:13 +0000