summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)Author
2019-11-27jsdialogs: dumpAsJSON for SfxItems with FillGradient exampleSzymon Kłos
Change-Id: I1b9303af6f52ad071074200bb630c587c8f611c1 Reviewed-on: https://gerrit.libreoffice.org/83875 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2019-11-27tdf#129027: Expand scrolledwindow if parent is resizedXisco Fauli
Reproduced in gen Change-Id: I57d7deb7d9e51cc6d01e19597e5b6937398a90a9 Reviewed-on: https://gerrit.libreoffice.org/83904 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org> Tested-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-11-27sc: rowcol: tdf#50916 add UI to turn jumbo sheets onNoel Grandin
Change-Id: I9e50c38f38acdf5a275b125e9e421a6c6af6d590 Reviewed-on: https://gerrit.libreoffice.org/83661 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-27jsdialogs: send .uno:FillStyle updates in CalcSzymon Kłos
Change-Id: I51682546a3c8fd4ee6d97cf8bf79d066e571addf Reviewed-on: https://gerrit.libreoffice.org/83386 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/83780 Tested-by: Jenkins
2019-11-27Remove unused return_type templateStephan Bergmann
unused since 1c2405ba44c5a146188c19e235f857ab18ea05f0 "tdf#89387 General functor and basic operations" (found by upcoming loplugin:unusedmember, which identified each of the two explicit specializations' sole member as unused) Change-Id: I275137cc70cbe4e58a728779e7e7593c5e11224b Reviewed-on: https://gerrit.libreoffice.org/83836 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-27Remove unused sc/qa/unit/ucalc_*.cxx dataStephan Bergmann
(found by upcoming loplugin:unusedmember) Change-Id: I2ed1fd158779716297a93fade34b1cf541c44aba Reviewed-on: https://gerrit.libreoffice.org/83818 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-26xmloff,sw: fix handling of invalid attribute with multiple ':'Michael Stahl
ooo53770-1.odt contains an invalid attribute style:style:use-optimal-row-height, which was round-tripped as an unknown attribute, triggering the assert in CheckValidName(). This reveals a confusing mess of SvXMLNamespaceMap::GetKeyByAttrName functions. The bCache flag for one of them was accidentally inverted in commit 78f0d15893c56d7368ddd7ded4e70f2a3bb9d2f4 "loplugin:constantparam in xmloff/" There are basically 2 use cases for this: * XML element and attribute names, which are XML QName and contain at most 1 ':' * XML attribute values, which are namespace-prefixed and may contain any number of ':' in the "local" part of the value Because caching is explicitly disabled for Calc formulas, just resolve the inconsistent bCache by always caching element and attribute names, and never caching attribute values, so we need just 1 flag. Change-Id: I363ea2229d0bf5c7199d61b0fee0d9f168911bfa Reviewed-on: https://gerrit.libreoffice.org/83619 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-26lok: calc formula bar tunneling: function list callbackMarco Cecchetti
Added a lok callback for sending the list of functions matching the current characters typed by the user. Change-Id: Ia971fc55ec5eb961b4098592a8049dd0eed3ba14 Reviewed-on: https://gerrit.libreoffice.org/83750 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-11-26Resolves: tdf#129027 make manage names resizableCaolán McNamara
Change-Id: I8b82c3dfbf07ddb565d767a223c2c46b924a29e8 Reviewed-on: https://gerrit.libreoffice.org/83733 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-26uitest for bug tdf#122232Zdeněk Crhonek
Change-Id: I40045b46f5cf8063e41211f9f7ea55e712036cd2 Reviewed-on: https://gerrit.libreoffice.org/83713 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2019-11-25Remove some redundantly user-declared copy ctors and assignment opsStephan Bergmann
...that trigger -Werror,-Wdeprecated-copy ("definition of implicit copy {constructor, assignment operator} for ... is deprecated beause it has a user-declared copy {assignment operator, constructor}") new in recent Clang 10 trunk (and which apparently warns about more cases then its GCC counterpart, for which we already adapted the code in the past, see e.g. the various "-Werror=deprecated-copy (GCC trunk towards GCC 9)" commits) Change-Id: Ie37bd820e6c0c05c74e1a862bb1d4ead5fb7cc9c Reviewed-on: https://gerrit.libreoffice.org/83698 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-25sc: disable tdf91217 UITest for nowMiklos Vajna
It passed Jenkins once, but it times out for me locally and it regularly also times out on Jenkins. Disable this till the root cause is identified and fixed. Change-Id: I0501407fb8362c5e1d965e5bf1bdec7fa50b572a Reviewed-on: https://gerrit.libreoffice.org/83684 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Miklos Vajna <vmiklos@collabora.com>
2019-11-25sc: rowcol: tdf#50916 convert segmenttreeNoel Grandin
Change-Id: Ia05d1bc60a76a8bbf65afe5b0459ce213be9bfbe Reviewed-on: https://gerrit.libreoffice.org/83646 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-24cppcheck: performing init in init list (sc/scripting/sd)Julien Nabet
Change-Id: I8bd4c1b7b551a96ecd5a2b50fbfdf225567175f6 Reviewed-on: https://gerrit.libreoffice.org/83621 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-11-24tdf#128976: properly calculate default value when writing XLSMike Kaganski
XLS stores default column width as 16-bit unsigned integer in the range from 0 to 255 inclusive ([MS-XLS] 2.4.89 DefColWidth), unlike in OOXML where any floating-point value is valid. Additionally, some correction is used, introduced in commit 555d702903fb0857122024e1ab78a72d122d3f16 (basis of empirical formula in XclTools::GetXclDefColWidthCorrection is unclear). So in XLS, when the default is calculated, we need to take into account if the resulting stored value will actually represent our calculated value. If not, then just ignore the calculated value, and use arbitrary 8 as the default. With that, following IsDefWidth will correctly check if passed width is represented by the stored default or not. All widths that can't be represented as integral count chars in DefColWidth will have fUserSet set in corresponding ColInfo records, thus correctly keeping widths. Change-Id: Iedcc5583c861f5b18a422a9b279c48cff729cbc5 Reviewed-on: https://gerrit.libreoffice.org/83613 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-11-23uitest for bug tdf#91217Zdeněk Crhonek
Change-Id: I0322a3bc821850d5f15aeb690ba80ff7b8129140 Reviewed-on: https://gerrit.libreoffice.org/83546 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2019-11-22Fix typoAndrea Gelmini
Change-Id: Ibf2e90ff53f201d7b1f279c11eb8238eb403c05e Reviewed-on: https://gerrit.libreoffice.org/83533 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-11-22make some classes module-privateNoel Grandin
Change-Id: If7303a082e06f6937fca911c578a40475546cda2 Reviewed-on: https://gerrit.libreoffice.org/83442 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-22tdf#128951: restore passing nullptr to ScTableSheetObj when not inserted yetMike Kaganski
This partially reverts 009e7a54f40ebacd9dd4a394504c277789699801 Change-Id: I5a9605ff9d0ff1cd825968fb247b2a3bf4b2902a Reviewed-on: https://gerrit.libreoffice.org/83464 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-11-22tdf#128894: unit test for the bugfixDennis Francis
Change-Id: Ic6d3910f12409f5af541c887760caefcb78b30f9 Reviewed-on: https://gerrit.libreoffice.org/83362 Tested-by: Jenkins Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2019-11-22tdf#128894: xlsx-import : Do not share tokens between cells...Dennis Francis
which are part of a xlsx-shared-formula along a *row*. If we do, any reference-updates on these cells while editing will mess things up. For example a shared formula "=A30+1" used for a few cells in the first row (say, A1, B1, C1 and D1) and on deleting a row, say row#5, the reference update operation will decrement the row index of all tokens in A1, B1, C1 and D1. But if they share tokens, they all end up pointing to row#26 instead of row#29 as each cell is updated which amounts to decrementing 4 times instead of once. However shared formulas along columns are not affected by this bug, when tokens are shared since we use formula-groups which only keeps one copy of token array for the entire group and reference-update code is designed to correctly work with formula-groups. Change-Id: Ic0fe84d12fef18fbf21658664e2b2b86409bca27 Reviewed-on: https://gerrit.libreoffice.org/83361 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com> Reviewed-by: Eike Rathke <erack@redhat.com>
2019-11-22Extend loplugin:external to warn about classesStephan Bergmann
...following up on 314f15bff08b76bf96acf99141776ef64d2f1355 "Extend loplugin:external to warn about enums". Cases where free functions were moved into an unnamed namespace along with a class, to not break ADL, are in: filter/source/svg/svgexport.cxx sc/source/filter/excel/xelink.cxx sc/source/filter/excel/xilink.cxx svx/source/sdr/contact/viewobjectcontactofunocontrol.cxx All other free functions mentioning moved classes appear to be harmless and not give rise to (silent, even) ADL breakage. (One remaining TODO in compilerplugins/clang/external.cxx is that derived classes are not covered by computeAffectedTypes, even though they could also be affected by ADL-breakage--- but don't seem to be in any acutal case across the code base.) For friend declarations using elaborate type specifiers, like class C1 {}; class C2 { friend class C1; }; * If C2 (but not C1) is moved into an unnamed namespace, the friend declaration must be changed to not use an elaborate type specifier (i.e., "friend C1;"; see C++17 [namespace.memdef]/3: "If the name in a friend declaration is neither qualified nor a template-id and the declaration is a function or an elaborated-type-specifier, the lookup to determine whether the entity has been previously declared shall not consider any scopes outside the innermost enclosing namespace.") * If C1 (but not C2) is moved into an unnamed namespace, the friend declaration must be changed too, see <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71882> "elaborated-type-specifier friend not looked up in unnamed namespace". Apart from that, to keep changes simple and mostly mechanical (which should help avoid regressions), out-of-line definitions of class members have been left in the enclosing (named) namespace. But explicit specializations of class templates had to be moved into the unnamed namespace to appease <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=92598> "explicit specialization of template from unnamed namespace using unqualified-id in enclosing namespace". Also, accompanying declarations (of e.g. typedefs or static variables) that could arguably be moved into the unnamed namespace too have been left alone. And in some cases, mention of affected types in blacklists in other loplugins needed to be adapted. And sc/qa/unit/mark_test.cxx uses a hack of including other .cxx, one of which is sc/source/core/data/segmenttree.cxx where e.g. ScFlatUInt16SegmentsImpl is not moved into an unnamed namespace (because it is declared in sc/inc/segmenttree.hxx), but its base ScFlatSegmentsImpl is. GCC warns about such combinations with enabled-by-default -Wsubobject-linkage, but "The compiler doesn’t give this warning for types defined in the main .C file, as those are unlikely to have multiple definitions." (<https://gcc.gnu.org/onlinedocs/gcc-9.2.0/gcc/Warning-Options.html>) The warned-about classes also don't have multiple definitions in the given test, so disable the warning when including the .cxx. Change-Id: Ib694094c0d8168be68f8fe90dfd0acbb66a3f1e4 Reviewed-on: https://gerrit.libreoffice.org/83239 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-22tdf#124513 let wizard reappear on tabbing back to documentCaolán McNamara
where it was showing before tabbing away Change-Id: Ia87aeb9789ae034611431983c6489569a59d47d3 Reviewed-on: https://gerrit.libreoffice.org/83434 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-21ScQueryParam can be allocated inline in ScQueryCellIteratorNoel Grandin
Change-Id: I9debf80755a3950cc34be280af8006e52006b14a Reviewed-on: https://gerrit.libreoffice.org/83313 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-21tdf#47490: Show overwrite warning when pasting data using "Enter"Aditya
In Calc when a cell is copied and its value is filled/pasted to different cell(s) by using the "Enter" key when focus is on selected cells -- replace warning is not shown even if the selected cells have values of their own inside it. The old data is simply lost. Provide a replace warning dialog box whenever such a case is encountered. Change-Id: I13acb424bc449e096512b5a0864ebc47a407f234 Reviewed-on: https://gerrit.libreoffice.org/83333 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-11-21If a SdrOle2Obj object is missing/broken show the preview set for itCaolán McNamara
if the object isn't valid, e.g. link to something that doesn't exist, set the fallback graphic as mxGraphic so SdrOle2Obj::GetGraphic will show the fallback, otherwise the failing mxObjRef.is test in SdrOle2Obj::GetGraphic means it doesn't get used Change-Id: I8f1aea6b25dc216e01a0f888a44d10876bb1bebd Reviewed-on: https://gerrit.libreoffice.org/83322 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-20Turn useless OSL_FAIL/OSL_ENSURE into assert()Eike Rathke
Change-Id: Idc1cbb5ba7580963dd47f293d4104998d1f0095d Reviewed-on: https://gerrit.libreoffice.org/83218 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2019-11-20tdf#128812 speed up loading calc doc with lots of countifNoel Grandin
by creating a copy of ScQueryCellIterator that is specialised for this use-case. Takes the opening time from 50s to 8s on my machine. Change-Id: I193a7c181a5dfed6fecf75e871729d73625d0df6 Reviewed-on: https://gerrit.libreoffice.org/83299 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-20loplugin:unusedmethodsNoel Grandin
Remove a filtering step in the python script that was hiding some results Change-Id: Id94268f150902405ab197c077f18aaedf98845fc Reviewed-on: https://gerrit.libreoffice.org/83256 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-20cid#1399334 Uncaught exceptionCaolán McNamara
and cid#1399224 Uncaught exception cid#1399153 Uncaught exception cid#1399090 Uncaught exception Change-Id: Icbafde4a1e1bd1713c25a20337f3e2d0f4103cad Reviewed-on: https://gerrit.libreoffice.org/83240 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-20Options - calc - Calculate Dialog updateandreas kainz
Change-Id: Idc82bbbd7d3be045e70fe297a130f7b9197df9c9 Reviewed-on: https://gerrit.libreoffice.org/83146 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-11-19Options - calc - View Dialog updateandreas kainz
Change-Id: I4de99b93c3c3610d2ce5b19d44c1d12589a72e09 Reviewed-on: https://gerrit.libreoffice.org/83145 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-11-19Fix typoAndrea Gelmini
Change-Id: I5ae932e727eb3bb4cef3f7e160c3ace32e3f7d47 Reviewed-on: https://gerrit.libreoffice.org/83225 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-11-19don't crash if a linked to object is deleted after the doc is loadedCaolán McNamara
Change-Id: Ia6ab1261745d223dcf84b638edf6a64d46bc6f4b Reviewed-on: https://gerrit.libreoffice.org/83201 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-19cid#1448453 Untrusted value as argumentCaolán McNamara
Change-Id: I41a2f30df22b54e51acb593f340cb1ecf1c497b6 Reviewed-on: https://gerrit.libreoffice.org/83037 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-19Related: tdf#125917 remove active editing when we want to replace contentsCaolán McNamara
this addresses comment #6 so that the chosen value is entered in the cell Change-Id: I3b45301e00b2f79038e88c926f15babd49dcc2bf Reviewed-on: https://gerrit.libreoffice.org/83085 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-19tdf#125917 Ensure mouse is captured before the menu is launchedCaolán McNamara
calc seems to excessively capture the mouse and grabs + floats are messy across the different ports. But We usually have the mouse captured before calling the menu, except if we are editing a cell, an additional capture here will ensure the grab status is the same in both modes and that events go to the same place in either case. Change-Id: I213560273be1a6a398d6a1787a53d64501c473f0 Reviewed-on: https://gerrit.libreoffice.org/83130 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-19Related: tdf#125917 release mouse grab before showing warning dialogCaolán McNamara
Type text into the data validity dropdown cell and click elsewhere. The warning dialog cannot be interacted with due to the active mouse grab to its parent Change-Id: I51702c828dee6ec88106f7d44d7e3440f2e61298 Reviewed-on: https://gerrit.libreoffice.org/83128 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-19cid#1399259 Uncaught exceptionCaolán McNamara
Change-Id: Ia811eeb04cb9ab86aea205aa848e210fc34ab9d6 Reviewed-on: https://gerrit.libreoffice.org/83072 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-19tdf#97926 Add UNO API for InfobarSamuel Mehrbrodt
This allows creating, updating and removing infobars from macros/extensions. It also extends the infobar with a primary and a secondary text, so there can be a bold summary at the beginning at the infobar with a longer text following in normal letters. Macro sample: ------------------------------------------------------------ Sub AddInfobar dim buttons(1) as new com.sun.star.beans.StringPair buttons(0).first = "Close doc" buttons(0).second = ".uno:CloseDoc" buttons(1).first = "Paste into doc" buttons(1).second = ".uno:Paste" ThisComponent.getCurrentController().appendInfobar("my", "Hello world", "Things happened. What now?", com.sun.star.frame.InfobarType.INFO, buttons, true) End Sub Sub UpdateInfobar ThisComponent.getCurrentController().updateInfobar("my", "WARNING","Do not read this message.", com.sun.star.frame.InfobarType.WARNING) End Sub Sub RemoveInfobar ThisComponent.getCurrentController().removeInfobar("my") End Sub ------------------------------------------------------------ Change-Id: I5d0a223525845d23ffab17acdaa431e0eb783fec Reviewed-on: https://gerrit.libreoffice.org/29816 Reviewed-by: Serge Krot (CIB) <Serge.Krot@cib.de> Tested-by: Serge Krot (CIB) <Serge.Krot@cib.de> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-11-18crashtesting fdo78617-2.odsNoel Grandin
as a consequence of commit feec8e3c34e08b621098a17f1011dccd0b4f7f4c Date: Tue Nov 12 16:00:55 2019 +0200 reduce iteration in ScViewData::GetScrPos Change-Id: Iec539c33bd80b9ad2d2a3698d443c5cec81f8f85 Reviewed-on: https://gerrit.libreoffice.org/83093 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-18cid#1399260 Uncaught exceptionCaolán McNamara
Change-Id: I975716ae1f7406af57cc4141f4cbdb9e5e4c4bd2 Reviewed-on: https://gerrit.libreoffice.org/83074 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-18cid#1448537 silence Wrapper object use after freeCaolán McNamara
Change-Id: I896556485c441c9d0e79e75f41d0eb452f0eb21f Reviewed-on: https://gerrit.libreoffice.org/83069 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-18tdf#103092 export uses MeasureUnit not FieldUnitRegina Henschel
ctor of SvXMLExport expects a util::MeasureUnit, but getMetric() from XGlobalSheetSettings returns a FieldUnit. The conversion was missing. So FieldUnit::MM (=1) was treated as MeasureUnit::MM_10TH (=1). But that one has no unit string, so the 'translate' transformation got numbers without unit, which then were wrongly interpreted. Change-Id: I433c7534be21655887863005f14836d2b733cf1f Reviewed-on: https://gerrit.libreoffice.org/83004 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2019-11-18cid#1249470 Uninitialized scalar fieldCaolán McNamara
use comment as an annotation Change-Id: Ia8b5ba157d0d240c4a3e6beed74d66e6d34d1a32 Reviewed-on: https://gerrit.libreoffice.org/83067 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-18convert AccessibilityFlowTo to scoped enumNoel Grandin
and drop the unused FORSPELLCHECKFLOWTO Change-Id: I128e84d386c10d001aa63f93b4b6dcb7238a1242 Reviewed-on: https://gerrit.libreoffice.org/83060 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-18Options calc general tab only one columnandreas kainz
Change-Id: Iba382f28695ed4452151a7576727114ba99afea9 Reviewed-on: https://gerrit.libreoffice.org/83042 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-11-17cid#1430084 Arguments in wrong orderCaolán McNamara
add an annotation Change-Id: Id3b90eae8a2306cfb7f0f46b3fd73e320c851f6a Reviewed-on: https://gerrit.libreoffice.org/83029 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-17Extend loplugin:external to warn about enumsStephan Bergmann
To mitigate the dangers of silently breaking ADL when moving enums into unnamed namespaces (see the commit message of 206b5b2661be37efdff3c6aedb6f248c4636be79 "New loplugin:external"), note all functions that are affected. (The plan is to extend loplugin:external further to also warn about classes and class templates, and the code to identify affected functions already takes that into account, so some parts of that code are not actually relevant for enums.) But it appears that none of the functions that are actually affected by the changes in this commit relied on being found through ADL, so no adaptions were necessary for them. (clang::DeclContext::collectAllContexts is non-const, which recursively means that External's Visit... functions must take non-const Decl*. Which required compilerplugins/clang/sharedvisitor/analyzer.cxx to be generalized to support such Visit... functions with non-const Decl* parameters.) Change-Id: Ia215291402bf850d43defdab3cff4db5b270d1bd Reviewed-on: https://gerrit.libreoffice.org/83001 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-16cid#1448453 Untrusted value as argumentCaolán McNamara
coverity doesn't warn about XclImpString::ReadFormats Change-Id: Ide6285f39fed09a1767c2a2272f30ec213a20106 Reviewed-on: https://gerrit.libreoffice.org/82993 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2025-02-15 12:20:37 +0000