summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)Author
2018-10-15loplugin:constfields in scNoel Grandin
Change-Id: If326175d571d15752efd1b63df45b2bc785f7541 Reviewed-on: https://gerrit.libreoffice.org/61653 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-14MoreButton is solely used by toolkitCaolán McNamara
Change-Id: Ieb436b49be3598e316d59a6d89cb211879d061c1 Reviewed-on: https://gerrit.libreoffice.org/61766 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-14drop unnecessary vcl/group.hxx includesCaolán McNamara
Change-Id: I09d86ee7e156ac71d7c1f9fd58d43751037d2629 Reviewed-on: https://gerrit.libreoffice.org/61761 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-13Fix a weird checkbox label in Calc’s recalculation promptAdolfo Jayme Barrientos
GTK+’s dumb defaults strike again! Similar to 7da61ec6d8ab6312b45ef7d683f3ec24e6b2b570. Found while triaging tdf#120513. Change-Id: I9ade695184cbcc9f1de9f11b20aa751754263586
2018-10-12coverity#1440239 Uncaught exceptionCaolán McNamara
Change-Id: I2b744d70ab426fbf26bcb3762aafaa569d0aafc7 Reviewed-on: https://gerrit.libreoffice.org/61675 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-12Simple translation passing by...Andrea Gelmini
Change-Id: I643e8bdf6b88d53f41008e41ac04fbf49696c3a2 Reviewed-on: https://gerrit.libreoffice.org/61707 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2018-10-12Conditional formatting: Allow to set the icon set CF via .uno: command.Jan Holesovsky
When .uno:IconSetFormatDialog gets a parameter, it directly creates the icon set conditional formatting with pre-selected values. Change-Id: I75dda90e5ea9c191254acc24c564cda7b27243a5 Reviewed-on: https://gerrit.libreoffice.org/56429 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk> Reviewed-on: https://gerrit.libreoffice.org/61669 Tested-by: Jenkins Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2018-10-11tdf#119580 sc: Use the regular object popupmenu for chartsMaxim Monastirsky
Context menu of a chart is supposed to be the same as for other ole objects, except the additional .uno:ExportAsGraphic. Given that .uno:ExportAsGraphic is hidden when non-chart object is selected, we can just place it in the regular ole object popupmenu (done already), and use that menu also for charts. Discussion is in https://gerrit.libreoffice.org/60128 . Change-Id: I8a07c550998e1db0d2af7f87c625dbd258454bdd Reviewed-on: https://gerrit.libreoffice.org/61678 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2018-10-11Remove superfluous separatorMaxim Monastirsky
Change-Id: I12f7ebf8cb40c5c1ea40509ac38ae977e1abca89 Reviewed-on: https://gerrit.libreoffice.org/61677 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2018-10-11tdf#120528: check for empty mpMouseEvent in ScDataTableView::MouseButtonUpMike Kaganski
The preceeding mouse button down event could happen in a different (closing) window, like context menu. Change-Id: I630b827fb5fe05399ca8436ea79210f4642a56d4 Reviewed-on: https://gerrit.libreoffice.org/61691 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-10-11Resolves: tdf#120476 need to be resizable if number of tabs is variableCaolán McNamara
across runs Change-Id: Ie77512557c10f564ed9d2dab837b134e9b4834a1 Reviewed-on: https://gerrit.libreoffice.org/61672 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-11Resolves: tdf#90698 catch list (1;2) of non-references as errorEike Rathke
Change-Id: Icc6f93bbf85df245ba332ce89791a1c8d266b1c6 Reviewed-on: https://gerrit.libreoffice.org/61639 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2018-10-11tdf#111980 oox optionbutton autoGroup inside GroupBoxJustin Luth
The area of a GroupBox indicates which radio buttons are considered to be part of the same group. The button needs to be fully inside of the groupbox in order to participate. This patch resolves the last worry of commit 9f969799629fe6bdf8b922d8cb922846aa646ece Change-Id: Ie6057337c63bf9eb173a0615e30c8d4e4d0c7a19 Reviewed-on: https://gerrit.libreoffice.org/61131 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-10-10tdf#120410: Disable insert/delete row/page break in read-only modeXisco Fauli
Change-Id: Idbc81467c57c8e597e5065ef316bc4c5773b695b Reviewed-on: https://gerrit.libreoffice.org/61602 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2018-10-10optimize adding a block of entries at one timeCaolán McNamara
Change-Id: I9a59154fa445cf3c44ede3ceb1d09f408d906530 Reviewed-on: https://gerrit.libreoffice.org/61618 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-10make VLOOKUP in Calc thread-safeLuboš Luňák
There is mutex protection needed for accessing the same SvtBroadcaster when calling StartListeningArea(). Also some of the memory management and caching needed fixing. Change-Id: Ia57ed85286cf195521719cfd3b320f73a6342bb1 Reviewed-on: https://gerrit.libreoffice.org/61187 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2018-10-10fix detection of self-referencesLuboš Luňák
If the reference points to another sheet, it obviously cannot be a self-reference. Change-Id: I3290660e6ed679c84036ab4e65a55bdb369a64e9 Reviewed-on: https://gerrit.libreoffice.org/61188 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2018-10-10ColumnSpanSet variant optimized for just one ScRangeLuboš Luňák
Since ScInterpreter::IterateParameters() iterates over just one range, there's no point to to set flags for that range and then generically walk over that range, just directly use the range. Change-Id: I13003eb09bd98f145e9ead5e485596168d9399cb Reviewed-on: https://gerrit.libreoffice.org/60866 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2018-10-10do not needlessly create ScTokenArray copies in Calc input filtersLuboš Luňák
It doesn't make much sense to keep around one ScTokenArray, pass it around, use a copy of it and then Clear() the original. Change-Id: I8636b32dc9b547b4b649c8d811c8425530896100 Reviewed-on: https://gerrit.libreoffice.org/60863 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2018-10-10add ScTokenArray::Finalize() to explicitly reduce memory usageLuboš Luňák
Since ScTokenArray::Add() overallocates memory, make sure we do not keep such possibly large arrays. Since any copying of ScTokenArray implicitly finalizes as well, this is not a big problem right now, but then why needlessly do the copies? (next commit) Change-Id: I55398bcd8fb31f1be5a4b8e3f5a71b26649a7594 Reviewed-on: https://gerrit.libreoffice.org/60862 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2018-10-09Resolves: tdf#66545 display URL fields non-shaded in CalcEike Rathke
This disables shading of URL and email address fields when displaying cell content and still preserves shading in the Input Line and when editing cell content to indicate that it is actually a field content value. Change-Id: I8737045168646b6cd446bd357713ec9ac4631b31 Reviewed-on: https://gerrit.libreoffice.org/61594 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2018-10-09add some more pluralized form examplesCaolán McNamara
Change-Id: I7163577fb43f28c8c9c138ebf3a9d36586247a32 Reviewed-on: https://gerrit.libreoffice.org/61587 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-09tdf#120264 - Access to "Get Involved"heiko tietze
UNO command SID_GETINVOLVED added with access to the website from all main menus under Help Dispensable ellipsis removed from other UNO commands around Help Change-Id: I79536be3de31f55a7b208bcdd5a243e05b3d3668 Reviewed-on: https://gerrit.libreoffice.org/61238 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-10-09Extend loplugin:redundantinline to catch inline functions w/o external linkageStephan Bergmann
...where "inline" (in its meaning of "this function can be defined in multiple translation units") thus doesn't make much sense. (As discussed in compilerplugins/clang/redundantinline.cxx, exempt such "static inline" functions in include files for now.) All the rewriting has been done automatically by the plugin, except for one instance in sw/source/ui/frmdlg/column.cxx that used to involve an #if), plus some subsequent solenv/clang-format/reformat-formatted-files. Change-Id: Ib8b996b651aeafc03bbdc8890faa05ed50517224 Reviewed-on: https://gerrit.libreoffice.org/61573 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-10-09loplugin:unusedmethodsNoel Grandin
Change-Id: Icd7a0f9909f36363b307b4fe7ee920183881afbb Reviewed-on: https://gerrit.libreoffice.org/61576 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-09use unique_ptr in SfxUndoManager::AddUndoActionNoel Grandin
Change-Id: I11483e3cece12a7373f4276972b4c899edf1ce15 Reviewed-on: https://gerrit.libreoffice.org/61566 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-09sc: Enhance binary search for ScAttrArraySerge Krot
Change-Id: Idf417c452dbbadbede0e3f0860cce7a8a6fd308e Reviewed-on: https://gerrit.libreoffice.org/61517 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-10-09Related: tdf#83128 support translation of plural formsCaolán McNamara
Change-Id: Id3d41099a895ca5423be2ac3d497851bc65eaff7 Reviewed-on: https://gerrit.libreoffice.org/61426 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-09use unique_ptr in SdrUndoGroupNoel Grandin
Change-Id: I569c56b6114e07b2a227ad0f906c1a5188a94af4 Reviewed-on: https://gerrit.libreoffice.org/61528 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-08cppcheck: variableScope and fix index typesJochen Nitschke
Change-Id: I045b4d84e0ad07a98523b91fc7203bfd422b3529 Reviewed-on: https://gerrit.libreoffice.org/61541 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2018-10-08Added date time transformations - follow-upVikas Mahato
Change-Id: I130feda7c835b067a542736ad6fadc79cabc4f41 Reviewed-on: https://gerrit.libreoffice.org/59413 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2018-10-08tdf#42949 Fix IWYU warnings in include/comphelper/[m-z]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I04c5ba277d5b3398c07de6ae66713d977636088d Reviewed-on: https://gerrit.libreoffice.org/61347 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-10-08use more std::unique_ptr in ScDBCollection::NamedDBsNoel Grandin
Change-Id: I5825208435fd179e9515e731a24a6e5bf1c94431 Reviewed-on: https://gerrit.libreoffice.org/61436 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-08use more std::unique_ptr in ScDPCollectionNoel Grandin
Change-Id: I7d76704ba76b0d47544456047bc699b12fa7c288 Reviewed-on: https://gerrit.libreoffice.org/61435 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-08tdf#113236 change menu "Tools > Protect Spreadsheet" to "Protect Spreadsheet ↵Cor Nouws
Structure" Change-Id: Id9f69e6f27610591ef0c62b7d0dec83fa1e4fe9a Reviewed-on: https://gerrit.libreoffice.org/61066 Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com> Tested-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-10-08sc: speed-up: no usage of temp strings objectsSerge Krot
Change-Id: I7d9812672e4cbefd7e422b5c70b54ee3ea50df2d Reviewed-on: https://gerrit.libreoffice.org/61446 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-10-08weld ScTPValidationErrorCaolán McNamara
Change-Id: Iaea475dc1037ed070ab2ff61be647f345d39ae3c Reviewed-on: https://gerrit.libreoffice.org/61501 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-08weld ScTPValidationHelpCaolán McNamara
Change-Id: I7bf8219bfef8f6e7d765b2a9f1240f364418cbc2 Reviewed-on: https://gerrit.libreoffice.org/61500 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-08weld ScTpSubTotalOptionsCaolán McNamara
Change-Id: Id147ae786c8c93939acff8a97c4167f99451f364 Reviewed-on: https://gerrit.libreoffice.org/61499 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-07Resolves: tdf#73081 empty <> not-empty is also a match if numericEike Rathke
This simplifies to match empty for the same conditions whether numeric or not, an empty string does not result in numeric 0 here. Change-Id: I923a3e1f07dd2691d3ac720fc28ba76986fe6c3d Reviewed-on: https://gerrit.libreoffice.org/61486 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2018-10-07tdf#120317 Set control layer name if not defaultRegina Henschel
In commit a9ec212c1b545d745285f0ab3119a80713b1d1f2 the internal default name of the layer, which holds form controls, was changed to controls, the same name as used in file format and UNO. Users of the class SdrLayerAdmin have to set the control layer name explicitly in case they want an own, different name. Change-Id: Ia08a85a4d01a75ee2c5115da25b2a409204ccc01 Reviewed-on: https://gerrit.libreoffice.org/61447 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2018-10-07use more std::unique_ptr in ScCheckListMenuWindowNoel Grandin
Change-Id: Ia63d663204af570fb0e7faa46e4925c2787fc59b Reviewed-on: https://gerrit.libreoffice.org/61433 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-06return unique_ptr from CreateDefaultObject in sc/Noel Grandin
Change-Id: I8981050aeadc1efe907e7e9a47d18dc3c72956c2 Reviewed-on: https://gerrit.libreoffice.org/61439 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-06use more std::unique_ptr in ScUndoDrawNoel Grandin
Change-Id: I4216efd74f279a0997754b75b62b2dedce09511e Reviewed-on: https://gerrit.libreoffice.org/61434 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-06drop some now unnecessary includeCaolán McNamara
Change-Id: I9db3d9a172a41c70ed343efd76f4c7c8f88b3a3f Reviewed-on: https://gerrit.libreoffice.org/61471 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-06introduce SdrObjectUniquePtr typedefNoel Grandin
Change-Id: I00106a7be04d473e2ee60ef6165bebc4148f954b Reviewed-on: https://gerrit.libreoffice.org/61438 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-06use more std::unique_ptr in ScUndoMoveTab and ScUndoCopyTabNoel Grandin
Change-Id: Id69d87369d2a73b00e4ed6159047eef3135722e1 Reviewed-on: https://gerrit.libreoffice.org/61432 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-05sc: Enhance binary search for ScMarkArraySerge Krot
Change-Id: I0fe6a0b8987fb3c3229c5aabcbf056cfb365650c Reviewed-on: https://gerrit.libreoffice.org/61373 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-10-04Do not let end row creep above start row, tdf#69977 tdf#119305 follow-upEike Rathke
commit 3acc5a2383f5b0458e3caf1505fe6b8ad7dc3fb0 CommitDate: Tue Mar 27 13:26:30 2018 +0200 tdf#69977 improve creation of large charts changed the loop such that it removed the stop condition for rStartRow < rEndRow, and commit aaa3c31ba79b1b3d335dcf55d72837a13411b45e CommitDate: Tue Sep 11 20:29:04 2018 +0200 tdf#119305 Chart created from fully selected sheet only targets header row still checks only for a minimum of the original end row and the last data row, which for an empty (no data) range selected may be above the start row. Change-Id: I9de08d09be62e86e7c946df701c49314fa4d682e Reviewed-on: https://gerrit.libreoffice.org/61389 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2018-10-04tdf#120301 oox: lclIsWhiteSpace should return true for a spaceJustin Luth
Change-Id: I72c79c1fed4d9a91bf02024eef23cd3b1a58632e Reviewed-on: https://gerrit.libreoffice.org/61388 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
generated by cgit (git 2.34.1) at 2025-02-28 07:14:43 +0000