Age | Commit message (Collapse) | Author |
|
and replace it with OUString/OString::replaceAll
Change-Id: I37b1c3b51251dfd9d749d6f1060c75b3a93d7f1a
Reviewed-on: https://gerrit.libreoffice.org/26850
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
|
|
convert usage of deprecated class, and remove the old class
Change-Id: I19fb9271090d19e5531622b58492e1a848d306e2
Reviewed-on: https://gerrit.libreoffice.org/26843
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: I10fdf45171505ba53e971c1a634ffa66a4a09f9a
Reviewed-on: https://gerrit.libreoffice.org/26811
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
|
|
Just quoting the source comment from the breaking commit
61c39eae570d6d6040b65bfe93127b30e6080cc8.
// If a matrix formula has a matrix reference cell that is intended to
// have // a blank text result, the matrix reference cell is actually
// saved(export) as a float cell with 0 as the value and empty <text:p/>.
Ok
// Import works around this by setting these cells as text cells so that
// the blank text is used for display instead of the number 0.
This seems to be wrong.
Forcing the cell to a util::NumberFormat::TEXT actually kills
the cell value, if the text is a result of the formular.
I'm not sure if forcefully changing the cell format at this point is
correct at any time, if a cell type was already determinated.
I imagine that an undefined cell type should probably be fixed at the
end of the row import, if Calc detected an error case, or even generally,
This patch is just a minimalistic initial fix. If it's correct, it
probably needs an additional code comment.
Change-Id: If7d9d69467d56c7d8fd2444f9e8b3ae906285264
Reviewed-on: https://gerrit.libreoffice.org/26435
Reviewed-by: Eike Rathke <erack@redhat.com>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
|
|
Change-Id: Ie335210609a556fc4081b16292ba756819bfa4d1
Reviewed-on: https://gerrit.libreoffice.org/26827
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
|
|
Change-Id: Iec3e70ceeae38d6a5c18996e89fa5ae10a9f9668
Reviewed-on: https://gerrit.libreoffice.org/26862
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
|
|
In previous XLSX export implementation the outline
for column was not saved. Also rows without cell content
was not saved if it was collapsed or outline level was set.
This commit resolve all such issues
Change-Id: I401f23e97f4803209fcd31c7d93baca3bd2a2385
Reviewed-on: https://gerrit.libreoffice.org/26625
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
|
|
After save to .xlsx in usePrinterDefaults was added into PageSetup.
Due to bug in MS Excel, when usePrinterDefaults is present,
(no matter what value), the orientation of the Page is alway "portrait".
To resolve that issue, if usePrinterDefaults is set to default value,
then usePrinterDefaults XML field is not added during export to .xlsx
Change-Id: I3ab310babb278913bce3d66f7fae1192ed9727b9
Reviewed-on: https://gerrit.libreoffice.org/26871
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
|
|
Test removal or not of escape char in number format strings in XLSX
Change-Id: I02a7e1bfd9df1ffd3bbad7dc072cfc85be68f949
Reviewed-on: https://gerrit.libreoffice.org/26877
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
|
|
Should fix
<http://ci.libreoffice.org/job/lo_callgrind_linux/2013/console>.
Change-Id: I4ff4ddafbbb15ee360cb845afe8e8b4dbbf04460
|
|
Fails with the sc/source part of commit (sc lok: add
LOK_CALLBACK_CELL_VIEW_CURSOR, 2016-07-01) reverted.
Change-Id: I4a1a7d97b744dd089fe15bd58af6cca5e0b79e8f
Reviewed-on: https://gerrit.libreoffice.org/26856
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
|
|
Change-Id: I1dded11e0572dee7cd917a1aa8c2e2ca53b81d84
Reviewed-on: https://gerrit.libreoffice.org/26849
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
|
|
Change-Id: Iad2942851fced632c0c662bf754b1d687740105c
|
|
Change-Id: Id62acb1800b3a302d62900699a01d1a5cdf1ab56
|
|
like it should always had been the case ...
Change-Id: I75b9e71bbaad5e356a45b416a3b42dc4becec801
|
|
So a view can be aware where the cell cursors of other views are.
Change-Id: Ifcf06c0019c6af8b859e2e92222e4f3fd18da74f
Reviewed-on: https://gerrit.libreoffice.org/26844
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
|
|
Needed to adapt the WEEKS and YEARS test documents to cope with the
change.
Change-Id: Ia52505418f4fed684bd04290c608e2a65eee2fbc
|
|
+ vcl builder setups action for custom buttons
+ new control: vcllo-SmallButton with WB_SMALLSTYLE property
Change-Id: I54891969f26d237eac8e45532906d76040264272
Reviewed-on: https://gerrit.libreoffice.org/26781
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
|
|
found with /approxFloor.*GetDouble
Change-Id: Ice058c9cb318d7b0b0cadb9a26b4eb9f3691752f
|
|
found with /approxFloor.*GetDouble
Change-Id: I2a08d8c268e6c1d64270d9c9f343b69a62f27708
|
|
found with /approxFloor.*GetDouble
Change-Id: Ib14a60e872c6a3adde2aa11f96f391c42b4e510c
|
|
Most places will use GetInt*() to obtain flags or enums in a range
0..somenumber and explicitly check for valid values, so returning MAX instead
of 0 will save us an extra comparison of nGlobalError and push/return.
Change-Id: I84c5d693d3642ea643308dc4650a391de2ebe82a
|
|
Change-Id: Ic3a5c65e4846a4582461564f572be83897b1d12d
|
|
Change-Id: Iba1a8cfcab01083a23b4956d7da51651ad3a447f
|
|
in the places changed by 2606915f0f480af30367a5d0f67adbf930c2c6b9 and
002697221215e009cdf20fd5c12b50350b8a2128
Change-Id: Iea056b3101c5c41ee932defe13edf4769cb9eab1
|
|
in preparation of replacing oversimplifying casts and special handling
like in 2606915f0f480af30367a5d0f67adbf930c2c6b9 and
002697221215e009cdf20fd5c12b50350b8a2128
Change-Id: I81327dbc2218f40359c3485cf3d639d19fd69cef
|
|
Change-Id: I4f32b77a4b107e5315e0c2bc9b20db897135c8b0
|
|
There were some VclPtrs hiding inside std::vector (twice), so fix
that, but the destructor is still not called (getting Window::~Window
inconsistency assert). With this patch however the screenshot cppunit
test no longer fails
Thanks noelgrandin for help
Change-Id: I8b46c4608cbab2070e36ef4abec226bcd997425e
Reviewed-on: https://gerrit.libreoffice.org/26772
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: I42e96a0c7818abdaff15f5cd2b1111839aa771e6
|
|
Change-Id: Id9a2d84e1efb86a89e620dca5cd35274979aa1b9
|
|
Add a number format with "/ " at the begining like in bug report
Change-Id: I98ae12434608e16c8e202a1c4acfda50df4db6f1
Reviewed-on: https://gerrit.libreoffice.org/26576
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
|
|
In XLSX files, in number format, all escape characters were removed.
But it is only necessary for space character in fraction.
Preserve escape character in other cases.
Change-Id: I6f82b7285cf91726725b723b0bb109bcced066b8
Reviewed-on: https://gerrit.libreoffice.org/26466
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
|
|
instead of being randomly embedded somewhere deep inside the CXX code.
Found with:
git grep -nP '^#include' -- *.cxx | sort -g -k 2 -t :
Change-Id: I9ee432d3b665ecb6ec600bd51cc4b735a1b1127a
Reviewed-on: https://gerrit.libreoffice.org/26764
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: Ia3a5fa02029e06e083fcc10748b0deb3048dae79
Reviewed-on: https://gerrit.libreoffice.org/26675
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
|
|
with extra disposes to shutdown the test thingies in the right order
This reverts commit a4780b3c8b45261e59ed3cbb34c4463d58ad8079.
Change-Id: I13282d6bc54a0dceb3ed91a04cd438a9011154fe
Reviewed-on: https://gerrit.libreoffice.org/26756
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I07a2cf1d38757614c469e2cb7bfb3730ea32f3cc
Reviewed-on: https://gerrit.libreoffice.org/26741
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
|
|
This reverts commit 0cb200d000fad8ba31c7400e08cd031823f27308. Even if it
was verified by Jenkins, it broke CppunitTest_sd_import_tests on a
number of tinderboxes. Need to at least find out how to reliably trigger
the crash and fix it before it goes in again.
Change-Id: I7ed52cae559648ec101b7a343046a7d74a7c48d3
|
|
Change-Id: Ic96736e5dc07abcbb738bcc4664981e3e142eee9
|
|
Since 23e5540a05e940cb4a591815e6b85a485b01fc32 we can use
GetDoubleOrStringFromMatrix() and check for SC_MATVAL_BOOLEAN.
Only if transported of course..
If not, then even a {FALSE,FALSE,FALSE,...} result is better than the previous
{FALSE,TRUE,TRUE,...} for any array sequence where all TRUE results resulted
from the previous call to ISLOGICAL() ...
Change-Id: I879e0cbc6557e73ac24713267b5122f923500501
|
|
None of the callers checks for SC_MATVAL_VALUE but all use IsValueType()
instead, which includes SC_MATVAL_BOOLEAN, but we may want to explicitly
identify SC_MATVAL_BOOLEAN.
Change-Id: I6737eb2909c819b6c54f7e62cf8ebfc12af14fea
|
|
Change-Id: I5cf02f1889090539f7adb826483c91a1ef3c3925
Reviewed-on: https://gerrit.libreoffice.org/26015
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
|
|
If TextBox contained text that is larger than the box, and
autofit was off, and autosize was off, and full width was off,
then text always aligned to box's left top corner, regardless of
text anchor setting.
Related problem (i103454) was fixed in 2009 by Armin Le Grand, but
only for full width text. This patch extends the scope of that fix
to correctly process other cases.
The fix introduces a new compatibility flag:
AnchoredTextOverflowLegacy
If it is true, then old behaviour is retained.
It is always false for new documents and imported documents.
When opening existing ODF documents, it's true by default, unless
it is explicitly set in settings.xml.
Unfortunately, I couldn't find a way to access the document model
from any of SfxBaseModel::load() or SfxObjectShell::DoLoad, where
it could enable setting the compatibility flag universally when
loading own format. Instead, I had to do it individually in each
of SfxObjectShell::Load() implementations.
Unit test is included.
Change-Id: Ifad79d546739daafff59fb6c7fb0dce51babc53d
Reviewed-on: https://gerrit.libreoffice.org/26737
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
|
|
Change-Id: I0d9d27715ed987b6cdcc88ac6ce000083d184e90
Reviewed-on: https://gerrit.libreoffice.org/26742
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
|
|
There should be no need for it as far as I see. Possibly it made some
sense back when we thought we could use OpenCL for operators and
functions that are supposed to ignore the case of strings they
handle. But we hopefully should never try to use OpenCL for string
data nowadays anyway. And actually, the case-folding ended up
affecting strings handled by the so-called software interpreter. For
the tdf#75387, the sample sheet worked fine when OpenCL was enabled.
Change-Id: I1c170ebf09551fea0964f394cdb3c65079672257
|
|
Also make changes to make loplugin:staticmethods happy
Change-Id: Ia55d063c0fa5a1d9392e09f23ebb1266f46745b9
Reviewed-on: https://gerrit.libreoffice.org/26740
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: I6e5a1c33eeb5eb139f12d4a9d696c53ad65a3af7
|
|
This commit introduces a system for reading/writing common
model-level user data (like compatibility flags from settings.xml).
It is designed to reduce code duplication in cases where an option
is applicable to any type of document.
Change-Id: Id4e31df14f49cbb673f4a6df943ccec6d98eb9aa
Reviewed-on: https://gerrit.libreoffice.org/26719
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
|
|
Change-Id: Iaca091205954a947101a9185673d5dad9c4abaa1
Reviewed-on: https://gerrit.libreoffice.org/26731
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
|
|
Change-Id: Idb71f928327b97b937d659695569df930e9a6d2a
Reviewed-on: https://gerrit.libreoffice.org/26728
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
|
|
Change-Id: I55602625a0f8b434e9356529e52f36230ae0360a
Reviewed-on: https://gerrit.libreoffice.org/26730
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
|