summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)Author
2021-09-03tdf#131548 Android: jump to cellIlhan Yesil
Added LOK_CALLBACK_SC_FOLLOW_JUMP: fire this signal to jump to cell cursor in android viewer. Payload format same as LOK_CALLBACK_INVALIDATE_TILES. Change-Id: Ic896baccf1327d6ccdf104811446e3454a42679e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116448 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2021-09-03tdf#144155: Revert "tdf#36383 sc AutoFilter: fix changing row height"Xisco Fauli
This reverts commit 3678e0efcb8bedc58dd329a430da0ac3b1572df8. Conflicts: sc/qa/uitest/autofilter/tdf36383.py Change-Id: Ie1abd0cdea013571a27b187ffcb20125a0656442 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121512 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: Jenkins
2021-09-02tdf#144209: sc_subsequent_filters_test2: Add unittestXisco Fauli
Change-Id: I00a0f1efad4d003c7213117ede7f14fbdcb2c00e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121509 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-09-02rename UpdateMode -> UpdateLayout in editeng classNoel Grandin
... because "update" is such a generic term I keep forgetting what we are turning on and off Also return the previous value from SetUpdateLayout to make the save/restore code more compact. Change-Id: Iae1764c837a92e58c9b17521f130e8fc80311d22 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121479 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-09-02Use utl::TempFile::EnableKillingFileMike Kaganski
Helps keep temp directory clean also on exceptions Change-Id: I81c17d90d6905653db946e68faf2a7f59c17da15 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121466 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-09-02Resolves tdf#144227 - Default command to switch UIHeiko Tietze
Remaining .uno:ToolbarMode replaced by .uno:ToolbarModeUI Change-Id: Ie5afaa997dabaca0feafde41355945460f1292f2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121417 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2021-09-02unused definesNoel Grandin
Change-Id: I494e64c69decb9fb3d5b13ffc2f18d99f6b7749f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121442 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-09-02ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara
Change-Id: I2b33dd4893bb71bd7880e068d26ebe3d31d07ab1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121485 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-01Resolves: tdf#144209 Handle General containing formats in RoundValueAsShown()Eike Rathke
Calling SvNumberformat::GetThousandDivisorPrecision() for a "AA "General format resulted in 3000 as that was implemented for tdf#106253 without taking into account that ImpSvNumberformatInfo::nThousand may be abused under some conditions, which here is having FLAG_STANDARD_IN_FORMAT = 1000 as nThousand, multiplied by 3 gives 3000. Subtracted from the 0 precision gave -3000 decimals for which of course the new rounding produced 0 where it previously simply ignored the decimals and returned the original value. Change-Id: I66afaf1e2d8b2654d9f7cc8cfb66389357fb742d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121447 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2021-09-01ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara
Change-Id: I8d581560433e555f7f26b4e24d1acd399acf4d52 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121445 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-01ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara
Change-Id: I7f37460bd39f5d069550c0e6241fe654f8c910d1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121443 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-01ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara
Change-Id: I9ae6e92cd5677619f8604764acbbe30a7290002e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121444 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-01clang-tidy:readability-redundant-member-initNoel Grandin
Change-Id: I8553b1e2b1c3461fa55eb19593b1a97ed9e7ab1f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121433 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-09-01tdf#118938 XLSX import/export: fix permission for editingTünde Tóth
The password for editing wasn't asked, also wasn't exported in XLSX documents. Now it's exported in Calc using the following steps, also verified before editing: - In File->Save As, choose Excel 2007–365 (.xlsx) format; - enable checkbox "Save with password" and click Save; - in the dialog "Set password", click on "Options" and enable checkbox "Open file read-only", and enter a password for editing (i.e. skip the password for opening). Note: Excel 2016 doesn't ask password for editing, but Office 365 does. Passwords created in Excel haven't been supported, yet. Also passwords with diacritics aren't interoperable. Note: saving the file under a different path is still allowed both in Calc and Excel without asking the password for editing. Change-Id: Ic00d7c5a785e04d270a182a4087ea922d7d92979 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121371 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-09-01sc: do not use dashes in the file namesXisco Fauli
underscores are used predominantly Change-Id: I4a51903a2c7712f463b10a56c7466077544adfee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121408 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-09-01ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara
Change-Id: I4e1a5a6254c22423d8b7e75d4afc88393fc816de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121399 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-01ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara
Change-Id: I3b32e04f05c39871d172a35ef60af787ffb5ee87 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121397 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-31CSV/Paste: setting a text format is only necessary when using ScDocumentImportEike Rathke
For ScDocument::SetTextCell() it is forced anyway so was actually done twice, in the case of Paste and TextToColumns. Change-Id: I3144e2d316810c702c5ebd84698e8611674adace Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121381 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2021-08-31tdf#117868: sc: Add UItestXisco Fauli
Change-Id: Ic8630d3497ece3903662c671878a42e448e7f553 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121383 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-08-31CSV: use target doc's formatter to determine and set forced textEike Rathke
If text is to be forced check if the string is a number in the target doc's locale which then needs to be forced to text format, not in the input parsing locale. Also set the text format of the document's default locale, not the input locale's text format (which may or may not match the document locale). Question remains if this isn't duplicated work anyway because setting text at cells forces text format if necessary if ScSetStringParam is setup correctly. To be investigated if all paths taken actually do that. Change-Id: I3db3907cfe81156ccd1b0b523372dd97ee8598a3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121366 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2021-08-31tdf#142881 XLSX import: fix shapes rotated exactly 45°,Daniel Arato (NISZ)
135°, 225° and 315° by correcting their cell anchor points, like MSO does. Previously the XLSX export with the bad anchor points messed up the rotation of the shapes, resulting also broken text content in LO and MSO. Thanks to Regina Henschel for analyzing the problem. Co-authored-by: Szabolcs Tóth <toth.szabolcs@nisz.hu> Change-Id: Ica625545a22a74ed027ac0fa2bbf38804611c172 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121307 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-08-31ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara
Change-Id: I3be8bae46978b8641abf82acd9620c770a076a33 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121320 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-31reversed conditionCaolán McNamara
Change-Id: I5d4440ed16fe6acc21923209f94067ce7df03564 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121323 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-31Resolves: tdf#114878 Add 'Evaluate formulas' option to CSV import and pasteEike Rathke
... and Text to Columns, defaulting to false for CSV import via dialog and stored as config item option similar to all other CSV/Text options. Change-Id: I742f447b905a07b05dcf5fc58796c46de212276b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121344 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2021-08-31Resave with glade 3.38.2 to convert property names with '_' to '-'Eike Rathke
Change-Id: I745fda9e2b61c15f281d7a2d8f21d8003253c6d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121343 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2021-08-30make this more readableCaolán McNamara
Change-Id: I031054d3a6929c48b796ce527448d2c5a5099a8b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121319 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-30tdf#139734 Drop redundant asserts after MacrosTest::loadFromDesktop4k5h1t
Change-Id: I7347d2c9429647e9cd87ad8147848d24f717d181 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121222 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-08-30ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara
Change-Id: Ic00ecbb8e482b8e666f27db73539d65e54ec7c51 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121264 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-30ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara
Change-Id: I7e52d33f0e94f4bad03e9e3881b54e90172e12a7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121263 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-30LOK: avoid writing freeze pans data to file if not setPranam Lashkari
Change-Id: I9bc4023ae1673a2ae68db584357fb6c6643342a3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121065 Tested-by: Jenkins Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
2021-08-30ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara
Change-Id: Ife47559f456e17175eccf4bb6509688b61972d7d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121235 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-30ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara
Change-Id: If76fdb6d83d1d2d71baee5f892cd239806a6fd61 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121236 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-30Add Swap Rows Transformation.tushar
Entries of given rows are swapped after applying transformation. Change-Id: Iac9da1b15781656b4127bf74f6a95e8cb82fa3d0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120556 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Jenkins
2021-08-30ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara
Change-Id: I941bb60c1d06189491964004fb98d0d21fc75c49 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121237 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-29Resolves: tdf#117868 CSV: support sep=; and "sep=;" separator settingEike Rathke
When reading CSV the separator (any BMP character) is taken from an initial sep=; or "sep=;" single field if that is the only row content. The quoted form is preserved as (unquoted) cell content, of the unquoted form the separator is discarded as contextually it is a real field separator. When writing CSV an existing single top left cell's content if that is the only cell in the row is adapted to the current separator (any BMP character) in the quoted form "sep=;" (if quotes / text delimiters aren't set empty ...) and always uses the ASCII '"' double quote character. Change-Id: I854477bd0f9d1cafaa51a2130b616292347519cf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121232 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2021-08-29ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara
Change-Id: Ic2179724b182262c01b9e5993234b1d89ccbe49f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121224 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-29be a little more readableCaolán McNamara
Change-Id: Ic0f7dd5ead93aa7e3178dcc5128df615d1d7a4e2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121218 Tested-by: Jenkins Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-29ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara
Change-Id: I8422da20656626f2512a63a8a4282b2f09c79e37 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121217 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-29ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara
Change-Id: I649e8b8fa0d1752f0f4b0b6b688cea8ae945bb87 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121186 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-29ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara
Change-Id: I136816837eddcb1bf81c23b6f4fcfa65e9335629 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121187 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-28Fix typosAndrea Gelmini
Change-Id: Ie4e2ef5a884b51250863d3384d5e703232f31258 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121179 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-08-27tdf#59820 - Search for the longest substring in a multiline stringAndreas Heinisch
In order to determine the optimal column width of imported ASCII files in the simple text mode, search for the longest substring in a multiline string which is determined by a line break. Change-Id: I2c606dd97549455009b9f8fad2b8ec4386b7b7db Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120772 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2021-08-27tdf#143940: the style index might be -1Xisco Fauli
Similar to 52aebe6986bcec07071adb3f94d6c09fea147044 < tdf#138466 Crash when creating different scenarios > ExportColumns calls GetStyleNameIndex which might return -1 so check the index is different than -1 as it's already done when calling ScFormatRangeStyles::GetStyleNameByIndex Also move fix for tdf#138466 down the stack to be consistent Debug builds will still assert, see coverity#1438402 Since 5e777f23fd0118f6649f0d9e30eb77a72f1099e4 < loplugin:useuniqueptr in ScColumnRowStylesBase > where the nIndex < 0 check in ScColumnRowStylesBase::GetStyleNameByIndex was removed Change-Id: I084bfa04c39f37cb325c3b3df76801b3abdea994 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121128 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-26tdf#139734 Drop redundant asserts after MacrosTest::loadFromDesktopRadhey Parekh
Change-Id: I8ccb5e43ac86ff2b8da94bd03e6fa50de0c33741 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120961 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2021-08-26tdf#118538 Extended tips for regression analysis dialogOlivier Hallot
Change-Id: Ib063540742f8fef44d2848d9cfe5f97deef072cf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120971 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-08-26tdf#142307 - Upgrade SSE2 sum to AVX512 sum with Neumaier 1dante
This part focuses on allowing it on replacing arrayfunctor By thefault it will try AVX512F (1,17%) If not available will use AVX (94,77%) Use of AVX2 (82,28%) has been avoided even if the code could been more compact Source of hardware statistics: https://store.steampowered.com/hwsurvey Change-Id: Iae737a565379e82c5f84f3fdee6321ac74f59d40 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115675 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-08-25tdf#143979: sc_subsequent_export-test2: Add unittestXisco Fauli
Change-Id: I9051187dcb252d800ba4c2f062ff18f0ed022c03 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121028 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-08-25tdf#143929: chain XMLTextExportPropertySetMapper to sc's shape exportMike Kaganski
This allows to export editengine columns to ODS. Alternatively, we could re-introduce chaining text attributes in XMLShapeExport ctor, which was commented out in commit d5b1e4827f8e6e0661563ec856cd80d926ba7b58 without explanation; but that would affect export from other modules as well (e.g., SdXMLExport::setSourceDocument sets up respective chaining in sd), so to be on the safe side, I do it only for ScXMLShapeExport. Change-Id: Iafee77b2b57e95031cfe1bbd2d43d7361a3e8469 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120958 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-08-25Fix typo after translation roundOlivier Hallot
Change-Id: I2e88905f38f9fade306de064e84e0863f9eeea71 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120918 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-08-25Bump ui file to latest Glade releaseOlivier Hallot
Change-Id: I1a22cecbcf193f0617b5490e6d22a8fc6d830158 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120917 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>