summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)Author
2017-05-02untranslated strings are just stringsCaolán McNamara
removes starmaths InsertCommand in favour of InsertCommandText Change-Id: I5659adcaa28e5b5861d1a1cc5d2afa84009490f6 Reviewed-on: https://gerrit.libreoffice.org/37113 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-05-02loplugin:checkunusedparams in forms..formulaNoel Grandin
Change-Id: Iacd973b97fccda217c691cca0a8f440640ff7a0b Reviewed-on: https://gerrit.libreoffice.org/37140 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-02loplugin:checkunusedparams in editengNoel Grandin
Change-Id: I2b770d40ac2339cd2b04a765a6d970675d2ea1c1 Reviewed-on: https://gerrit.libreoffice.org/37133 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-01tdf#107145 display applied filters for page field in pivot chartTomaž Vajngerl
Add field output description which shows the description of the filtered output, which can be either "- all -" when nothing is filtered, "- multiple -" when multiple values are outputted or the specific value - the only value remaining. Change-Id: I8fca6050dabba9878e9f3a31e4be7a03e3b87467 Reviewed-on: https://gerrit.libreoffice.org/37125 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2017-05-01tdf#107102: fix crash in ScCheckListMenuWindow::CreateAccessibleJulien Nabet
by checking maEdSearch in addition of !mxAccessible.is() See http://bugs.documentfoundation.org/attachment.cgi?id=132608 for bt Change-Id: I2cf7f28daaa6d371d3be0d21bb7f140ff6bb8c8c Reviewed-on: https://gerrit.libreoffice.org/37110 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-05-01Remove SlotType sdi propertyMaxim Monastirsky
sdi files have two ways to specify the type of a slot: (a) Put it at the beginning of the first line (b) Using the SlotType property Where (b) have higher priority, and (a) is actually ignored for "method slots" (i.e. the ones that have parameter parentheses, even empty, and therefore get the SfxSlotMode::METHOD flag), which is very confusing. The goal here is to make exclusive use of (a) for all kinds of slots, and eventually remove the SlotType support code from svidl (in a follow-up commit). Change-Id: Ib6654d34e2f8aa8ebd0bd3c41aa2a86e30e9a634
2017-05-01Return values of sdi "method slots" were unusedMaxim Monastirsky
Also expand nested methods. Only diff in workdir/SdiTarget is for SID_STYLE_WATERCAN from sw/sdi/_basesh.sdi which changed the .uno name from WatercanStyleModeOnOff to StyleWatercanMode, to match the name in sfx2/sdi/sfx.sdi (it was forced by svidl to have the same name). Change-Id: Iaeac9f4f10a36cb0b3afe3de2b6def8cd90edc6d
2017-04-30Let's be more specific about the threshold etc.Kohei
Change-Id: Iaa644b38775477f8f6f329ab55d9d32414ee0738 Reviewed-on: https://gerrit.libreoffice.org/37089 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2017-04-30More fine-grained disabled vector states.Kohei
Useful for group formula logging. Change-Id: I40a02f0aa88d7c63a641f2a79956236d0db39f15 Reviewed-on: https://gerrit.libreoffice.org/37088 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2017-04-29tdf#107097 invoke internal DP and correctly handle "range" namesTomaž Vajngerl
When we copy/paste a pivot chart to another (new) document, we "send" a chart data as ODC to the other document. In the new document we can't use the pivot table (as there is none in this document) so we read-in the table data from the document to the internal data provider. The problem was that we didn't match the (fake) range names from the pivot table correctly in the internal data provider and the data wasn't populated. This commit fixes that and changes the fake range names to something that is easy to parse and matches the names in internal data provider. Change-Id: I9872160cca68abd91738a25bf9b3b27bc77ce38d Reviewed-on: https://gerrit.libreoffice.org/37086 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2017-04-28tdf#39486: Translate some randomly found German commentsJens Carl
Change-Id: I4c2950180f504c06666f055d166c51e32a6d5294 Reviewed-on: https://gerrit.libreoffice.org/36969 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-04-28loplugin:salunicodeliteral: scStephan Bergmann
Change-Id: I7f63388d3c0214be8f69095fe5ec0030df59a416
2017-04-28move builder attributes from OString to OUStringCaolán McNamara
Change-Id: I235188c9a086337b104e600f31a1c81deeca6c17 Reviewed-on: https://gerrit.libreoffice.org/37076 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-04-28sc lok: Do not change comment indicator settingPranav Kant
This setting is saved to doc model when document is saved eventually. We should respect the user settings, and not play with it like this - changing this setting to false unconditionally. Originally, setting SetNotesMode to false was meant to prevent any kind of in-tile note rendering in case of LOK when it is turned off. But turns out this option is only for note indicator i.e the red button. We already have a LOK in-tile rendering guard in ScDocFunc::ShowNote that prevents popping drawinglayer note even if corresponding UNO command is sent by the LOK client. Change-Id: Id6c7b2cd30cdbefe7dacc2a701638b2488ab245d
2017-04-28loplugin:cppunitassertequals: scStephan Bergmann
Change-Id: Ifc250cf5bc293b4c87b9abb2d00be62078c2338a
2017-04-28loplugin:checkunusedparams in accessibility and avmediaNoel Grandin
Change-Id: I94df9a65578792fb06f3b3259603f70ca1e0b3db Reviewed-on: https://gerrit.libreoffice.org/37059 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-28Bin the same comment copy-pasted meaninglesslyTor Lillqvist
Change-Id: I1f6498f037a2ff121ef7db0976329b12e22c2f94
2017-04-27Resolves: tdf#107241 don't let floating function description grow infinitelyCaolán McNamara
Change-Id: Ief87c15c637d725d25416b64739fb3f5f07cded4
2017-04-27remove svx bitmaps from .src filesCaolán McNamara
Change-Id: Ie3795870484648e62dea483f9976af31cd1be167 Reviewed-on: https://gerrit.libreoffice.org/37006 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-04-27tools: move errcode.hxx to the vcl moduleChris Sherlock
Change-Id: I17e5a033de5f0aeb0a726744f7b464cdab6e2ee3 Reviewed-on: https://gerrit.libreoffice.org/36854 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-04-26remove sc bitmaps from .src filesCaolán McNamara
Change-Id: I351b67616b240e3c0c91ea31d8f14ecfa6de8b4a Reviewed-on: https://gerrit.libreoffice.org/36991 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-04-26use strong_int for LanguageTypeNoel Grandin
Change-Id: If99a944f7032180355da291ad283b4cfcea4f448 Reviewed-on: https://gerrit.libreoffice.org/36629 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-25vcl: change ErrorHandlerFlags to DialogMaskChris Sherlock
Change-Id: I1959ac97f679d8d719f851f9869962b39a20ded9 Reviewed-on: https://gerrit.libreoffice.org/36841 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-04-25errinf.hxx moved out of tools and into vcl moduleChris Sherlock
ErrorInfo has a hard depency on VCL, yet is in the tools package. It is more appropriate to have it reside in the VCL module. Change-Id: Ica54a46c3a7f86cf0331ed7245234bea69c05650 Reviewed-on: https://gerrit.libreoffice.org/36839 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-04-25make __RSC a builtin define for the RSC compilerNoel Grandin
instead of randomly defining it in only some of .src files Change-Id: Ifec3920740723d248400f451d717b5288c421b8d Reviewed-on: https://gerrit.libreoffice.org/36832 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-25tools: svstream.hxx needs only errcode.hxx & not errinf.hxxChris Sherlock
Change-Id: Ia28e35ae5af4f601e9a586a3deffbcd61702b0ca Reviewed-on: https://gerrit.libreoffice.org/36896 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-04-25tdf#107310: add unit test for this.Kohei Yoshida
I decided to add this to the filters test since it's the ods import code that sets the cells in hybrid "zero as empty string" mode. Change-Id: Icb34733e8550b655fbd70be718af5006b257a3e3 Reviewed-on: https://gerrit.libreoffice.org/36818 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2017-04-25tdf#107310: hybrid cell is a value cell as well as a string cell.Kohei Yoshida
Else it would cause a legitimate calculation to fail with #VALUE!. Change-Id: If8d4f40859d0c87b97afc952e4a3e4268450c40c Reviewed-on: https://gerrit.libreoffice.org/36817 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2017-04-24tdf#84837 Comment submenu icon and remove hide/show all commentsYousuf Philips
Change-Id: Ifa0fd92363a4edc64e312a8b063179ce6ea30dd4 Reviewed-on: https://gerrit.libreoffice.org/36570 Reviewed-by: Yousuf Philips <philipz85@hotmail.com> Tested-by: Yousuf Philips <philipz85@hotmail.com>
2017-04-24clang-tidy readability-simplify-boolean-expr in scNoel Grandin
Change-Id: I702e52e56487f201b9e0d7af21ff8167464aa58c Reviewed-on: https://gerrit.libreoffice.org/36876 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-24tdf#107147 ignore subtotals and grandtotals when gathering labelsTomaž Vajngerl
When gathering the labels and categories for the pivot chart, ignore subtotals and grandtotals so they don't end up in the chart. Change-Id: I45e80a59531d6a048a22016132e9bef280bb325c Reviewed-on: https://gerrit.libreoffice.org/36868 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2017-04-24preserve "Total" label on round-trip, remove code duplicationTomaž Vajngerl
Change-Id: Ic4e682f2193291798a3ebbf5a7f3f435d40a0645 Reviewed-on: https://gerrit.libreoffice.org/36867 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2017-04-24use translated string for "Total" label in pivot chartsTomaž Vajngerl
Change-Id: Ic75224cb35c34b8be5504af1032cb326196e2306 Reviewed-on: https://gerrit.libreoffice.org/36866 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2017-04-23Replace GetImage with CommandInfoProvider::GetImageForCommandMaxim Monastirsky
And move ToolBoxButtonSize->ImageType mapping code to a common place. Change-Id: If158f4b6f2750054fcf64491c2941706e7d3a329
2017-04-23Fix open command nameMaxim Monastirsky
Change-Id: If5768a8f624a34b721ed14039ba5d2440aaf109d
2017-04-23tdf#104610 Always enabled no-width break formatting marksYousuf Philips
Change-Id: I0708a61d43bfa44dac19683b200975e3a6da788a Reviewed-on: https://gerrit.libreoffice.org/36807 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>
2017-04-22mark all new styles as default styles, tdf#103380, tdf#103330Markus Mohrhard
Change-Id: I0b893d61ea6c9d0fd4af9f08b0d3b2e5454e544e Reviewed-on: https://gerrit.libreoffice.org/36819 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-04-22tdf#107068 add arrow to the buttons, mark if field is filteredTomaž Vajngerl
Change-Id: Iba0b4c2ce3ab84229d388a7cb2d20db1f47c0b57 Reviewed-on: https://gerrit.libreoffice.org/36738 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2017-04-21gbuild: Remove MSVC 2013 legacy codeDavid Ostrovsky
Uwinapi is discontinued. Change-Id: I063b4d0d8fab2d60de168e960a63b8181158ac01 Reviewed-on: https://gerrit.libreoffice.org/23198 Reviewed-by: David Ostrovsky <david@ostrovsky.org> Tested-by: David Ostrovsky <david@ostrovsky.org>
2017-04-21LOK - Calc: changed the way header is updated on row/col insert/removeMarco Cecchetti
This patch introduce a new LOK callback for informing the client that the row/col header is no more valid and needs to be updated. Change-Id: I21a3a41d69bd1a3c11c9ffaf1d7d53dbc3b9681d Reviewed-on: https://gerrit.libreoffice.org/36733 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2017-04-21loplugin:unnecessaryvirtualNoel Grandin
Change-Id: Ibf396e5431d30cb62f086fa723b88c330c18961b Reviewed-on: https://gerrit.libreoffice.org/36771 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-21convert HTML_OPTION_IDS to scoped enumNoel Grandin
Change-Id: Ia766dc58a571e5853005fd394283d7b53f02e4a6 Reviewed-on: https://gerrit.libreoffice.org/36748 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-21remove unnecessary explicit linefeeds from end of SAL and OSL log callsNoel Grandin
Change-Id: I3fa363c8e76e6cfb297f4ec346e3f031c09d6fbf Reviewed-on: https://gerrit.libreoffice.org/36727 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-21remove some old MSVC workaroundsNoel Grandin
Change-Id: I6abd8aaffb27b3c85df7c0518f7f576be4e32222 Reviewed-on: https://gerrit.libreoffice.org/36660 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-20tdf#107143 Add delete all comments command.Gulsah Kose
Change-Id: I1375375543172146a27ed4225f584121f9945a8c Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/36623 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-04-20renumber string IDs and close 40 gaps of resident empty stringsEike Rathke
With the help of sc/util/number-defines-consecutively.awk Change-Id: I1d2656ee8527cde6d6464b423a332401946f82a1
2017-04-20keep list sorted by alphabetical opcodeEike Rathke
Change-Id: I8eafa00cadd6196e4e9dd87a00fd530c3945af2c
2017-04-20Resolves: tdf#99625 add parameter classification for TEXTJOIN and CONCATEike Rathke
So in array context the functions return a single string instead of an array of identical strings. Change-Id: Ia6ada10be4912745b60e281fac1736c560162d3a
2017-04-20sc lok: Notify when comment is added to destination docPranav Kant
This can happen, for example, when undoing a deleted comment. Change-Id: I4aff244f1263b650457a70334f5f4d2c75ad3b64
2017-04-20loplugin:unusedmethodsNoel Grandin
Change-Id: Ib7a9b1b0802ca751da258065e89b412b090bb672 Reviewed-on: https://gerrit.libreoffice.org/36718 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>