summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)Author
2016-09-01remove now pointless comment about alignment boundariesEike Rathke
... and adapt ScRawToken size comment to reality. Change-Id: Ia9c1cecc5d01f49c6d5fbe5b53472e6f0ef153cb
2016-09-01cosmeticsEike Rathke
Change-Id: I22d4c04db2917f96e3c9ca1a71c628e859ad13c5
2016-09-01move comment to where it belongsEike Rathke
Change-Id: Ia3110b911e6d367a3b5d246a95384efc2f72f9f8
2016-09-01No more need for ScRawTokenBaseStephan Bergmann
...since 05eda0dc19af81ed0d5167bdd0a92113e6e8bc60 "loplugin:unusedfields in sc" Change-Id: Id80ec49fc93a6d599e2b36727c0424af77fae693
2016-09-01exclude also single quoted strings from function name suggestionEike Rathke
These may be sheet names or label names, but never function names. For example, typing ='e should not suggest "[EASTERSUNDAY], EDATE, ..." Change-Id: I818b91b533b868ccb6d2eb1eef74112162d2fe3d
2016-09-01sc lok: implement SfxViewShell::NotifyCursor() APIMiklos Vajna
This way a new Calc view gets the cell cursors of existing views even if they don't move after registering the LOK callback in the new view. Change-Id: I5babc9921d37217ac199d4c19ed33cbb9620d119 Reviewed-on: https://gerrit.libreoffice.org/28581 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-09-01std::list<sal_Int32> to vectorNoel Grandin
Change-Id: I9691983a026ce4c0d2979de85b0abaed48b90910
2016-09-01std::list<sal_Int32> to vectorNoel Grandin
Change-Id: I468689916e508e65cbe37d7b1123f47b63d9b08b
2016-09-01convert RefDevMode to scoped enumNoel Grandin
and fix the bForceZeroExtleadBug TODO Change-Id: Iac9295c6ce31112d69a870e3a229823eb1e9a4f2
2016-09-01remove some unnecessary global.hxx includesJochen Nitschke
Change-Id: I50afe36056d32352a1c3118bc445fd55bcf10b6e Reviewed-on: https://gerrit.libreoffice.org/28568 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-09-01use IsStaticDefaultItem from poolitem.hxx instead of custom checksJochen Nitschke
Change-Id: Ic49a940d83e5b8944bd724203bb2045bb1eb22b9 Reviewed-on: https://gerrit.libreoffice.org/28567 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-31let's make Impress crash less - SfxStyleFamily editionMichael Stahl
Commit bcb41235deaf4b7ca90522bda3ba21a686819e6e - in addition to introducing the enum SfxStyleFamily - inconsistently converted one call of DrawDocShell::SetStyleFamily to use enum SfxStyleFamily instead of a mysterious "5", but did not adapt all of the code that extracts the SfxUInt16Item that subsequently extracts this value and expects a number 0-5. Since it's clearly inexcusably stupid to have 2 different public sets of integers identifying styles, make the usage of the second "array index" integers private to templdlg.cxx; the SfxUInt16 item now always contains enum SfxStyleFamily. (regression from bcb41235deaf4b7ca90522bda3ba21a686819e6e) Change-Id: I333575c504277c2046f8f5a6b36ae3f86b3b3201
2016-08-31add COVAR test caseZdeněk Crhonek
Change-Id: I734d3a2b958a7d353e3b87db46793c836dbb0e27 Reviewed-on: https://gerrit.libreoffice.org/28563 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-08-31add COVARIANCE.S test caseZdeněk Crhonek
Change-Id: Ib7f716c76ea9f56c70045b9b6cc2fcbd0cab8d77 Reviewed-on: https://gerrit.libreoffice.org/28560 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-08-31add CONFIDENCE.T test caseZdeněk Crhonek
Change-Id: Ibd7b84360a27642dc9f9210876f514e9dc109c2d Reviewed-on: https://gerrit.libreoffice.org/28562 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-08-31add COUNTIF test caseZdeněk Crhonek
Change-Id: I5b4f961ff051ecbaf615d5584bb9964f05dc65fd Reviewed-on: https://gerrit.libreoffice.org/28559 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-08-31Resolves tdf#100709 Optimize SheetDataBuffer::addColXfStyleMaarten Bosmans
The insertion of RowRanges into the sorted set was done by iterating through the set until the correct insertion point was found. By using set.lower_bound(), the complexity goes from O(N) to (log N) for a single insert. Regarding tdf#100709: the import time for the attached example document reduces by 12x. Change-Id: Ifb03d58a0e46a936ab61a5f0b512e956c87e5e2b Reviewed-on: https://gerrit.libreoffice.org/28510 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2016-08-31Related: tdf#100709 Fix two bugs in SheetDataBuffer::addColXfStyleMaarten Bosmans
The addColXfStyle method is supposed to add a formatId to all the cells in a specified CellRange where there is no previously set formatId in the maStylesPerColumn member variable. There where two bugs in this function: - If there is overlap between the row ranges already in maStylesPerColumnBB and the given RowRange, it should be updated to only cover non-overlapping cells. - In the case when the given CellRange spans multiple columns, the RowRange should be applied to all these columns. When the row range given to this method is changed because of earlier set RowRanges in maStylesPerColumn[nCol], the RowRange was not reset to the given method argument for a new column. Change-Id: I4244c4303ca983801c5116cbd26971dd641411ab Reviewed-on: https://gerrit.libreoffice.org/28509 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2016-08-31add CORREL test caseZdeněk Crhonek
Change-Id: Ifffb6e2ba2c9d7370d49799f4b741e8687ea69bb Reviewed-on: https://gerrit.libreoffice.org/28533 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-08-31add COVARIANCE.P test caseZdeněk Crhonek
Change-Id: I5e5fe6d302b46580048de69eeda3968981f322b5 Reviewed-on: https://gerrit.libreoffice.org/28527 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-08-31add ERFC.PRECISE test caseZdeněk Crhonek
Change-Id: I072ed4639feba9f6f32ee57e6425e6b2c0dde479 Reviewed-on: https://gerrit.libreoffice.org/28532 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-08-31add COUNTA test caseZdeněk Crhonek
Change-Id: Ie86278cbcf11f5d4002a7345534ad9bc85ef7980 Reviewed-on: https://gerrit.libreoffice.org/28528 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-08-31add COUNT test caseZdeněk Crhonek
Change-Id: I0709224de2735c9a1a0ea3c92d091145910ced3e Reviewed-on: https://gerrit.libreoffice.org/28531 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-08-31add COUNTIFS testcaseZdeněk Crhonek
Change-Id: I367b1cd13175233a51e05844c0f6e3d1e7115afd Reviewed-on: https://gerrit.libreoffice.org/28530 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-08-31add COUNTBLANK test caseZdeněk Crhonek
Change-Id: I2e220dd0e2b00a06e4fc3f06a5510961828929f5 Reviewed-on: https://gerrit.libreoffice.org/28529 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-08-30add HYPERLINK test caseZdeněk Crhonek
Change-Id: Ic7254e2c69a85f2020b0a79e79d9252fe0a0069d Reviewed-on: https://gerrit.libreoffice.org/28471 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-08-30Translate some German comments and messagesMaarten Bosmans
Change-Id: Id15e1afd991f3476e260ba40a8c45c7261113577 Reviewed-on: https://gerrit.libreoffice.org/28493 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2016-08-30sc lok: implement getCommandValues(.uno:AcceptTrackedChanges) APIMiklos Vajna
Unlike in Writer, there doesn't seem to be an existing UNO API that can be reused here. Change-Id: I011a2f34d4d09ad604991637322ceadf6b2eb181 Reviewed-on: https://gerrit.libreoffice.org/28498 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-08-30loplugin:stringconstant: adapt to improved OUStringLiteral1 (sc)Stephan Bergmann
Change-Id: I41af3d6acdb5dfdaa27febf99cc3c5aa031ad779
2016-08-30loplugin:countusersofdefaultparamsNoel Grandin
Change-Id: I69f55593e6101906e0e97565f2cfc818852258dd Reviewed-on: https://gerrit.libreoffice.org/28486 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-30Let OUStringLiteral1 take its arg as ctor arg, not template argStephan Bergmann
...which makes it more flexible, can now also be used on non-const arguments. The drawback of the argument no longer being a compile-time constant is remedied by making the ctor constexpr. Change-Id: Ia4903a2cc86791fece92eac0cb8406b6659dd19d
2016-08-29add GETPIVOTDATA test fileZdeněk Crhonek
Change-Id: Ief1028336815671e43b4ae3c84fe2c8c31c882c2 Reviewed-on: https://gerrit.libreoffice.org/28441 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-08-29add AVERAGEIFS test caseZdeněk Crhonek
Change-Id: Ie4c713f3724ffaa7100e40c469d1e117d0fa277d Reviewed-on: https://gerrit.libreoffice.org/28146 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-08-29add ERROR.TYPE test caseZdeněk Crhonek
Change-Id: I1df542dd2c4d09e7968cfc8db29a8ff33c2dc397 Reviewed-on: https://gerrit.libreoffice.org/28466 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-08-29add HLOOKUP test caseZdeněk Crhonek
Change-Id: I4a4fcec694522060bede6ef66aed818b1dd37c14 Reviewed-on: https://gerrit.libreoffice.org/28442 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-08-29Adapt loplugin:stringconstant to improved OUStringLiteral1Stephan Bergmann
Change-Id: Ibc5128df8bcf8cb5f2f09551c0de6dfdb46bdee0 Reviewed-on: https://gerrit.libreoffice.org/28447 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-08-29loplugin:countusersofdefaultparamsNoel Grandin
Change-Id: I26f46ddac3d7d810ebfa1c3e7f1a77427369828e Reviewed-on: https://gerrit.libreoffice.org/28451 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-29tdf#93329 : Fixes FTest algorithmic bugDennis Francis
Also added tests for FTEST() with reference results from Octave that covers a reasonable range of variance ratios. References : 1) Octave-Forge : https://sourceforge.net/p/octave/statistics/ci/default/tree/inst/vartest2.m with head = f8f3ede1f4e9576f0e05700d7bed0b3f2753e9c5 2) R-project : https://github.com/wch/r-source/blob/trunk/src/library/stats/R/var.test.R From read-only mirror of R source code from https://svn.r-project.org/R/, updated hourly. branch : "trunk", head = d48a3960875fa373e1e68286245ee8e1bc7ac0fd Change-Id: Icc843be3a1497e4d69e8b39b31c4b6998594dfe9 Reviewed-on: https://gerrit.libreoffice.org/26482 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
2016-08-27put StreamMode masks in scope of enum classJochen Nitschke
Change-Id: I77682f7e289a59b986bb84edf014029a20266470 Reviewed-on: https://gerrit.libreoffice.org/28420 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-26Change the wrong message in testJaskaran Singh
Change-Id: I1c0d9563c67f2480906299bc039a853926f707df Reviewed-on: https://gerrit.libreoffice.org/28413 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jaskaran singh <jvsg1303@gmail.com>
2016-08-26handle overwriting of symbols/opcodes in symbol map for known casesEike Rathke
This silences the SAL_WARN_IF like warn:formula.core:6944:1:formula/source/core/api/FormulaCompiler.cxx:625: OpCodeMap::putOpCode: reusing OpCode 161, replacing '_xlfn.ORG.OPENOFFICE.ERRORTYPE' with 'ERRORTYPE' in English map 0x1018000 that occurred during the first load of OOXML .xlsx documents since the old bad entries were added with commit 89c4a69103b6e15e7f52401c51110b926c3ccf36 In fact the direction opcode -> string was replaced, which it should had not. That specific mapping is only used though when loading msoxl namespace formulas from ODF. Also, the replacement of parameter separator and array column and row separator worked merely by chance, depending on in which order the entries where inserted to the hash map. Fixed along as it popped up with the new handling. Change-Id: I88017a8b38ccc30874c3dca7d78f0fa47a77a36f
2016-08-26tdf#101672 non-split underline buttonMaxim Monastirsky
Change-Id: Ib20dc0d0036f594adb83a50c2e3da66f565b2db8 Reviewed-on: https://gerrit.libreoffice.org/28356 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2016-08-26add COLUMN test caseZdeněk Crhonek
Change-Id: I84aa4fb7029eece377db445c058e16824818717c Reviewed-on: https://gerrit.libreoffice.org/28390 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-08-26add COLUMNS test caseZdeněk Crhonek
Change-Id: I411f82576359ba7da9e9f9bda701b7438e542603 Reviewed-on: https://gerrit.libreoffice.org/28391 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-08-26add Errortype test caseZdeněk Crhonek
Change-Id: Ib432198503063a5ce43b2d1b877c36a9aa587fd9 Reviewed-on: https://gerrit.libreoffice.org/28394 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-08-26convert SV_ITEM_ID_LBOX defines to scoped enumJochen Nitschke
and remove unused SV_ITEM_ID_EXTENDRLBOXSTRING Change-Id: Ic84d9341d0225b01b9ef46814483c66b1af307b5 Reviewed-on: https://gerrit.libreoffice.org/28397 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-25Notebookbar: Single contextual toolbar implementationYousuf Philips
Change-Id: I72a0bffc3f1093d9f07ea9d4ba9101df2cf4d032 Reviewed-on: https://gerrit.libreoffice.org/28331 Reviewed-by: Szymon Kłos <eszkadev@gmail.com> Tested-by: Szymon Kłos <eszkadev@gmail.com>
2016-08-25coverity#704161 Resource leak in objectCaolán McNamara
Change-Id: I111f815526c3f50238f5df6f795abb397bb089e2
2016-08-25use PushTokenRef()Eike Rathke
Change-Id: I626eeb2e996dc33915a045acfe6892e428c6db03
2016-08-25ditch the now unused ever cloning PushTempToken(const formula::FormulaToken&)Eike Rathke
Change-Id: I0d09039a5f9cb797b5b72f3ee9044eab7c8f05c5