summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)Author
2020-03-06loplugin:unusedmethodsNoel Grandin
Change-Id: I698981490eb1391930cdd06821a80a5f770e000e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90109 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-06formula manager: wrong category returned by ScFuncDesc::getCategoryMarco Cecchetti
In the function manager the index associated to each category starts from 0 while in ScFuncDesc starts from 1 (data member ScFuncDesc::nCategory) Change-Id: I92d0cd2a1a2871785e45faafd797dcf3a500bec7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89198 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Dennis Francis <dennis.francis@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90072 Tested-by: Jenkins Reviewed-by: Marco Cecchetti <marco.cecchetti@collabora.com>
2020-03-06lok: calc: unwanted cell range selection occurs when clicking on a cellMarco Cecchetti
When user clicks on a cell after the browser has lost focus user gets the cell range from A1 to the current clicked cell selected Change-Id: I1dd495f42ca7e5ee8cad1d2354dcebc0cb05d65f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88549 Tested-by: Marco Cecchetti <marco.cecchetti@collabora.com> Reviewed-by: Marco Cecchetti <marco.cecchetti@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90071 Tested-by: Jenkins
2020-03-06lok: calc: send text selection rectangles for the input barMarco Cecchetti
Change-Id: I3caeaddd7a5ddc6e496650539b88e2fd81b37e6e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86790 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90069 Tested-by: Jenkins Reviewed-by: Marco Cecchetti <marco.cecchetti@collabora.com>
2020-03-06lok: calc: zoom: object selection - is unreliableMarco Cecchetti
Change-Id: Ic8e61c56bdf38bbb74f179fa36075bdd3a601249 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90068 Tested-by: Jenkins Reviewed-by: Marco Cecchetti <marco.cecchetti@collabora.com>
2020-03-06lok: calc formula bar tunneling: resize the main windowMarco Cecchetti
When a resize msg is forwarded from the client to the core for the formula bar, for instance because of a browser window resizing, we need to resize the whole main app window not the formula bar only. On the contrary we have 2 issues: 1) each time the formula bar get focus the layout manager tries to set the size of the formula bar back so that it fits inside the app window 2) the part of the formula bar outside the app window doesn't respond to mouse events on the client side. Change-Id: I13ddc40a2a8e543808a4bf36a04022deb3700163 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89858 Tested-by: Jenkins Reviewed-by: Marco Cecchetti <marco.cecchetti@collabora.com>
2020-03-06lok: calc formula bar tunnelingMarco Cecchetti
Change-Id: I92026098222e04a163796225a048c6d7dc1b37c5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89857 Tested-by: Jenkins Reviewed-by: Marco Cecchetti <marco.cecchetti@collabora.com>
2020-03-06lok: on calc spelling context menu didn't pop upMarco Cecchetti
The problem has been fixed by making visible cell range syncronized with client visible area Change-Id: I632f8ef4d5e8fa227b55fcb0459ed89d10798134 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89856 Tested-by: Jenkins Reviewed-by: Marco Cecchetti <marco.cecchetti@collabora.com>
2020-03-06Related: tdf#131157 inherit ScDrawTransferObj from TransferDataContainerCaolán McNamara
Change-Id: I5119b959a6bff958582c404c03af59bd52c9497a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90051 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-03-06tdf#131157 problems dragging and dropping from calc navigatorCaolán McNamara
Change-Id: I40f05704248c43c30d479d42932adfd594391a60 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90052 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-03-06use more FastParser in ScXMLTableContextNoel Grandin
Change-Id: I16018b07bb4c71b60c547dad2d53420a14686e18 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90056 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-06use more FastParser in ScXMLContentValidationContextNoel Grandin
Change-Id: I958d2ad1a8dc6c2a3da1c1a4fc6bd4f0011367fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90055 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-05restore calc navigator custom tooltipCaolán McNamara
Change-Id: Ic378364e0d6c5eb704872ec9a3c73f63c222855a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90049 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-03-05lok: remove complex rotation / alignment settingsHenry Castro
It is very confusing for mobile user the text orientation properties, let's remove the property for mobile view. Change-Id: I4150f9ed7343d38fd00ee66fa5afffe40426b984 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89840 Tested-by: Jenkins Reviewed-by: Henry Castro <hcastro@collabora.com>
2020-03-05tdf#75330 add a new overlay/no-overlay feature for the legendTünde Tóth
Implement "Show the legend without overlapping the chart" option for chart legend. Change-Id: Ifbba4c81136e13995d276434dc17a97b0675428c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89810 Tested-by: Jenkins Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-03-05use FastParser in ScXMLMasterStylesContextNoel Grandin
Change-Id: I432a3b5a1087a50b2cdc959b42bc58209a6cedfc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89993 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-05use FastParser in XMLTableStylesContextNoel Grandin
Change-Id: If06d8cfc856aa5180199bce2bc747fa9bd667bb0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89994 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-05Rename method setReplacementElement()Jens Carl
... to setElement() to have a uniform interface with similar classes like XNameContainer. Change-Id: I2058e3ea9f14a5792a07f23f4bd13c4708dccdfc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89784 Tested-by: Jens Carl <j.carl43@gmx.de> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2020-03-04fix ToC links give unhelpful url popupsMert Tumer
core expects ctrl+click for internal links too and it should not expect it if it is tiled rendering Change-Id: Id841f0e9729e46f00988ea0b4eb29bd65098a740 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89559 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit 3fe9dfca2d44d9e41ee329883f199359c673f382) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89919 Tested-by: Jenkins
2020-03-03Revert "Make Chart Creation Wizard async"Stephan Bergmann
This reverts commit ed86b6250cd00ed6b7bdb81307bc66adba129cae. Reason for revert: Most Jenkins builds for that change were aborted after timing out, and many other Gerrit Jenkins and tinderbox builds now time out, too. It very much smells like that commit was the culprit. Change-Id: I5473c58957f92d63113e32f862ad9c114f9c844c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89803 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-03-02uitest: check copy in .uno:MoveXisco Fauli
Change-Id: I916d3853500705b1037aa669374511c184402313 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89822 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-03-02cid#1459023 Dereference null return valueCaolán McNamara
Change-Id: Id99adac0a544b59b6ac8f6ac225df1f218ed8405 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89765 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-03-02tdf#126904 calc right arrow large unexpected column jump in protected sheetNoel Grandin
regression from commit 7282014e362a1529a36c88eb308df8ed359c2cfa Date: Fri Feb 1 15:15:16 2019 +0100 tdf#50916 Makes numbers of columns dynamic. Change-Id: I3b6f6e5430c97ef52f63c406eb3c3b39b9dd578e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89809 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-02Make Chart Creation Wizard asyncSzymon Kłos
* FuInsertChart as a memeber in ScTabViewShell stores instance is needed to react on the dialog's result * CreationWizardUnoDlg converted to XAsynchronousExecutableDialog added dialog close handler which notifies listeners In the Online dialog become dead after closing, additional PostUserEvent was needed to kill the dialog after real close (without it user needed to select any cell to close dialog) * Reuse in Writer Change-Id: I9fe123d5c189d568f0edb4d36173a224a820a8a3 Reviewed-on: https://gerrit.libreoffice.org/79654 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/79571 Tested-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2020-03-02Add XServiceInfo tests to ScTableSheetsObjJens Carl
Change-Id: Iaaadc2554bb0ce103ef01bbf02c316d21fae51af Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89761 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2020-03-01Related: tdf#130371 Broadcast ScAreasChanged for created namesEike Rathke
... to notify the Name Box to refresh its name list. Change-Id: I20fb461d59c0dd98698837d91e2a7ef9a8c5a4ef Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89768 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2020-03-01cid#1459028 various checked_return warningsCaolán McNamara
and cid#1459027, cid#1459026, cid#1459025, cid#1459024, cid#1459021, cid#1459018 Change-Id: If92e7665fcf947c5daf3094b9003e85c5c51f48f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89763 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-03-01lok: Unlock chart contollers after insertion on mobile viewMuhammet Kara
The chart controllers were locked until the dialog finishes its execution, but at some point, dialog is disabled for mobile view, and seems like it was forgotten to unlock the controllers. Change-Id: Ib1e5799f5c84ef8b3ebc0f538909b4f8b586ff1a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86716 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89708 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-03-01lok: Improve hyperlink insertion to cell with contentMuhammet Kara
Change-Id: I520939dd5b44236cf835108ee2bc96c29f0a9677 Reviewed-on: https://gerrit.libreoffice.org/85509 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Marco Cecchetti <marco.cecchetti@collabora.com> Tested-by: Marco Cecchetti <marco.cecchetti@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89707 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-02-29ofz#20904 check boundsCaolán McNamara
Change-Id: I5d6d381ebd359b233b309e08131f3dda21310d80 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89620 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-29send hyperlinkclicked callback on calc mobileMert Tumer
for opening links ctrl+click must be pressed but in mobile this cant be done This patch allows it to send the callback and also cell coordinates for hyperlink popup Change-Id: I8c0fac167627ef449d9cf20a36a7a5a77978ae0f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89121 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com> (cherry picked from commit 9bfa939f87f28cdaed2a24c3dc5f9a21004b19da) Blind build fix for Android After 9bfa939f87f28cdaed2a24c3dc5f9a21004b19da Also, replace chained OStringBuffer::append() with operator+ Change-Id: I7012667b3c4173cc0193720e0197992e5942bc7d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89164 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89693 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-02-28weld calc navigatorCaolán McNamara
note: non-standard dnd via parent so the treeview triggers the dnd but doesn't itself strictly speaking drive the dnd, see copying a range from the navigator where the calc main edit window shows the outline where the copy of the range from the calc main window will go Change-Id: Ideecbe779e3d9bb5b392357a93ec25f625180ba8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89597 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-28tdf#130909 Tabbed interface calc hide subsuperscriptionandreas kainz
Change-Id: I627733a719d52afdfbac07525a9609bbe1b5f20c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89650 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2020-02-27tdf#45904 Move XNameContainer Java tests to C++Jens Carl
Move missing XNameContainer Java tests to C++ for ScTableSheetsObj. Change-Id: I63a91487ab2e50b97c937edae929c43261553db9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89614 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2020-02-27tdf#45904 Move XElementAccess Java tests to C++Jens Carl
Move XElementAccess Java tests to C++ for ScTableSheetsObj. Change-Id: Ibc9d7e164e82387159a51568157c1d3b0756bf05 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89610 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2020-02-27inherit ScLinkTransferObj from TransferDataContainerCaolán McNamara
Change-Id: I04d8a673e92e847e1485f85d951172bf71a8877b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89647 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-27tdf#101710 Fix invalid style:data-style-name attributeMaxim Monastirsky
There were two problems with this attribute: 1. It was written in style:table-cell-properties instead of in style:style. 2. It was referencing a number format id, instead of a style name. Moreover, the data style wasn't even exported as part of office:styles (if at all). Both import and export were affected. For export, it was easily possible to reuse some related stuff from Calc, so that stuff was moved into xmloff and used from there (there are no logic changes for Calc). For import, loading of the invalid attribute was kept for compat reasons. Although it's only useful for automatic number formats, as the data styles weren't exported properly anyway (e.g. see the document attached in bugzilla). Change-Id: I8b70ad205972fada6f3845837d6ed5928d7d6406 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89551 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-02-27tdf#130959: Add unittestXisco Fauli
Change-Id: Ib66a2a48b6e0d746fc54d2b1987a574c26ea1c1e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89619 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-02-27Related: tdf#130725: use strtod also in rtl::math::stringToDoubleMike Kaganski
Size of buffer on stack is 256 characters. Logging function usage in make check, of >1 100 000 invocations, the longest string was 80 characters, average being 4.6 characters. So heap allocation is unlikely in scenarios with intensive function usage. Several existing unit tests had to be fixed. Usually, the change is either minimal or getting closer to what Excel returns (for Calc tests). But in case of AMORDEGRC, I had to change rate value passed to the function from 0.3 to 0.31. It's because the closest double value for 0.3 is 0.29999999999999999, which is a bit less than 0.3; multiplied by 1.5, this gives 0.44999999999999996, and then rounding the result of multiplication of the latter by cost gave the result 1 less than before, when 0.3 was imported as 0.30000000000000004. Now the function returns a value 1 less than Excel for that set of arguments. I don't see how to fix that. Having rate slightly different gives consistent result between Calc and Excel. Change-Id: Icae5ce374fe0c31a1aa10cee815e65ef0014f382 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89422 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-02-27tdf#130725: use strtod by David M. Gay to make sure we get the nearestMike Kaganski
... representation of given decimal. Use dtoa.c from https://www.netlib.org/fp/dtoa.c to build a custom static library that doesn't use current locale (unlike strtod from stdlib.h). This is the implementation used by e.g. python and nss (search for "dtoa.c" under UnpackedTarball). To avoid name clash with the standard strtod, rename the function to strtod_nolocale. Size of buffer on stack in ImpSvNumberInputScan::StringToDouble is 256 characters. Logging function usage in make check, of ~124 600 invocations, the longest string was 14 characters, average being 2.1 characters. So heap allocation is unlikely in scenarios with intensive function usage. After std::from_chars is available in baseline compilers, external library can be dropped, and call to strtod_nolocale replaced with the standard function. The artifact at https://dev-www.libreoffice.org/src/dtoa-20180411.tgz is created with mkdir dtoa && mkdir dtoa/src && wget https://www.netlib.org/fp/dtoa.c -O dtoa/src/dtoa.c && \ printf 'd8bab255476f39ea495c8c8ed164f9077da926e6ca7afb9ad3c56d337c4484fe dtoa/src/dtoa.c' | sha256sum -c && \ tar -c --owner=0 --group=0 --mode=go=r,u=rw --mtime='Wed, 11 Apr 2018 15:59:39 GMT' dtoa/src/dtoa.c | gzip -n > dtoa-20180411.tgz && \ printf '0082d0684f7db6f62361b76c4b7faba19e0c7ce5cb8e36c4b65fea8281e711b4 dtoa-20180411.tgz' | sha256sum -c (where the date "Wed, 11 Apr 2018 15:59:39 GMT" is from `wget -S https://www.netlib.org/fp/dtoa.c` "Last-Modified: Wed, 11 Apr 2018 15:59:39 GMT" header). Change-Id: Ia61b7678e257c4bc1ff193f3f856d611aa5c1a21 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88854 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-02-27tdf#130959 crash when opening file with non-existing hyperlinksNoel Grandin
regression from commit 0ef5c47547bec6319b853326603f3b807407fe78 sc: rowcol: tdf#50916 convert core/tool Change-Id: I8cb8fa4c6abf7450386a284a26be0a6d3ab9a623 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89617 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-27loplugin:unusedfieldsNoel Grandin
Change-Id: I0d3941ed2a6f0caadbe080ac8a6273c5ec21462c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89616 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-27CheckDataArea is dead codeCaolán McNamara
nDataId is not a togglebutton so IsItemChecked is always false Change-Id: I6b75e36ee34f7234f1ffa11f38495e4dc1ad1eb6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89558 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-27tdf#45904 Move XIndexAccess Java tests to C++Jens Carl
Move XIndexAccess Java tests to C++ for ScTableSheetsObj. Change-Id: Idb130a51dc024cebbbc739d15c767f99558a69b7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89609 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2020-02-26Unit test tdf#130825 insert/delete sheet moving sheet-local namesEike Rathke
Change-Id: I1f0aed734ebb2c1035e06350d3508becb0d68b4d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89476 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2020-02-26Resolves: tdf#130825 Compare exclusive end, not inclusive end sheet numberEike Rathke
Change-Id: Id5c3056f4e4466ccb5ea3654e60869bf7788b7ca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89471 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2020-02-26Resolves tdf#127508 - Flat table header in CalcHeiko Tietze
Amends 67fd62b3edc86c2891f279b25cf9919c4bbbbca1 with flat corner button Change-Id: Ia26aff0844069dd435cf4edd7524c19f5f0f22ea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89365 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-02-26tdf#45904 Move XNameReplace Java test to C++Jens Carl
Move XNameReplace Java test to C++ for ScTableSheetsObj. Fixes i#23594 by creating a new "com.sun.star.sheet.Spreadsheet" rather then using an existing one. Change-Id: If7058647cc5d79d11e5542a82017d5bd02f7049e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89493 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2020-02-26tdf#45904 Move XNameAccess Java tests to C++Jens Carl
Move XNameAccess Java tests to C++ for ScTableSheetsObj. Change-Id: I5fdaafe35852ea3c6e260d490200ce99e990c3b6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89408 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2020-02-25loplugin:referencecastingNoel Grandin
getting --enable-pch=normal working with clang means that the plugins now have a better view on some stuff, so trigger more warnings Change-Id: I83ca010c0ef07c8106068362bb50a354e3cf7dae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89312 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>