summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)Author
2016-10-19tdf#96015 (part) link to Doc'tation in Help menuOlivier Hallot
Add the entry "Documentation" to the modules Help menu. on click, the system browser opens http://hub.libreoffice.org/documentation/?&LOlang=<locale> <locale> is obtained from .getLocale() Patch2: create a member with try/catch for external URLs Patch3 Use sfx2::openUriExternally Revert to User Guides.. in UI. Change-Id: I8332253c31bd3be330cdd794f9e056b632b38037 Patch4: remove 1st '&' in URLs Reviewed-on: https://gerrit.libreoffice.org/28817 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-10-19Resolves: tdf#100841 use Popover instead of Tooltip for the fill series hintCaolán McNamara
Change-Id: Id84265d7c76869059144e28c1d9a735efa46fe29
2016-10-19Plugin::isInUnoIncludeFile should not cover WORKDIRStephan Bergmann
...that got in, for no apparent reason, when various, slightly different implementations of isInUnoIncludeFile got consolidated into one. Change-Id: I64a9eb62703d57a0b7b57720ec9f251ffa780691
2016-10-19loplugin:expandablemethodds in scNoel Grandin
Change-Id: Idda64b23ea91ec457b60279d851b7f01d8c02881 Reviewed-on: https://gerrit.libreoffice.org/30033 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-18tdf#93894: Write a new test case for column and row labels combined.Kohei Yoshida
Change-Id: I76e1f6f3c3aed9d940e4433026f752f3630f2373
2016-10-18tdf#93894: These assumptions no longer hold.Kohei Yoshida
Since we've switched to not grouping formulas with column / row labels. Change-Id: I0097a5103b5dfaa5b021ee76545beb9f24ac7bd3
2016-10-18tdf#93894: Prohibit grouping when certain token types are present.Kohei Yoshida
For instance, column / row label tokens don't work correctly in grouped cells with the current implementation. Change-Id: Idf86312ef15fbfd4382aa90ee6d131c671a80683
2016-10-18replace <<= with assign for <<= with rhs AnyJochen Nitschke
found by deleting specialization of '<<=' template Change-Id: I253f15177ab20fd3ef9baf4158da8c662cb47e6c Reviewed-on: https://gerrit.libreoffice.org/29956 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2016-10-18unit test for tdf#101583, named expression reference expansionEike Rathke
Change-Id: I40dc157ebb33da59e436214b703800dfabc11a23
2016-10-18Resolves: tdf#101583 references to be expanded must be at least 2 cols/rowsEike Rathke
... wide/tall also in named expressions. Change-Id: If0c192def74812cc9405ae633b6f83f7021344d0
2016-10-18tdf#89307: Removed T* SvRef::opeartor &()Jacek Fraczek
Usage has been replaced with SvRef::get() or removed where applicable. Change-Id: I49f108910b668466134c40940b53fc3ab2acd816 Reviewed-on: https://gerrit.libreoffice.org/29780 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-10-18add EXACT testcaseZdeněk Crhonek
Change-Id: I6e0d868e0e3dc8e1575145fc942fdb208f121887 Reviewed-on: https://gerrit.libreoffice.org/29918 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-10-18add FIND test caseZdeněk Crhonek
Change-Id: I4e053243df348f2ad4edfc78bb93c4226fe66d8c Reviewed-on: https://gerrit.libreoffice.org/29933 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-10-18add LOGNORM.INV test caseZdeněk Crhonek
Change-Id: I0ba74df841161a06d7ce1f697d44ecd9aeaea560 Reviewed-on: https://gerrit.libreoffice.org/29974 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-10-18add FIXED test caseZdeněk Crhonek
Change-Id: I9016563b9d01b3ac917e10f17f844b1ce3a3f13c Reviewed-on: https://gerrit.libreoffice.org/29979 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-10-18add LOGNORMDIST test caseZdeněk Crhonek
Change-Id: I08df55702e8dfe251c57fbb0ff3bde876e0934e8 Reviewed-on: https://gerrit.libreoffice.org/29975 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-10-18loplugin:unusedmethodsNoel Grandin
Change-Id: Icf773925c37dde8b7404edac9864e7b10fe113b4 Reviewed-on: https://gerrit.libreoffice.org/29968 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-17comment that the country entries are just placeholdersEike Rathke
09f2f36 related, tdf#102357 Change-Id: I053853227d36dfd17da5914487a6aefe8af06f2d
2016-10-17pamper over-pessimistic whining compilers, tdf#102357 follow-upEike Rathke
No, stupid, the switch-cases really cover all possible cases we entered this block for. Change-Id: I1abbe2d784d5bbcc29c4c929adb622d9fe92fe54
2016-10-17Resolves: tdf#102357 export correct locale attribution, not just countryEike Rathke
So all XMLPropertyHandler derived XMLCharLanguageHdl, XMLCharScriptHdl, XMLCharCountryHdl and XMLCharRfcLanguageTagHdl are actually called. Broken since commit 21661ebfbec9ea162582bbc7ab46607eb9095f1a Date: Wed Aug 21 19:16:23 2013 -0400 fdo#60740: Populate auto styles from edit cells without using UNO API. Change-Id: If0523752a4dea4e18d3d86ca5a2735fbcf39c3e3
2016-10-17replace <<= with assign for <<= with rhs AnyJochen Nitschke
makeAny and Any ctor return an Any Change-Id: Iaa361bc315d785f80153acf1009bf47d109728ec Reviewed-on: https://gerrit.libreoffice.org/29914 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2016-10-17tdf#103274: Add default XCommandEnvironment referenceGiuseppe Castagno
Change-Id: I4c9e4945e9fd4bb4fc2fe29e5a2a800cc5f298ae Reviewed-on: https://gerrit.libreoffice.org/29966 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
2016-10-16clang-cl loplugin: scStephan Bergmann
Change-Id: I24d091174ab602ecf80c65ad75fd450e55cb01ac Reviewed-on: https://gerrit.libreoffice.org/29856 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-10-16tdf#46738 Fix exporting .xlsx of coloured empty cellsBartosz Kosiorek
When spreadsheet contains more that 84 cells, and these cells are empty, but contains additional data (border color, text color, specific formatting), the remaining rows are ignored during export to .xlsx and .xls As a result such empty rows are not saved during export. This patch is fixing most cases and make sure that at least first 84 empty cells will be preserved. It is not impacting the performance as it is still notchecking next columns when the visible cells are more that 84 characters. This patch improve exporting empty cells, but not impacts performance. Change-Id: Ia7027e2c8a2fd48ab4a0e840f970d57167454451 Reviewed-on: https://gerrit.libreoffice.org/29899 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-10-16add BETAINV test caseZdeněk Crhonek
Change-Id: I0e3ed47b3efd4f869ab7d3b75577282d37b76619 Reviewed-on: https://gerrit.libreoffice.org/29895 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-10-16add DOLLAR test caseZdeněk Crhonek
Change-Id: I8bbc8b14faf17cd2219a26b25fe10ceb448b90ba Reviewed-on: https://gerrit.libreoffice.org/29896 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-10-16add CRITBINOM test caseZdeněk Crhonek
Change-Id: I0f6c28937da22ab3b514a51e5c4f63ca89377169 Reviewed-on: https://gerrit.libreoffice.org/29906 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-10-16add GAMMA.DIST test caseZdeněk Crhonek
Change-Id: Id17a38c823d0dae6bdf2bd7ec550b7b0f6e0c7f2 Reviewed-on: https://gerrit.libreoffice.org/29905 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-10-15Use UNO registration for font name toolbox controlMaxim Monastirsky
Should help to eventually get rid of the wrapper in reportdesign. Change-Id: I9fc94f2ed650561eb47f2f91939b3aa37f031c3b Reviewed-on: https://gerrit.libreoffice.org/29910 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2016-10-15Resolves: tdf#98481 Google Sheets uses OOXML t="str" differentlyEike Rathke
Set string results only for known good generators, otherwise recalculate. See source code comment. Change-Id: Ib89ba70fd7c3c515439498882fef90ca7c6e278d
2016-10-15PivotTable: No reason to call GetSource hereTamás Zolnai
GetSource generates internal members related to source data, but when this constructor is called we don't have valid source data yet. Change-Id: Ia813740fc425d70e7b294fca287f7afe784201a5
2016-10-15PivotTable cache: Remove useless mnValueSortIndexTamás Zolnai
We can use mnOrderIndex to get the same result. Change-Id: I71f68ebefe08c3664954ecdf6345cca4ed5ccafc
2016-10-15Small pivot table performance improvementTamás Zolnai
Change-Id: Ic57082aaadc4e2ed516c9875a421278e1ce4564a
2016-10-15use initializer list ...Jochen Nitschke
... for default pool item arrays and item infos Change-Id: I79db1b4e4a78471d81409dd976a912eeccf1065b Reviewed-on: https://gerrit.libreoffice.org/29540 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-10-14This is no longer used.Kohei Yoshida
Change-Id: I625a418c582b41ca324874e27900670151a9d2b2
2016-10-14Remove the branching at the end of IterateParametersIfs().Kohei Yoshida
For (hopefully) better performance. Change-Id: I59ed454aa9ace2f945facceee14f4e25610feebf
2016-10-14Do parameter count check outside of IterateParametersIfs().Kohei Yoshida
To reduce branching and scoping. Change-Id: I664e013f941c5b5dea44a6794ed133381cfc7b4c
2016-10-14sc: silence loplugin:staticmethodsMiklos Vajna
Where it complains about one specialization, but other ones can't be static. Change-Id: I031ddb795914c778f363b11ba16065e2b372b381
2016-10-14tdf#103211 Calc: it is insane to call EditGrowX/Y while the edit view is ↵Marco Cecchetti
growing. That could occur because of the call to SetDefaultItem later. We end up with wrong start/end edit columns and the changes to the output area performed by the inner call to EditGrowX are useless since they are discarded by the outer call. In the inner call the output area is not the new one computed by the outer call, on the contrary the data field `nEditStartCol` and `nEditEndCol` have been already modified, so the inner call would modify them using the wrong output area width. Maybe the call to SetDefaultItem should be performed in another place, anyway the outer call takes into account the correct horizontal adjust when computing the new start/end edit columns and the new left/right output area. Change-Id: I56d038f33ab9d1933c4c6cd1db6d9cd012fb6db1 Reviewed-on: https://gerrit.libreoffice.org/29784 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-10-14tdf#102948 Make HYPGEOMDIST ODFF1.2 compliant.Winfried Donkers
Also reduce duplicate code. On Export to OOXML, HYPGEOMDIST is converted to HYPGEOM.DIST. Change-Id: I70a70ee6b5c542e272ef574073ebcd1924f31083 Reviewed-on: https://gerrit.libreoffice.org/29767 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-10-14LOK: Calc: fixed missed tile invalidations on cell text editingMarco Cecchetti
What's new: 1) when an edit view is killed, the area which was used by the edit view is invalidated for both own window and other view windows after the edit view has been destroyed; 2) when an edit view is created or its out area is expanded, the windows of other views are invalidated too; 3) when a vertical scroll occurs in the edit view area the windows of other view are invalidated too; 4) same methods renaming since now we add/remove windows not edit views. Change-Id: Iac54f5b182c9562f08bb724f9ddde1c26cffa2e7 Reviewed-on: https://gerrit.libreoffice.org/29783 Reviewed-by: Marco Cecchetti <mrcekets@gmail.com> Tested-by: Marco Cecchetti <mrcekets@gmail.com>
2016-10-14LOK: Calc: an edit view may be not displayed when a 2nd one is killedMarco Cecchetti
- description: when in view #1 text editing of a cell is over (edit view killed) a cell still text edited in view #2 can stop to be painted correctly; - reason: when an edit view is killed an ScTabViewShell::UpdateFormulas is broadcasted to all views which in turn ends by invoking ScViewData::SetEditEngine for already existent edit views: if the needed output area size for the actual text content is less then the actual output area size (once grown, output area is never shrunk) leads to this issue; - solution: skip to invoke ScViewData::SetEditEngine when LOK is active and the related view is not the current view. Change-Id: I2a97966c7c04701f0a5443aaaeb74760b622045d Reviewed-on: https://gerrit.libreoffice.org/29627 Reviewed-by: Marco Cecchetti <mrcekets@gmail.com> Tested-by: Marco Cecchetti <mrcekets@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/29660
2016-10-14LOK: Calc: if text of 2 cells overlaps, painting occurs in wrong orderMarco Cecchetti
- description: when text content of two near cells (edited in 2 different views) overlaps, the input content showed is the one entered in the other view; - reason: the edit view of other views was painted after the edit view owned by the current view; Change-Id: I7c47f63bc46f7ce43fc494f018167918d44314b6 Reviewed-on: https://gerrit.libreoffice.org/29626 Reviewed-by: Marco Cecchetti <mrcekets@gmail.com> Tested-by: Marco Cecchetti <mrcekets@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/29659
2016-10-14LOK: Calc: missing invalidate when ending larger-than-cell edit textMarco Cecchetti
- reason: when text content goes further than the cell border the output area of the edit view is grown (extended to an adjacent cell), on the contrary the output area of edit views used only for invalidating windows of other view shells is never updated, so, in other views, only the tile where the edit cell is placed is invalidated; - solution: instead of adding fake edit views for invalidation porpuse (and having to updated the output area of each of them when required), the new solution provides each new edit view, created on cell editing, with a set of `foreign` windows related to other views, they are added and removed to this collection owned by an edit view still using the ScExtraEditViewManager, which has been in turn simplified; when EdiEngine::UpdateViews is invoked not only the window where the edit view lives is invalidated but also all `foreign` windows in the owned set; - note: ScTiledRenderingTest::testTextEditViewInvalidations unit test has been enhanced in order to test correct invalidation when text content goes out of the starting tile. Change-Id: Id223fb1a032d3b18d2cf70df31f704abd245b3ac Reviewed-on: https://gerrit.libreoffice.org/29625 Reviewed-by: Marco Cecchetti <mrcekets@gmail.com> Tested-by: Marco Cecchetti <mrcekets@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/29658
2016-10-14LOK: Calc: parallel cell editing: small code improvementsMarco Cecchetti
- A single instance of ScExtraEditViewManager is created per ScTabView; - On destruction a counter is checked in order to be sure that all created edit views have been destroyed. - BoolLock has been replaced by comphelper::FlagRestorationGuard Change-Id: I6b0293c4d2e9151dff8b13601d0074c4b2567b25 Reviewed-on: https://gerrit.libreoffice.org/29582 Reviewed-by: Marco Cecchetti <mrcekets@gmail.com> Tested-by: Marco Cecchetti <mrcekets@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/29657
2016-10-14tdf#102212: correct constraints for Calc functions CRITBINOM, BINOM.INV.Winfried Donkers
Argument alpha can be 0<=alpha<=1. Change-Id: Ic1e6dec52bcfe227de49f6b9af38a618f4602c95 Reviewed-on: https://gerrit.libreoffice.org/28934 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-10-14loplugin:mergeclasse merge ScCbWarningBox with ScReplaceWarnBoNoel Grandin
Change-Id: I7b55b036c1992b88b01b51053a3560e9f97986c9
2016-10-13Annotate the code a bit around EditGrowX/Y.Kohei Yoshida
Change-Id: Ib7ee2e4aa393b7d842aeaf0569f104eee17ea4ad
2016-10-13tdf#102742 fix wrong results for MOD functionWinfried Donkers
ScInterpreter::ScMod has been largely rewritten and a constraint check has been added (numerator != 0). It appears that integer values of arguments cannot accurately determined nor converterd accurately to int values, so no simpler (faster) treatment for integer values. Updated test document. Change-Id: I3af60d93019b212ce7c03eea48b509bfbc713cf7 Reviewed-on: https://gerrit.libreoffice.org/29365 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-10-13tdf#94635 follow up; handle linear data properly when samples in periodWinfried Donkers
are to be calculated by function. Applies to all FORECAST.ETS functions with argument period_length having value 1. Change-Id: Icb5a0288670321caf0dd5b70bee4b8811b9ba4a9 Reviewed-on: https://gerrit.libreoffice.org/28923 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>