summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)Author
2014-10-02Another test case for this feature.Kohei Yoshida
Change-Id: Ia406baec2867605bf515dac0ba090500e2bbd1ce
2014-10-02Write the first test for this formula-to-value feature.Kohei Yoshida
Change-Id: I545328a1c126b3bfeee8c1f662c5eb9a471d33ca
2014-10-02New feature to allow converting formula cells to static values.Kohei Yoshida
You used to have to convert formula cells to static values by copying them and pasting them as values onto the original place. Why not just allow converting them in place? This is something I've always wanted to implement.
2014-10-02Scope reduction by early bail-out.Kohei Yoshida
Change-Id: Iacbf9f46a1b5683b6de5dd93002a69078af46951
2014-10-02Make the coding style consistent with the rest of Calc code.Kohei Yoshida
I just ran SlickEdit's 'beautify' command with some follow-up manual editing. Change-Id: I402e782e7d147c4c95ebaa8ffcc40b50a0c565a7
2014-10-02Bin EE_CNTRL_URLSFXEXECUTE which was only set, never testedTor Lillqvist
Change-Id: I18a9355bb902b19f0eeecb26d33eba4fb25db8cb
2014-10-02coverity#1242506 silence Arguments in wrong orderCaolán McNamara
order doesn't matter one bit as far as I can see Change-Id: I55aa5d23d9865a47ef4dcda9d3e19863794a18c9
2014-10-02coverity#1130190 'Constant' variable guards dead codeCaolán McNamara
Change-Id: Ifc462622919c8247c1f4ff8304f3107a23ef1c49
2014-10-02coverity#1242475 no point calling SetText with GetText resultsCaolán McNamara
Change-Id: I0ebd4a53a0d309b45f5af31adc6fa54a5f143a21
2014-10-02coverity#1242751 Uninitialized scalar fieldCaolán McNamara
Change-Id: Ib56544cf49d53952c7381512b650633abac047e9
2014-10-02coverity#1242872 Unused valueCaolán McNamara
Change-Id: If385b910c1778217d8db881b5d27ea993e27a66e
2014-10-02coverity#1242940 Uninitialized scalar fieldCaolán McNamara
Change-Id: I60efbf0cbba81f973a258f1ba90cc910b1abe075
2014-10-02coverity#1242417 Logically dead codeCaolán McNamara
this looked a little less odd before commit 6dda3d45c902d64323a085ea1604a993521f313d Date: Wed Apr 23 11:08:48 2014 +0200 sc: sal_Bool->bool so simplifying it now Change-Id: Ibadfc140581f186ba4c98874b740a18d19b77970
2014-10-02coverity#735819 Unchecked dynamic_castCaolán McNamara
Change-Id: I4e8834a2cdc979757ae6d37730a89fc20bcc6b26
2014-10-01Remove leftover SAL_WNODEPRECATED_DECLARATIONS_PUSH/POPStephan Bergmann
...from times when code used std::auto_ptr. Change-Id: Ia4eca8b0b95a8846886884404009e895daba8a22
2014-10-01fdo#39468 Translate German Comments - sc/cource/filter/difChristian M. Heller
Change-Id: I1d44c2538baac9a1443118c95a2886db5098dab1 Reviewed-on: https://gerrit.libreoffice.org/11736 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-01fdo#39468 Translate German Comments - sc/source/filter/excel/Christian M. Heller
Change-Id: I2a5104c6da0cf9843c42b1687aec6eb9c459c3d4 Reviewed-on: https://gerrit.libreoffice.org/11735 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-01fdo#82577: Handle TimeNoel Grandin
Put the TOOLS Time class in the tools namespace. Avoids clash with the X11 Time typedef. Change-Id: Iac57d5aef35e81ace1ee0d5e6d76cb278f8ad866 Reviewed-on: https://gerrit.libreoffice.org/11684 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-01Replace TSdrObjectPtr with unique_ptr with custom deleterStephan Bergmann
Change-Id: If15e1bab07ee5e9c70a6a0f1961ec2db0c946eb5
2014-09-30sc: std::auto_ptr -> std::unique_ptrStephan Bergmann
Change-Id: I25468d578de597ff9aeba3ffc850c630fa532767
2014-09-30sc: ensure global variables in tests are cleared before shutdownMichael Stahl
If the destructors run from exit handlers, they could access already deleted globals from VCL etc. and crash. Change-Id: I265046e95998a4384e1ce0f1f205d03c078a40a9
2014-09-30sc: lock SolarMutex before calling ScDocument::RemoveUnoObject()Michael Stahl
This can race against other threads calling AddUnoObject(), and hopefully this should fix the assert from SfxBroadcaster::AddListener() line 96 that has been observed in sc_unoapi. Change-Id: Ia2dd38a499c51a77c54cffe9dde31e14053ae0e5
2014-09-30fdo#53920 Switch back tab at RefButton closure timeLaurent Balland-Poirier
Bug occurs because visible tab is not the initial tab. So, instead of switching back to initial tab at dialog closure time (removed from cellsh2.cxx), this commit proposes that switching back to initial tab is operate when expanding the RefButton shrink dialog. Change-Id: I3cf7ed14054fa69881d4ecbc55c48dfbfc4356aa Reviewed-on: https://gerrit.libreoffice.org/11660 Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> Tested-by: Kohei Yoshida <libreoffice@kohei.us>
2014-09-30fdo#82577: Handle PolyPolygonNoel Grandin
Put the TOOLS PolyPolygon class in the tools namespace. Avoids clash with the Windows PolyPolygon typedef. Change-Id: I811ecbb3d55ba4ce66e4555a8586f60fcd57fb66
2014-09-30fdo#82577: Handle RegionNoel Grandin
Put the VCL Region class in the vcl namespace. Avoids clash with the X11 Region typedef. Change-Id: I6e008111df7cf37121fbc3eaabd44a8306338291
2014-09-29sc: fix locking in ScXMLConsolidationContextMichael Stahl
Essentially revert commit 4fa05ecc089a027f243e87f76cc9bcd1f70447e4, plus move the unlock to the dtor for more RAII-ness. Change-Id: Ie5a9cc183626e3f5b005348606bffa69c4be4f7f
2014-09-29MSVC 2012 apparently isn't ready yet for std::vector<std::unique_ptr<T>>Stephan Bergmann
...producing error messages about trying to access private undefined unique_ptr copy ctor etc. Partial revert of 014e7933af751bfe0a03867373b82efa806f3a3d "svtools: std::auto_ptr -> std::unique_ptr: ...changing HTMLOptions to std::vector<std::unique_ptr<...>> because boost::ptr_vector<...>::push_back only supports auto_ptr, not unique_ptr," going the awkward std::unique_ptr x(...); push_back(x.get()); x.release(); route instead (which could be simplified if boost::ptr_vector::push_back ever started to support unique_ptr). Change-Id: I15693030a0bbfdedbfdfbe76ede5d0c74f4e5b41
2014-09-29svtools: std::auto_ptr -> std::unique_ptrStephan Bergmann
...changing HTMLOptions to std::vector<std::unique_ptr<...>> because boost::ptr_vector<...>::push_back only supports auto_ptr, not unique_ptr. Change-Id: Ie5f92bc40ce5425dc1c634b17addc2b0dd9bbda3
2014-09-28border_width from 12 to 6, as the rest of dialogsAdolfo Jayme Barrientos
Second pass. Change-Id: Ic4702d2ca7a9d54ee4712dcd073006f16b2d5d1d Reviewed-on: https://gerrit.libreoffice.org/11669 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-09-27fdo#53682 Merge 'Insert Image' and 'Insert Audio/Video' in submenuSamuel Mehrbrodt
Change-Id: I4ddbd134ba15a48c0c529a11bcb1cd1f71f3a51a
2014-09-27fdo#83808 Scale images proportionally by default in CalcSamuel Mehrbrodt
Change-Id: I979d721d2e6617a1214b70138660d657eb1e46b1
2014-09-26add a RAII class that tries to acquire the SolarMutex and releases itMichael Stahl
Motivated by ScCompiler::IsMacro() which has an error return that does not release the SolarMutex. Change-Id: I064219bb3c0d68839a133101491d5f8828a26c7a
2014-09-26fdo#84370 - xlsx threaded import - protect editeng.Michael Meeks
Sadly we need to hold the solar mutex for rich text import, cue massive lock contention on sheets packed with rich text cells; hopefully not a common case. Change-Id: I6a094a070b11c8b572fd8687be96110c4905e78d
2014-09-26formula: std::auto_ptr -> std::unique_ptrStephan Bergmann
Change-Id: I7b4784abf5177e22a9df33c5d4faccfd39801b11
2014-09-26remove unnecessary casts in misc calls to SvStream.Write*Noel Grandin
left over from our conversion of the SvStream output operators to more specific methods Change-Id: Ib80032e8626f5476a89b958f590441994594f4e4
2014-09-26remove unnecessary casts in calls to SvStream.WriteUInt16Noel Grandin
left over from our conversion of the SvStream output operators to more specific methods Change-Id: I482ca7abb84613971e7e8f839f7aa67a65cd71ff
2014-09-26remove unnecessary casts in calls to SvStream.WriteInt16Noel Grandin
left over from our conversion of the SvStream output operators to more specific methods Change-Id: Ie44bec6b988f3e46fe78d14b740818c9141f5df0
2014-09-26remove unnecessary casts in calls to SvStream.WriteUCharNoel Grandin
left over from our conversion of the SvStream output operators to more specific methods Change-Id: I2ea4c7d97e745b3e6a3834f41ac7bfefa4883c7a
2014-09-26remove unnecessary casts'sNoel Grandin
left over from our conversion of the SvStream output operators to more specific methods Change-Id: I63f18be8e940098c2acbbc73ee49ede3a949fcb2
2014-09-26remove unnecessary static_cast'sNoel Grandin
left over from our conversion of the SvStream output operators to more specific methods e Please enter the commit message for your changes. Lines starting Change-Id: Ibfe7635451ef7b8813d7a59c78c5223092a17ad5
2014-09-25editeng: std::auto_ptr -> std::unique_ptrStephan Bergmann
Change-Id: I25e3599a37d720cbcf70ea13ab30234e54637d53
2014-09-25Revert "fdo#73151 Always open Styles&Formatting dialog in the sidebar"Stephan Bergmann
This reverts commit 473ed449a4b6f550dc1af47a07c6e0ef243a98b2, which made JunitTest_toolkit_unoapi fail, as AccessibleDropDownListBox.createTestEnvironment (qadevOOo/tests/java/mod/_toolkit/AccessibleDropDownListBox.java) was no longer able to find its AccessilbeRole.COMBO_BOX AccessibleDropDownListBox, which it apparently expected to find in a docked stylist (cf. DesktopTools.dockStylist in AccessibleDropDownListBox.initialize).
2014-09-25fdo#39468: translationJennifer Liebel
Change-Id: I8ee3c1cf551f5b242d20cf244d728b79e68616ed Reviewed-on: https://gerrit.libreoffice.org/11637 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-09-24fdo#73151 Always open Styles&Formatting dialog in the sidebarSamuel Mehrbrodt
This removes the floating window for Styles&Formatting as discussed in fdo#73151. Change-Id: I352d27a4d30632dcfda8963c23629e62ab850524 Reviewed-on: https://gerrit.libreoffice.org/11253 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-09-24Replace some std::auto_ptr function parameters with std::unique_ptrStephan Bergmann
Change-Id: Ic66d325fd9559c6dde9556c26e5b2a7e60376c49
2014-09-24Remove o3tl/heap_ptr.hxx, use std::unique_ptr insteadStephan Bergmann
Change-Id: Iac70c9be13892a36bfb5975f62e5345b88d4f144
2014-09-23fdo#83848 Add GetAddressConvention to RefButtonLaurent Balland-Poirier
Change-Id: I20d633909d3c13bf49998a6cca054ab125b6c991 Reviewed-on: https://gerrit.libreoffice.org/11578 Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> Tested-by: Kohei Yoshida <libreoffice@kohei.us>
2014-09-23fdo#65281 Empty/Not empty doesn't work in columns with date formatDavid Ostrovsky
"Empty" and "Not empty" predicates were unconditionally overriden in filter dialog for date format columns. Rectify it by preventing the overriding for these functions. Test Plan: * open calc document * define column with date format * put some data and let some columns empty * apply standard filter on date column with "Not empty" function * verify that rows with non empty columns still visible Change-Id: I2111c5a6b6350cab63173d42419069813d1137b6 Reviewed-on: https://gerrit.libreoffice.org/11613 Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> Tested-by: Kohei Yoshida <libreoffice@kohei.us>
2014-09-23loplugin: cstylecast, update PTR_CAST macro to use static_castNoel Grandin
I introduce a template method into the PTR_CAST machinery to maintain constness. There is now a FIXME in sd/../docshell.cxx because I needed to use a dynamic_cast there to work around the games it appears to be playing with OLE in-place activation. Signed-off-by: Stephan Bergmann <sbergman@redhat.com>, dropping the GCC-extension, unnecessary use of typeof from tools/rtti.hxx Change-Id: Iba5ace1aa27e02b34fcc91af1e658c43371afd03
2014-09-23fdo#82577: Handle WindowNoel Grandin
Put the VCL Window class in the vcl namespace. Avoids clash with the X11 Window typedef. Change-Id: Ib1beb7ab4ad75562a42aeb252732a073d25eff1a