summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)Author
2014-01-11fdo#73484: Ensure that we import all tab settings from Excel.Kohei Yoshida
The old code would not import settings of the last sheet if maTabData was not large enough before the loop begins. Enlarge maTabData ahead of time to ensure we load all tab settings. (cherry picked from commit 3e87471b6815a3cad48cab2ef81073bad5453c56) Conflicts: sc/inc/scextopt.hxx Change-Id: I9093a93ef26ccba9fef06a8929d1d86311f5c55d Reviewed-on: https://gerrit.libreoffice.org/7383 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2014-01-08fdo#72774: Generate correct group items for the year group.Kohei Yoshida
This changes bring it back to the same algorithm used in 3.5. Change-Id: I16855cef1de133a1f886baa823d5b0d2b148e781 (cherry picked from commit c2e88a32314012afb799e321ec1d658f99f71781) Reviewed-on: https://gerrit.libreoffice.org/7306 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2014-01-08fdo#72774: Ensure that all the group fields are in cache upon file load.Kohei Yoshida
This resolves the originally reported issue in that bug (in Comment 1). Change-Id: I6fb85cff1eafb78d784605aa08e7d992a1ac36e0 (cherry picked from commit 256e4ccba8a331f2d30c6b5da9dca70206deadae) Reviewed-on: https://gerrit.libreoffice.org/7302 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2014-01-08fdo#72645: Case-insensitive string comparison in GETPIVOTDATA.Kohei Yoshida
Change-Id: Ibdb2b7ab2bae03875a3462816e860f58d9076457 Reviewed-on: https://gerrit.libreoffice.org/7285 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2014-01-08fdo#72645: Allow GETPIVOTDATA to get result from leaf node of result tree.Kohei Yoshida
Change-Id: I0fc1fd069440ed6fee378fc2dfd2ed761afbdeab Reviewed-on: https://gerrit.libreoffice.org/7284 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2014-01-06read elements/attribs written to extension namespaceMarkus Mohrhard
Related to validation errors with fdo#31296 Change-Id: I1b76e05a9996b1123db164629475a3f7b07dda69 Reviewed-on: https://gerrit.libreoffice.org/7222 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2014-01-06only write new element and attributes in ODF 1.2 extendedMarkus Mohrhard
Change-Id: I038f200f500ef1c6a0815b6332fb17bb2f62282a Reviewed-on: https://gerrit.libreoffice.org/7221 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2014-01-03added "EEK" and "LVL" to EUROCONVERT(), "EUR" to [*-LV] locale data fdo#73239Eike Rathke
This is a combination of 3 commits. added Estonian "EEK" to EUROCONVERT(), fdo#73239 (cherry picked from commit 127f863c727c07f1da40005fe638d97e89baaccf) Conflicts: sc/source/core/tool/interpr2.cxx added EUR as default currency to Latvia [*-LV] locale data, fdo#73239 (cherry picked from commit c32996987354d045523beaa98b5d227d161f72fb) added Latvian "LVL" to EUROCONVERT(), fdo#73239 (cherry picked from commit cc1b6535e01db62688a7bee50852d33e4ee50761) Change-Id: I82085b6661c954b2afbf22b8b8ed5bd8c48cc50e Reviewed-on: https://gerrit.libreoffice.org/7263 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-12-21prepare to read loext:vertical-justify, fdo#72922Eike Rathke
Change-Id: I56d72d5cb8ea95aa63d4659899cba2f295ce9bea (cherry picked from commit 11a73705d9dd10ebefa2bcdefa560f55e7024a1b) Reviewed-on: https://gerrit.libreoffice.org/7150 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2013-12-21XMLPropertyMapEntry::mbImportOnly and XMLPropertySetMapper bForExportEike Rathke
Although a rather large change this does not change the property mappings or import/export behavior yet, but prepares for further changes that add mappings for generating correct ODF and consuming both old and new namespace/element/attribute names. This is a combination of 4 commits: added bool bForExport parameter to XMLPropertySetMapper ctor Set to true for export, false for import. If export true, an XMLPropertyMapEntry with mbImportOnly==true is not added to the mappings. This to be able to have more than one mappings for import (for example a current extension namespace and the future namespace proposed to the ODF-TC, or corrected typos in element or attribute names), but map only to one entry on export, of course. (cherry picked from commit ebc1b2fe50c7ed1002ed8431410b8e2ac6e795b9) Conflicts: dbaccess/source/filter/xml/xmlHelper.cxx xmloff/source/chart/PropertyMaps.cxx xmloff/source/draw/sdpropls.cxx xmloff/source/style/PageMasterPropMapper.cxx xmloff/source/table/XMLTableImport.cxx prepared XMLPropertyMapEntry with mbImportOnly flag (cherry picked from commit 9dd7ee88bd9835ae2bae36093100fcd651fd3aeb) Conflicts: dbaccess/source/filter/xml/xmlHelper.cxx xmloff/source/table/XMLTableExport.cxx xmloff/source/text/txtprmap.cxx just beautify this a little (cherry picked from commit 44b4973fbd0f190906f36321b31215d80b363d52) reordered member variables for 4 byte alignment (cherry picked from commit dd902b8e256867b5d5fed06b52995f14d969f67d) Change-Id: I15b03870fd14f110833037b6c0ff934624d72de1 Reviewed-on: https://gerrit.libreoffice.org/7144 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2013-12-13fdo#70499 selectn of lock/unlocked cells with worksheet protection reversedNoel Power
The ooxml spec documentation is rather confusing ( for me at least ) and the sense of the of the sheetProtection attributes as described seems reversed to how I read it ( or maybe it is the equivelant option in ScTableProtection that operates with the reverse sense <shrug> ) In anycase the import ( and export ) have been adjusted to take that into consideration, also the export now actually deals with the defaults correctly. Change-Id: Ia69567b8898b39c9d171486cfa800e1748c5814b Reviewed-on: https://gerrit.libreoffice.org/7075 Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> Tested-by: Kohei Yoshida <libreoffice@kohei.us>
2013-12-12fdo#68160 Revert "Resolves: #ii122335# Disabling the old task pane"Eike Rathke
fdo#68160 Revert "Partly revert "Resolves: #ii122335# Disabling the old task pane"" This reverts commit cb4225144f1fff44f9bb972fe06f51524da11b8b. To be able to revert 95ae39c0c34c9a5e6fa6e72bf3a631a9a799b872 entirely. fdo#68160 Revert "Resolves: #ii122335# Disabling the old task pane" This reverts commit 95ae39c0c34c9a5e6fa6e72bf3a631a9a799b872. We need a TaskPane even in Writer and Calc to be used by extensions. Sidebar is experimental so TaskPane is needed anyway for Impress (see fdo#72371). Change-Id: Ia94ab377a59996ba434b56e3823117183674afb7 Reviewed-on: https://gerrit.libreoffice.org/7042 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-12-11fdo#66969: Reset group dimension data from all referencing pivot objects.Kohei Yoshida
The previous code was doing it only with the first referencing pivot table, which would break the rest of them sharing the same cache if the first one doesn't contain all group dimensions used in all of the referencing pivot tables. Change-Id: I35d6907ef8db7ed69db42583cac92b2b74406e2c (cherry picked from commit b3977983e9f662392426f581516d86d7034ad0fd) Reviewed-on: https://gerrit.libreoffice.org/7028 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2013-12-11fdo#66969: Set selected page name after building all dimension members.Kohei Yoshida
Because the new implementation relies on the visiblity flag of the dimension members, they need to exist before setting currently selected page, which is still used in documents generated by the older version of LibreOffice. Change-Id: I6cec5fd3d2165f714fc01b596d3761890d87a4ff (cherry picked from commit 2e1b90a4272defb917b23e2e360e171114d6fa4d) Reviewed-on: https://gerrit.libreoffice.org/7027 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2013-12-10be able to read the correct 'sort-ascending' value, fdo#72548Eike Rathke
... for <table:content-validation table:display-list='sort-ascending' ...> but do not write it yet. Change-Id: I05bdf27cee27f7456b660267b95126420474eb99 (cherry picked from commit 8047ae4a8244199717698f2e2f5281551e97912c) Reviewed-on: https://gerrit.libreoffice.org/7016 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2013-12-07fdo#66984: Define an assignment operator to prevent double deletion.Kohei Yoshida
The code path was assigning one ScDPObject to another via assignment, but we didn't define one. So we were using the compiler generated assignment which only shallow-copies data members, which ultimately caused double-deletion of one of its data members. Change-Id: Ie98d0789e51aebff683dbcc0e533a9a0a87943d5 (cherry picked from commit bd976e5b070ec68a4f842190db4d0c1ea0e93428) Reviewed-on: https://gerrit.libreoffice.org/6966 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-12-06resolved fdo#66564 calculate formula cell once if AutoCalc disabledEike Rathke
Was lost with 2ce72093cdc68e60fb06ddd4358e0bc7fc8c63a9 and previous restructuring. (cherry picked from commit 2212051e792cb5f51f4191afe83c85fc3730a087) Backported. Change-Id: Ie4c8bdb287b56448406c873840c26ec4759de375 Reviewed-on: https://gerrit.libreoffice.org/6964 Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> Tested-by: Kohei Yoshida <libreoffice@kohei.us>
2013-12-06fdo#69518: Correctly handle the old constraint syntax.Kohei Yoshida
We apparently support this syntax for ODF-backward compatibility. To fix this, I resurrected ScDPObject::ParseFilters() which was removed as unused, adjusted it for the String->OUString change, and changed the filter data structure to the UNO one rather than using the old one we no longer use elsewhere. (cherry picked from commit 1d85c8df2fb9cb25fc524485339ae9f11e8da676) Conflicts: sc/inc/dpobject.hxx sc/source/core/data/dpobject.cxx sc/source/core/tool/interpr2.cxx Change-Id: If52b38aaa1e8b208fb0ef9d92a6e853decdf43e3 Reviewed-on: https://gerrit.libreoffice.org/6962 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2013-12-05fdo#69984: Handle duplicate field names correctly.Kohei Yoshida
Duplicate field names are represented in two ways: 1) 'Name' vs 'Name*' in the UNO part of the pivot engine, and 2) Name,0 vs Name,1 which are a pair of textural name and a numeric duplicate index in the non-UNO part of the engine. But some parts lost this duplicate index information and/or confused the 2 ways of representation. Hopefully this change will sort things out. (cherry picked from commit 7e491281d2ba71490fa22cce1e43ba91f60395e3) Conflicts: sc/inc/pivot.hxx Change-Id: I03ae7b6c011c31ace454679837542d6d0909ecaa Reviewed-on: https://gerrit.libreoffice.org/6944 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2013-12-05resolved fdo#71667 and fdo#72278, fdo#69971 follow-up fixEike Rathke
a9d85d62a889288b17899c8defc020da487d8b36 used ScInputHandler::EnterHandler() to reset all sort of things related to input EditEngine, but that is a handler for Enter and does not enter a handler and actually attempts to finalize input, which lead to various unwanted side effects. Introduced ScInputHandler::InputTurnOffWinEngine() as only the input bar window EditEngine needs to be reset in the window switching case (which EnterHandler also does hence it did prevent that bug). The approach could be polished with further refinement but most importantly fixes the actual problems now. (cherry picked from commit dfd1a47a38dac743f9ed0f1e9507714bac027d35) Conflicts: sc/inc/scmod.hxx sc/source/ui/app/scmod.cxx Change-Id: I9a0bc452b49ba11a3313cafbc1e5972f41dc65c7 Reviewed-on: https://gerrit.libreoffice.org/6935 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-12-04write valid dxf record, related fdo#71971Markus Mohrhard
Change-Id: I99f4dfca78cc0fd5d9b947000a99f8414c2a899b (cherry picked from commit 7415fc31f5cdf7ff3f78dd304b9576b931a82aeb) Reviewed-on: https://gerrit.libreoffice.org/6878 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2013-12-03resolved fdo#71589 reimplemented horizontal range lookupEike Rathke
Regression introduced with ebdd9c300718bce454ef56a31d5d8fb699fc1822 (first eaea417bfdf8d06df2b7f2e42c904c32ce77e871) that removed the bMixedComparison member from ScQueryParam under the false assumption that is was only used to emulate a legacy Excel behavior. In fact it was also needed to do the at least horizontal range lookup in sorted mixed data, though didn't evaluate exactly the same conditions as Excel and defined in ODFF. Reimplemented a similar behavior for the new code structures but this time also checking for the additional condtion that a query ByString does not return the last numeric result and vice versa, which previously was missing. (cherry picked from commit f0701470858f57a855ba57c0c2283e52953db327) Conflicts: sc/source/core/data/dociter.cxx Backported. Change-Id: I46061777879ba5301bfcaca2d50cf87a994f93f2 Reviewed-on: https://gerrit.libreoffice.org/6839 Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> Tested-by: Kohei Yoshida <libreoffice@kohei.us>
2013-12-02don't use fixed size icon sets, fdo#62652Markus Mohrhard
actually we should switch to svg as soon as it becomes possible Change-Id: Ifbbe5befab94441f04fadb90b779e0bc8c15eda4 Reviewed-on: https://gerrit.libreoffice.org/6890 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-12-02fdo#72078 make status bar text localizableAndras Timar
2nd try to get it right on libreoffice-4-1 Change-Id: I66ebc292231069cca708eb56ad876f56829e78f5 Reviewed-on: https://gerrit.libreoffice.org/6894 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-12-02Revert "fdo#72078 make status bar text localizable"Markus Mohrhard
This reverts commit ae5519c8c42b2a9473da236f3c84bfe630893cc4.
2013-12-01fdo#72078 make status bar text localizableAndras Timar
Change-Id: I5d8ce77c8034819fd618d3d970908462511d2e1d Reviewed-on: https://gerrit.libreoffice.org/6888 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2013-12-01fix 2D vs 3D coordinatesystem regression, fdo#67300Markus Mohrhard
regression from 088e86b865062dd4cc5ba0c85c6068dea62238db Change-Id: Ifc8d5a1da328278175bbc97b4f2aad8e6d200751 Reviewed-on: https://gerrit.libreoffice.org/6880 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2013-11-30resolved fdo#67536 export internal equivalents as add-in to .xlsEike Rathke
For BIFF .xls export the internal functions that are equivalents of known add-in functions as those add-in functions. (cherry picked from commit 06a5b1ecc39bb50dadc0bcb7378455500943ece3) Conflicts: sc/source/filter/inc/xlformula.hxx Change-Id: If37f616a34fdabb3fa971fddad01da3dc1f28ee9 Reviewed-on: https://gerrit.libreoffice.org/6525 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2013-11-30resolved fdo#53103 actually use the external data filter optionsEike Rathke
ScDocShell::ConvertFrom() queries the filter options from the SfxItemSet at SfxMedium, which is fine when loading the data into the table selector first, but the final load via ScAreaLink created a bare SfxMedium without options set. Do so. Additionally it may now even work that ScDocShell sets options at SfxMedium, which the ScAreaLink code prepared for but previously the SfxMedium did not have an SfxItemSet. Change-Id: I45d6a24906dc3ba41654b8c0951dd84939d8af5e (cherry picked from commit 513eadd422ff6a41cfe9a16f82cf32872d729652) Reviewed-on: https://gerrit.libreoffice.org/6823 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2013-11-30resolved fdo#61946 use correct TabDelta for UpdateReferenceEike Rathke
The sheet delta was reverted resulting in the references not being updated when conditional formats were copy-pasted between sheets. Saved to .ods then was an identical calcext:target-range-address as for the copied source range. (cherry picked from commit ef8e0beba442f58abe3bc77f6f55fc6109025dd4) Backported. Change-Id: I038b58f20f71ff1393dccafa3021dac02cd69e4b Reviewed-on: https://gerrit.libreoffice.org/6768 Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2013-11-30resolved fdo#67572 export add-in equivalents as internal to .xlsxEike Rathke
For OOXML .xlsx export the add-in functions that are equivalents of known internal functions as those internal functions. (cherry picked from commit da7c6092a644dc22f90fb8eef0c4f0df06ec204a) Minus the DURATION change that was fixed on master (and 4.2) with 62e1a27dc757637223f5f18b1a340ba138e0cb82 Change-Id: Ic41f32b67902effa07c3d4db137be08dc5af7265 Reviewed-on: https://gerrit.libreoffice.org/6530 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2013-11-22resolved fdo#38592 do not insert extraneous parameter in importEike Rathke
Importing already a Calc-only number of parameters do not insert extraneous parameters. (cherry picked from commit 4b9304ecdd067307e24e4388fe1addcab9e85bd0) Change-Id: I011e3df24573fce9f2788c9311089af984650220 Reviewed-on: https://gerrit.libreoffice.org/6764 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2013-11-20resolved fdo#70750 reverted inappropriate implementation of fdo#63546Eike Rathke
This is a combination of 2 commits. Revert "fdo#63546: set appropriate alignment when wrt direction of cells is changed." This reverts commit 706e3b8e43df94310b2fe8458da67875073a046c. Related previous commits that commit depends on will also be reverted. Triggered by fdo#70750 inspecting the code it turned out that the changes for fdo#63546 did several things wrong: * looping over individual cells of a large selected range results in slicing and merging ScAttrArray for each row in each column which is utterly slow (the reason for fdo#70750) * instead of executing the changes in ScFormatShell calls should had been forwarded through ScTabViewShell to be passed down to ScViewFunc, ScDocFunc, ScDocument, ... * setting hard attributes on all cells (except if already centered or block justified) is not wanted * value cells for example should stay automatically right justified if no justification is given yet * overwriting already existing left or right justification may not be what the user expects * applied styles' justification is overridden this way (cherry picked from commit 2f29e544932633a01162ecb80e50872eabdd2bc1) Revert "fix fdo#63546 : set appropriate alignment when writing direction is changed." This reverts commit 16f508686c29bfa244ca6f81b5ab3bbaf5fef2a7. (cherry picked from commit 955281e50e2728932edc3b688ce3cf235bdfd0c9) Conflicts: sc/source/ui/view/formatsh.cxx Change-Id: I53fc56a09f2b396577fff3ec679b39837fc2f649 Reviewed-on: https://gerrit.libreoffice.org/6691 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-11-08"%1 is replaced to ..." ... maybe, or maybe notEike Rathke
Translations may have omitted the %1 placeholder in SCSTR_COLUMN and SCSTR_ROW, or not have it translated newly yet because it was introduced later. In these cases append the column indicator / row number as it was done before. (cherry picked from commit 9b10373edae490d2b9b7f8d733c59b4f63927bec) Conflicts: sc/source/ui/dbgui/filtdlg.cxx sc/source/ui/dbgui/pfiltdlg.cxx sc/source/ui/dbgui/tpsort.cxx sc/source/ui/dbgui/tpsubt.cxx Change-Id: I331cf0c529bebea02277784ea145c202eb6f6fda Reviewed-on: https://gerrit.libreoffice.org/6618 Reviewed-by: Ivan Timofeev <timofeev.i.s@gmail.com> Tested-by: Ivan Timofeev <timofeev.i.s@gmail.com>
2013-11-08"%1 is replaced to column letter" ... so do itEike Rathke
In StandardFilter dialog when not using column headers the field names were displayed as "Column %1 A" instead of "Column A". Change-Id: I29216eaa6b98e4a786f77d47ef20135e15d7d45a (cherry picked from commit 2d793b1a7f08e2f42a8e9bd96b7470e15784f7cf) Reviewed-on: https://gerrit.libreoffice.org/6591 Reviewed-by: Ivan Timofeev <timofeev.i.s@gmail.com> Tested-by: Ivan Timofeev <timofeev.i.s@gmail.com>
2013-11-04fdo#69971 formula dialog crash when Paint restores EditEngine listenerCaolán McNamara
We need the EditEngine Modification handler of the inputbar that we are feeding to be disabled while this dialog is open. Otherwise we end up in a situation where... a) this ScFormulaDlg changes the editengine b) the modify callback gets called c) which also modifies the editengine d) on return from that modify handler the editengine attempts to use old node pointers which were replaced and removed by c We turn it off in the ctor and back on in the dtor, but if calc has to repaint, e.g. when switching to another window and back, then in ScMultiTextWnd::Paint a new editengine will have been created via GetEditView with its default Modification handler enabled. So ensure its off everytime we will access it via InputReplaceSelection pScMod->InputEnterHandler(); I wonder if we should really be calling ScMultiTextWnd::GetEditView (which creates an EditView if one does not already exist) in ScMultiTextWnd::Paint or just check for pEditView directly, but that then leading to the need for it to be explicitly created somewhere else. As it stands in ScMultiTextWnd::Paint(...) the "if ( pView )" can never be false. Change-Id: I2f6df9ce0cc7ec59e8be33f4e67d91422796d251 (cherry picked from commit a9d85d62a889288b17899c8defc020da487d8b36) Reviewed-on: https://gerrit.libreoffice.org/6566 Tested-by: Eike Rathke <erack@redhat.com> Reviewed-by: Eike Rathke <erack@redhat.com>
2013-11-02remember column style during XLSX import, fdo#70315Markus Mohrhard
WE overwrote the column style that was set earlier with the default style. Change-Id: I4c02e1cdd3e72f27d75b8153e2af45b5658ff456 (cherry picked from commit 512a14438c4098ca2e30d0b10b6e18506c8475f1) Reviewed-on: https://gerrit.libreoffice.org/6528 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2013-11-02no default LTR mode does not mean RTL, fdo#68097Markus Mohrhard
Change-Id: Ice4957077e7eda5f7bb93042d6e2ba745935ef8b (cherry picked from commit 045e037b7acde9d8e63fbb977c28b167e8815278) Reviewed-on: https://gerrit.libreoffice.org/6527 Tested-by: Eike Rathke <erack@redhat.com> Reviewed-by: Eike Rathke <erack@redhat.com>
2013-11-01Resolves: fdo#71106 editing dde function crashesCaolán McNamara
Change-Id: Id2f4bffb7de7201ddeb8f75daaa2723cc42c59b0 (cherry picked from commit 3b27470860cfa377dfc0cb940bba204d827434ad) Reviewed-on: https://gerrit.libreoffice.org/6520 Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> Tested-by: Kohei Yoshida <libreoffice@kohei.us>
2013-10-31resolved fdo#70815 broadcast emptied cell in ScColumn::SwapRow()Eike Rathke
Change-Id: Ie939f12a54d0b4cf8bedc34683e20fb924f1bf3b Reviewed-on: https://gerrit.libreoffice.org/6516 Tested-by: Kohei Yoshida <libreoffice@kohei.us> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2013-10-31resolved fdo#56209 reviving FilterFormulaParserEike Rathke
First it was moved from oox to sc without carrying over the component factory bits, then subsequent commits removed the remaining bits in steps as it appeared to be unused: 8ada1cd2846e5e60ad63250c68ddea3a9356546f 887d7945addeb823e0d3f783609c4e79d92ad4a7 effda59a12cedd3cf200d2e9f5186a623b0855bb f2fd2a66ee827024b31a310d67804cb7cb18d2da (cherry picked from commit 20e0afa76087e20f95247406d265a122263a8c6f) Backported. Change-Id: I445b11c95daff6f30b3654936d0f22a113158f97 Reviewed-on: https://gerrit.libreoffice.org/6469 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2013-10-29Related: fdo#69641 double iterateCodePoints doesn't make sense to meCaolán McNamara
This came in with 04212c3015cd4ab118a0aec2bb04bc153a64af41 but the bug number of #i86439# appears to be the wrong id. It doesn't make sense to me. Rework cclass_Unicode::getStringType to iterate safely over the codepoints of the requested range. Perhaps that was the reason for the original commit. Change-Id: Ice4287eb6f9fc6a9705845c0cf995263815de2e7 (cherry picked from commit 507e627d83dbfb6a35677450a3fc42d10c79a82e) Related: fdo#69641 check index against length before iterateCodePoints Change-Id: I71346b12fcfe3e02015038c3c78db574ada873d6 (cherry picked from commit 08b7af126e546bdbd175023429f544baa9861dba) Related: fdo#69641 add a regression test Change-Id: Icf3324a224d02425acd679a286f3c4a0b7e3ed1c (cherry picked from commit 9d5b07b9085f97edfff5d4ac474e9711036bb0c4) lets be super sure in the face of falling between surrogates Change-Id: I6d8259df3d4f2e73f9236b7c0547f87c89801082 (cherry picked from commit 8f0ecf253531963144d3d1c9ee5c12a6cda99c4e) Reviewed-on: https://gerrit.libreoffice.org/6473 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2013-10-28fdo#70100 Detect single stream excel files with BOF ID 5Maxim Monastirsky
Change-Id: I321b7a08e0436a9c33878acd1ce2f98c497040b5 Reviewed-on: https://gerrit.libreoffice.org/6447 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit 71882916f617528a6d6fcc54450674dc3f630319) Reviewed-on: https://gerrit.libreoffice.org/6464 Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> Tested-by: Kohei Yoshida <libreoffice@kohei.us>
2013-10-13fixed another "Out of bounds substring access"Eike Rathke
Introduced with 3c2a26c84e70fd996855181d319970e2230b2459 Didn't have consequences here because the result was used to check for a "startsWith" condition which it wouldn't had matched anyway. However, use the real startsWith() now. (cherry picked from commit b1caf176a44b6979d2e0ea47f495a3dacf86e197) With f81ed484ffd443e2593627f3d8d3133161817af2 in 4-1 we should have this as well. Change-Id: Ia1d558fc106d9a2010ad41c30f7eb2a2a480c59b Reviewed-on: https://gerrit.libreoffice.org/6218 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2013-10-04compare against IDF_HARDATTR, fdo#69720Markus Mohrhard
regression from e851ea0ed30e9bb95c273a29aeab7f48f606145f Change-Id: I07819f90efe87fe9d82515d637960fe48ca40c80 (cherry picked from commit 6f2957969bd72308ddf79cb2befa2373f2dc1dbe) Reviewed-on: https://gerrit.libreoffice.org/6034 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2013-10-03Resolves: rhbz#1013844 fdo#47482 encrypted OOo 1.0 docs cannot be reopenedCaolán McNamara
Workaround for the encrypted OpenOffice.org 1.0 documents generated by Libreoffice <= 3.6 with the new encryption format and using SHA256, but missing a specified startkey of SHA256 Change-Id: Ib1acc4441b5adc6721cb3cde7a1191aa978e9a1b (cherry picked from commit 11ad93f4ba84f190c908e92a2c960f7a9fa800c0) Reviewed-on: https://gerrit.libreoffice.org/6105 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2013-09-27fdo#69450 - IDF_ATTRIB & IDF_CONTENTS must be disjoint.Michael Meeks
Change-Id: Ib971824a7f274334012b872acec65310535ad767 Signed-off-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2013-09-19Resolves: fdo#68431 style:font-name unknown in non autostyles in impress/drawCaolán McNamara
Reviewed-on: https://gerrit.libreoffice.org/5810 Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric@lanedo.com> Tested-by: Pierre-Eric Pelloux-Prayer <pierre-eric@lanedo.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit d87cb77b42b591b1333aacd60e107514d6e20864) Conflicts: xmloff/source/style/xmlexppr.cxx Change-Id: Ib904af4fac5659821ba3b5dbbf62370df8243001 Reviewed-on: https://gerrit.libreoffice.org/5988 Reviewed-by: Eike Rathke <erack@redhat.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2013-09-16fdo#69091: Copying data from Base-table to Calc by drag and dropJulien Nabet
Depending on whether the data source is registered, either rDescriptor[svx::daDataSource] or rDescriptor[svx::daDatabaseLocation] will be filled in (and should be used). Luckily, ODataAccessDescriptor provides a utility function that will automatically return the one that is set. Use that instead of hardcoding svx::daDataSource. Thank you Lionel! Change-Id: I02673e7924c4323915dea579015326194c3f5077 Reviewed-on: https://gerrit.libreoffice.org/5959 Tested-by: Lionel Elie Mamane <lionel@mamane.lu> Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
2013-09-09CID#1079180 initialize bufferCaolán McNamara
Change-Id: Id00bce6fe4826293f6b0ae842bc70b536e9aa99a (cherry picked from commit c119ec426b2a20b79d3ecaccaa91d15bc8d43a23) Reviewed-on: https://gerrit.libreoffice.org/5892 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
generated by cgit (git 2.34.1) at 2024-07-16 14:09:24 +0000