summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)Author
2018-03-05drop sax::tools::*base64 methodsNoel Grandin
and use the underlying comphelper methods rather. This is so that I can break the dependency that tools has on sax, and can add methods that make sax depend on tools. Change-Id: I8a2d6ce2ffc3529a0020710ade6a1748ee5af7d5 Reviewed-on: https://gerrit.libreoffice.org/50767 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-05Removed duplicated includeAndrea Gelmini
Change-Id: I5c938d4e86e371c7ee5eab66581d6ed736bc2033 Reviewed-on: https://gerrit.libreoffice.org/50754 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-03-05use more Color in ooxNoel Grandin
Change-Id: I8fdc6742de5af9101e246411e7208650bae2c4c7 Reviewed-on: https://gerrit.libreoffice.org/50617 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-05weld SfxPasswordDialog DialogCaolán McNamara
Change-Id: If8c9757986f4af7b7927717221860e65c8c7285e Reviewed-on: https://gerrit.libreoffice.org/50755 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-04tdf#45904: Move _Shape Java tests to C++Jens Carl
Change-Id: If0bfa9fb465f37e0ccce5b2fa4e909baaac1df50 Reviewed-on: https://gerrit.libreoffice.org/50722 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-03-04Related tdf#116171: don't try to convert empty value in timestampJulien Nabet
Assert retrieved: warn:tools.datetime:3915:3915:tools/source/datetime/tdate.cxx:109: Date::setDateFromDMY - sure about 0 year? It's not in the calendar. soffice.bin: /home/julien/lo/libreoffice/tools/source/datetime/tdate.cxx:62: sal_Int32 {anonymous}::ImpYearToDays(sal_Int16): Assertion `nYear != 0' failed. Thread 1 "soffice.bin" received signal SIGABRT, Aborted. __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:51 51 ../sysdeps/unix/sysv/linux/raise.c: Aucun fichier ou dossier de ce type. (gdb) bt 0 0x00007ffff73a26a0 in __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:51 1 0x00007ffff73a3cf7 in __GI_abort () at abort.c:90 2 0x00007ffff739afca in __assert_fail_base (fmt=0x7ffff74eb890 "%s%s%s:%u: %s%sAssertion `%s' failed. %n", assertion=assertion@entry=0x7fffed7d43a4 "nYear != 0", file=file@entry=0x7fffed7d4368 "/home/julien/lo/libreoffice/tools/source/datetime/tdate.cxx", line=line@entry=62, function=function@entry=0x7fffed7d4720 <(anonymous namespace)::ImpYearToDays(short)::__PRETTY_FUNCTION__> "sal_Int32 {anonymous}::ImpYearToDays(sal_Int16)") at assert.c:92 3 0x00007ffff739b042 in __GI___assert_fail (assertion=0x7fffed7d43a4 "nYear != 0", file=0x7fffed7d4368 "/home/julien/lo/libreoffice/tools/source/datetime/tdate.cxx", line=62, function=0x7fffed7d4720 <(anonymous namespace)::ImpYearToDays(short)::__PRETTY_FUNCTION__> "sal_Int32 {anonymous}::ImpYearToDays(sal_Int16)") at assert.c:101 4 0x00007fffed75e7e2 in (anonymous namespace)::ImpYearToDays(sal_Int16) (nYear=0) at /home/julien/lo/libreoffice/tools/source/datetime/tdate.cxx:62 5 0x00007fffed75eeb5 in Date::DateToDays(unsigned short, unsigned short, short) (nDay=0, nMonth=0, nYear=0) at /home/julien/lo/libreoffice/tools/source/datetime/tdate.cxx:156 6 0x00007fffed75ee6d in Date::GetAsNormalizedDays() const (this=0x7fffffff0318) at /home/julien/lo/libreoffice/tools/source/datetime/tdate.cxx:149 7 0x00007fffed760342 in operator-(Date const&, Date const&) (rDate1=0-0-0, rDate2=1899-12-30) at /home/julien/lo/libreoffice/tools/source/datetime/tdate.cxx:609 8 0x00007fffc7e8b705 in ScDatabaseDocUtil::PutData(ScDocument*, short, int, short, com::sun::star::uno::Reference<com::sun::star::sdbc::XRow> const&, long, long, bool, ScDatabaseDocUtil::StrData*) (pDoc=0x55555794c920, nCol=14, nRow=1, nTab=0, xRow= uno::Reference to (dbaccess::ORowSet *) 0x555557b5db08, nRowPos=15, nType=93, bCurrency=false, pStrData=0x7fffffff04b0) at /home/julien/lo/libreoffice/sc/source/core/data/dbdocutl.cxx:127 9 0x00007fffc892e963 in ScDocShell::DBaseImport(rtl::OUString const&, unsigned short, std::__debug::map<short, ScColWidthParam, std::less<short>, std::allocator<std::pair<short const, ScColWidthParam> > >&, ScFlatBoolRowSegments&) (this= 0x55555794c8c0, rFullFileName="/home/julien/lo/bugs/116171_dbffoxpro/addresses.dbf", eCharSet=63, aColWidthParam=std::__debug::map with 14 elements = {...}, rRowHeightsRecalc=...) at /home/julien/lo/libreoffice/sc/source/ui/docshell/docsh8.cxx:413 Change-Id: I240ddd435c148360dc9a874913596b4844d726dc Reviewed-on: https://gerrit.libreoffice.org/50732 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
2018-03-03Fix typoAndrea Gelmini
Change-Id: I401b74b4c95bfe653509edb55ed042ff31398e5d Reviewed-on: https://gerrit.libreoffice.org/50641 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-03-03Add a new test case for Excel 2003 XML import.Kohei Yoshida
This one checks on importing column widths and row heights. Change-Id: I19c63230666aa949eb61805ed2bffe46199a305e Reviewed-on: https://gerrit.libreoffice.org/50653 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2018-03-02Resolves: tdf#116149 handle external references in VAR* and STDEV* functionsEike Rathke
Change-Id: I644a5f8f92452ca775ee3b42a73d3f0a0ac3c623
2018-03-02Resolves: tdf#115351 convert boolean equivalent format codes to proper BooleanEike Rathke
Because Excel does not know a Boolean number format, BOOLEAN is saved to Excel as "TRUE";"TRUE";"FALSE" with implicit conditions [>0] and [<0]. This when loaded has no boolean property. Then saved to ODF it is loaded as [>0]"TRUE";[<0]"TRUE";"FALSE" with explicit conditions, which has identical meaning. Convert both equivalent format codes to proper BOOLEAN when reading. Locale dependent representations are treated the same, e.g. "WAHR";"WAHR";"FALSCH" Change-Id: I49383d71fce972fdd7ad9b19ce3bc150d02aba62 Reviewed-on: https://gerrit.libreoffice.org/50642 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2018-03-02-Werror,-WformatStephan Bergmann
Change-Id: I33a1ff0ba75e26daf9c368a36629122582a85b01
2018-03-02Related: tdf#114555 cater for lastcolumn+1 oddity if last is last possibleEike Rathke
Else our own saved .xlsx files raise the excess columns warning. Change-Id: Ie1791dd026d9faf4b391ad34da43ec0c70c8de83
2018-03-02forcepoint #15 notify FormatsContext if Format deletedCaolán McNamara
Change-Id: Icb7b0c3b1fc3d38e2d7e44e0a8bdb03529c5b41d Reviewed-on: https://gerrit.libreoffice.org/50621 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-02delete colordata.hxxNoel Grandin
move what we still need into color.hxx Change-Id: Ied7e31eb16468aa334c666b1499a6262f16a6350 Reviewed-on: https://gerrit.libreoffice.org/50561 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-02add Color method version of OORGBToXLRGBNoel Grandin
Change-Id: I769ff8aed3caa74679e1b4d03e8fbc3cd5d22b1a Reviewed-on: https://gerrit.libreoffice.org/50587 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-02Add a new test case for Excel 2003 XML import.Kohei Yoshida
Change-Id: I1ba74f35e44b9cea3e3770d513ae520da02b3406 Reviewed-on: https://gerrit.libreoffice.org/50610 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2018-03-01Related: tdf#54197 copy AutoSpellData from adjacent if no selectionEike Rathke
Change-Id: I82223a64f5c5ec3c98dba390d88af8369a322bd7
2018-03-01Related: tdf#115297 copy AutoSpellData from row above if no selectionEike Rathke
Change-Id: I62ebb3579d5c05e71ca10879ae0ade5bda3bbeba
2018-03-01Resolves: tdf#54197 update input line with new cell content after Ctrl+D fillEike Rathke
... and invalidate cell slots. Change-Id: Icbe7784430f7ddeed8fa0bc56352269447ee8cbb
2018-03-01Resolves: tdf#114555 check .xlsx col/row/tab overflow and display warningEike Rathke
Change-Id: I3091a890b6d4a3f27d9284fc5c0e2df3bc8ce527 Reviewed-on: https://gerrit.libreoffice.org/50541 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2018-03-01weld ScStringInputDlg to native dialogCaolán McNamara
ScStringInputDlg and SwStringInputDlg do the same thing, but one uses the old name as the label and leaves the new name blank in the entry. The other puts the old name into the entry and autoselects it and uses a normal label. Both are used from the rename button of the shared autoformat dialog. Change-Id: I2ebf09a79f92c3f9020304e23e8907b67c06cd35 Reviewed-on: https://gerrit.libreoffice.org/50525 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-01make Color::GetRGBColor return Color instead of ColorDataNoel Grandin
Change-Id: I532959a7103c3857510f26ecce2f942d676a233b Reviewed-on: https://gerrit.libreoffice.org/50487 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-01sc: add props. BackGraphic as replacement for BackGraphicURLTomaž Vajngerl
...and also add and adjust in the report designer Change-Id: I5593f4d0bf9daf94f7d521f9c195e27a98282b2b Reviewed-on: https://gerrit.libreoffice.org/50537 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-02-28Revert "Resolves: tdf#114555 check .xlsx col/row/tab overflow and display ↵Eike Rathke
warning" This reverts commit f2a4cea6c035e9a837942934068b5f80a996580a. Some builds have problem with WarningBox not being declared. Will dig into that later.
2018-02-28Resolves: tdf#114555 check .xlsx col/row/tab overflow and display warningEike Rathke
Change-Id: I3091a890b6d4a3f27d9284fc5c0e2df3bc8ce527
2018-02-28use less COLORDATA_RGBNoel Grandin
part of removing ColorData Change-Id: I5518cddeeefe66f70380367e1e3f78af0f3b5fbc Reviewed-on: https://gerrit.libreoffice.org/50486 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-28Translate German comments and debug stringsJohnny_M
Change-Id: Ie2da785cb674e21f042caa5e6d461e3489036003 Reviewed-on: https://gerrit.libreoffice.org/50467 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2018-02-28convert COL_ constants to be of type ColorNoel Grandin
Change-Id: I0e25c8950ac26b851ff42f71e1471fcbe4770d48 Reviewed-on: https://gerrit.libreoffice.org/50373 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-27tdf#45904: Move _SheetFilterDescriptor Java tests to C++Jens Carl
Change-Id: I894b2e2534efeb5369c491053caf56f67dc56618 Reviewed-on: https://gerrit.libreoffice.org/50411 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-02-27convert Redline warning dialog to .ui to get helpidsCaolán McNamara
etc. Change-Id: Ic5e6031fe99347f19002d5d8527b5632333fefb0 Reviewed-on: https://gerrit.libreoffice.org/50431 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-27crashtesting: remove wrong assert with tdf114555-2.xlsxEike Rathke
Wrong since commit 597f7b1f02be79f2443230c963b6d1bb594cffa0 Date: Sun Nov 20 02:21:56 2016 +0100 tdf#48140 Replace uno call from worksheethelper.cxx We are importing a document, so asserting on our own max dimensions is wrong. Wrong is also to compare positions <= MAXCOLCOUNT or <= MAXROWCOUNT, if at at all it should had been <= MAXCOL and <= MAXROW Change-Id: I9f3aae061785ab62de7c709e19fc68653f15ed1e Reviewed-on: https://gerrit.libreoffice.org/50397 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2018-02-27lok: All mouse,key events asyncPranav Kant
custom posting of mouse,key events on main thread This still bypasses vcl while keeping the processing of events on the main thread which is what we want. Change-Id: Ia7a6f5ef1ac546245715abe418d261b49df12d4c Reviewed-on: https://gerrit.libreoffice.org/50274 Reviewed-by: Aron Budea <aron.budea@collabora.com> Tested-by: Aron Budea <aron.budea@collabora.com>
2018-02-27lok sc: This is not needed nowPranav Kant
I guess since these events are routed through vcl now. Change-Id: Ib2a44c82d76a25ac5a3341c060a665c62e3d60a7 Reviewed-on: https://gerrit.libreoffice.org/50254 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2018-02-27lok sc: Post mouse events to main threadPranav Kant
Change-Id: I1311938d7c01d0e3bfd239743e6cb2148da56cdf Reviewed-on: https://gerrit.libreoffice.org/50253 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2018-02-27lokdialog sc: post key events to the main threadPranav Kant
This also fixes the problem when some dialog is executed inside the key handler. Change-Id: I831ed4b886c1a5eac13dffd8e881a07045458e44 Reviewed-on: https://gerrit.libreoffice.org/50244 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2018-02-27remove unused vclunohelper.hxx includesJochen Nitschke
Change-Id: I68178379e5493d0e738861a4dce5aa6e4b58cd22 Reviewed-on: https://gerrit.libreoffice.org/50393 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-27uitest for bug tdf#77479Zdeněk Crhonek
repair test case - original file contain smb:// URL. New test file created from scratch. Change-Id: I64f32f87cb620be9988b91f8c96548e219057316 Reviewed-on: https://gerrit.libreoffice.org/50386 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-02-27replace Color(COL_*) with COL_*Noel Grandin
using git grep -lwP "Color\s*\(\s*(COL_\w+)\s*\)" | xargs perl -pi -e "s/Color\s*\(\s*(COL_\w+)\s*\)//g" and then some manual fixup where the resulting expression no longer compiled Change-Id: I0e268d78611c3be40bba9f60ecfdc087a36c0df4 Reviewed-on: https://gerrit.libreoffice.org/50372 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-27convert various MessBox to weld::MessageDialogCaolán McNamara
Change-Id: I4d2d0393c753114aeb9bb7e646dfdc810f6caa38 Reviewed-on: https://gerrit.libreoffice.org/50398 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-27convert remaining WarningBox to weld::MessageDialogCaolán McNamara
Change-Id: I7e3c156a6ad47ac232636ae274280c1cb7556d4a
2018-02-27drop old tools/gen.hxx methods in scNoel Grandin
Change-Id: I3652c0a35a6873e80ee22d908a8969d09410776b Reviewed-on: https://gerrit.libreoffice.org/50361 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-26convert corner case warningboxes with checkboxesCaolán McNamara
Change-Id: Ic8b58b792236a733b6687148eac5c06bbf734acf Reviewed-on: https://gerrit.libreoffice.org/50325 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-26Introduce enum comphelper::Hash::IterCount instead of boolEike Rathke
Clarifies intention, and with IterCount::NONE prepared to handle something like old PBKDF1, if anything actually used that. See https://tools.ietf.org/html/rfc8018#section-5.1 where iteration count is not part of the re-hash. Change-Id: I5f97ca7a91f611eced8ced0a0c64961c04535d36
2018-02-26convert remaining ErrorBox to weld::MessageDialogCaolán McNamara
and convert remaining QueryBox to weld::MessageDialog Change-Id: Ifb4c316dee8eabf57c4940c44e29c65a2781aa6c
2018-02-26use less RGB_COLORDATANoel Grandin
part of removing ColorData Change-Id: If31b5b88545529863377e9a178f45f4516bf6cbb Reviewed-on: https://gerrit.libreoffice.org/50345 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-26Prepare to handle OOXML Agile Encryption password hash as wellEike Rathke
... that prepends the iteration count to the hash instead of appending it Change-Id: I090393e6337c110029e35baaa259b40ef4e5d416
2018-02-26sc lok: Make the Validation "Invalid value." message box working.Jan Holesovsky
Change-Id: Ic0131fa6fc397ae440efed834266b8396aa9e619 Reviewed-on: https://gerrit.libreoffice.org/50160 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2018-02-26Move convenience abstractions to DocPasswordHelper, tdf#104250 follow-upEike Rathke
Change-Id: If0775ccf14b631918e51342a767412948e812c87
2018-02-26loplugin:useuniqueptr in SvxMSDffSolverContainerNoel Grandin
Change-Id: Ied7b60ac59cf1c869232a96e1b2ccb4e1b5cbf53 Reviewed-on: https://gerrit.libreoffice.org/49945 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-26loplugin:oncevar extend to tools/gen.hxx typesNoel Grandin
Change-Id: I5c75875da44334569c02e2ff039b33c38397a0a2 Reviewed-on: https://gerrit.libreoffice.org/50283 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>