summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)Author
2019-07-28lok: send cell selection rectangle and cell area fill rectangleTomaž Vajngerl
Instead of text selection start/end for cell selection we send a cell selection rectangle event. This is needed so we're able to differentiate when to draw cell selection and text selection markers. In addition send cell fill area rectangle, which is the area where we need to hit to trigger area fill functionality in Calc. Change-Id: I54af958932815818a1a4d48364192ba43f1df7de Reviewed-on: https://gerrit.libreoffice.org/76491 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-07-27cid#1401328 Uncaught exceptionCaolán McNamara
Change-Id: I1c4bdd4afec30d7d52054d8c9bd4958191c480f8 Reviewed-on: https://gerrit.libreoffice.org/76470 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-26cid#1401334 Uncaught exceptionCaolán McNamara
Change-Id: I6eaf41e5a2761c7c2d9f44c908720bebc53178a5 Reviewed-on: https://gerrit.libreoffice.org/76353 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-26UI test for #tdf121949Artur Neumann
Test if calc crashes when copying a noncoherent range to the clipboard Change-Id: I64d436ffb01775df9d50eb966ea2a12040482517 Reviewed-on: https://gerrit.libreoffice.org/76348 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2019-07-26tdf#42949 Fix IWYU warnings in sc/source/ui/vba/*cxxGabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I888a8f7269c03d9d4d066032f90564f92c4af2e4 Reviewed-on: https://gerrit.libreoffice.org/75596 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-07-26UI tests opening all dialogs in writer and see if it crashesArtur Neumann
Open a dialog, close it by the given button e.g. "cancel" or "close". If the dialog has an enabled "OK" button open the dialog again and try to close it also using the OK button. For every dialog a complete new document is opened to ensure test-separation, otherwise one action could hamper the next action. For dialogs that already have other tests a "cancel/close" test was added to the previous test. As far as possible opening new documents was avoided in those cases. And in some cases a simple check was added to check if the "cancel" button does not change anything. Simmilar tests for calc have been renamed and code dublication has been removed by moving main part of the code to a helper file Change-Id: I01f197cae8bc6fe0345661fe042b655f16229485 Reviewed-on: https://gerrit.libreoffice.org/75124 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2019-07-25LOK: sc: Issue DOCUMENT_SIZE_CHANGED only when size changesAshod Nakashian
Issuing DOCUMENT_SIZE_CHANGED triggers document-loaded event. This is accidental and historic, but the end result is that the client assumes everything is invalidated and fires initialization handlers, which are normally invoked the first time a document is loaded. Undesirable when really nothing has changed. Change-Id: Ia4fa4479ca627b0f605e4ff5009f7e631a26f6d7 Reviewed-on: https://gerrit.libreoffice.org/76313 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-25lok sc: Fix the formula input bar and address bar notifications.Jan Holesovsky
Apparently we did not have the pInputWin living in the background; but now we have. There is no reason to treat it in an 'else' branch, these checks should be separate either way. Change-Id: Ibb8d92fb1e2803942460d2063847917d082fcb2e Reviewed-on: https://gerrit.libreoffice.org/71863 Reviewed-by: Aron Budea <aron.budea@collabora.com> Tested-by: Aron Budea <aron.budea@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/76292 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-25tdf#107394 sc ui: fix lack of row height update on undo of pasteMiklos Vajna
This is a problem since commit df9243626b39742a9a148bea95796f8824fee68a (fdo#73606: Avoid excessive and unnecessary heap allocation of array objects., 2014-01-14), though it seems this uncovered a problem that was introduced earlier. Reading ScViewFunc::AdjustBlockHeight(), commit 64a36fd4f4085ed05e4c0ee40ac109452ff81a78 (ScUndoPaste to handle multiple ranges., 2011-09-09) changed ScUndoPaste::DoChange(), so that AdjustBlockHeight() is invoked in a loop, but always with the same arguments. In case AdjustBlockHeight() doesn't get a mark data, the function takes the mark data from the view data, which is empty in the "undo of paste" case, so no row height gets updated. Fix the problem by explicitly providing the mark data to AdjustBlockHeight(), probably that was the intention in the second commit. [ Testing this from CppunitTest_sc_copypaste means ScImportExport has to be dllpublic, but that seems still better than having a view shell in CppunitTest_sc_ucalc. ] Change-Id: I140b53588d59d231772152c0e820e5fdedf6894c Reviewed-on: https://gerrit.libreoffice.org/76265 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-07-25Fix typosAndrea Gelmini
Change-Id: I59a0fd175fa5185c15d093d2d9bed9f95bb4cfd5 Reviewed-on: https://gerrit.libreoffice.org/76280 Tested-by: Jenkins Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
2019-07-24Fix typoAndrea Gelmini
"an URI", to complete: https://gerrit.libreoffice.org/#/c/75985/ Change-Id: I57489b05117fd12ae6aa22544437ab5bc6b5154f Reviewed-on: https://gerrit.libreoffice.org/76037 Tested-by: Jenkins Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
2019-07-24cid#1448321 Dereference after null checkCaolán McNamara
Change-Id: I724e4c19df9aa446f496b21ea5f3918e2def28da Reviewed-on: https://gerrit.libreoffice.org/76249 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-24loplugin:unusedenumconstantsNoel Grandin
Change-Id: I484b39d1060e6a563dabdde03867989b8ba067f9 Reviewed-on: https://gerrit.libreoffice.org/76237 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-24convert AreaOverlapType to scoped enumNoel Grandin
and remove unused AreaPartialOverlap Change-Id: I21e94d8d15c59485c1287e99dcc6558e0570a8eb Reviewed-on: https://gerrit.libreoffice.org/76234 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-24cid#1451636 silence Division or modulo by zeroCaolán McNamara
Change-Id: Ibe9ee3d5f555d153fd208a03ba2e3ae68d263ab3 Reviewed-on: https://gerrit.libreoffice.org/76224 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-23Don't draw gridlines and document background in Online server processMike Kaganski
... see https://gerrit.libreoffice.org/72417 They will be drawn client-side. Borders and explicit cell background are still drawn in core. This mode is activated using "sc_no_grid_bg" option in SAL_LOK_OPTIONS environment variable. Change-Id: Ie10e7770b8168ec648d44ae5af0a0a0602d89ee6 Reviewed-on: https://gerrit.libreoffice.org/75484 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-07-23Fix typoAndrea Gelmini
Uhm... maybe missed traslantion from German? Anyway, this just to spot it to smarter ones Change-Id: Icba3458d9acf9d123a73973c749c94aebd518881 Reviewed-on: https://gerrit.libreoffice.org/75258 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins
2019-07-23tdf#122774 Make all ScCheckListMenuWindow items keyboard accessibleJim Raykowski
This patch provides keyboard tab navigation to the menu window menu items. In addition to the Ok button being already disabled when search is empty the patch disables the check list box, toggle all check box select, single button and unselect single button. This prevents keyboard focus from being trapped in the check list box and from tab navigation visting useless controls when search is empty. This patch also provides a hack fix for tdf#122772 Change-Id: I7677d544ae63acc8eca08877ecd001d394fcfaca Reviewed-on: https://gerrit.libreoffice.org/75684 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2019-07-23loplugin:unusedfieldsNoel Grandin
Change-Id: If1e0b32f2cce7678f454009c0180d7612b4fb7c6 Reviewed-on: https://gerrit.libreoffice.org/76119 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-23close some more holes in structuresNoel Grandin
and improve the pahole script so I can just run it once over the whole codebase Change-Id: I7e1775974a3a61f8c0e40646158f01163ace60cc Reviewed-on: https://gerrit.libreoffice.org/76122 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-22tdf#106000 sc ui: fix missing invalidation when cancelling note creationMiklos Vajna
Regression from commit dca01def7885ad69cf66edd75cf8207a5adb64f9 (refactor ListBox/ComboBox to use RenderContext, 2015-05-07), invalidating the area of note anchors worked like this in the past: - user ended text edit of a new, empty comment - the Calc shell was updated from shape text edit to the tab view, which called ImplListBoxWindow::SelectEntry() - this called ImplPaint(), which invoked maUserDrawHdl (if it was set) - and at the end this invoked ScViewFunc::UpdateSelectionArea(), all triggered by the font name and font size listboxes So the update of the cell of the former note depended on the presence of font name/size listboxes, by accident. This broke, because ImplListBoxWindow::SelectEntry() now calls Invalidate(), and Paint() calls ImplDoPaint(), which doesn't invoke maUserDrawHdl anymore. Fix the problem by invalidating the cell explicitly, so in case the user customizes the toolbar to not have these listboxes, the behavior is still correct. Do this in FuText::StopEditMode(), because there we know the position of the deleted note and that's where we delete the matching SdrCaptionObj (via the RemoveLastUndoAction()). Change-Id: Iaa4b609477ac6c7f23efc575fddac6e39aa6a7b5 Reviewed-on: https://gerrit.libreoffice.org/76120 Reviewed-by: Luboš Luňák <l.lunak@collabora.com> Tested-by: Jenkins Reviewed-by: Dennis Francis <dennis.francis@collabora.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-07-22cid#1448321 Dereference after null checkCaolán McNamara
Change-Id: Ic8f70f01ea78d40ae1676c2d6561fa39dcb8ae9e Reviewed-on: https://gerrit.libreoffice.org/76113 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-22cid#1242892 Untrusted value as argumentCaolán McNamara
Change-Id: Ie08f75468fc7acbdf8b89496c750e5fec6d19f0d Reviewed-on: https://gerrit.libreoffice.org/76103 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-22cid#1448325 Dereference after null checkCaolán McNamara
Change-Id: I7ca6b442f9aadaeb6debe7806e30693aa06b90ff Reviewed-on: https://gerrit.libreoffice.org/76114 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-22cid#1448318 Dereference null return valueCaolán McNamara
Change-Id: Ibdb452f5c8a6da255e3641d38078870d4206f913 Reviewed-on: https://gerrit.libreoffice.org/76112 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-22cid#1448220 Explicit null dereferencedCaolán McNamara
Change-Id: I0e612cf738d54e2108458da5c4afe78f1699f475 Reviewed-on: https://gerrit.libreoffice.org/76105 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-22cid#1401328 Uncaught exceptionCaolán McNamara
Change-Id: I7b038954fbe6b4a5d463c543313a424c4a6aabdc Reviewed-on: https://gerrit.libreoffice.org/76090 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-22cid#1448348 silence Stray semicolonCaolán McNamara
Change-Id: I4ceeb7099b8f5bfc132ffe1e18c7116de15d55d1 Reviewed-on: https://gerrit.libreoffice.org/76093 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-22tdf#42949 Fix IWYU warnings in include/vbahelperGabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I31ca76998b4fab5fe383993c89319b3a08d30401 Reviewed-on: https://gerrit.libreoffice.org/75181 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-07-21cid#1399198 Uncaught exceptionCaolán McNamara
Change-Id: Ibf07c82669919a3f905b416e92cfbe0f08d99a8d Reviewed-on: https://gerrit.libreoffice.org/76004 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-20cid#1451628 Dereference after null checkCaolán McNamara
Change-Id: I6ec54ac4568959e70a2d894bf4a564ac1bed627d Reviewed-on: https://gerrit.libreoffice.org/76027 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-20cid#1448415 Pointer to local outside scopeCaolán McNamara
Change-Id: I35f20fa37a19ff921916cd0e8bb7bafbc66ec8b5 Reviewed-on: https://gerrit.libreoffice.org/76021 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-20cid#1399336 Uncaught exceptionCaolán McNamara
Change-Id: Ia2b0fee5be67009731af8cc79088020e770dddbf Reviewed-on: https://gerrit.libreoffice.org/76005 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-20cid#1448465 Uncaught exceptionCaolán McNamara
Change-Id: Ic70f0926b4e26f82045a791eadf6af1e9d7949a9 Reviewed-on: https://gerrit.libreoffice.org/76009 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-20assign nLen during ctorCaolán McNamara
Change-Id: I9164bd2b653208214276c48ddf49b21436edbd63 Reviewed-on: https://gerrit.libreoffice.org/76012 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-20cid#1448265 Untrusted value as argumentCaolán McNamara
Change-Id: I31280f417e3542bb7596bab798e971b714b5285f Reviewed-on: https://gerrit.libreoffice.org/76002 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-20loplugin:referencecasting in scNoel Grandin
Change-Id: Ife30500d1ff67e06afc4d64634febfb4c161c702 Reviewed-on: https://gerrit.libreoffice.org/75976 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-19cid#1448351 Use after freeCaolán McNamara
Change-Id: I5591303096a495565e4e3638ca8db8196fa26092 Reviewed-on: https://gerrit.libreoffice.org/75913 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-19cid#1448217 Use after freeCaolán McNamara
Change-Id: Icb7700c701dd8e9b23bfe29bbedf27ddd9c8f0a1 Reviewed-on: https://gerrit.libreoffice.org/75911 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-19cid#1448311 Dereference null return valueCaolán McNamara
Change-Id: Ie0ad350d48441dc6012dddc9fa3989acc4d4aab8 Reviewed-on: https://gerrit.libreoffice.org/75917 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-19cid#1448287 Unchecked return valueCaolán McNamara
Change-Id: Ifd6bd0f4218805ad52a256fad82a4d2455c6afa9 Reviewed-on: https://gerrit.libreoffice.org/75871 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-18cid#1448339 Use after freeCaolán McNamara
Change-Id: I3259e0fe9ebaba819d529af2fdb003ce9a297961 Reviewed-on: https://gerrit.libreoffice.org/75813 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-18tdf#101443 Horizontal inset margin of Calc input bar increasedThorsten Wagner
Change-Id: Ic609da4b8b5fae0f556761c4493e490c82a6386d Reviewed-on: https://gerrit.libreoffice.org/74214 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2019-07-18tdf#126453: hide ScInputHandler's tooltips when loosing focusMike Kaganski
Change-Id: I188db03ad9027bcb17a72f7c59d85e611b57bfd0 Reviewed-on: https://gerrit.libreoffice.org/75824 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-07-18include supported SIMD intrinsics headers automaticallyTomaž Vajngerl
If we include simdsupport.hxx, this now includes the supported intrinsics headers automatically, so this removes the need to do it ourselves. Change-Id: Icc406316a7e27b7b5fd5905f51664f4fe47e5468 Reviewed-on: https://gerrit.libreoffice.org/75783 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-07-17fix "tdf#119388 calc, slow removing column, improve ScChildrenShapes"Noel Grandin
forgot to add the code to actually update the map, which would be bad for accessibility Change-Id: I5d93dd84649ce27a37c9035622f94fff3237b778 Reviewed-on: https://gerrit.libreoffice.org/75773 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-17tdf#121039 "Open hyperlink" from context menu does not workSamuel Mehrbrodt
Change-Id: I802a4a64d48befa9c41b7095416f165082a155f2 Reviewed-on: https://gerrit.libreoffice.org/75778 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-07-17crashtesting: assert on export of fdo63407-3.ods to xlsCaolán McNamara
since... commit 3cdc1b35b9d86bcfa1277e3e94925ae7b18b8fde Date: Tue Jul 2 10:07:24 2019 +0200 tdf#126177 XLSX export: fix hyperlinks to documents Change-Id: Id5aaaab760a53b1e996d5d47c7477d77ce1d4efc Reviewed-on: https://gerrit.libreoffice.org/75757 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-17tdf#126421: don't limit pasted data to allocated columns in destinationMike Kaganski
Change-Id: Ic30360795c5dac1dc232f95bd25f5a11946c7dee Reviewed-on: https://gerrit.libreoffice.org/75738 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-07-17tdf#126393 Select cell even when clicking on a hyperlinkSamuel Mehrbrodt
and the hyperlink isn't being opened anyway (no ctrl clicked e.g.) Change-Id: Ic0c0df9b91000a8e661075901e8bfdb7167081f9 Reviewed-on: https://gerrit.libreoffice.org/75730 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
generated by cgit (git 2.34.1) at 2024-08-08 23:23:11 +0000