summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)Author
2021-05-10Resolves: tdf#126928 allow link updates in an intermediate linked documentEike Rathke
... if link updates are allowed in the current document and that intermediate document resides in a trusted location. This works with both, the "Always (from trusted locations)" and the "On request" settings under Tools -> Options -> Calc -> General. It can't work with documents residing in a non-trusted location as there is no way to allow updates on demand for a such loaded document (hidden via formulas). Reviewed-on: https://gerrit.libreoffice.org/77588 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit 54bf84746a2a9a2e2aaf0df9e429b0cfd538f640) Reviewed-on: https://gerrit.libreoffice.org/77604 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> (cherry picked from commit 14825a8b7f00ee4c148f2583856e5102312cabbd) (cherry picked from commit f136b30fa3e991b780e4b1ed704d04256d0cfca0) Change-Id: Ie483f7743db7c6d5cf947dc16a9c3660855f3423 (cherry picked from commit 86a3ea14d959f8a5409ea4883d9bf19e48046947)
2021-05-10Postpone loading of all external references, including INDIRECT()Eike Rathke
... which can be constructed with an arbitrary URI text string not an svExternal* token type, until link updates are allowed. Reviewed-on: https://gerrit.libreoffice.org/75422 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit b824b23860b2cf533d4f2428d4a750bd72576181) Reviewed-on: https://gerrit.libreoffice.org/76304 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Change-Id: I2ce4de415ff99ace04c083c36c1383d76a4ef40d (cherry picked from commit 31b1d2af8ce01804049168b7b0317d93d77a42d7) (cherry picked from commit e374cd045665226e0af82e1ba787bcb2a3879d31)
2021-05-10Postpone filter detection until link update is allowedMike Kaganski
Change-Id: I85b2185e550f2a133ceb485241ef513b40593e34 Reviewed-on: https://gerrit.libreoffice.org/75301 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit 03c708bf085f91480c014d7fa31e7a317b2c7b8f) Reviewed-on: https://gerrit.libreoffice.org/76303 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit 43bf332aeede732557378e81765f29b704b17188) (cherry picked from commit 73176974d613b01bdf5223b93cf2705d3fd8c155)
2021-05-10forcepoint#55 invalid iterator incrementCaolán McNamara
Change-Id: I151602f645a48404d93e0ae64a9e1d2a6ba2bc4b Reviewed-on: https://gerrit.libreoffice.org/58386 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit 26300f5d4c4e6241baf8cadcfea094e7969814a5)
2021-05-10forcepoint#64 null derefCaolán McNamara
Change-Id: I4acf03a7911aa203fc4ef10b6a96b0135d6adbbc Reviewed-on: https://gerrit.libreoffice.org/58415 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> (cherry picked from commit a5b84a6888deaa406786b350a0adcf9ef9020f48)
2021-05-10ofz#9431 don't check attribs of Invalid columnCaolán McNamara
Change-Id: I9c5adcadfa2a8593ff90622449d6bdfa4810f2c0 Reviewed-on: https://gerrit.libreoffice.org/57917 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit d909146913c762c2cdb6bed52fbbd817c05681e9)
2021-05-10forcepoint#40 null derefCaolán McNamara
presumably since commit 0098bee792c3e208ea4f6ef1c676958d3f4cd207 Date: Thu Sep 21 06:48:09 2017 +0200 tdf#112501: Pivot table: popupbuttons are placed on wrong cells Change-Id: I5413c0ba06fca25cb22256a20ef9640767dd9e50 Reviewed-on: https://gerrit.libreoffice.org/54970 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> (cherry picked from commit 69c5be9b26cf1a45e220d69f65b1bb0fa2aedaf6)
2021-05-10Prevent out-of-bounds access, tdf#114228 relatedEike Rathke
Such document access should be validated, specifically if it's called from accessibility. Change-Id: I67fa14c7fb1bf3885fc009428b981149f3f448fb Reviewed-on: https://gerrit.libreoffice.org/45978 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 7265e75f8b34cc1043b972478e8b499566660f86) Reviewed-on: https://gerrit.libreoffice.org/45979 Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit d17dfb3dc1cc7fd91ede9a58337d89e38fd3b022)
2021-05-10ofz#10189 check container sizeCaolán McNamara
Change-Id: Ie99e3b082795989290799d057a99b1bcff94b161 Reviewed-on: https://gerrit.libreoffice.org/59913 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> (cherry picked from commit 6ee76d210846b84e93420a321c7908721ffe9e43)
2018-05-23acim#1133: tdf#117043 pivot table refresh fixrking
2018-04-30Related: tdf#100925 background not getting set under X sometimesCaolán McNamara
not sure why this is the case, but it is reminiscent of rhbz#1283420 which results in missing glyphs in some circumstances X11CairoTextRender::getCairoContext has a hack in it for that problem, whic forces a read from the underlying X Drawable before writing to it which seems to have the effect of syncing it up. So, just before drawing the bg, draw a glyph on it to get it synced, and then overwrite it. Change-Id: I2ffff7e8e989b91821869d8b75a59728ac513d1b Reviewed-on: https://gerrit.libreoffice.org/52819 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit e8080c79043a7d9036f27cc24b76b7ff21c58da8) Reviewed-on: https://gerrit.libreoffice.org/53657 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Tested-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-04-05forcepoint #34 survive missing autostylesCaolán McNamara
Change-Id: I742816297659d614e836a8d5e8965b1c55154719 Reviewed-on: https://gerrit.libreoffice.org/51892 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2018-04-05forcepoint #32 survive missing value rangeCaolán McNamara
Change-Id: I90315f0481bf73c4d9071959bf5408f4a2690257 Reviewed-on: https://gerrit.libreoffice.org/51886 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2018-04-05forcepoint #31 check validity of another group rangeCaolán McNamara
Change-Id: I82ff3e47a033c91581b108e1685b1ff4d5865895 Reviewed-on: https://gerrit.libreoffice.org/51883 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2018-04-05forcepoint #30 check validity of group rangeCaolán McNamara
Change-Id: Ie0611f36809b051ce46030e44c137b4e1f8d2fe0 Reviewed-on: https://gerrit.libreoffice.org/51865 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2018-04-05forcepoint #29 detect illegal self series addCaolán McNamara
Change-Id: I3bba0f942780c54951a3a810c05cc3b56ca18a5e Reviewed-on: https://gerrit.libreoffice.org/51862 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2018-04-04tdf#112997 multiple animated gif only one frameNoel Grandin
Not sure what the problem is, but using a vector and just making sure we insert into the right spot for the sorting fixes it. Change-Id: I11c08e08a14c98ba7eb6a5d925c75bab891ecf63 Reviewed-on: https://gerrit.libreoffice.org/51829 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit d312ff2b52c0ea2e2864518a36f6b432653c8297) Reviewed-on: https://gerrit.libreoffice.org/52010 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-27ofz#7121 NamedDBs::insert takes ownership of its argumentEike Rathke
at one point this was based on std::auto_ptr and didn't free its arg on failure Adapt description to reality Change-Id: I24133fb6c52bd7500037364120cb11d1b1f099c2 (cherry picked from commit f161cdc979587488df83e63002bee7ee15152d42) Change-Id: I8aeed6876d80b7ebe4ebb5e2cfd12e00420bd207 Reviewed-on: https://gerrit.libreoffice.org/51934 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2018-03-21Resolves: tdf#116324 treat jump empty path as 0 when nestedEike Rathke
Apparently a fallout from commit 0f45ac20cd2ab2a64c40c7d6850f333cc33feeb0 AuthorDate: Mon Jun 28 11:40:39 2010 -0400 CommitDate: Sat Nov 6 23:40:00 2010 -0400 More on fixing build by eliminating use of ScMatrixValue. or other commits related to ScMatrix handling. Change-Id: I10e8b58aed51cd707b1503dbbc0b369aea4a2805 (cherry picked from commit 8930f8f530b4879226a6bac55bfeb551ac9e7489) Reviewed-on: https://gerrit.libreoffice.org/51054 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2018-03-21Resolves: tdf#116215 separate column sums and row sums, tdf#71339 relatedEike Rathke
Change-Id: Ifc7ab0c460f521ad3be4aa2785d54a1e4ed304e5 (cherry picked from commit 9d8dcec608dde63c68b34450a95a3b168121e289) Reviewed-on: https://gerrit.libreoffice.org/50846 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2018-03-13forcepoint #26 check input against max valid enum valuesCaolán McNamara
Change-Id: Ide72884c77904ae9495b5189cde086e43923e4bd Reviewed-on: https://gerrit.libreoffice.org/51138 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-03-13tdf#103175: Initialize DrawLayer if requiredMike Kaganski
Change-Id: Ia99dd1e349e807d339dce0ead518a72a31e0fc02 Reviewed-on: https://gerrit.libreoffice.org/51096 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit de53d4690d25b9f1bbc0def6c66ce5b45b2fdc96) Reviewed-on: https://gerrit.libreoffice.org/51111 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2018-03-06tdf#116171: Tunnel arbitrary rtl_TextEncoding from sc to sdbc:dbase connectionStephan Bergmann
...including those that have no corresponding textual IANA character set name representation, like RTL_TEXTENCODING_MS_950 which is apparently used in some DBase files. In the past, if eCharSet was RTL_TEXTENCODING_DONTKNOW in lcl_getDBaseConnection it was sent as an empty string CharSet property, which the receiving OConnection::construct translated back to else m_nTextEncoding = RTL_TEXTENCODING_DONTKNOW; so the net effect remains the same for that special case. Reviewed-on: https://gerrit.libreoffice.org/50772 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit 5ad62544bce42396faaae2bc79c7517af6ff085b) Conflicts: sc/source/ui/docshell/docsh8.cxx Change-Id: I84eec8a93d000752b3c429976c58721ea9ea32a4 Reviewed-on: https://gerrit.libreoffice.org/50791 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2018-03-05tdf#115866 comments inside StringArray blocks drop translationsCaolán McNamara
Change-Id: I422d87bd51e581eebafe961d308923a27c004f42 Reviewed-on: https://gerrit.libreoffice.org/50353 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2018-02-21for listeners the range needs to be set before the formula, tdf#115530Aron Budea
Change-Id: I001795fd456375c4babab2c2e505bedff03e991f Reviewed-on: https://gerrit.libreoffice.org/49957 Reviewed-by: Aron Budea <aron.budea@collabora.com> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit 26b51c9550ef300e7685fc41eb9cde4dbbc11265) Reviewed-on: https://gerrit.libreoffice.org/50016 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2018-02-21Resolves: tdf#115710 let css::sheet::FunctionAccess execute WEBSERVICEEike Rathke
... independent of a LinkManager that is not present in the interim FunctionAccess document. FunctionAccess is executed by extensions, Add-Ons and macros that the user gave permission already. Change-Id: I9349a59ee24089c3657de7786b49e5e81946f175 (cherry picked from commit 121fda77b0cc16d54607a1f5f7b26c0f1050284f) Reviewed-on: https://gerrit.libreoffice.org/50020 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-17Resolves: tdf#115046 don't restore a sheet-local DBData from temporaryEike Rathke
And don't clear AutoFilter button flags in the new temporary range. Change-Id: I273de1e04632ac99c267523b2843665d257fd361 (cherry picked from commit 74d30155c5067271fb98bacbcb895c215e61678d) Reviewed-on: https://gerrit.libreoffice.org/49810 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-02-15ScSetStringParam::mbCheckLinkFormula for HTML and RTF importEike Rathke
This is a combination of 3 commits. Introduce ScSetStringParam::mbCheckLinkFormula (cherry picked from commit 5a93c51e3b7f455ff5d4cfc9e8b6e510fc126b75) Handle ScSetStringParam::mbCheckLinkFormula in ScColumn::ParseString() (cherry picked from commit 271d9ebfe0c4fc57ea6f01a9c048021e5429dd15) Conflicts: sc/source/core/data/column3.cxx ScSetStringParam::mbCheckLinkFormula for HTML and RTF import (cherry picked from commit 98c0bd7ffd008015623b2c5eb8630649394d76f6) d6b0705140baacdb872560f7031efaf0c03f0e00 7cf7cf12142322cbffd5160e9a8dce55efd36be5 Change-Id: I2028fc53f9778606778cd8629611752acd3f1a1c Reviewed-on: https://gerrit.libreoffice.org/49709 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-02-15CheckLinkFormulaNeedingCheck() for ScDocumentImport::setFormulaCell()Eike Rathke
and ScDocumentImport::setMatrixCells() This is a combination of 2 commits. CheckLinkFormulaNeedingCheck() for ScDocumentImport::setFormulaCell() (cherry picked from commit bcd62f2050336951ad56892d6e0a42f63c59a674) Conflicts: sc/source/core/data/documentimport.cxx More CheckLinkFormulaNeedingCheck() for ScDocumentImport::setFormulaCell() and ScDocumentImport::setMatrixCells() (cherry picked from commit f41c14706c6bf8aa5c3df220c706669f1ec6e1f6) Conflicts: sc/source/core/data/documentimport.cxx d3303fb71889c760424459daa79feca0f2510a3c Change-Id: I1587be914b390b2597185dd5af870d1d785010a4 Reviewed-on: https://gerrit.libreoffice.org/49735 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-02-13CheckLinkFormulaNeedingCheck() for .csv importEike Rathke
Change-Id: I89be713531436f10b38d38f9e0fa527db1e036cd (cherry picked from commit c7dd72b2bd6a7988e4e1074e9a85222b53ba84ac) Reviewed-on: https://gerrit.libreoffice.org/49501 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-02-13CheckLinkFormulaNeedingCheck() for .slk importEike Rathke
Change-Id: I79953cf4fd6e9e00351a3b1f1687b6024085e395 (cherry picked from commit 664c2902a6672be51c4a3163a5bf44aa2145d408) Reviewed-on: https://gerrit.libreoffice.org/49611 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-02-12tdf#72440 Abs sheet ref must be givenLaurent BP
When resolving tdf#90799, sheet ref was forced abs But its value must be changed. It worked only if initial sheet = Sheet1 Change-Id: I715f93dce93beb78d767e00dd45fb9634cb173a8 Reviewed-on: https://gerrit.libreoffice.org/49548 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit d69017c8a17be21657ea7ab9d37023ee59116799) Reviewed-on: https://gerrit.libreoffice.org/49609
2018-02-09tdf#115493 postpone name resolution after unsuccessful IsNamedRange()Eike Rathke
... for names used in named expressions when compiling during import and collecting named expressions, to not match an arbitrary other name. Change-Id: I02a92747a1485b46873281de98879a89385d4622 (cherry picked from commit 30083601334279f33a3021dfe7d22970d02c8e9e) Reviewed-on: https://gerrit.libreoffice.org/49397 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-06tdf#114820 Fix reading external reference for VLOOKUP and HLOOKUPBartosz Kosiorek
Change-Id: Iaa1307123d97a740bdaf90647e8adff224211851 Reviewed-on: https://gerrit.libreoffice.org/49263 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 5c3d0a70a0edb182714725ef920d74667feffb0e) Reviewed-on: https://gerrit.libreoffice.org/49316
2018-02-06tdf#115162 Fix support for external reference for IFS functionsBartosz Kosiorek
Functions SUMIFS, AVERAGEIFS, COUNTIFS, MINIFS, MAXIFS were not supported External references. The root cause issue, was using PopMatrix() method for: svExternalSingleRef and svExternalDoubleRef. PopMatrix() method only supports svMatrix, and in other cases returns FormulaError::IllegalParameter error. To resolve that issue, the method GetMatrix() was used. It is properly support svMatrix, svExternalSingleRef and svExternalDoubleRef. Change-Id: I3e30ca50069264a6d990b16ec668e6d0df51c6e6 Reviewed-on: https://gerrit.libreoffice.org/49264 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit b6db65752c60de7268e4f65d7fc5ac110adb2fb0) Reviewed-on: https://gerrit.libreoffice.org/49284
2018-02-06Turn assert into SAL_WARNEike Rathke
In the wild there are named expressions without expression and formula error cells without formula. Change-Id: I11546b09173de65cebe776529edee74c549d73c8 (cherry picked from commit 951dd781743c975a7d29cc30e88e1b4a56c0b176) Reviewed-on: https://gerrit.libreoffice.org/49259 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-05sc: disable "forecast.ets.add.fods" test file on MacsMichael Stahl
This sometimes fails, since months, and nobody has fixed it. Let's improve the reliability of CI a bit. Change-Id: Ic4d2e085151855d35804f8ed6ebca04366815c0b Reviewed-on: https://gerrit.libreoffice.org/49144 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit 00a6f0908a73a80fb0521e1f4cdc99647e43c126) Reviewed-on: https://gerrit.libreoffice.org/49228
2018-01-30tdf#112033: enable the xml source feature when the experimental features are ↵Markus Mohrhard
enabled Change-Id: I066b2927c5e22664b7a4e96549da3a02ec4c99d3 Reviewed-on: https://gerrit.libreoffice.org/41085 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit 65722772f00a40b8ca8adf21e31c22295ef7d215) Reviewed-on: https://gerrit.libreoffice.org/47696 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2018-01-30tdf#115044: do not load external documents if it is not allowedVasily Melenchuk
Referenced external document data can be loaded after user permission from dialog or corresponding settings. Change-Id: If3aec37c8bbdee4aebeb99c7807e87c26df8e592 Reviewed-on: https://gerrit.libreoffice.org/48398 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 8b98991a66197a71953dbb900dc3aece6b4f9e3a) Reviewed-on: https://gerrit.libreoffice.org/48870 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-30CheckLinkFormulaNeedingCheck() for named expressionsEike Rathke
This is a combination of 3 commits. CheckLinkFormulaNeedingCheck() for .ods named expressions This is specifically necessary for named expressions that are used in conditional format formulas, for which RPN is generated at a later stage, not during import. (cherry picked from commit eae9648e99be53ba441d9d8207aac6f3ce211ef2) CheckLinkFormulaNeedingCheck() for .xls named expressions (cherry picked from commit 8512f13c42ae3fbb287a555616fe10ff04295616) CheckLinkFormulaNeedingCheck() for .xlsx named expressions (cherry picked from commit a1f933ee2b9e23a505d937035821e9571cf4119c) Conflicts: sc/source/filter/oox/defnamesbuffer.cxx e03cb5767c34f8157a492a6d6c3b0700d065052d 217c89822ab477a6c383d170ae739e44efd10fa3 Change-Id: I54ab8dc14f81d6b18b0d17f448187d19d8e396fc Reviewed-on: https://gerrit.libreoffice.org/48858 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-27CheckLinkFormulaNeedingCheck() for conditional format expressionsEike Rathke
This is a combination of 4 commits. Prepare CheckLinkFormulaNeedingCheck() to use either RPN or tokenized code Conditional format formulas aren't finally compiled until needed so the check will have to operate on the tokenized expression instead of RPN code. (cherry picked from commit faa0305ba3d0dc698fce4915d4f3a1fb52422380) CheckLinkFormulaNeedingCheck() for .ods conditional format expressions (cherry picked from commit 2930ba2ac5d9423f2848b968edcd8ddc71966186) CheckLinkFormulaNeedingCheck() for .xlsx conditional format expressions (cherry picked from commit fef24d9f999ee54d7936900485d97ff26656f517) CheckLinkFormulaNeedingCheck() for .xls conditional format expressions (cherry picked from commit af2a2a0c72db312902e466c36697b5c198041e82) 45eb1ab5efa0ec9da2663f20427d2474ce300826 31ede1a23223a798141a0891deeabd8cf88fff58 afa112cc591b411d80ead48bf726788d361f6eb3 Change-Id: I68837e9bd33f125ab47b10b1a6fa18175abd1627 Reviewed-on: https://gerrit.libreoffice.org/48719 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-27CheckLinkFormulaNeedingCheck() for .xls and .xlsx formula cellsEike Rathke
This is a combination of 3 commits. Move implementation to CheckLinkFormulaNeedingCheck() for further reuse (cherry picked from commit 55e484c7bcd3ef218e08d3fd93f97bf98fd8cb7f) CheckLinkFormulaNeedingCheck() for .xlsx cell formulas (cherry picked from commit f96dbc3dd9c33202f75e29ef49d962386595995d) CheckLinkFormulaNeedingCheck() for .xls cell formulas (cherry picked from commit 6bc48275558c3f76c4da25eb8af3c48583ac5599) a6dd195f7eb4d43483e87eeca59f651e7bf2dcb8 2587fbc4fec39b6f2c8e733331815a2953dee308 Change-Id: I541d2b6e12a88371c064b901b00e71206ee0c18e Reviewed-on: https://gerrit.libreoffice.org/48143 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-27Flatten ScRangeList::Join() and ScRangePairList::Join() recursionEike Rathke
This is a combination of 2 commits. Flatten ScRangeList::Join() recursion Joining an existing list of identical ranges could end up in a very deep (but not infinite) recursion which could lead to stack exhaustion. Recursion is unnecessary if we re-enter the loop with the picked range. Continuing the loop as it was done after recursion isn't necessary either, to the contrary, as long as there is one join try the entire list again. Commit f6eefd96cb16a9b5607fe59bdbf9b1121c9b56e8 pointed this out as the UBSan build runs with ulimit -s 8192 Reviewed-on: https://gerrit.libreoffice.org/48360 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit 03f429665b4d57f63b8e2862a55e5c4273bc7a2b) Flatten ScRangePairList::Join() recursion Similar to ScRangeList::Join() done before. Reviewed-on: https://gerrit.libreoffice.org/48361 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit 73049e5dbf9430df077dd26bed9d01435f745544) e513b4c72bc211c196e13761b63446174321a389 Conflicts: sc/source/core/tool/rangelst.cxx Backported. Change-Id: Ibbc542fc8ae6d1509744aa731771eb6e32a38841 Reviewed-on: https://gerrit.libreoffice.org/48411 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-23Handle also the case where a range extends an existing one with overlapTor Lillqvist
Check for a new range being joined Extending an existing one in any of four directions (up, right, down, left), within a tab (sheet), that is. And add unit test for this. Reviewed-on: https://gerrit.libreoffice.org/42304 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 596efaad51735a130e7b7bd27dbc34dc07f32f68) Change-Id: I4bd0525c2837f8b4b9d5a8967e0d5d661c6a5e2f Reviewed-on: https://gerrit.libreoffice.org/48410 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2018-01-22Related: tdf#114251 disable vectorization of svDoubleRefEike Rathke
It doesn't work, not knowing how to handle implicit intersections not only produces huge unnecessary matrix operations but also delivers wrong results. Unit test will follow as a separate commit. Change-Id: I14982d4a53d6af57196da998e53d426502c22fec Reviewed-on: https://gerrit.libreoffice.org/46647 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 67444cbe5dae6e24db776ab712017ad063319276) Reviewed-on: https://gerrit.libreoffice.org/46670 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-01-22Type svIndex does not necessarily mean range name, tdf#114251 relatedEike Rathke
Change-Id: I5e7930b7f93ee44fb0d6b4c86f261afde8ed2ccc Reviewed-on: https://gerrit.libreoffice.org/46615 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit ecac94f3a6872538c19827603b52f1ed7e671a4c) Reviewed-on: https://gerrit.libreoffice.org/46668 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-01-22copy ScAddress before possibly joining itCaolán McNamara
Change-Id: Ib1148584b9771da67d3f4b3141184228e1bbe3a2 Reviewed-on: https://gerrit.libreoffice.org/48271 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit f6eefd96cb16a9b5607fe59bdbf9b1121c9b56e8) Reviewed-on: https://gerrit.libreoffice.org/48298 Reviewed-by: Eike Rathke <erack@redhat.com>
2018-01-16Resolves: tdf#114539 only pop own parameters from stackEike Rathke
... and not another pending one.. Change-Id: Ief5c27ccfb0b4121f2ba019e0fb8770dabbf60cf (cherry picked from commit 4b444b4c1efc2be219e6975e30048ff616fdac0f) Reviewed-on: https://gerrit.libreoffice.org/46801 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-01-16handle ocWebservice similarly to ocDdeCaolán McNamara
might have too much in here seeing as we don't need to worry about ocWebservice calling into itself Change-Id: I0145f38cc1c1f9ff514a496f7101d81cde9e7c67 Reviewed-on: https://gerrit.libreoffice.org/47819 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2018-01-16Better handle ScDde formulas with missing dde-link entriesCaolán McNamara
typically each ScDde formula has a matching table:dde-link which results in a ScDdeLink getting inserted during the load. If that dde-link is missing then no ScDdeLink exists and ScDde() will create a new one without cached content. So detect that ScDde is used in the freshing loaded ods and defer fetching new content until the right time. only call GetHasMacroFunc to set SetHasMacroFunc and bHasMacroFunc is not accessed any other way, so this is an oxbow Change-Id: I016b53288076d83dd49e92e245346a5f7f560522 Reviewed-on: https://gerrit.libreoffice.org/47757 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit b0597ba5d745974fce752e1b677451a19350d351) Reviewed-on: https://gerrit.libreoffice.org/47818 Reviewed-by: Eike Rathke <erack@redhat.com>
generated by cgit (git 2.34.1) at 2024-06-09 16:51:17 +0000