summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)Author
2020-12-19Set correct interface domainAndras Timar
Change-Id: Iaab2c0da9782132204d22d1dc84b2d444ba8dd8f
2020-12-16pivot table: properly close all subdialogsSzymon Kłos
Change-Id: Ieda601ce25d822394d6ddd12da861128b9270aa2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107843 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2020-12-16pivot table: make options cancel button workingSzymon Kłos
Change-Id: Ife5b5b09d7fb0879f5c29a5aefeec4746bc0ae56 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107816 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2020-12-16jsdialog: make Data field dialog workingSzymon Kłos
Change-Id: Iae4ec2b585272fb09253b6e05ac2a59da2219fd7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107777 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2020-12-16pivot table: make subdialogs of pivot table dialog asyncSzymon Kłos
Change-Id: I2c1b26ebe661a2f66bc7bf94e4f3ede2fc5e18b9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107775 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2020-12-15online: Don't lock new views if ref dialog is openedSzymon Kłos
When one of ref dialogs was opened in one view and then new user opened new view - the new one was locked. Don't do that for all dialogs, not only function wizard. Was partially fixed for one dialog in: 48a216cd16b306f4d2d7edc374ceb4670d177db8 Change-Id: I3b37aa182fd2096a5c989dfbdeb6c245985706d7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107743 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2020-12-15online: make buttons work in statistics dialogsSzymon Kłos
Change-Id: Ie4810b87ea5ce4fc7b3e98afdd37bcd903e2907c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107755 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2020-12-14sampling dialog: improve layoutSzymon Kłos
added correct alignment for sections under radio buttons Change-Id: I3235182447d37056349f8954a757b6330863c7b0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107588 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2020-12-10notebookbar: add named ranges managementSzymon Kłos
Change-Id: I63c2589cd9ab7bfa3a10ea7f2d4729e1f715c92f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107531 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2020-12-10allow sorting buttons via weld::BoxCaolán McNamara
Change-Id: I315fe2dd2e40c976edd802c1e87b7ccdb0c298fe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95221 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107523 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2020-12-10pivot table: add separator between list viewsSzymon Kłos
Change-Id: If4cb3735014bfde6124fb1173fb03aa950c3b77a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107519 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2020-12-04pivot table: fix interactions in onlineSzymon Kłos
Single clicks were identified as double so clicks in the pivot table caused to create new tables or other unwanted behaviour. In case cursor is over pivot table - require real double click. Change-Id: I6ca9af9ff9dbe5a1e00f2b57753ce4f8f298288d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107225 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2020-12-04Revert "Avoid crash while closing autofilter"Szymon Kłos
This reverts commit 8e75c42253d92a014baf24dda82d3379bd736978. Fixed by other patch solving problem in DockingManager during removing DockingWindows. see "Avoid crash on closing docking window" Change-Id: I1a2d0a18705ad497f3aef0edcf01e2b8d57b5cd4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107216 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2020-12-04pivot table: hide database source in onlineSzymon Kłos
Change-Id: Ifc9fdb6010f9a998ffd2d6eeaa562528563f0666 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107219 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2020-12-04notebookbar: add pivot table section to tab dataSzymon Kłos
Change-Id: If770155d5246c8697bb72db957b2b13e1501263f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107193 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2020-12-03jsdialog: make source selector dialog buttons workSzymon Kłos
Make sure buttons are welded so we will be able to execute actions. Change-Id: I1cb7bdcd80d1cd4d60751940e4d24ecf8e7be1ce Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107164 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2020-12-02tdf#128135 update Pivot Table Layout to fit minimum heightandreas kainz
Change-Id: I450625ccac06aec54371ede6bf9b50a221e1ba8f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102319 Tested-by: Jenkins Reviewed-by: Andreas Kainz <kainz.a@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107053 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2020-12-01Make Pivot table db & external source dialogs asyncSzymon Kłos
Change-Id: Iff1a49a9fa04b55ece1aa30259ab57d105883eda Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106996 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2020-12-01Fix stack-use-after-returnStephan Bergmann
...introduced with 244a447734d2abae8896884d4ab73eb4510d243c "Make Pivot table data source dialog async", as seen e.g. during UITest_calc_tests8: > ==1217030==ERROR: AddressSanitizer: stack-use-after-return on address 0x7f06d7133444 at pc 0x7f069f0cb613 bp 0x7ffe24058430 sp 0x7ffe24058428 > WRITE of size 2 at 0x7f06d7133444 thread T0 > #0 in ScAddress::operator=(ScAddress const&) at sc/inc/address.hxx:415:10 > #1 in ScCellShell::ExecuteDataPilotDialog()::$_4::operator()(int) const at sc/source/ui/view/cellsh1.cxx:3014:42 > #2 in void std::__invoke_impl<void, ScCellShell::ExecuteDataPilotDialog()::$_4&, int>(std::__invoke_other, ScCellShell::ExecuteDataPilotDialog()::$_4&, int&&) at ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/11.0.0/../../../../include/c++/11.0.0/bits/invoke.h:60:14 > #3 in std::enable_if<is_invocable_r_v<void, ScCellShell::ExecuteDataPilotDialog()::$_4&, int>, void>::type std::__invoke_r<void, ScCellShell::ExecuteDataPilotDialog()::$_4&, int>(ScCellShell::ExecuteDataPilotDialog()::$_4&, int&&) at ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/11.0.0/../../../../include/c++/11.0.0/bits/invoke.h:110:2 > #4 in std::_Function_handler<void (int), ScCellShell::ExecuteDataPilotDialog()::$_4>::_M_invoke(std::_Any_data const&, int&&) at ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/11.0.0/../../../../include/c++/11.0.0/bits/std_function.h:291:9 > #5 in std::function<void (int)>::operator()(int) const at ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/11.0.0/../../../../include/c++/11.0.0/bits/std_function.h:560:9 > #6 in Dialog::EndDialog(long) at vcl/source/window/dialog.cxx:1137:9 > #7 in Dialog::ResponseHdl(Button*) at vcl/source/window/dialog.cxx:1391:5 > #8 in Dialog::LinkStubResponseHdl(void*, Button*) at vcl/source/window/dialog.cxx:1376:1 > #9 in Link<Button*, void>::Call(Button*) const at include/tools/link.hxx:111:45 > #10 in Button::Click()::$_0::operator()() const at vcl/source/control/button.cxx:124:87 > #11 in void std::__invoke_impl<void, Button::Click()::$_0&>(std::__invoke_other, Button::Click()::$_0&) at ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/11.0.0/../../../../include/c++/11.0.0/bits/invoke.h:60:14 > #12 in std::enable_if<is_invocable_r_v<void, Button::Click()::$_0&>, void>::type std::__invoke_r<void, Button::Click()::$_0&>(Button::Click()::$_0&) at ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/11.0.0/../../../../include/c++/11.0.0/bits/invoke.h:110:2 > #13 in std::_Function_handler<void (), Button::Click()::$_0>::_M_invoke(std::_Any_data const&) at ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/11.0.0/../../../../include/c++/11.0.0/bits/std_function.h:291:9 > #14 in std::function<void ()>::operator()() const at ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/11.0.0/../../../../include/c++/11.0.0/bits/std_function.h:560:9 > #15 in Control::ImplCallEventListenersAndHandler(VclEventId, std::function<void ()> const&) at vcl/source/control/ctrl.cxx:315:13 > #16 in Button::Click() at vcl/source/control/button.cxx:124:5 > #17 in ButtonUIObject::execute(rtl::OUString const&, std::__debug::map<rtl::OUString const, rtl::OUString, std::less<rtl::OUString const>, std::allocator<std::pair<rtl::OUString const, rtl::OUString> > > const&) at vcl/source/uitest/uiobject.cxx:614:19 > #18 in UIObjectUnoObj::executeAction(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&)::$_0::operator()() const at vcl/source/uitest/uno/uiobject_uno.cxx:124:16 > #19 in void std::__invoke_impl<void, UIObjectUnoObj::executeAction(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&)::$_0&>(std::__invoke_other, UIObjectUnoObj::executeAction(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&)::$_0&) at ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/11.0.0/../../../../include/c++/11.0.0/bits/invoke.h:60:14 > #20 in std::enable_if<is_invocable_r_v<void, UIObjectUnoObj::executeAction(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&)::$_0&>, void>::type std::__invoke_r<void, UIObjectUnoObj::executeAction(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&)::$_0&>(UIObjectUnoObj::executeAction(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&)::$_0&) at ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/11.0.0/../../../../include/c++/11.0.0/bits/invoke.h:110:2 > #21 in std::_Function_handler<void (), UIObjectUnoObj::executeAction(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&)::$_0>::_M_invoke(std::_Any_data const&) at ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/11.0.0/../../../../include/c++/11.0.0/bits/std_function.h:291:9 > #22 in std::function<void ()>::operator()() const at ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/11.0.0/../../../../include/c++/11.0.0/bits/std_function.h:560:9 > #23 in (anonymous namespace)::ExecuteWrapper::ExecuteActionHdl(Timer*) at vcl/source/uitest/uno/uiobject_uno.cxx:83:13 > #24 in (anonymous namespace)::ExecuteWrapper::LinkStubExecuteActionHdl(void*, Timer*) at vcl/source/uitest/uno/uiobject_uno.cxx:78:1 > #25 in Link<Timer*, void>::Call(Timer*) const at include/tools/link.hxx:111:45 > #26 in Timer::Invoke() at vcl/source/app/timer.cxx:75:21 > #27 in Scheduler::ProcessTaskScheduling() at vcl/source/app/scheduler.cxx:486:20 > #28 in Scheduler::CallbackTaskScheduling() at vcl/source/app/scheduler.cxx:288:5 > #29 in SalTimer::CallCallback() at vcl/inc/saltimer.hxx:54:13 > #30 in SvpSalInstance::CheckTimeout(bool) at vcl/headless/svpinst.cxx:210:53 > #31 in SvpSalInstance::DoYield(bool, bool) at vcl/headless/svpinst.cxx:463:21 > #32 in ImplYield(bool, bool) at vcl/source/app/svapp.cxx:447:48 > #33 in Application::Yield() at vcl/source/app/svapp.cxx:511:5 > #34 in Application::Execute() at vcl/source/app/svapp.cxx:426:9 > #35 in desktop::Desktop::Main() at desktop/source/app/app.cxx:1588:13 > #36 in ImplSVMain() at vcl/source/app/svmain.cxx:196:35 > #37 in SVMain() at vcl/source/app/svmain.cxx:228:12 > #38 in soffice_main at desktop/source/app/sofficemain.cxx:98:12 > #39 in sal_main at desktop/source/app/main.c:49:15 > #40 in main at desktop/source/app/main.c:47:1 Change-Id: I7ff5148f4bf9170fc7add312053de5acc153125b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106919 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106980 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2020-12-01Make Pivot table data source dialog asyncSzymon Kłos
Change-Id: I573038935e31c5393293197c1a9706110a970837 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106979 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2020-12-01Avoid crash while closing autofilterSzymon Kłos
EndPopupMode called on destroy causes set of actions which may cause a crash in DockingManager Change-Id: Ia01f6ca6e200a2e23f8b72da26053dbf800316a4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106969 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2020-12-01autofilter: fix submenu popup for onlineSzymon Kłos
Change-Id: If48428f99b921d3c6f9927c612e6ade81b980678 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106968 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2020-12-01autofilter: make working with multiple users in onlineSzymon Kłos
Change-Id: Ib0255178112fae5d964cd6155d42848e7c7c51e8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106909 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2020-12-01jsdialog: handle close for autofilter menuSzymon Kłos
Change-Id: Iea30bac99e521bc629999e7fd3cb1c13422704e7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106908 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2020-12-01jsdialog: notify about autofilter dropdown closeSzymon Kłos
Change-Id: If6eb585f04f2d7441a7950bbdca378cc92ba641b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106906 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2020-12-01Set height for autofilter dropdownSzymon Kłos
Change-Id: I2111773e9c8f871707f95a0ce24b472217afa8e6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106905 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2020-11-30Fix uitests for autofilter menuSzymon Kłos
Change-Id: Ifd7d39f787d7530da62fbe479e7b70f656a67911 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106893 Tested-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2020-11-30add get_row_area for TreeViewCaolán McNamara
Change-Id: I0fa8e3666f6731abb831d0ba62f128614eae261c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87048 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106885 Tested-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2020-11-30tdf#136559 We can get a performance boost from using a ListStoreCaolán McNamara
instead of a TreeStore if we only need a list see: https://gitlab.gnome.org/GNOME/gtk/-/issues/2693 Change-Id: I03d03f2364ccc75b87d3f7c31d21ac9993fb384b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103036 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106878 Tested-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2020-11-30Autofilter popup: sync code with masterSzymon Kłos
Change-Id: I37f236e9f2331b42fe86d933d64ff136e98cad90 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106877 Tested-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2020-11-30rework treeview initial toggle button col to be like expander colCaolán McNamara
cause this assumption is baked into the vcl one making it hard to adapt remaining cases Change-Id: I75dd5264c65b1ffbf4d26c9a86f6d4d08b400d90 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95622 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106874 Tested-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2020-11-30weld checklistmenuCaolán McNamara
rework the "menu" to be a treeview using hover selection instead of a custom set of widgetry, and drop the newly unused custom a11y code Change-Id: Ie7d9b7875ce00843b3f262882816cebb472bf681 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95223 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106870 Tested-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2020-11-29LOKit: hide 'To document' dropdowncp-6.4-15Andras Timar
In Online sheets can be copied/moved only in current document Change-Id: Ic30d9ae1e48184ab2aadccedcc670e0fea357296 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106844 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-11-29Resolves: tdf#137215 restore original modality before dialog loop endsCaolán McNamara
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105214 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> (cherry picked from commit 022c11602d2101b49724b5cf104cc6c70b5a5e4b) Change-Id: I83467e28534b781c51b8d75a023e41f3c6a03903 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106831 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-11-24added new parameter in uno:MovePranam Lashkari
new parameter UseCurrentDocument forces to use the correct document for moving/copying sheet tabs around When this parameter is true first parameter DocName will be ignored Change-Id: I207966af5e11fdaaa0bdd91c07e1923399680395 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106478 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2020-11-15added parameter to SheetRightToLeft commandPranam Lashkari
Change-Id: Ib809e0e1686f83fa1412587eea47c4a4f8c94448 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105438 Tested-by: Andras Timar <andras.timar@collabora.com> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-11-15Hide calc input bar tooltips in onlineSzymon Kłos
Change-Id: I07b364d55a3578161087eef281e313d5efae3ba7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105632 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-11-15notebookbar: add advanced filterSzymon Kłos
Change-Id: I8b59a76570b6e7c13b3d91719af6dc5e8609bd81 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105475 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-11-03tdf#137897 scRetypePassInputDlg: re-allow password removalco-6.4-10Justin Luth
This weld-conversion logic error caused a LO 6.1 regression in commit 0e4f93e88bfae3489d2de84fc2febed100880628. - m_pPasswordGrid->Disable(); + m_xPasswordGrid->set_sensitive(false); //disable == false - m_pBtnOk->Enable(); + m_xBtnOk->set_sensitive(false); //enable == true The result is that attempting to remove the password did not enable the OK button, so it was impossible. Change-Id: I4067b2ec6b89e86b21968d33c8850cca6d067e71 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105049 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 9eeaff5fa9070bea685db8b6bbd2dfc1565756ac) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105059 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-10-28Don't let sc's spell-checking EditEngine linger around as long.Michael Meeks
Attempted blind fix for problems with stale OutputDevice usage. Change-Id: Ifa9eb000907aa18e2007cc1020c269d97d182e72 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104848 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-10-27Don't show tooltip for formula bar in onlineSzymon Kłos
Change-Id: Ib7608bb31222234ea08c99e76dcd341570d3685b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104861 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2020-10-27calc: clear the spell-checking cache on tab switch.Michael Meeks
Change-Id: I187b5ff65c951e088e403f1a7a833bee248229fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104850 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2020-10-23tdf#136694 - share spelling context across all ScGridWindows.Michael Meeks
Adding new ScGridWindows later (as we do for split panes) didn't call EnableAutoSpell on them; also duplicating the spell-checking cache looks wasteful, so share it. Change-Id: Ieb67bb292590a097bb5a59d369416a094c54c954 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104704 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2020-10-23Improve spell checking performance and impl. in several ways:Dennis Francis
* do synchronous spell checking, avoiding an idle handler * avoid continuous invalidations caused per-cell by spell-checking * cache spell-checking information for a given SharedString to avoid repeated checking of frequently recurring strings. Change-Id: Ie251f263a8932465297dd8bd66dfc4aa10984947 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103941 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2020-10-19Check render parameters for AutoSpellCheckingMert Tumer
Change-Id: Ife2551b4023461da26e70ac3de505adf9d7db1e8 Signed-off-by: Mert Tumer <mert.tumer@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104274 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2020-10-18tdf#137091: sc_subsequent_filters_test: Add unittestXisco Fauli
Change-Id: I435ffbdd82b5a40e56dd5f6ef55c032802184767 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103604 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> (cherry picked from commit 7672ac2e8764d9e4fcb5a896ef6210077907dcd0) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103657 (cherry picked from commit 91de839547719b7177518386f9b39bd9e4b1cf73) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104493 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-10-18Resolves: tdf#137091 Use CharClass matching the formula languageEike Rathke
This is a combination of 3 commits. Resolves: tdf#137091 Use CharClass matching the formula language ... not the current locale. Specifically important for uppercase/lowercase conversions that may yield different results for example in Turkish i with/without dot. I2aa57cdcf530d7a0697c4ffbd5dccb86bb526d8e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103588 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 3c6177be2705303044e3de262689d593f3d0f282) Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Current sytem locale's CharClass for user defined names, tdf#137091 follow-up I5f025a12ca183acb3f80d2a7527677aceb9ffbd5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103593 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit d41c45a522c5e973d7043d36bc6c82e77735ab9b) Determine CharClass difference once, tdf#137091 follow-up As a side note: Clang plugin simplifybool for !(rLT1.getLanguage() == "en" && rLT2.getLanguage() == "en") told "error: logical negation of logical op containing negation, can be simplified" which is nonsense (the message stayed the same while the checks evolved). It actually complained about !(a==b && c==d) to be rewritten as (a!=b || c!=d) whether that makes sense or not.. it may save one boolean operation, yes, but.. Ib478d46d7ff926c1c9f65fec059c7a3f31fa7ce3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103601 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 1acf517906b7cdc4931dd26319d467dff53ae7d2) Conflicts: sc/source/core/tool/compiler.cxx Change-Id: I2aa57cdcf530d7a0697c4ffbd5dccb86bb526d8e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103598 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104486 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-10-14Revert "lok: text box insertion: default to insert directly for lok."Tamás Zolnai
Breaks a lot of cypress tests. This reverts commit 1952f042e724f39bf92a52947ef1c59f6e13441b. Change-Id: I2f11c094082bad7cb8e70350f724a0789318a8ac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104321 Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-10-13lok: text box insertion: default to insert directly for lok.Michael Meeks
The various bits of positioning functionality are not helpful. Change-Id: I26a62fc939a1e24a8a811c06c8c1a8da831a73f0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101415 Tested-by: Andras Timar <andras.timar@collabora.com> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-10-09Added optional parameter Enabled for uno:SpellOnlineMert Tumer
Change-Id: I3578b0a002ea2cdcc7893972607f26732ce545ea Signed-off-by: Mert Tumer <mert.tumer@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104083 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
generated by cgit (git 2.34.1) at 2024-05-22 15:36:39 +0000