summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)Author
2021-03-16check for quit when calling Yield in loopNoel Grandin
so we don't get stuck threads when the main application quits Change-Id: Id36e99267ceb4154873b6ef8ef494622fff6c19a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112409 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com> (cherry picked from commit c880d3e30405342a5ae6239cc77f69ed3ca6cc15) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112491 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-03-16Clean up duplicated command dispatch test functionalityMiklos Vajna
Used in both Writer and Calc at few different places, so host it in unotest/. Change-Id: I013e6df471deb8693cf4ae62f0958b12e16fda7b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86972 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112395 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
2021-03-15Calc: Update selected cell range before calculating the selection area.Gökay Şatır
Change-Id: I7a814be03acb246e1eb9d68425418ee1357510fd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112472 Tested-by: Jenkins Reviewed-by: Dennis Francis <dennis.francis@collabora.com> Reviewed-by: Gökay ŞATIR <gokaysatir@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112487 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2021-03-08Pivot table: fix data field subdialogSzymon Kłos
Changes done in 'Data field' subdialog were not applied in the result pivot table. Change-Id: Ia221380a9ab3d292033512b9b642646f4b53a39d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112096 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2021-02-26lok: mark calc document as modified when adjusting split-panes (2)Andras Timar
Change-Id: I91231770ebf02218ae0380ddf76a8664dc6e5e19 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111651 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2021-02-26lok: mark calc document as modified when adjusting split-panes.Michael Meeks
Change-Id: I592ee4dc4317f27fae24141b2052475ef26e9fc4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111599 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2021-02-24avoid LOK text selection update when reference cell is in different tabPranam Lashkari
Change-Id: I511b9c5a27f97b6e14e9a844179c27a96997abe1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111346 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2021-02-24show reference range specific to only selected calc sheetPranam Lashkari
Problem: when switching tab in online reference range would not change according to tabs this would show incorrect reference range Change-Id: I07e072a74b2925a25b7a4a50ce0c238308d99ebf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111408 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2021-02-24Implemented MoveShapeHandle uno command for scmert
Change-Id: I5f81348cd778d7fbcb3b4e721fbf0412c4f5753d Signed-off-by: mert <mert.tumer@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111195 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2021-02-18online: fixed freeze pane not writing correct data on file savePranam Lashkari
problem: when we save the file after setting freeze panes in online, opening same file in Desktop libreoffice will show incorrect view, each freeze view would start from A1 this patch ensures that we write correct starting cell pos for each freeze view Change-Id: Ic8ccd5fb5cbedf2ea4f0e9376f0cfdd530e32d6b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111131 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2021-02-11Don't shrink row height when deleting cell contents interactively eitherTor Lillqvist
Follow-up to e763e13873adfe3c6abfa4c2dfd3ac3847e2d494. Such shrinking of row height, typically by a few silly pixels, just causes unnecessary invalidation thrash in a collaborative editing context. Change-Id: I5651ce994ba4bf82c83d7d4ef1bb8ed5bab0a66d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110697 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Dennis Francis <dennis.francis@collabora.com> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2021-02-10autofilter: handle click for scaled dropdown buttonSzymon Kłos
Missing thing for commit: 68892230ddcde135e9951047a3621438eb7987d0 autofilter: scale dropdown button according to zoom level rendering was scaled but click position was handled using non scaled button size Change-Id: I599b7e6aef39e8b5225b53423125f2b271597a46 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110646 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2021-02-09pivot table: avoid crash on drag n dropSzymon Kłos
prevents from unexpected situation when user will send double request for the same drag and drop operation (slow internet connection and repeating operation) Change-Id: I8d081cf884c38b2e4f367143ad728c29b1466fbd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109634 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> (cherry picked from commit fbef08d9cb9c5bfc852dc23d5bafc9d057ee3bcd) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109737 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2021-02-09autofilter: scale dropdown button according to zoom levelSzymon Kłos
Change-Id: I4f8a16e196bc33ea5b29fda0edc1f773a24e28db Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110259 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2021-02-09fontwork: insert in the center of LOK viewSzymon Kłos
Change-Id: Iabde4ee927546b0e396c4fbd6d0099fa82240166 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109968 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2021-02-08jsdialog autofilter: show submenu on demadSzymon Kłos
- add posibility to trigger full update - send information if docking window is visible - send close message on builder destruction Change-Id: I0b3abc5ebcacf7f9a48910edf1bf0d73e8120d6e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110577 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2021-02-05prevent reference range resetting on panning in mobilePranam Lashkari
Change-Id: Ic6cabe1d4e5a1e7c4d42294550d654e38e27db22 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109769 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
2021-02-04lok: sc - suppress LOK editengine events for the calc input bar.Michael Meeks
The calc input uses an EditEngine - but it emits events as if it is part of the document - as well as emitting events as if it is a dialog window. This causes horrible jumping artifacts to the top of the document with word auto-completion and typing in cells a few page down. Also remove obsolete tweak to turn off autocorrect for LOK, since it was contradicted by: 1f0943e5e9432f96daff9f3b006388d5bc7415b2 Change-Id: I7352cd3b5ca6d18645cfd9e18959b0e44ec969d7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110419 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Tested-by: Henry Castro <hcastro@collabora.com> Reviewed-by: Henry Castro <hcastro@collabora.com>
2021-02-03lok: Take indent and margins into accountDennis Francis
... when painting tiles with edit-text content. Change-Id: I31199c18ed5aab005d56241046a9f7109691db99 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109755 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2021-02-01Don't bother shrinking row height when changing just one row interactivelyTor Lillqvist
I.e. when interactively entering a new value. This used to happen at least for a sample document in .xlsx format for cells with automatic wrap turned on. After entering a value, the row height was annoyingly shrunk by a few pixels, which looked weird and pointless, and caused unnecessary invalidation thrash in the online collaborative editing context. We assume that the call to ScDocFunc::SetNormalString() in ScViewFunc::EnterData() is the result of interactivity. Change-Id: I3c77f7fb4e575f02e1dd7cdc18f2919f5eb3426e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110245 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2021-02-01Probably this LOK invalidation should be done only if something changedTor Lillqvist
Change-Id: I0164ac8d74c08abce0a1d8c2e7a7dd9679da91fa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110256 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2021-01-25fixed range text not being updated on dragging reference markerPranam Lashkari
dragging reference stat marker in online did not change the text of range selection Change-Id: I0f9ee9df2418bc4dcf519ca3462b510758b9766d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109786 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2021-01-24sc: GetRowForHeight performance improvement.Michael Meeks
Instead of just skipping hidden rows, either skip or interpolate into visible ones. This method, and it's single caller look rather unusual to me. It is unclear why we would want to return the results we do, and why the one caller subtracts a row. Some surprising proportion of tile rendering was exercising this code path extremely slowly. --5.94%--ScDocument::GetPrintArea | |--5.04%--ScDrawLayer::GetPrintArea | ScTable::GetRowForHeight | | | --4.58%--ScFlatBoolRowSegments::getRangeData | | | --2.46%--ScFlatSegmentsImpl<bool, bool>::getRangeData Change-Id: I75418d6af59a33b99e8bb0c374139e1a4ee6ef87 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109837 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Tested-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-by: Ashod Nakashian <ash@collabora.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2021-01-22tdf#139830: keep the right sidebar context for chart after view switch (calc).Tamás Zolnai
There is a general behavior to switch to the default sidebar context by view deactivation and switch back to the right context by view activation. See SfxShell::Activate() and SfxShell::Deactivate(). By activation, we use the selection to find out the right sidebar context. See GetContextForSelection_SC() method for example. However, for charts, this does not work, because the chart window is a separate environment and the shell does not know what is selected inside the chart window. So let's avoid context switches when we have a chart window active. Let the chart controller handle sidebar context changes. Change-Id: I272ee5c35ac30221eed2930201c4710a9a5877c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109790 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2021-01-21unit test: check for row height invalidations on sortDennis Francis
Change-Id: I5b4e690c48583dcb609eb139ef2bf8e62d146d30 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109662 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2021-01-21unit test for row-height invalidations on pastingDennis Francis
... into a cell whose line-break attribute is set. Change-Id: I82d021a262d6af48d5eaef5fefa0fe9098758a86 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109661 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2021-01-19LOK: stop range selection with mouse/touch move in mobilePranam Lashkari
Change-Id: I0a7b3a5fc89bcbced4acee18415308ed8aa57ba2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109035 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2021-01-19Added uno command for formula range selectionPranam Lashkari
Change-Id: I01cd06ed51197ffe21102fb1fd0fcdce88ab333b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108810 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2021-01-19fix location of change tracking boxes in OnlineNoel Grandin
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108849 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com> (cherry picked from commit 042bb632978a1d01f3240890ea9d39ead707633d) Change-Id: I65fcb52e224dce7df2a5a7baed2b8f23d0d49397 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108861 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2021-01-19lok: Send rows heights invalidation on pasteDennis Francis
... when the dest cell has wrap-text option set. Change-Id: I9f0dd157694701c96fd91e02b8232ed205f13ae4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109602 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2021-01-18Revert "pivot table: make options cancel button working" + fix crash againJulien Nabet
In the dialog, you have 3 buttons "Help", "Cancel" and "OK" Using "Cancel" will call "close" which doesn't revert back changes. To test this: - Launch Calc - Create an array with 2 cols (qtX and qtY) and put 2 rows of values - Create a pivot dialog - Put qtX in "Filters" part - Double click on qtX (=> "Data Field" dialog appears) - Click "Options..." (=> "Data Field Options" dialog appears) - Enable any checkbox (eg: Empty line after each time) + click "OK" (=> dialog "Data Field Options" closes) - Click "Options..." again (the checkbox is still enabled as expected) - Disable the checkbox + click "Cancel" (=> dialog "Data Field Options" closes) - Click "Options..." again (the checkbox is still enabled as NOT expected) So revert the below quoted commit and fix this by using "cancel" in: - action-widget response - id for the GtkButton - the use of the id to initialize m_xBtnCancel with m_xBuilder->weld_button This reverts commit c2a349bc1482482d3e5ec06232c166d77fe9b602. Change-Id: I555a90706de635e90b0ee397dfd958df55b5c40a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109193 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109255 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2021-01-14lok: sort: invalidate the row-height cache tooDennis Francis
Change-Id: I13e59dc045b23a6ea60cd4cf34dda3166dbf5aad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109208 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2021-01-14lok: send sheetGeometry invalidation after sortDennis Francis
...just for the rows to let the client know the row sizes/spans have changed. Change-Id: I26f985ab0ba4eb5b21db5783a8ac3957c64c2f22 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109207 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2021-01-13lok: don't turn off online spelling by view change.Tamás Zolnai
Since we don't exit editing for LOK inside this NotifyChange() method, we should keep also spelling functionality alive. See also the comment we have here: "As long as the content is not edited, turn off online spelling." So it seems a good idea to make this spelling modification dependent of bStopEditing flag. This causes issues, during view switches. Change-Id: Ic684073d129c1cac4b6f4d11f34cd64cb5db3295 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109206 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2021-01-12tdf#133858 reduce the double-ref range to data contentDennis Francis
in certain matrix formulas like SUM(IF(A1=G:G, H:H)*B1/B2) where whole columns are used for comparison in the condition of IF ultimately followed by a reducer like SUM. In such cases we can safely reduce the double-refs involved in the comparison to the sheet area where there is data before converting the data to ScMatrix. This is a more restricted version of Noel's fix in 37ffe509ef011357123642577c04ff296d59ce68 Change-Id: I1c2e8985adedb3f4c4648f541fb0e8e7d0fae033 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109050 Reviewed-by: Luboš Luňák <l.lunak@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2021-01-07sc: ODF export: test new ODF 1.3 features exported to different versionsMichael Stahl
Change-Id: I7eeac54d1d75340133dc2bb8ce9b3c21c3909193 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95157 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2021-01-07[API CHANGE] officecfg,xmloff: remove SaveBackwardCompatibleODFMichael Stahl
org.openoffice.Office.Common.Save.Document.SaveBackwardCompatibleODF was added in 2007 and apparently enables storing invalid ODF (or OOoXML) to workaround bugs in OOo <= 2.3; nobody should need it in this day and age, and the OOoXML export has been removed anyway. bce5e157785745a6729db62b15fb98bc396cddee 2007 c7a3859693971bf7103bfb0d05d64712e724fa37 2007 7477a65e09b20917adf025550c550f8822b508ee 2007 77baabe992c77018a0467ffec8f9482f8d76b66b 2007 575222083e058a740f5ad69e14e18622c3d4f7af 2007 66b908b45cde78af020b35e817e67bc40b8493f0 2007 Change-Id: Ib3f730c7c9ac6fbbbbae9fb4a42c1bd65f6c93df Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94571 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2021-01-07sc: ODF export: OFFICE-3665 table:name on source-cell-rangeMichael Stahl
It turns out that commit d840c7e15402dc3a133b400b113e28c0c78702c5 is pointless because this attribute was actually added in ODF 1.3, which i didn't notice before; this means there's no benefit to add a loext:name at this point. Change-Id: Ic4c7a00f62e399f232a6e515ab83cd9ad99c01e1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94501 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2021-01-07convert XML_STYLE_FAMILY to scoped enumNoel Grandin
Change-Id: I5335b0190a2f5a8111993c0c9c224c8a6a8f0cfb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88723 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-01-07xmloff: ODF export: adapt all checks of ODFSVER_012 etc.Michael Stahl
Most of these actually want to check ODFSVER_EXTENDED because the extension didn't get into ODF 1.3. Change-Id: I1b625a329f7a3d146c616c62c15b56e2c314c2c0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92872 Reviewed-by: Michael Stahl <michael.stahl@cib.de> Tested-by: Jenkins
2021-01-07sc,xmloff: ODF 1.3: adapt XMLPropertyMapEntryMichael Stahl
Map the following property attributes to ODFSVER_013: * OFFICE-2173 table:tab-color * OFFICE-3767 text:contextual-spacing * OFFICE-3857 table:scale-to-X/table:scale-to-Y Change-Id: I3585560a3654c71353bbcaf66da20eacba8ebd1f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92861 Reviewed-by: Michael Stahl <michael.stahl@cib.de> Tested-by: Jenkins
2021-01-07xmloff: ODF export: rework version checks in SvXMLExportPropertyMapperMichael Stahl
There's some issues with the version checks here: * The requirement is to retain support for ODF 1.2 extended, but some attributes are in ODF 1.3, while others require ODF 1.3 extended, so a single version number can't be used to compare * A recurring problem is that new extension attributes are erroneously exported to standard namespaces; there is the pre-existing buggy case of style:hyperlink to consider... * Currently it's possible to distinguish multiple extended version but the only minimum version that's actually used is the minimum one ODFSVER_012_EXT_COMPAT Rework this to use a different check, by: * distinguishing extension attributes from standard attributes via their namespace, to avoid such bugs by construction * interpreting the version number always as a standard ODF version number: if the attribute is in extension namespace: if the minimum standard version is met, ignore else: if the minimum standard version is met, export * adapting all XMLPropertyMapEntry to use ODFSVER_FUTURE_EXTENDED for extension attributes (TODO: check which of these should be ODFSVER_013) This should have an effect on the drawext:fontwork* attributes, which need ODFSVER_FUTURE_EXTENDED to be exported now. Change-Id: I986c8064e578a61d69ed5fdb261f23e7582a7d75 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92856 Reviewed-by: Michael Stahl <michael.stahl@cib.de> Tested-by: Jenkins
2021-01-07sc: ODF export: table:name extension element, step 1Michael Stahl
3119de050ef5e3561e01badeb6307ae2538d215a introduced an attribute table:name on table:source-cell-range, but it should be in loext namespace. Allow import from LO_EXT namespace, but keep export to TABLE for now because existing LO releases expect that. Change-Id: Ic0e8737218473338d18b00150209bcc16678fee9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92863 Reviewed-by: Michael Stahl <michael.stahl@cib.de> Tested-by: Jenkins
2021-01-07sc: ODF export: style:hyperlink extension element, step 1Michael Stahl
Commit 066bdb31f7ff801b7a36c79c43ecbd527ffb2a88 introduced style:hyperlink element but it should be in loext namespace. Allow import from LO_EXT namespace, but keep export to STYLE for now because existing LO releases expect that. Thanks to vmiklos for discovering that such link can be inserted via: ThisComponent.Sheets(0).getCellByPosition(0, 0).Hyperlink = "http://libreoffice.org/" Change-Id: Id951f4a657fefe1e4af5e1635acca7a96f90ce28 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92800 Reviewed-by: Michael Stahl <michael.stahl@cib.de> Tested-by: Jenkins
2021-01-07replace ODFDefaultVersion usage with ODFSaneDefaultVersion...Michael Stahl
... in SvXMLExportPropertyMapper. The condition nCurrentVersion == SvtSaveOptions::ODFVER_UNKNOWN is impossible since d571a509aa324db9a425110a67ea142d157256b2. ODFVER_UNKNOWN isn't a value of ODFSaneDefaultVersion so use std::optional to handle the remaining usage. Change-Id: I1e33cb707c289224664a385b4e4425e6788b2943 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92728 Reviewed-by: Michael Stahl <michael.stahl@cib.de> Tested-by: Jenkins
2021-01-06Clear warning about shared ptrSzymon Kłos
Change-Id: I4d4717f04953d3d915366b2ed51420416f8e4c98 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108880 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2021-01-06autofilter: show menu only if has itemsSzymon Kłos
Change-Id: Ie6b7158e74a8bdccdbafaa9b6d9b09b3796088ba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108846 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2021-01-06pivot table: make partial sum message box asyncSzymon Kłos
Change-Id: I63011526d60f332ee56edebf5bf48b30ad6b2a94 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108807 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2021-01-04Related: tdf#130108 ensure we don't reuse the last SetSearchMask settingCaolán McNamara
Conditional style formats can only be SfxStyleFamily::Para formats as far as I see, and presumably we don't want to reuse any previous SetSearchMask settings here in xml export, so this looks like a dup of the same problem of commit 454a3c945fdc02d706b0a5ad49ca13e0443fa8e5 Date: Sun May 3 16:43:06 2020 +0100 Resolves: tdf#130108 ensure we don't reuse the last SetSearchMask setting Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93453 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 8e53551db00d325dd638d45e50b32984dc778f17) Change-Id: Ic26b450068bd1e13a3c82b1c1466630402498787 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108662 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Aron Budea <aron.budea@collabora.com>
2020-12-21replace ODFDefaultVersion usage with ODFSaneDefaultVersionMichael Stahl
Compare with ODFSVER_012 mostly works the same, except for places where namespaces are defined where the ODFSVER_EXTENDED bit should be checked. Conflicts: sc/source/filter/xml/XMLExportDataPilot.cxx xmloff/source/chart/SchXMLExport.cxx Change-Id: I86469b763bc2f903632976bc9d6ec04d543d705e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108107 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
generated by cgit (git 2.34.1) at 2024-05-01 15:11:36 +0000