summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)Author
2019-08-12Fix typosAndrea Gelmini
Change-Id: I11aeaafb0e158eb8da5b8a36dbef10d7b5bb08ff Reviewed-on: https://gerrit.libreoffice.org/77298 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-12Fix typosAndrea Gelmini
Change-Id: I0ca6c4057c382fa4c025410c1c8e143feb1348c5 Reviewed-on: https://gerrit.libreoffice.org/77296 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-12Fix typosAndrea Gelmini
Change-Id: I14e37e2920d69b1bd6d2f633f23f37feea104c01 Reviewed-on: https://gerrit.libreoffice.org/77293 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-12Fix typosAndrea Gelmini
Change-Id: I46f80e6f453b8825f666e4bf7bbc4804e596222b Reviewed-on: https://gerrit.libreoffice.org/77299 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-12Fix typosAndrea Gelmini
Change-Id: I331ac595c68601cee49fa726e5a074d4a9341d12 Reviewed-on: https://gerrit.libreoffice.org/77297 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-12Fix typosAndrea Gelmini
Change-Id: Ibcf33db2157ce10c037a70a3e7c3ec586505f60b Reviewed-on: https://gerrit.libreoffice.org/77292 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-12Fix typosAndrea Gelmini
Change-Id: Id5e35965c590dbf79e08e6d531b79696af9e9159 Reviewed-on: https://gerrit.libreoffice.org/77300 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-12Fix typosAndrea Gelmini
Change-Id: I6ceb04830192bd6415cb41688bb604fccc25a882 Reviewed-on: https://gerrit.libreoffice.org/77294 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-12Fix typosAndrea Gelmini
Change-Id: I3e6b96f4ea341130e98ee54ed8c124209b05d343 Reviewed-on: https://gerrit.libreoffice.org/77291 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-12Fix typosAndrea Gelmini
Change-Id: I94d0e85c731801b8b0ec844ae2a8f268b2f1022e Reviewed-on: https://gerrit.libreoffice.org/77256 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-12tdf#42949 Fix IWYU warnings in sc/source/ui/{view,xmlsource}/*cxxGabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ie47dff381392ef57cb857184c179bf82d3b55862 Reviewed-on: https://gerrit.libreoffice.org/77258 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-08-12Fix typosAndrea Gelmini
"its" Change-Id: I02c660e46964270376a66210fdb5f1b1985ce5b6 Reviewed-on: https://gerrit.libreoffice.org/77255 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-12Fix typosAndrea Gelmini
Change-Id: I4bd004af206813b9dc01c50ab20f2e8b954b8dca Reviewed-on: https://gerrit.libreoffice.org/77323 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-11cid#1242793 make fuzzing tabsize check compile time instead of runtimeCaolán McNamara
Change-Id: I9f5190e903a7e645712210b3e3aa5f2ad42c0d72 Reviewed-on: https://gerrit.libreoffice.org/77266 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-11revert some consts to placate coverity Uncaught exceptionsCaolán McNamara
Change-Id: I4d8cccd98a60efd928409514944d60d6ee5532d1 Reviewed-on: https://gerrit.libreoffice.org/77251 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-10cid#1401328 Uncaught exceptionCaolán McNamara
Change-Id: I6e0c7090fc1548d7d2fa41e8c65225c64c6398d3 Reviewed-on: https://gerrit.libreoffice.org/77243 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-10loplugin:stringconstant (macOS)Stephan Bergmann
Change-Id: Icb9d9e1cd21e2506e36fe40a3b93b6a2521a868c Reviewed-on: https://gerrit.libreoffice.org/77239 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-08-09Simplify Sequence iterations in scArkadiy Illarionov
Use range-based loops, STL and comphelper functions Change-Id: I047fb2e6ec9591166339b9748c5013a32185f14b Reviewed-on: https://gerrit.libreoffice.org/76912 Tested-by: Jenkins Reviewed-by: Arkadiy Illarionov <qarkai@gmail.com>
2019-08-08tdf#125288 Databar dialog's entry color was changed to RYB BlueKovács László Zoltán
Change-Id: I9ac6df07078d60bf439babc46384fa96267fb4cd Reviewed-on: https://gerrit.libreoffice.org/77119 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2019-08-08tdf#126634 Move uno:Grid back to Form controls toolbarRoman Kuznetsov
Change-Id: Ic13da0d0295a9ceb30e605dfb634bc86c6390ec9 Reviewed-on: https://gerrit.libreoffice.org/77065 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2019-08-07tdf#126748: temporary hack to avoid crash when several pivot tables ...Mike Kaganski
... reference a single cache, and have different sets of group fields. The problem is getting group field names from the tables referencing the cache; so when a table referencing not all group fields happens to be first in the reference list, the returned name is empty. The hack just stops writing group fields as soon as it finds an empty name; this naturally leaves bad cache data behind, but at least doen't crash. The retrieval of the names should be reimplemented using a different source, to not depend on tables referencing the cache. Regression after commit b082998401e37e6c7534906601bc481423a6ded0. Change-Id: Ib2e92f8acf93a801861c6ba5c68fab3bebe3672c Reviewed-on: https://gerrit.libreoffice.org/77110 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-08-07tdf#126673 Auto-fit column and auto-fit row don't work with line breakNoel Grandin
Revert "tdf#94677 Calc is slow opening large CSV, avoid reset SetUpdateMode" This reverts commit c47d0174f2c6c3ebcb3b33276d0277e7aceac330. Change-Id: I38e065d44dfb9d08498176b8231aff14ff51d91c Reviewed-on: https://gerrit.libreoffice.org/77109 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-07tdf#126685 CRASH: selecting all in sheetNoel Grandin
regression from commit 7282014e362a1529a36c88eb308df8ed359c2cfa Date: Fri Feb 1 15:15:16 2019 +0100 tdf#50916 Makes numbers of columns dynamic. We need to clamp the columns whenever we change sheet/table Change-Id: I5cf22b2a7cf2f6473b8340289bcddd75ed0ad70b Reviewed-on: https://gerrit.libreoffice.org/77105 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-06Select shape even when clicking on a hyperlinkSamuel Mehrbrodt
and the hyperlink isn't being opened anyway (no ctrl clicked e.g.) Change-Id: I262a32b0f295ed66339c0a12a551f68d9d63c978 Reviewed-on: https://gerrit.libreoffice.org/77032 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-08-06Add "Copy hyperlink location" to sc context menusSamuel Mehrbrodt
Change-Id: I93840c7a7e6bbbba0c5dedb6fa460a46d1785e80 Reviewed-on: https://gerrit.libreoffice.org/77018 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-08-06Improve hyperlink selection in scSamuel Mehrbrodt
Change-Id: Ia8c6b9f9994cbe3e503061b4762dbd8648a4b857 Reviewed-on: https://gerrit.libreoffice.org/76598 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-08-03tdf#39593 Drop lcl_GetIndexFromNameArkadiy Illarionov
Use comphelper::findValue instead Change-Id: Id8490034b0f957084680fef18ba07974b5373fb2 Reviewed-on: https://gerrit.libreoffice.org/76896 Tested-by: Jenkins Reviewed-by: Arkadiy Illarionov <qarkai@gmail.com>
2019-08-03tdf#39593 extract getting max row length to template functionArkadiy Illarionov
Change-Id: I23c81ac7dbd8785b12620aaf8ae2c090ae1785f8 Reviewed-on: https://gerrit.libreoffice.org/76894 Tested-by: Jenkins Reviewed-by: Arkadiy Illarionov <qarkai@gmail.com>
2019-08-03Fix typosAndrea Gelmini
Change-Id: I5c95e180681220fc592400435d90e4d46603d41c Reviewed-on: https://gerrit.libreoffice.org/76883 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-02calc: simplify getDocumentSize calculation.Michael Meeks
Change-Id: Iee2ebf2c6ed74651556647264f519caa9c59dad7 Reviewed-on: https://gerrit.libreoffice.org/76492 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2019-08-02lok: minimal implementation of isComplex for calc for now.Michael Meeks
Change-Id: Ic4141d30a0ff48a9ec5ecc8e6119d9d779c4a0fc
2019-08-02lok: disable calc char-set dialog for HTML when pasting.Michael Meeks
Change-Id: I3ec9e98549d06ae3e6b4ede89215a5137d01ccab
2019-08-01Make QR Code callable in calc and writerShubham Goyal
Change-Id: I73793100478c34a7721821cec1f8ccec0174d20c Reviewed-on: https://gerrit.libreoffice.org/74598 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-08-01Resolves: tdf#126496 - "Page Fields" in pivot table unclearHeiko Tietze
Renamed to Filters Change-Id: I512a06830635a8b6c62ca8a0ad64683f9824b9e0 Reviewed-on: https://gerrit.libreoffice.org/76777 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2019-08-01clean up ViewCallback nicelyNoel Grandin
Change-Id: Idb882460092642bc77804560cd8fd6432a590323 Reviewed-on: https://gerrit.libreoffice.org/76776 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-31Improved loplugin:stringconstant (now that GCC 7 supports it): scStephan Bergmann
Change-Id: I1bfd2bb623aac5ac457a0b719da64ab393ccd0ba Reviewed-on: https://gerrit.libreoffice.org/76654 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-07-30tdf#125800: accessing cond format props in UNO throws errorAron Budea
These conditions were always evaluated to true: OR should become AND when negated. Regression from 8c637b47d9de4b3a64c33a9c2ffe7ed220be2467 Change-Id: I87038319ed27eff2bed2412da49e01f73ec0a79c Reviewed-on: https://gerrit.libreoffice.org/76493 Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com> Reviewed-by: Aron Budea <aron.budea@collabora.com> Tested-by: Aron Budea <aron.budea@collabora.com>
2019-07-30tdf#126306: Add UItestXisco Fauli
this is possible after Jim Raykowski added accessible support to the autofilter popup ( tdf#122774 ) Change-Id: I9b503f8260fd914e7b5794b837d2661c63c7d21b Reviewed-on: https://gerrit.libreoffice.org/76563 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-07-29sfx2: Re-enable the sidebars for LOKAshod Nakashian
This re-enables the sidebars for LOK, which were disabled to avoid overheads. Also, fixes a regression where editing stopped when loading a new view because the sidebar window creation killed the edit view. Revert "Avoid various desktop GUI elements when used from LibreOfficeKit" This reverts commit c0b70ec34d5e056bb92a66cbf83838923cb41fee. Also (added by Noel to the above commit) (1) Comment out parts DesktopLOKTest::testPaintPartTile test that trigger a crash. We are installing a callback that points to something on the stack, and then not removing that callback, resulting in calls to random stack memory. There is a further problem in the LOK code in that we cannot uninstall a callback when we have multiple views because the uninstall code in doc_registerCallback can only remove a callback for the __current__ view, which I do not fix here. (2) prevent code from accidentally creating empty entries in the mpCallbackFlushHandlers map, which is what happens when you use the index operator on map, which results in a crash in doc_registerCallback because the std::shared_ptr is empty. (3) In SdTiledRenderingTest, only turn off LOK via LibreOfficeKit::setActive(false) once the document has been torn down. Otherwise, we don't remove entries from the statically allocated s_pLOKWindowsMap map in vcl/source/window/window.cxx, which means that at process exit, we have dangling Window objects. Reviewed-on: https://gerrit.libreoffice.org/71165 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com> (cherry picked from commit 88565c3662c6fde240c98a9b4f2ce6dfbcf4094e) Change-Id: I06b06a990f05c06b1889fa89b698dff6f494e09c Reviewed-on: https://gerrit.libreoffice.org/76466 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-29weld ScRedlineOptionsTabPageCaolán McNamara
Change-Id: I80151384f5e75eac08665f45ce87468e10fb987e Reviewed-on: https://gerrit.libreoffice.org/76553 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-29weld ScTpContentOptionsCaolán McNamara
Change-Id: Ia0ad05337ae3195e565e4b913cdf34e9a32e9cea Reviewed-on: https://gerrit.libreoffice.org/76552 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-29weld ScTpFormulaOptionsCaolán McNamara
Change-Id: I8d45dfc745dbb7f90346028eb29a432309db0845 Reviewed-on: https://gerrit.libreoffice.org/76547 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-29rename DoubleField back to ScDoubleFieldCaolán McNamara
Change-Id: I3d3923f3131e13abde145f96468ade0d0c8cc142 Reviewed-on: https://gerrit.libreoffice.org/76546 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-29drop newly unused ScDoubleFieldCaolán McNamara
Change-Id: I2105306d1d865512a5fa2f8c862e7a21c384ee39 Reviewed-on: https://gerrit.libreoffice.org/76545 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-29weld ScTpCalcOptionsCaolán McNamara
Change-Id: I4b5bd08a9ed04b9bceb08640a275dee02d6e9b36 Reviewed-on: https://gerrit.libreoffice.org/76544 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-29Drop ScDataPilotFieldObj::HasStringArkadiy Illarionov
Use comphelper::findValue instead Change-Id: I59a3ef2781643dfdb7ecbfe578fb9e1faebb0c42 Reviewed-on: https://gerrit.libreoffice.org/76502 Tested-by: Jenkins Reviewed-by: Arkadiy Illarionov <qarkai@gmail.com>
2019-07-29weld ScTpLayoutOptionsCaolán McNamara
Change-Id: I02f36b18d3803a7539a66b95cfc5e485d30344d7 Reviewed-on: https://gerrit.libreoffice.org/76539 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-29revert bits of "loplugin:sequentialassign"Noel Grandin
from commit 0d36b32755ac662299e6a8165e9fa57311b74a2f Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Sun Jul 28 12:03:35 2019 +0200 loplugin:sequentialassign which were false positives and not meant to be committed Change-Id: I6f2f185bd3564c9329f5a0c78c9020f3ddb52d34 Reviewed-on: https://gerrit.libreoffice.org/76518 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-29loplugin:sequentialassignNoel Grandin
Change-Id: I56a9bf698b60bd278c71cc632aacef2bd2f4c13f Reviewed-on: https://gerrit.libreoffice.org/76501 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-28weld ScTpCompatOptionsCaolán McNamara
Change-Id: Id67570b53604489fa0b2194a0f9ad0b67d535f0e Reviewed-on: https://gerrit.libreoffice.org/76487 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>