summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)Author
2020-04-23tdf#132278: sc: Add unittestXisco Fauli
Change-Id: Iaba8917fb18e86c68701b13b0ff26246c3cc8986 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92746 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-04-23Fix typosAndrea Gelmini
Change-Id: I6c9fe715c0d188d3970027fcb63c6c039c957fd9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92733 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-04-23tdf#132278 crash after opening an old fileNoel Grandin
regression from commit 7282014e362a1529a36c88eb308df8ed359c2cfa tdf#50916 Makes numbers of columns dynamic. Change-Id: I7a37631094b91f4859326db054f285daa8dccbb8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92740 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-23lokit: fix edit-text/view-cursor positionDennis Francis
in case of views with heterogeneous zooms. 1. EditText render position fix The EditView has an 'output-area' which is used to clip the rectangle we pass to the Paint() call. It also holds on to the ScGridWindow instance where the edit started. The 'output-area' of the EditView is in the coordinates/units of the MapMode of the ScGridWindow it holds. So we need to temporarily change the MapMode and 'output-area' of the EditView in agreement to the device(with the current view's zoom settings) where we are going to paint to. After we call the Paint(), we rollback the original settings of the EditView. 2. EditViewCursor position fix Before this change the cursor position in twips (calculated based on pixel aligned cell position in the view where editing occurred) is broadcasted to all the client-views. If the clients have different zooms, then simply scaling this common cursor position in the client for its zoom is not going to be accurate enough (due to the non-linear Logic->Pixel->Logic transformation involving pixel rounding). This is very visible if you are editing far away from A1 (like Z50). The fix is to turn off this broadcast for calc-cell editing and send view specific edit-cursor invalidation messages. This is accompanied by a online.git patch that removes unnessecary broadcast of view-cursor invalidation messages which messes up things again. "Do not broadcast view-cursor invalidation messages" (cherry picked from commit d58f1e334245f9e136750fbba267c2a941a213cc) Conflicts: editeng/source/editeng/impedit.cxx editeng/source/editeng/impedit.hxx Change-Id: Ib2fbbe4b6f93f26fc85d6adaa8684dd4397d886f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92631 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92721 Tested-by: Jenkins Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2020-04-22move InterimItemWindow to svtoolsCaolán McNamara
Change-Id: I058b1d96a3ddfaa1aa96f66d0ebc6fa68900a48c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92697 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-22tdf#42949 Simplify use of rtl::math::approxEqual in include/basegfx/Gabor Kelemen
Turns out we can save about 500Mb of preprocessor input if we use rtl_math_approxEqual from rtl/math.h instead of its C++ wrapper rtl::math::approxEqual from rtl/math.hxx and manage the fallout accordingly. Before: bin/includebloat.awk | head sum total bytes included (excluding system headers): 19017296671 After: $ bin/includebloat.awk | head sum total bytes included (excluding system headers): 18535432672 Change-Id: I1691171f3a309405a7099882ad9989d147f59118 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92508 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-04-22uiobject.hxx only needs forward declaresCaolán McNamara
and update pches accordingly Change-Id: I411712532fd85961bffe6678416fcdc1d9c7f53d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92617 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-21uitest: remove unneeded time.sleepXisco Fauli
Change-Id: I618a17fb8347d1f935caaef54738299863ddbb49 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92612 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-04-21use better number sof LOK fields in ScTabViewNoel Grandin
LOK is (a)busing tools::Rectangle to calculate coverage, which triggers my new asserts because the existing numbers turn into RECT_EMPTY. Change-Id: Ib3cd6a63ebaad7dc9887567dd2463a0ef5cfc900 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92607 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-21CreateDocumentInfoDialog should return shared_ptrNoel Grandin
which is what it's only call site wants Change-Id: I1c2c2ed3a91a3376af142ac9a5d6993a2186d660 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92590 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-20add tools::Rectangle::JustifyNoel Grandin
so rectangles can be constructed already valid Change-Id: I3ae5e24add3c81f79dcdf863f855dca439876f11 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92521 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-20Translate German variable namesJohnny_M
Ende -> End Change-Id: I8150dbc897ab60d01f183d724d923d946615dcab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92027 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2020-04-18tdf#132210: fix Calc crash when closing spreadsheet fileJulien Nabet
make the dialog modal See bt: https://bugs.documentfoundation.org/attachment.cgi?id=159677 Change-Id: I75719fe241950f13c2e5d65c5d9078193e631ffd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92488 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Jenkins
2020-04-18Optimize a bit loop in ScFormatShell::GetStyleStateJulien Nabet
Change-Id: I2479072f00edd919496e534146a619103559784b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92463 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-18Move implementation of CELL("format";...) to SvNumberFormatter, tdf#132106 prepEike Rathke
In preparation of further detailed handling. Change-Id: I9e4d916de031b742d0af1025b945b7608fed8266 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92462 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2020-04-17Break overly long lineEike Rathke
... and make it more legible. Change-Id: Ie5325f614cf8d95290e04c9b0e9fa29f353d8301
2020-04-17tdf#130583: fix Switch in CalcJulien Nabet
Don't set bFinished to true too soon if there are still some params to take into account Change-Id: Ie7bdd6f316c08342d379d55bf3853774dd738e7d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92345 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2020-04-17Added unique id for number format comboboxMert Tumer
This will allow us to control it for the mobilewizard easily rather than using the id of 'category' which is not unique. Change-Id: I61b612d5355584597a16942b7151a82376033a45 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92202 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92309 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Jenkins
2020-04-16tdf#132097: sc: Add UItestXisco Fauli
Change-Id: Ib4aa2c9ed4a0de10aa7a91796fa3034720a160b3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92386 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-04-16tdf#132147: formula may be emptyMike Kaganski
"Regression" after commit ab285c743afa1c8769581871d7b56374fd8c49f1 author Noel Grandin <noel.grandin@collabora.co.uk> Sat Nov 02 18:59:49 2019 +0200 committer Noel Grandin <noel.grandin@collabora.co.uk> Sun Nov 03 17:11:14 2019 +0100 loplugin:stringadd tweak the plugin to be more permissive, then validate by hand afterwards which replaced strFor.replaceAt(0,1,"") with strFor.copy(1). Both methods are illegal on empty string, but the former asserted, then silently corrected wrong count; while the latter returns "br0ken". So the change actually revealed a pre-existing bug. Change-Id: Ic32b69d46e852f26e6c6ba819eed08bb79dce7a9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92301 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-04-16cid#1462266: Logically dead code (sc/dbfunc3)Julien Nabet
Regression from: commit 61d8db6b1a2026a29f61eaa691beb3c6cf05de5c Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Wed Apr 15 09:25:22 2020 +0200 loplugin:buriedassign in sc Change-Id: I9b4146c4e8814a36c7bfcd4c31f913c8412320e8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92244 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Change-Id: I5835f5c92cdf381a57ac6ccf627e327ae9f9e26b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92377 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-04-16fixes for code creating reversed RectanglesNoel Grandin
ie. where left > right or top > bottom These are all places where the code is self-evidently doing the wrong thing. Found by adding asserts to tools::Rectangle. In theory, this is legit, and code that wants a proper Rectangle is supposed to be first call Justify on a Rectangle, but lots of places don't do that, and that seems very dodgy to me. So lets work towards Rectangles always being in a valid state. Change-Id: I03296a624bd9b5b193e6aa8778addfb09708cdc7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92310 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-16tdf#132097: fix Find Previous with direction columns crashes in specific caseJulien Nabet
See bt here: https://bugs.documentfoundation.org/attachment.cgi?id=159553 nBlockPos vector is created with nLastCol + 1 elements, so if we click on a cell in a column which is after last value, the search will crash Change-Id: I9de688a8a80a45c3e5ddea6d2f461926e9777052 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92165 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-15loplugin:buriedassign in scNoel Grandin
Change-Id: I9b4146c4e8814a36c7bfcd4c31f913c8412320e8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92244 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-15mobile: fix double tap on chart doesn't get into editmodeMert Tumer
Sometimes double tapping on a chart when it is not selected in the beginning, starts the input mode instead of chart editing. Change-Id: Iee2a01c1ac909ac4060e91cdacfa9161dc4f1c3b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91992 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit d09a35bc10251ef0b66e06c6ffbb2d16332b318b) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92291 Tested-by: Jenkins
2020-04-15Fix typoAndrea Gelmini
Change-Id: I4ddc0ea4dea4b374104e2a3100858c225409e2e3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91929 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Eike Rathke <erack@redhat.com>
2020-04-15Related tdf#130778: New About dialogHeiko Tietze
More flexible dialog logo & about images as SVGs Change-Id: Icefa035893e241a7dee6aa28236e6b89b38477de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91908 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-04-15add an IsEmpty method to tools::Size and use itNoel Grandin
Change-Id: I7f5201e2ea6c74329336e16bf219630e38ff92cf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92264 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-15uitest: wrong filenameXisco Fauli
Change-Id: I06b3586519b8b58410ffb4e08822af53e252ecbe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92262 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-04-15tdf#131170: Add UItestXisco Fauli
Change-Id: I3d881803014d80cd3e8b3ed2f3cc2e84fdc1b3b6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92261 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-04-14tdf#130960: Add UItestXisco Fauli
Change-Id: I41f5bd8c8b9183138b673a5f40d8a29abe9874df Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92218 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-04-14uitest: improve tests in trackedChanges.pyXisco Fauli
Change-Id: I644a6e64ab7da002915a43745a35517a144b6cf5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92217 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-04-13tdf#113621: Add unittestXisco Fauli
Change-Id: Id733bfb64cd750f80a13b36e1937137354282787 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92109 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-04-13tdf#112936: Add unittestXisco Fauli
Change-Id: I9c2f21491ef97f9a1b82f43cdb9b0b978689f70b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92110 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-04-12tdf#41722: Add unittestXisco Fauli
Change-Id: I95ff8794addcce6a73d32f49222adffd7d824255 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92090 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-04-12lok: get the formula input bar focused after inserting '='Marco Cecchetti
Change-Id: I7f86ea7135fcb4071cc0162c233c63be6c9485bd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92083 Tested-by: Jenkins Reviewed-by: Marco Cecchetti <marco.cecchetti@collabora.com>
2020-04-12tdf#105272: Add unittestXisco Fauli
Change-Id: I80aa192651595a719a5ac9a06423d2cf80aa7a3d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92078 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-04-12improve fastparser loggingNoel Grandin
so we print out the full namespace, which is quite handy when tracking down attributes that are not being parsed. Change-Id: I085d39b365d43c1a53a7c176b633ea38e6a7fb45 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92064 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-11tdf#131907 Crash: reject/clear formattingNoel Grandin
regression from commit 0ef5c47547bec6319b853326603f3b807407fe78 sc: rowcol: tdf#50916 convert core/tool Change-Id: Ib8207f60d34e4257fc9a854f4e4d358951e24718 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92062 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-11rename vcl::Window::Update to PaintImmediatelyNoel Grandin
To make the code easier to read. Change-Id: Iebc648150391939fba5d1cd815c72dbcf02ceec6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90378 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-10tdf#55417: Add unittestXisco Fauli
Change-Id: I1cf633ea0be39c58bf38026d5ea73ad89bec72bc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92052 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-04-10tdf#73063: Add unittestXisco Fauli
Change-Id: I69beef7f6014af1940cd89749f1712a40c74e543 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92053 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-04-09GetObjectShell() can return nullSamuel Mehrbrodt
Change-Id: Ie410688c124d6653fc58fa9e63bd5dd3b46bf8ff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91979 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins
2020-04-09Move is*Locked methods to object shellSamuel Mehrbrodt
They depend on the model, not the view. Follow-up to 523922ee9d033fd304d2b50a72b76853ddcfbcdf Change-Id: I429bc25b8dd4f04ebf62eddd5ef455b5161e925d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91867 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2020-04-09tdf#95425 follow-up: enable "Source format" checkbox of data labelBalazs Varga
settings after file opening, if its value is true in the opened ODF or OOXML document, instead of always showing disabled state. Testing notes: double click on a data label during chart editing of unit test document testAreaChartNumberFormat.docx of commit e57d90cd4e51a1353eafc87bb29cfe6076704a7c (tdf#129173 tdf#129175 Fix number format of data labels) to see the Data Labels for Data Series... window. On the page "Data Labels...", click on the Number format... button to see the enabled checkbox "Source format" (that was disabled previously). Change-Id: I2845e6f462db273f21c47bb286bed56046f8cf21 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91038 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-04-08tdf#122331: Add unittestXisco Fauli
Change-Id: I5c104f225b0d3fd060c36db6b3cef34f46534c61 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91906 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-04-08Make SalInstance::CreateClipboard return a single instance in the non-LOK caseStephan Bergmann
I came across this when seeing UITest_calc_tests2's tdf118189.tdf118189.test_tdf118189 fail on Linux with SAL_USE_VCLPLUGIN=gen and also on Windows, see the mailing list thread starting at <https://lists.freedesktop.org/archives/libreoffice/2020-April/084822.html> "Linux SAL_USE_VCLPLUGIN=svp and the clipboard". That email thread clarified that the codified behavior of that non-LOK test was wrong. (While the LOK test ScTiledRenderingTest::testMultiViewCopyPaste in sc/qa/unit/tiledrendering/tiledrendering.cxx keeps working as intended.) I did not find documentation for what arguments CreateClipboard shall support, but things seem to work if anything but empty arguments is rejected with an IllegalArgumentException. Change-Id: I1918254cc15878ad43b8aa22aff7eb1c4bea73fe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91869 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-04-08cid#1461387 Uncaught exceptionCaolán McNamara
Change-Id: Ifcd9d3043bf51df6eb6a030481c63758f8501a0b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91872 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-08Resolves: tdf#131442 Sort must not contain matrix formula except 1x1 arrayEike Rathke
Change-Id: Idc7a9646a70c59fceee0b36426f38a938cf073ce Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91858 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2020-04-07Fix typoAndrea Gelmini
Change-Id: Iaeafd85b5d1becbafba644bb873dd7f676707cb6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91805 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
generated by cgit (git 2.34.1) at 2024-08-19 00:24:43 +0000