summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)Author
2021-10-11Resolves: tdf#126928 allow link updates in an intermediate linked documentEike Rathke
... if link updates are allowed in the current document and that intermediate document resides in a trusted location. This works with both, the "Always (from trusted locations)" and the "On request" settings under Tools -> Options -> Calc -> General. It can't work with documents residing in a non-trusted location as there is no way to allow updates on demand for a such loaded document (hidden via formulas). Reviewed-on: https://gerrit.libreoffice.org/77588 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit 54bf84746a2a9a2e2aaf0df9e429b0cfd538f640) Reviewed-on: https://gerrit.libreoffice.org/77604 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> (cherry picked from commit 14825a8b7f00ee4c148f2583856e5102312cabbd) (cherry picked from commit f136b30fa3e991b780e4b1ed704d04256d0cfca0) Change-Id: Ie483f7743db7c6d5cf947dc16a9c3660855f3423 (cherry picked from commit 86a3ea14d959f8a5409ea4883d9bf19e48046947)
2021-10-11Postpone loading of all external references, including INDIRECT()Eike Rathke
... which can be constructed with an arbitrary URI text string not an svExternal* token type, until link updates are allowed. Reviewed-on: https://gerrit.libreoffice.org/75422 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit b824b23860b2cf533d4f2428d4a750bd72576181) Reviewed-on: https://gerrit.libreoffice.org/76304 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Change-Id: I2ce4de415ff99ace04c083c36c1383d76a4ef40d
2021-10-11Postpone filter detection until link update is allowedMike Kaganski
Change-Id: I85b2185e550f2a133ceb485241ef513b40593e34 Reviewed-on: https://gerrit.libreoffice.org/75301 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit 03c708bf085f91480c014d7fa31e7a317b2c7b8f) Reviewed-on: https://gerrit.libreoffice.org/76303 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2021-10-10forcepoint#55 invalid iterator incrementCaolán McNamara
Change-Id: I151602f645a48404d93e0ae64a9e1d2a6ba2bc4b Reviewed-on: https://gerrit.libreoffice.org/58386 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2021-10-10forcepoint#64 null derefCaolán McNamara
Change-Id: I4acf03a7911aa203fc4ef10b6a96b0135d6adbbc Reviewed-on: https://gerrit.libreoffice.org/58415 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2018-10-03Resolves: tdf#119954 do not copy the old parent, init with new parent insteadEike Rathke
The parent is always the ScDBCollection that contains the ScDBCollection::NamedDBs container, not the one the ScDBCollection::NamedDBs was copy-constructed from. Change-Id: Ia409347f3aeb9ad7a5e68da7af727adfac98d6a2 Reviewed-on: https://gerrit.libreoffice.org/60833 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit 7ea5d339dc4d8412f436f3affa589bfbd0b1ef68) Reviewed-on: https://gerrit.libreoffice.org/60842 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2018-09-04ofz#10189 check container sizeCaolán McNamara
Change-Id: Ie99e3b082795989290799d057a99b1bcff94b161 Reviewed-on: https://gerrit.libreoffice.org/59913 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2018-08-31tdf#112454 Also consider last SCTAB in loopMichael Weghorn
Since 'rRange.aEnd.Tab()' is valid, it needs to be included in the loop to get a valid result. Reviewed-on: https://gerrit.libreoffice.org/59798 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> (cherry picked from commit 03b361673d04f31e0602d2988e4df26eaeb53a34) Conflicts: sc/source/core/data/document.cxx Backported. Change-Id: I7b2447e059dc03444c56e7fc0b113e1b618dd510 Reviewed-on: https://gerrit.libreoffice.org/59878 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2018-08-23Resolves: tdf#119402 +- typo sign flipEike Rathke
Regression from commit 667aa6ade94a4dee441868d21db037e42c871932 CommitDate: Wed Jul 19 20:13:58 2017 +0200 Avoid temporary Date and normalization that introduced a sign flip from + 5 - eDay to + (5 + eDay) instead of + (5 - eDay) Change-Id: I28194296b20552135e6abd24eb9eefe8634ce7c0 Reviewed-on: https://gerrit.libreoffice.org/59461 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit cadd6c595b250b3ce0025a2a09c160eaae483d5a) Reviewed-on: https://gerrit.libreoffice.org/59475 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-08-22Resolves: tdf#118983 do not expand range if sheet references not affectedEike Rathke
Change-Id: Ib207d3723ce1d370a953e652957aaed399affc9c Reviewed-on: https://gerrit.libreoffice.org/59255 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com> (cherry picked from commit da0dc858fc05e7f1d6a60ca61f722044e688d4f8) Reviewed-on: https://gerrit.libreoffice.org/59272 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-17tdf#119128 toggle INSERT/OVERWRITE is brokenMaxim Monastirsky
Regression of 632bc11ce8fab1c4046ab24810b90a7ce9ac5914 ("tdf#117017 Pasting into the formula bar shouldn't retain formatting"). Toggling the overwrite mode sets the EVControlBits::OVERWRITE bit from inside the editeng keyboard handler, so make sure to not override it. Change-Id: I2b5e3fe9cb885ed20e7528fdfe2fd59f5ef05f42 Reviewed-on: https://gerrit.libreoffice.org/58658 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com> (cherry picked from commit 92a4e4eac7520541a433e40836cafa4e29edf47f) Reviewed-on: https://gerrit.libreoffice.org/58718 Reviewed-by: Eike Rathke <erack@redhat.com>
2018-08-17Related tdf#118547: Lock mark on protected sheet tabJulien Nabet
Fix opposite case, see https://bugs.documentfoundation.org/show_bug.cgi?id=118547#c10 Reviewed-on: https://gerrit.libreoffice.org/59035 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit d064ced9e9db3f924dd954b86c40f21addab1c68) Change-Id: I2c4e55f8929b1979e71a4040dfac1ba7cff51aeb Reviewed-on: https://gerrit.libreoffice.org/59041 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2018-08-15tdf#119141 Revert "sc htmlimp: non-global sheet range names"Justin Luth
This reverts commit 5720c85ccea9f1481bd604b806c5be728e59a13f, which was made in response to the suggestion in comment 6 of bug 114487 and backported to 6.0.6. But ScAreaLink::FindExtRange doesn't bother to search the local rangenames, and the Links to External Files dialog also doesn't give non-global variables as options. Since this was just a "logical" change, simply revert it to repair the regression. Any attempt to support local rangenames is something bigger that isn't appropriate for backport to stable. Change-Id: I8bd4dcc6492da2712e13b2e54cf81609cdc5936e Reviewed-on: https://gerrit.libreoffice.org/58761 Reviewed-by: Justin Luth <justin_luth@sil.org> Tested-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 1597dbb5ba5d68b5807236c1d045f5215f221c91) Reviewed-on: https://gerrit.libreoffice.org/59065 Tested-by: Jenkins
2018-08-15tdf#115086 crash in assignLabelsToDataSequenceCaolán McNamara
since... commit c45358e928b9b9419bba10a0fcb661696cb7647a Date: Mon Apr 24 00:09:08 2017 +0200 preserve "Total" label on round-trip, remove code duplication Change-Id: I83ed20e1cab8d67f2f5aedcaf862756d9548bf9f Reviewed-on: https://gerrit.libreoffice.org/59062 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-08-15Resolves: tdf#118609 crash in calc after some manipulation through basicCaolán McNamara
Change-Id: I518b15359b29c845604d2e9cde64bdb637078ba1 Reviewed-on: https://gerrit.libreoffice.org/59054 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-07-26ofz#9431 don't check attribs of Invalid columnCaolán McNamara
Change-Id: I9c5adcadfa2a8593ff90622449d6bdfa4810f2c0 Reviewed-on: https://gerrit.libreoffice.org/57917 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2018-07-13tdf#118620 - avoid out of bounds iterator for end of sheet pivots.Michael Meeks
Change-Id: I2ddcf56dc94175718739611f0791558fda87b1ba Reviewed-on: https://gerrit.libreoffice.org/57358 Tested-by: Jenkins Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> (cherry picked from commit d3387b38fe0eea3fb7ac630c026f02986e8dafc4) Reviewed-on: https://gerrit.libreoffice.org/57385 Reviewed-by: Eike Rathke <erack@redhat.com>
2018-07-09tdf#114131 Remove insert rows/columns in read-only modeXisco Fauli
Change-Id: Ief3565bc41639af1a2f48fd2b4be9156a10596c2 Reviewed-on: https://gerrit.libreoffice.org/57098 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 1407aeea58046e0ab5e2483dbc5984ee1c0f4187) Reviewed-on: https://gerrit.libreoffice.org/57189
2018-07-08Resolves: tdf#118561 handle external references as jump matrix resultEike Rathke
Change-Id: I0381179347960293f5d470ed231d626cb6707b5a Reviewed-on: https://gerrit.libreoffice.org/57144 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit a5b9bb7be70c7aec2388199e68a0cf86dd220955) Reviewed-on: https://gerrit.libreoffice.org/57148 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-07-08tdf#118547: Remove lock mark only if password is correct, tdf#95880 follow-upEike Rathke
This is a combination of 3 commits. tdf#118547: Remove lock mark only if password is correct Reviewed-on: https://gerrit.libreoffice.org/57044 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit c3a732a11c320b98e31dad79f421d4d73f33a15b) Related: tdf#118547 handle multi-sheet un-/protect, tdf#95880 follow-up Also don't attempt to remove a lock for TABLEID_DOC that is not a sheet. Reviewed-on: https://gerrit.libreoffice.org/57060 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit 7eba8e98508d547f43fecbe3175a11a05956b30a) Handle protection lock mark in Undo/Redo, tdf#68290 follow-up Reviewed-on: https://gerrit.libreoffice.org/57063 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit 6fb449d127d1da165f610c4c99c2c7d9c5afbb97) Change-Id: I9f5731dfaaf9b4cc67e600a8b1c01709e7c9ba99 28775a068215a59063ed95fd141e125cf2155aa7 c88cb375f9f6030c9268fca84de7a5434bb82dc1 Reviewed-on: https://gerrit.libreoffice.org/57091 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-07-04tdf#118452 Don't crash when multi thread calculation is disabledGabor Kelemen
...by default configuration. Change-Id: If6075ae66537f613434dd38766324436f2426517 Reviewed-on: https://gerrit.libreoffice.org/56840 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit e119194aeec907f3d02cb914e5afde5ac763df7c) Reviewed-on: https://gerrit.libreoffice.org/56856
2018-06-20tdf#118189 : Propagate the state of mbNeedsNumberFormat...Dennis Francis
from source formula-cell to destination while calling SetFormulaCell() on dest formula-cell in CopyByCloneHandler CopyByCloneHandler get called when some data range is pasted to a document, or when data is copied to an undo document. This is a follow-up of the commit 37f6e5de1e72d209b0892734f4de5c4d8a849885 (tdf#114710 : Fixes crash when pasting as GDI metafile) Change-Id: I936310f13080f2de763ebcd5cb046a25d61d978e Reviewed-on: https://gerrit.libreoffice.org/55975 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 67c88e284af74c88e37cc8f66cdfc0e346de45ac) Reviewed-on: https://gerrit.libreoffice.org/56134
2018-06-14Resolves: tdf#118161 use ScCellIterator::isEmpty() for COUNTA()Eike Rathke
... instead of hasEmptyData() that considers inherited svEmptyCell as well. Effectively a regression from commit 0e9e3be6f51436c1e5bf1481a434a85e334c09ea CommitDate: Tue Mar 26 01:41:17 2013 -0400 More on ScCellIterator usage migration. that started to include mpCurFormula->IsEmpty() in ScCellIterator::isEmpty() which later was renamed to ScCellIterator::hasEmptyData() and isEmpty() introduced for real empty. Change-Id: Iec97d58080016c28bc9a7e47d056e4d301263928 (cherry picked from commit cfe2e4eb835c06b24adabd60c7a3fddbd3f4dbc9) Reviewed-on: https://gerrit.libreoffice.org/55804 Tested-by: Jenkins Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2018-06-14tdf#116552 restore copy on focus and jump focus to sourceCaolán McNamara
This is surely an utter abuse of focus and an a11y disaster, but it used to work this way. Change-Id: I265a2bafbc2cdd17ff4a5b7c2805def63c510d5c Reviewed-on: https://gerrit.libreoffice.org/55375 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2018-06-13tdf#114487 sc htmlimp: non-global sheet range namesJustin Luth
Allow multiple file imports, each one having a non-conflicting range name, by being sheet specific. As Eike states, "This does *not* mean that they couldn't be referenced from other sheets. By prefixing the sheet name it can be used from any other sheet, for example Sheet2.HTML_1. (This wasn't possible in early versions with sheet-local names but it has been possible for a while already)." In theory, it would previously have been possible to create a generic sheet with calculations using a range name that doesn't exist yet, and then importing *any* file to be analyzed. In practice that has never been possible since all names were relative, and imports always create a new sheet, so the relative name would point elsewhere. Also, the non-existant name only resolves after a round-trip of the file, not immediately upon file import. So, it is logical to set the imported range names to be sheet-local instead of global. Change-Id: I3103f0655b2373bb731c192bb5d2c0757938ee28 Reviewed-on: https://gerrit.libreoffice.org/55349 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 5720c85ccea9f1481bd604b806c5be728e59a13f) Reviewed-on: https://gerrit.libreoffice.org/55648 (cherry picked from commit f62340a104813e4a6a34e7281d86407bc8314ffd) Reviewed-on: https://gerrit.libreoffice.org/55698 Tested-by: Justin Luth <justin_luth@sil.org>
2018-06-13tdf#114710 : Fixes crash when pasting as GDI metafileDennis Francis
The bug document has a formula cell (at O7) that depends on cells with non-default number formats, but this cell's number format was force set by the user to the default. So the mbNeedsNumberFormat for this ScFormulaCell object is now false. But when a copy to clip and paste as GDI metafile is made, this subtle information about the "user forced default number format" is lost. ScColumn::SetFormulaCell() is used while making the copies of the original formula cell to clipdoc and then to another document, where it sets the field mbNeedsNumberFormat of the formulacell to true if the number-format of the target cell is default. Note that the number-formats along with all attributes of the target cells are copied from the source before copying the actual cell contents. As a result, after copy pasting, the formulacell at O7 of the new document will have mbNeedsNumberFormat = true. This causes the attribute modification (in ScAttrArray of corresponding column) while Interpret()'ing the cell. Unfortunately this Interpret() happens while in a call to ScRefCellValue::hasNumeric() while in the middle of rendering the cell of the new document (in ScOutputData::LayoutStrings()), and naturally this messes up the ScPatternAttr references the view has been caching, hence the crash. The steps involved in the fix are :- 1. Carry around the state of mbNeedsNumberFormat in the copy-constructor of ScFormulaCell, in case the src formula-cell is not yet Interpret()'ed. Note that after Interpret() is done, the mbNeedsNumberFormat is set back to false and inherited numfmt is applied to attributes data structure. 2. In ScColumn::SetFormulaCell(), allow an optional param bInheritNumFormatIfNeeded (default = true). In that method, the mbNeedNumberFormat is set to true only if this flag is true and the cell format is default. So when the copy/paste operation is going on, we pass the mbNeedNumberFormat of the source formula-cell for the new parameter to SetFormulaCell(). Reviewed-on: https://gerrit.libreoffice.org/55555 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 37f6e5de1e72d209b0892734f4de5c4d8a849885) Change-Id: I535e413d4bde4c33a5f6ad3ce01536d0e94e7074 Reviewed-on: https://gerrit.libreoffice.org/55693 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Dennis Francis <dennis.francis@collabora.co.uk>
2018-06-05tdf#117522 Calc Column Width after Insert ColumnsNoel Grandin
regression from commit d6fb5ca5661195520ca7a7ca2d0145a1e11be099 dyncolcontainer: use ScCompressedArray for pColWidth Change-Id: I65d1197c0c638216e063f74def4efb98bfbb9aad Reviewed-on: https://gerrit.libreoffice.org/54067 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit a111a7ba4067dc11070c4b1ab6eb24cc89263770) Reviewed-on: https://gerrit.libreoffice.org/55119 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-05Resolves: tdf#117879 preserve formula after inline array errorEike Rathke
Use FormulaError::NestedArray for now to be able to backport without new string resources. Introduce a more specific error in another change. Change-Id: I49bf731f0b17c81dc6a125718bf104e218e508cc Reviewed-on: https://gerrit.libreoffice.org/55300 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 2d330a5c48fd200db10fba7c40688221185c2dec) Reviewed-on: https://gerrit.libreoffice.org/55308 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-06-04tdf#114487 sc htmlimp: rangeNames should be 3DJustin Luth
Without a visible sheet name, these absolute ranges become relative after a round-trip. Another way to handle this would be to ensure that ODS (and other text-based formats) export Absolute in a way that can be properly imported. But handling it on import is safer and ensures UI consistency. The InitRange default is for !IsFlag3D and !IsTabRel(). Since the range already imports as absolute, just add the appropriate 3D flags. Change-Id: Ia664e6f87e235096e1c2e5b702e18505e375e2ad Reviewed-on: https://gerrit.libreoffice.org/54725 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit c42b1cf2464924b125aeae15968fb79cf795bc81) Reviewed-on: https://gerrit.libreoffice.org/55272
2018-05-29forcepoint#40 null derefCaolán McNamara
presumably since commit 0098bee792c3e208ea4f6ef1c676958d3f4cd207 Date: Thu Sep 21 06:48:09 2017 +0200 tdf#112501: Pivot table: popupbuttons are placed on wrong cells Change-Id: I5413c0ba06fca25cb22256a20ef9640767dd9e50 Reviewed-on: https://gerrit.libreoffice.org/54970 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2018-05-29tdf#115582 Correct coordinate usage for sc's ::ArrayArmin Le Grand
In ScOutputData::SetCellRotations() eventually existing CellRotations are added to the svx::frame::Array data that gets created for repaint. This used the wrong coordinate calculation, thus in some cases the repaint of rotated Cells failed. Change-Id: Ib5df8576e8c9404d717d5dcc5662aa04b82cf959 Reviewed-on: https://gerrit.libreoffice.org/53171 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de> (cherry picked from commit 0185e65bcd73dbad2205a39369e1e06b33a2ca51) Reviewed-on: https://gerrit.libreoffice.org/54922
2018-05-18Resolves: tdf#117093 sanitize the active grid window valueEike Rathke
Don't know yet how that could had happened, but the sample document has a bad ActiveSplitRange value that doesn't match HorizontalSplitMode and VerticalSplitMode. * sanitize the value when reading view settings * prevent writing such value to help versions that don't sanitize Change-Id: I1b450c7b8102148a24d545ff7568f725d7492a6a (cherry picked from commit 646e9564007b13bd841d28e7c02c060d2f96fb39) Reviewed-on: https://gerrit.libreoffice.org/54504 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-16Related: tdf#116939 Disable <cols><col> overflow detection due to excess ...Eike Rathke
... custom column widths. It's probably just confusing to users, even if technically correct. Live with truncation of a "layout form" if no content is present. Change-Id: I43d77c3e019badd053cb21d92aacd64c7bbcf0e6 Reviewed-on: https://gerrit.libreoffice.org/54319 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit f72bd4f02b70e1c4855795b4237e2965556c4689) Reviewed-on: https://gerrit.libreoffice.org/54332 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-11tdf#117433 count empty cells properly with COUNTIF.Winfried Donkers
All empty columns after the first column of the range were skipped. When the query contains an 'cell is empty' expression, skipping is omitted. Change-Id: I0d5b0d24c2d08bad88479cd5b356529a0a709156 Reviewed-on: https://gerrit.libreoffice.org/54021 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 1a8febcaa4f932124d417877a3b08bd059c0362d) Reviewed-on: https://gerrit.libreoffice.org/54037 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-08Resolves: tdf#117005 undo/redo skips comment when switching sheetsCaolán McNamara
while insert comment is active regression from.... commit 80509950d35cebaede89fcb52c446a1fd3e45ba3 Author: Caolán McNamara <caolanm@redhat.com> Date: Mon Jul 4 15:31:29 2016 +0100 Resolves: tdf#100761 after insert note, focus cannot return to inputbar which is a suspected regression from. commit 11d605cc5a0c221d2423b6e63f502db660d085d2 Date: Mon Feb 1 18:39:51 2016 +0200 tdf#84843 Stop using PseudoSlots for drawing slots Change-Id: Id4614624cbb85411ba0d368ae072a05f5f9e09ad Reviewed-on: https://gerrit.libreoffice.org/53799 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2018-05-04tdf#117017 Make modifier keys not trigger the InputChanged handlerMaxim Monastirsky
(cherry picked from commit a860c94f0da22065074cc36e8ddda73261641533) sc: Fix menubar auto-accelerator behavior under gtk2 ... when the focus is in the input field of the formula bar. Regression of commit d90dcf3554a84b5600800ee6deb3cde879c62b8d ("tdf#113894 release ctrl of ctrl+v in input line should strip formatting"). (cherry picked from commit baddcc38dee7b286cc73c1eaeb6f78d10b911a8e) tdf#117017 Pasting into the formula bar shouldn't retain formatting This is (kind of) regression from the previous commit a860c94f0da22065074cc36e8ddda73261641533 ("tdf#117017 Make modifier keys not trigger the InputChanged handler"). Reset of formatting when pasting into the formula bar via a keyboard shortcut, was actually a side effect of the gtk auto-accelerator work. In particual, bibisect (of the 5.2 cycle) points to commit 8d53d01f38b856f177aca3ed4d3cba3db10f24a5 ("tdf#96739: Send Ctrl-Left/ RightShift events to correct window"). The behavior was later changed back with commit 0321dbb9be72f92c02919457cdc3c4e76cfbd11d ("Resolves: tdf#99324 let sidebar toggle auto-mnemonics on/off with alt"), but introduced again upon request of tdf#113894, with commit d90dcf3554a84b5600800ee6deb3cde879c62b8d ("tdf#113894 release ctrl of ctrl+v in input line should strip formatting"). Now it's broken again with the previous commit of this bug. However, even if not retaining formatting is the desired behavior, triggering it on a modifier key release isn't a good idea. So keep the previous commit, and implement tdf#113894 differently. In addition, make sure to get identical behavior regardless of the pasting method, be it via a keyboard shortcut, a toolbar button or a menu/context menu command. And users can still override this behavior with the usual paste special dialog, or the toolbar dropdown. (cherry picked from commit 632bc11ce8fab1c4046ab24810b90a7ce9ac5914) Change-Id: Ib05883688ef4143c0b53871c4336920dde6f91cc Reviewed-on: https://gerrit.libreoffice.org/53144 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-02Resolves: tdf#116939 cater for the last cols col incremented by ExcelEike Rathke
Change-Id: I48c4b9afb4cf2cb826ae2bb52067256e7fcb2c83 (cherry picked from commit b78ab482911356ef282f7fd40a4509320608a203) Reviewed-on: https://gerrit.libreoffice.org/53565 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-04-24Related: tdf#116274 ignore the one excess cols definition's last columnEike Rathke
<cols> ... <col min="5" max="16384" width="31.75" style="3"/> </cols> may be present even if there isn't any content. Apparently used with pageBreakPreview to grey out the area. Change-Id: I6a79f9ec692ec07b02f4b4205ccd0cf3cf9f363f (cherry picked from commit 16265dcdb21d7cf69c65c2a84f1d21a5d8574dd4) Reviewed-on: https://gerrit.libreoffice.org/53377 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Jenkins <ci@libreoffice.org>
2018-04-24tdf#116821 Keep row/column buttons enabled even when insert impossibleMaxim Monastirsky
So other commands included in these buttons (like delete or set height/ width), could still be used. Change-Id: If9e96116aebf73b2d20fb8d63ee67da3d17e3d9f Reviewed-on: https://gerrit.libreoffice.org/52909 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com> (cherry picked from commit 3732d5ab1782bbadfee457115fbd8dce78453cc2) Reviewed-on: https://gerrit.libreoffice.org/53286 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-04-17Resolves: tdf#116003 check presence of subtotal in group, tdf#107267 follow-upEike Rathke
Change-Id: Ifed6e28926c689dd17914b8b1cbf47b58e2ffcdc (cherry picked from commit f50e370db8f7ae20b12e312ad89a0f9961b7ee7a) Reviewed-on: https://gerrit.libreoffice.org/52989 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-04-13Related: tdf#100925 background not getting set under X sometimesCaolán McNamara
not sure why this is the case, but it is reminiscent of rhbz#1283420 which results in missing glyphs in some circumstances X11CairoTextRender::getCairoContext has a hack in it for that problem, whic forces a read from the underlying X Drawable before writing to it which seems to have the effect of syncing it up. So, just before drawing the bg, draw a glyph on it to get it synced, and then overwrite it. Change-Id: I2ffff7e8e989b91821869d8b75a59728ac513d1b Reviewed-on: https://gerrit.libreoffice.org/52818 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2018-04-13Resolves: tdf#116813 Height/Width swappedCaolán McNamara
Change-Id: I9b41a4b65fda895ed73fa346fb0b8e13df010706 Reviewed-on: https://gerrit.libreoffice.org/52693 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2018-04-09tdf#116706 fix for AGGREGATE with hidden rows and single references.Winfried Donkers
Change-Id: I6ac88f26b46a17e1857b7b40d2034fb321973625 Reviewed-on: https://gerrit.libreoffice.org/52522 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit 0a4c1fb68c3619e61099a7c548f550b0d3fd7a53) Reviewed-on: https://gerrit.libreoffice.org/52651
2018-04-07tdf#114168 If minor axis unit is automatic, then set it to 5Bartosz Kosiorek
Based on OOXML implementation in MS Excel, if Minor axis Unit is set to automatic, then during chart import, LibreOffice should set Interval Count to 5, to mimic behaviour of MS Excel. Becaues default Interval Count for LibreOffice is 2, we need to override it to 5. With that solution, the Minor axis unit is preserved also after saving to .ods file format. During .xlsx export, if Interval Count is set to 5, then treat is as automatic axis unit. Change-Id: Iab9209fb3950ef73e79229329606363b528d35fe Reviewed-on: https://gerrit.libreoffice.org/49327 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl> (cherry picked from commit 274825b4180c81540cd0d1b22c5243f1b39fe4db) Reviewed-on: https://gerrit.libreoffice.org/50676 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-04-05forcepoint #32 survive missing value rangeCaolán McNamara
Change-Id: I90315f0481bf73c4d9071959bf5408f4a2690257 Reviewed-on: https://gerrit.libreoffice.org/51885 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-04-05forcepoint #34 survive missing autostylesCaolán McNamara
Change-Id: I742816297659d614e836a8d5e8965b1c55154719 Reviewed-on: https://gerrit.libreoffice.org/51891 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-04-05forcepoint #31 check validity of another group rangeCaolán McNamara
Change-Id: I82ff3e47a033c91581b108e1685b1ff4d5865895 Reviewed-on: https://gerrit.libreoffice.org/51882 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-04-05forcepoint #30 check validity of group rangeCaolán McNamara
Change-Id: Ie0611f36809b051ce46030e44c137b4e1f8d2fe0 Reviewed-on: https://gerrit.libreoffice.org/51864 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-04-05forcepoint #29 detect illegal self series addCaolán McNamara
Change-Id: I3bba0f942780c54951a3a810c05cc3b56ca18a5e Reviewed-on: https://gerrit.libreoffice.org/51861 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-04-04tdf#112997 multiple animated gif only one frameNoel Grandin
Not sure what the problem is, but using a vector and just making sure we insert into the right spot for the sorting fixes it. Change-Id: I11c08e08a14c98ba7eb6a5d925c75bab891ecf63 Reviewed-on: https://gerrit.libreoffice.org/51829 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit d312ff2b52c0ea2e2864518a36f6b432653c8297) Reviewed-on: https://gerrit.libreoffice.org/52009 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2024-06-21 15:54:28 +0000