summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)Author
2017-10-16use rtl::Reference for SvXMLGraphicHelperNoel Grandin
Change-Id: I0052b29660fb6157f7e98c4e124f030ba439d304 Reviewed-on: https://gerrit.libreoffice.org/43417 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-16tdf#105853 improve layout Options > Calc > Formula ... separatorCor Nouws
thanks Olivier for help with mastering Glade ;) Change-Id: If2e2381168a98d5b04c28d6625800d03b0c5e868 Reviewed-on: https://gerrit.libreoffice.org/43352 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2017-10-14ofz#3634: add a SC_MAX_MATRIX_ELEMENTS to limit max matrix elementsCaolán McNamara
Change-Id: Ib2b1a36d56cc8ac63cf28a18fa20ad2f075dcf21 Reviewed-on: https://gerrit.libreoffice.org/43394 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-10-14implement new more user friendly data provider dlgMarkus Mohrhard
This is still a work in progress. Change-Id: I1e68c86acc810eec068b1f184b2307c51d9b58df Reviewed-on: https://gerrit.libreoffice.org/43259 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-10-13derive size of tab bar in Calc from TabFont (in pixels).Bernhard Widl
Change-Id: I3a35850cb6a66b06ae6568b54c008669ee2f391a Reviewed-on: https://gerrit.libreoffice.org/43328 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-10-13Replace lists by vectors in chart2uno (sc)Julien Nabet
+ remove useless 'using ::std::list' in externalrefmgr (sc) Change-Id: Iacff73fafe5a048b47abea865a77645a960e1a0d Reviewed-on: https://gerrit.libreoffice.org/43355 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-10-12Translate German variable names in Calc (financial)Johnny_M
These names of variables correspond to German function names in Calc and were translated to their English equivalents. For used translations, see, e.g., https://translations.documentfoundation.org/de/libo54_help/translate/#search=RMZ&sfields=target&soptions=exact,case Note: This is an alignment of the function declaration to the definitions in /core/sc/source/core/tool/interpr2.cxx, some of which were translated on f8b9b8ec5686c1453e335d895aa78faba5fdf268, while others were already in English. Change-Id: Ifb01992e42af707a08a02139ffb8313d3b92701c Reviewed-on: https://gerrit.libreoffice.org/43077 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-10-12adapt dataprovider to the requirements of the new UIMarkus Mohrhard
Change-Id: If10a68a27591f3195ef85c21ea98324903819b36 Reviewed-on: https://gerrit.libreoffice.org/43256 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-10-11Replace list by vector "DataPilotSort" from dbfunc3 (sc)Julien Nabet
Change-Id: Ib8754d7e459d1019ed2d5f49ce593e20af0b7f0c Reviewed-on: https://gerrit.libreoffice.org/43315 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-10-10use std::swap instead of own implementationMarkus Mohrhard
Change-Id: Iabc0eee868a2ad5623a1ac39b26bb2bc5981e829 Reviewed-on: https://gerrit.libreoffice.org/43249 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-10-09sc, implement HAVE_FEATURE_AVMEDIAjan Iversen
iOS does not support avmedia, therefore HAVE_FEATURE_AVMEDIA is set, however not all sources test for it. Change-Id: I627d1a45420d4af093c57bc53d716d48bf3a4b00
2017-10-09update notebookbar to add ExportDirectToPDF and ExportDirectToEPUBandreas kainz
Change-Id: I6b161cc7d5e56b1a6507d6a513f1d3d70e8671c9 Reviewed-on: https://gerrit.libreoffice.org/43271 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2017-10-09tdf#45904: Move _XAreaLinks Java to C++Jens Carl
This allows to re-activate the test and fixes #i84701. Change-Id: Ifd295e9521a04e88a68aa96fad8f9e8e32f927fa Reviewed-on: https://gerrit.libreoffice.org/41855 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-10-09make sure to include all relevant header filesMarkus Mohrhard
Change-Id: I313d3a7dce5143ad8703e8ef8c2d066e652a4483 Reviewed-on: https://gerrit.libreoffice.org/43248 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-10-09prevent crash in the new dataprovider UI when adding a new columnMarkus Mohrhard
Change-Id: I3f87d2dac75662ab1da6049579d33d6b39e1da0c Reviewed-on: https://gerrit.libreoffice.org/43257 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-10-09document how formulas are stored in the cacheMarkus Mohrhard
Change-Id: I1a4f8dd16bb739eb84087e596278fbd4cdc8db7c Reviewed-on: https://gerrit.libreoffice.org/43255 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-10-09document a few method parametersMarkus Mohrhard
Change-Id: I08273d2a84c335e5eb9998e41a67b3b7340f348d Reviewed-on: https://gerrit.libreoffice.org/43250 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-10-08tdf#45904: Move _XSubTotalField Java tests to C++Jens Carl
Change-Id: I64528c4e315247583e185bc3ab0defbc22bd8726 Reviewed-on: https://gerrit.libreoffice.org/41826 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-10-07This method was replaced accidentallyTamás Zolnai
Change-Id: I37d6d0fc36420de6dbdd69f264b85f3ba591e312 Reviewed-on: https://gerrit.libreoffice.org/43232 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-10-07tdf#109016: Avoid to write the same pivot item member more timesTamás Zolnai
It seems it's allowed to have the same member name in a pivot table. We need to handle this in the filtering code. Regression from: 625653c8d119e720fb93b0c9f6f50d1eb625b179 Change-Id: Ic6f4110da3d83f4bbf5284e1b772e9e31b250bf1 Reviewed-on: https://gerrit.libreoffice.org/43230 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-10-06tdf#112946: Pivot table: Missing selector for a row field after RT in CalcTamás Zolnai
We need to explicitly set compact flags to false, since true is the default. It seems MSO prefers compact mode, when the file contains colliding mode flags. Change-Id: Ib311f1cf44345be294e6c6607c227c2baa0fb693 Reviewed-on: https://gerrit.libreoffice.org/43210 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-10-06tdf#112936: Pivot table: LO created XLSX file makes Excel to crashTamás Zolnai
It's not actually clear, why Excel crashes, but setting the version makes it working. I expect that this version number (which specifies MSO Excel versions) makes MSO to handle the pivot table differently. As the internal implementation of the pivot table was changed in different versions. The name "DATA" might had a special meaning in the earlier versions (e.g. XP, MSO 2000) which leads this crash. So setting the version to MSO 2007 seems a good solution for this. Older versions not seems a target of LO exported XLSX files in these days. Also smaller values leads to the crash described in the bug report. Change-Id: I6e9edc949d1670d657effff9277cfd86ff163458 Reviewed-on: https://gerrit.libreoffice.org/43208 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-10-06Process all pending events during Cppunit setUpJan-Marek Glogowski
Larger unit tests collect a lot of events, which are just processed on shutdown. But since the Scheduler is just an unsorted linked list, processing these in order is O(n^2) for lookup, which really adds up, e.g. sw_ooxmlexport8 has 35047 tasks on shutdown. So this just processes all pending events before running each unit test. Also adds missing spellchecking components to some calc tests. Change-Id: Icf12146015afc17a1f52f79c18f248b72650ad46 Reviewed-on: https://gerrit.libreoffice.org/43199 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2017-10-06use rtl::Reference in SvXMLEmbeddedObjectHelperNoel Grandin
instead of manual ref-counting Change-Id: I559ebb3871dd3dd4a160bd83a259e36dd2f7b4d6 Reviewed-on: https://gerrit.libreoffice.org/43200 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-06coverity#1418967 Uninitialized scalar variableCaolán McNamara
and coverity#1418960 Uninitialized scalar variable Change-Id: I2f96b3824fca585a22d7a02a974c371ebaf57bde Reviewed-on: https://gerrit.libreoffice.org/43187 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-10-06coverity#1418961 Uninitialized scalar fieldCaolán McNamara
Change-Id: I84692e07f3887c8440df535c2c0c1191cd2773be Reviewed-on: https://gerrit.libreoffice.org/43188 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-10-06coverity#1418965 Uninitialized scalar fieldCaolán McNamara
and coverity#1418963 Uninitialized scalar field Change-Id: I16bd91d2dfe2a1ae3f4697b5ff67acf6b6a5ba1c Reviewed-on: https://gerrit.libreoffice.org/43189 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-10-05sc: try to fix DISABLE_DYNLOADING hackeryMichael Stahl
Change-Id: I291ffc6cd1c7e9a43cd6f0861c05833316bfff78
2017-10-05tdf#112893: Pivot table: filtering of error item is not importedTamás Zolnai
... from XLSX Change-Id: Ib155852e5f0718f41e02596d1042513286c6d845 Reviewed-on: https://gerrit.libreoffice.org/43166 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-10-05tdf#112884: Error string is displayed as empty item in pivot tableTamás Zolnai
Need to get the right string representation of error cells. Based on the code it seems a regression from: d4cd8677889ec3807c194ef5b462f8e031807e5b Change-Id: I30001e63cd17ae68ba4988d5825de479a4496326 Reviewed-on: https://gerrit.libreoffice.org/43146 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-10-04Fix typosAndrea Gelmini
Change-Id: I7f6dbb170b88cc1717d08651d4ddd3aace0a7933 Reviewed-on: https://gerrit.libreoffice.org/43141 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-10-04add << operator for css::uno::ExceptionNoel Grandin
Change-Id: Ia23dafd07133779144965682df3b7125a3214235 Reviewed-on: https://gerrit.libreoffice.org/43046 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-10-04Revert "check for unnecessary DLLPUBLIC annotations"Stephan Bergmann
This reverts commit a599eeab786ecbe1b5b6509e3c792e5c1ba31248, plus follow-up fa4431449d0306e8179f53a2a69c549800bd24bd "Avoid bogus loplugin:dllmacro 'unnecessary *DLLPUBLIC declaration ...'". See (abandoned) <https://gerrit.libreoffice.org/#/c/42983/> "loplugin:dllmacro: Handle implicit member functions" how this would have needed to be extended to give consistent results across Linux and macOS, but then would have started to remove DLLPUBLIC from entities that apparently need to at least have default type visibility on macOS and started to make tests fail.
2017-10-04Indent part of ScInterpreter that for some reason was not indented at allTor Lillqvist
Change-Id: Ib514d8422a1a881f24fe7a10e8ce538ea997dc6b
2017-10-03tdf#112842: UI enable/disable leadingzeroeslabelXisco Fauli
Change-Id: I73c617c1416628d094b8ee5794f43e16b77681d3 Reviewed-on: https://gerrit.libreoffice.org/43058 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-10-03convert TPB_DISPLAY_NAME constants to scoped enumNoel Grandin
Change-Id: I0e4f9ce3392e48fc82c232ba3e6581f3b0d9af9f Reviewed-on: https://gerrit.libreoffice.org/43083 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-03convert WB_FORCECTRLBACKGROUND to bool field on EditNoel Grandin
Change-Id: I7a8731635bd22926df98cd70c8bb850408c1854c Reviewed-on: https://gerrit.libreoffice.org/43076 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-03new loplugin:blockblockNoel Grandin
Change-Id: I7b68b70fa4c7234e8882f7627026959a596968fd Reviewed-on: https://gerrit.libreoffice.org/43025 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-02Remove undefined elements after std::uniqueJan-Marek Glogowski
Change-Id: Ifebd1124fa081d50797904175d90e6d26d50ab7f
2017-10-02lok - sc: lift row limit to 500kMarco Cecchetti
Due to previously intruduced optimizations, it is safe and fast enough to navigate through a 500k rows speadsheet. Change-Id: I865d0b60629b5bbf796e9e48df6ff21242a13e5a Reviewed-on: https://gerrit.libreoffice.org/40454 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
2017-10-02lok - sc: row/column headers are updated fasterMarco Cecchetti
Now the computation of the row/column headers data exploits the cached row/col positions in HeightHelper/WidthHelper. That makes updating row/column headers at the bottom of the document as fast as at the top even for very big spreadsheets. Change-Id: I27381b520aaed68662e4d07c5879046d182c70e6 Reviewed-on: https://gerrit.libreoffice.org/40451 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
2017-10-02lok - sc: make computation of cell cursor position fasterMarco Cecchetti
Now the computation of the cell cursor position exploits the cached row/col positions in HeightHelper/WidthHelper. That makes navigating through arrow keys independent from the current cell cursor position: the cell cursor position is updated at the bottom of the document as fast as at the top even for very big spreadsheets. Change-Id: I2f23d4439f2157e702f09b56106bebdd0e0bbe86 Reviewed-on: https://gerrit.libreoffice.org/40450 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
2017-10-02lok - sc: invalidation of cached row/col positions on several casesMarco Cecchetti
Cached row positions are invalidated when one of the following event occurs: - one or more rows are inserted - one or more rows are deleted - one or more hidden rows are made visible - one or more visible rows are made hidden - one row is resized - optimal row height is changed - the value of the PPTY parameter is updated - a undo/redo involving any of the above actions The same occurs for cached column positions. The solution takes care of row/column operations performed in another view and of the current tab each view is displaying Change-Id: I57895506b17986d36ab024eec9c79864ea95dad7 Reviewed-on: https://gerrit.libreoffice.org/40449 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
2017-10-02lok - sc: document size as sum of row heights/col widths in pixelMarco Cecchetti
Grid lines, cursor overlay, row/col headers are all computed by summing up row heights / col widths converted to pixels. On the contrary the document size was converted to pixel only at the end after having summed up heights/widths in twips. All that lead to have a document height/width greater than the position of the last row/col, with the scrolling in online going unplesantly far beyond the last row/column. This patch change the way the document size is computed, so that the spreadsheet height/width matches the position of the last row/column. Moreover it exploits the cache-like structure for row/col positions introduced in a previous commit. Change-Id: Ibb2cc6a7b592e359a0b1202dc9bea1dd4c421354 Reviewed-on: https://gerrit.libreoffice.org/40448 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
2017-10-02lok - sc: a cache-like structure for row/col positions in the documentMarco Cecchetti
ScPositionHelper provides the ability to insert (and remove) row- position pairs where the position is in pixel and related to the spreadsheet top. In this way one can compute a new row position by starting from the nearest row presents in this cache-like data structure. It offers also the ability to invalidate the cache by removing all cached data below a given row or position. This data structure can be used for columns, too. Change-Id: Ifd66a003680ef9a3babf46ae952221c04451be9a Reviewed-on: https://gerrit.libreoffice.org/40447 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
2017-10-02lok: sc: overlays and edit view misplaced by other view actionsMarco Cecchetti
The edit view, the cell cursor and the cell selection overlays become misplaced when another user inserts, deletes or resizes a row. The same is true for columns. The solution takes care of the current tab each view is displaying and of undo/redo actions. Change-Id: I24c94f774f3b18028c9356a904e1b14b07c5c61a Reviewed-on: https://gerrit.libreoffice.org/40016 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
2017-10-02Translate German variable names in Calc (financial)Johnny_M
These names of variables correspond to German function names in Calc and were translated to their English equivalents. For used translations, see, e.g., https://translations.documentfoundation.org/de/libo54_help/translate/#search=kapz&sfields=target Change-Id: I5c0e4232b2e7b3039a42aff96a44a8f55c818d2e Reviewed-on: https://gerrit.libreoffice.org/42993 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2017-10-02Resolves: tdf#112780 no ResetDirty() after SetHybridEmptyDisplayedAsString()Eike Rathke
Change-Id: Idea5c1bd8e8577eaf90fc47d39f88c79963c422b
2017-10-02consistently apply std::unique_ptr to SvLBoxButtonDataCaolán McNamara
Change-Id: I307c9095aa562348ce1b9338203995d9d62eebb4 Reviewed-on: https://gerrit.libreoffice.org/43037 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-10-02Bin duplicated forward declarationTor Lillqvist
Change-Id: Id5fda192de625c5fdfd6f9dce3ebcd68e06f1c7a
generated by cgit (git 2.34.1) at 2024-07-11 02:13:36 +0000