summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)Author
2016-05-26loplugin:unusedreturntypesNoel Grandin
and clean up the python script Change-Id: I0a7068153290fbbb60bfeb4c8bda1c24d514500f Reviewed-on: https://gerrit.libreoffice.org/25439 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-26tdf#97831 unit test document for new Excel2016 functionsWinfried Donkers
Change-Id: I9bd1a74d39a66fd3fee56350af5c7c9a4359be93 Reviewed-on: https://gerrit.libreoffice.org/25457 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-05-25remove now moot comment, tdf#86282 follow-upEike Rathke
Change-Id: I7e720de93a5f47ca6a81addbb75c113dc2fe53f0
2016-05-25add DVARP test caseZdeněk Crhonek
Change-Id: I8b591ce8a96484df9a2c7e570227f75f80732e34 Reviewed-on: https://gerrit.libreoffice.org/25461 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-05-25tdf#86282 switch to base name sheet name again for external references CSVEike Rathke
... now that we can handle both, a base name and Sheet1 name. For the following reasons: * Since 4.3 we write and expect the base name as sheet name for CSV. While 43030487c45f49bccdfad987c60d9483b938ebac switched that back to Sheet1 or its equivalent to be able to load older documents, a mixed environment of earlier and later versions gets confused by this. * The name Sheet1 can be localized and even customized by the user and thus fails to update/refresh in a different localized or customized environment. This also was already the case for all versions prior to 4.3 but apparently wasn't recognized or brought in connection with some possible failures when updating externally referenced CSV files. * Deriving the sheet name to be stored from the base name prevents all problems related to localized or customized environments, and keeps interoperability with all versions from 4.3 on. Change-Id: I8d71b3ad6370747115ea419a21094b649326642c
2016-05-25add DVAR test caseZdeněk Crhonek
Change-Id: I1e7e86ec28138453a56170d7bc40076708930c0b Reviewed-on: https://gerrit.libreoffice.org/25460 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-05-25tdf#86282 handle both, base name and Sheet1, as external reference sheet nameEike Rathke
While 43030487c45f49bccdfad987c60d9483b938ebac fixed things for older 'name.csv'#Sheet1.A1 references, loading documents that meanwhile stored 'name.csv'#name.A1 lead to #REF! when the external links were updated. Now recognize both, the base file name and Sheet1 name and set up one as the alias of the other, so both variants can be handled. Change-Id: Ie9314e11be19c3316a06e10583777e2d5f5ec1b8
2016-05-25Resolves: tdf#98895 range search crashes open office if range is nullCaolán McNamara
Change-Id: I12cf1045e1fd606cff58b68254eaf5cba6dee838
2016-05-25(nearly) nothing uses GetUniqueId anymore, so remove it.Caolán McNamara
The odd one out is the usage in Formula, which attempts to restore focus to a particular window identified by an unique id. In this case restore focus by keeping a VclPtr to the desired window. Change-Id: I1dc335325c109d75745c6bba2e12662e6ae50638
2016-05-25SWITCH returns error if compared value contains an error, tdf#97831 follow-upWinfried Donkers
Partial revert of commit a2aea8bac55cef23297573733ba28f563f5aa791 Change-Id: Ia059dd434a52e959495c0ea6ffc47e68df7a474a Reviewed-on: https://gerrit.libreoffice.org/25165 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-05-25correct description of range argument of MINIFS and MAXIFSStanislav Horacek
Change-Id: Ie319836f1d916d3a53237fdbc80d6530a000afa9 Reviewed-on: https://gerrit.libreoffice.org/25256 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2016-05-25use consistent case for argument names of IFS functionStanislav Horacek
Change-Id: I19480507e90df46deee15a6a4e80b0fcd6a9c70d Reviewed-on: https://gerrit.libreoffice.org/25254 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-05-25Convert SC_MF to scoped enumNoel Grandin
Change-Id: I3089006b502e33710bfb2564f051ebf2892ad08a Reviewed-on: https://gerrit.libreoffice.org/25085 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-25add DSUM test caseZdeněk Crhonek
Change-Id: I0afb85a16f1128542eae5e966ac0d98f1d66861e Reviewed-on: https://gerrit.libreoffice.org/25414 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-05-25DCOUNT test case - one more testZdeněk Crhonek
Change-Id: Id4753112ec287f185440d1fd6f231841c944daec Reviewed-on: https://gerrit.libreoffice.org/25413 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-05-24Resolves: tdf#99733 don't crash on moving range of cellsCaolán McNamara
Change-Id: Ib9afc8ef292e517954b24321100862f5235290e5 Reviewed-on: https://gerrit.libreoffice.org/25405 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-05-24convert PIVOT_FUNC to scoped enumNoel Grandin
Change-Id: I6d50ad6fa0dbe7b21ad73e14dc2df3c854d08153 Reviewed-on: https://gerrit.libreoffice.org/25076 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2016-05-24Revert "remove some manual ref-counting"Noel Grandin
until I have a better understanding of the UNO reference counting. This reverts commit 111de438ea3e512a541281dc0716cc728ea8d152.
2016-05-24loplugin:unusedmethods in scNoel Grandin
Change-Id: Ic378126a30be853d10fe174c451cee3c6ded404f Reviewed-on: https://gerrit.libreoffice.org/25109 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-24remove some manual ref-countingNoel Grandin
triggered when I noticed a class doing acquire() in the constructor and then release() in the destructor. found mostly by git grep -n -B5 -e '->release()' Change-Id: Ie1abeaed75c1f861df185e3bde680272dbadc97f Reviewed-on: https://gerrit.libreoffice.org/25363 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-24add DSTDEVP test caseZdeněk Crhonek
Change-Id: I263ed01d155c5939ff52487bcf0920acab4c1e5c Reviewed-on: https://gerrit.libreoffice.org/25374 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-05-24add DSTDEV test caseZdeněk Crhonek
Change-Id: Ie7a597ec7799d4e6fcba760b5cd2e20ead53601a Reviewed-on: https://gerrit.libreoffice.org/25371 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-05-23Resolves: tdf#86282 do not use file name as sheet name for linked documentsEike Rathke
... and external references. Change-Id: I6e23eeff39086091f13914a3f964aec1016a7de4
2016-05-23Add DPRODUCT test caseZdeněk Crhonek
Change-Id: I45e813bfaa3b52fc6bc19382c31bc63b7ecdc9f1 Reviewed-on: https://gerrit.libreoffice.org/25323 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-05-23Convert SbxClassType to scoped enumNoel Grandin
Change-Id: I48afcdd9924d22b52a8db21aa253061e4d38c85b Reviewed-on: https://gerrit.libreoffice.org/25259 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-23clang-tidy clang-analyzer-deadcode.DeadStoresNoel Grandin
Change-Id: I7113a13ac36db5beef3a17e9849c1f5506df2374 Reviewed-on: https://gerrit.libreoffice.org/25194 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-22Convert XOUTBMP to scoped enumNoel Grandin
Change-Id: I8d10cdc78ca73d86bdc9aa08fca591f6eb85eb9e Reviewed-on: https://gerrit.libreoffice.org/25196 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-22add DMIN test caseZdeněk Crhonek
Change-Id: I6d7f8797609a466a8b01973a72453be27b6a1dae Reviewed-on: https://gerrit.libreoffice.org/25294 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-05-21add DMAX test caseZdeněk Crhonek
Change-Id: I954b556df5f3423bd3219d4b09d7548b320077fe Reviewed-on: https://gerrit.libreoffice.org/25248 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-05-21add DGET test caseZdeněk Crhonek
Change-Id: I9291ecebd47828a42ebb1fda027cadbf3738bd56 Reviewed-on: https://gerrit.libreoffice.org/25247 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-05-21add test for tdf#99947Markus Mohrhard
Change-Id: Ieede4a60587bf6a4d570761e0cf5fc59b74f9912
2016-05-21use CONV_XL_OOX for xlsx export, related tdf#99947Markus Mohrhard
Change-Id: Iff6ba46600a55a93eaa1f076b96bb18dec779f0e Reviewed-on: https://gerrit.libreoffice.org/25230 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-05-21use correct separator for ScRangeList, tdf#99947Markus Mohrhard
Change-Id: I2ee291207e899e9d64879176714f12d56dc69112 Reviewed-on: https://gerrit.libreoffice.org/25229 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-05-21disable the test that crashes windowsMarkus Mohrhard
Change-Id: I8f0f4dbc6453d7b9e00aba1399231a83b01668c2
2016-05-21document findings on external range reference handlingEike Rathke
Change-Id: Ib9f3bdb41d8fc8b3c370508675b39a331f5ba0a1
2016-05-21handle external references in CompareMat() as matrixEike Rathke
Change-Id: I1ab606bd1df0cea8ebbc14f70702423506bb8c70
2016-05-20add dcounta test caseZdeněk Crhonek
Change-Id: If6f7a21d2a80e07d14c011bd5cf8978e287ec4fc Reviewed-on: https://gerrit.libreoffice.org/25199 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-05-20unit test for unresolved external references, tdf#93101Eike Rathke
Change-Id: I02d948206aeba56a8d825646eeef0fcbf6e9b505
2016-05-20handle svExternalDoubleRef just the same as svMatrix in MATCHEike Rathke
Change-Id: Ibd2b6fcc2be85948a7e228494e4e388e79c1e9ab
2016-05-20Fix CopyPasta in MAXIFS range descriptionOlivier Hallot
Change-Id: Ibbf97ec006f1fbe95eff189035b0ee4c70f5586d Reviewed-on: https://gerrit.libreoffice.org/25205 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-05-20use vector replication for single row/column arraysEike Rathke
... also in GetStringFromMatrix() and GetDoubleOrStringFromMatrix(), not only in GetDoubleFromMatrix(). Change-Id: Idb4bd7d7ed7574cf80d2998d1e5bfa5a6015b833
2016-05-20always use GetNewMat() in interpreter context instead of plain ScFullMatrix()Eike Rathke
... so error handling interpreter is set and im-/mutable flagged correctly. Change-Id: I3e2647b6e4a4f4bcfdf7264d6942844941ea6c6b
2016-05-20handle svExternalDoubleRef in all IS*() functions, tdf#93101 relatedEike Rathke
Change-Id: I48813de703ea926b8828f4e262393f7643216989
2016-05-20handle svExternalSingleRef in all IS*() functions, tdf#93101 relatedEike Rathke
Change-Id: I14181dd2dbb5d412e3dd165dcbf7468cb8ea8b21
2016-05-20Fix typo in codeAndrea Gelmini
Change-Id: Idc46b1973afc1a3af5b48d53b0cec1a6bb924c92 Reviewed-on: https://gerrit.libreoffice.org/25184 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2016-05-20tdf#93101 handle svExternalSingleRef in ISERROR()Eike Rathke
Change-Id: I9e2a4aeb16d6777153d2f47a1c1af68fe2e97780
2016-05-20tdf#93101 correctly resolve svExternalSingleRef token in GetMatrix()Eike Rathke
... including error propagation, and use GetNewMat() instead of a plain ScFullMatrix so the interpreter error handling is set up. Change-Id: I862c46f9afc2afd0bb2a23aa767158e0945583a5
2016-05-20tdf#93101 propagate external reference error from refcache tokenEike Rathke
Change-Id: I90491a7b18fddaddb3bbb4d7a3f8b9555b9b1198
2016-05-20convert SC_COMPILER to scoped enumNoel Grandin
Change-Id: Ib8fdce056847b2b2514f61da18c106bb3e78631c Reviewed-on: https://gerrit.libreoffice.org/25079 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-20clang-tidy misc-assign-operator-signatureNoel Grandin
Change-Id: I2953a88d9e2f5923732865ef17615d5928ac5f5f Reviewed-on: https://gerrit.libreoffice.org/25154 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>