summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)Author
2016-10-05Remove _TYPED suffix from tools/link.hxx macrosStephan Bergmann
...which was introduced with 3ead3ad52f9bb2f9d1d6cf8dfc73a0a25e6778ed "Gradually typed Link" to distinguish the new, typed versions from the old, untyped ones, but is no longer necessary since 382eb1a23c390154619c385414bdbe6f6e461173 "remove untyped Link<>" removed the old versions. Change-Id: I494025df486a16a45861fcd8192dfe0275b1103c
2016-10-04Actually this should check for the top shared cell.Kohei Yoshida
To be extra cautious. Change-Id: I667d01dd82d957a0203a15602d9a2dacf7dc7e83
2016-10-05Pivot tables: Fix wrong group field number in cacheTamás Zolnai
getCache should not append new group fields to the cache, but use those which are stored in the dimension data. Change-Id: I2011b0d3a22644a86c31500d74469b9c4c641649
2016-10-05Test XLSX import of number groupsTamás Zolnai
Change-Id: I12a8f301607240684676c5b50bdad0eea0923f97
2016-10-05Test XLSX import of date groupsTamás Zolnai
Change-Id: I25cd7e946231a718ca1c0ed64fb5e32b2a81abe8
2016-10-04these helpids go nowhereCaolán McNamara
Change-Id: Ib8938ac69227b99434fa4ab05c460cc44a96e4fd
2016-10-04unused bitmap resourceCaolán McNamara
Change-Id: If7ca172846ee958e51c8648a425cf646e03f8826
2016-10-04can now remove both PopupContainer copiesCaolán McNamara
the recently unused svx one, and the forgotten not-built sfx2 one Change-Id: I1a4ede49dc74bb71f250ee3eee999d1a3dfbee57
2016-10-04These are just floating windows, no need for all the special intrastructureCaolán McNamara
get rid of the roundabout way that these popups are popup controllers (of a kind) for real popups for the moment keeping them as loaded from resources Change-Id: I083e8609ab133e3dc4a036daf8bfb44c08a6719f
2016-10-04remove PopupControl as an intermediate stepCaolán McNamara
Change-Id: I31438860511af6ae00bf7a94fb29326c3ed1a10c
2016-10-04coverity#1371197 the compiler defaults should be sufficient hereCaolán McNamara
Change-Id: I4230d03dc58027f958d8943c0ff90f00508f7386 Reviewed-on: https://gerrit.libreoffice.org/29523 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-10-04pNewPattern can never be null hereStephan Bergmann
Change-Id: I87d66bca7b9399e0268eb2fb4c1dfa51d4461fa2
2016-10-04Avoid UBSan "reference binding to null pointer"Stephan Bergmann
...at least during JunitTest_sc_unoapi_2 at > ScTable::DoSubTotals(ScSubTotalParam&) sc/source/core/data/table3.cxx:2097:25 > ScDocument::DoSubTotals(short, ScSubTotalParam&) sc/source/core/data/documen3.cxx:761:104 > ScDBDocFunc::DoSubTotals(short, ScSubTotalParam const&, bool, bool) sc/source/ui/docshell/dbdocfun.cxx:1076:29 > ScCellRangeObj::applySubTotals(com::sun::star::uno::Reference<com::sun::star::sheet::XSubTotalDescriptor> const&, unsigned char) sc/source/ui/unoobj/cellsuno.cxx:5868:15 > gcc3::callVirtualMethod(void*, unsigned int, void*, _typelib_TypeDescriptionReference*, bool, unsigned long*, unsigned int, unsigned long*, double*) bridges/source/cpp_uno/gcc3_linux_x86-64/callvirtualmethod.cxx:77:5 > cpp_call(bridges::cpp_uno::shared::UnoInterfaceProxy*, bridges::cpp_uno::shared::VtableSlot, _typelib_TypeDescriptionReference*, int, _typelib_MethodParameter*, void*, void**, _uno_Any**) bridges/source/cpp_uno/gcc3_linux_x86-64/uno2cpp.cxx:241:13 > bridges::cpp_uno::shared::unoInterfaceProxyDispatch(_uno_Interface*, _typelib_TypeDescription const*, void*, void**, _uno_Any**) bridges/source/cpp_uno/gcc3_linux_x86-64/uno2cpp.cxx:431:13 > binaryurp::IncomingRequest::execute_throw(binaryurp::BinaryAny*, std::__debug::vector<binaryurp::BinaryAny, std::allocator<binaryurp::BinaryAny> >*) const binaryurp/source/incomingrequest.cxx:240:13 > binaryurp::IncomingRequest::execute() const binaryurp/source/incomingrequest.cxx:77:26 > request binaryurp/source/reader.cxx:85:9 > cppu_threadpool::JobQueue::enter(long, bool) cppu/source/threadpool/jobqueue.cxx:107:17 > cppu_threadpool::ORequestThread::run() cppu/source/threadpool/thread.cxx:165:31 > threadFunc include/osl/thread.hxx:185:15 > osl_thread_start_Impl(void*) sal/osl/unx/thread.cxx:240:9 > start_thread (/lib64/libpthread.so.0+0x75c9) > __clone (/lib64/libc.so.6+0x102f6c) pStyle can apparently be null, will get passed through to ScColumn::ApplyStyle (sc/source/core/data/column.cxx), where it is only used in pNewPattern->SetStyleSheet(const_cast<ScStyleSheet*>(&rStyle)); and which is apparently fine with a null argument. Change-Id: I13fbb092aab06960d820c605476b2cee58889be4
2016-10-04tdf#93894: Add unit test for this.Kohei Yoshida
Change-Id: Ifd38b9fde776d9be48e776972993856cfe59b477 Reviewed-on: https://gerrit.libreoffice.org/29515 Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> Tested-by: Kohei Yoshida <libreoffice@kohei.us>
2016-10-04tdf#93894: Get column labels to work with formula groups.Kohei Yoshida
Change-Id: Ia2a09981dceae2e9809c76570300de8ca1927c1b Reviewed-on: https://gerrit.libreoffice.org/29514 Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> Tested-by: Kohei Yoshida <libreoffice@kohei.us>
2016-10-04Add a bit more description here.Kohei Yoshida
We are creating a formula string using the tokens from the previous cell to see what it would look like if the current cell was grouped with it, then perform string comparison to evaluate for grouping. Change-Id: I29b780d44bec16c0b42990837b70435e059c7594 Reviewed-on: https://gerrit.libreoffice.org/29516 Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> Tested-by: Kohei Yoshida <libreoffice@kohei.us>
2016-10-03Reverse the boolean logic.Kohei Yoshida
To have the 'true' value associate with action and 'false' with inaction. Change-Id: Icf61b1cb8642a72390d1f2aa45ca25fb67ec0dbd
2016-10-03add INTERCEPT test caseZdeněk Crhonek
Change-Id: I87038e7f0a33e81815591765550dc08944d7eb3d Reviewed-on: https://gerrit.libreoffice.org/29505 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-10-03set translatable attributes in .ui filesAndras Timar
Change-Id: Idcdf9fbbc6b980a376fc0b5d607cbb48aa1dc5f1 Reviewed-on: https://gerrit.libreoffice.org/29503 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2016-10-03add LARGE test caseZdeněk Crhonek
Change-Id: Id60b843887a9b55fa72bb26199972e32c2ab2ebb Reviewed-on: https://gerrit.libreoffice.org/29507 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-10-03add KURT test caseZdeněk Crhonek
Change-Id: Ie1f469eebaf85cbb0a519d43e300353dff68922e Reviewed-on: https://gerrit.libreoffice.org/29506 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-10-03Resolves: tdf#101711 problems with attempt to remove unused bg imagesCaolán McNamara
only do the save, unset (and possibly restore) of a bg image on the stylesheet if it has one owner, this continue to make the original scenario function without (so far anyway) the various reported problems Change-Id: I73382961973b1c53bf2ceff205615727dd378c77
2016-10-03loplugin:vclwidgetsCaolán McNamara
Change-Id: If31494809ba8ce0028a15a88cf1bb2ead2769701
2016-10-03LOK: Calc: clear cell background in other views on editingMarco Cecchetti
Change-Id: Ia61bcdf7db0994b6681607403c56be707a9f17d9 Reviewed-on: https://gerrit.libreoffice.org/29456 Reviewed-by: Marco Cecchetti <mrcekets@gmail.com> Tested-by: Marco Cecchetti <mrcekets@gmail.com> (cherry picked from commit 1922c8b1d46e0067ed21a18d249f04da6f3b0160) Reviewed-on: https://gerrit.libreoffice.org/29489
2016-10-03Calc LOK: clear cell background when editing in parallelAshod Nakashian
Change-Id: Id8eccf00ec6555d62c49e06130e3aa3a0eaaddea Reviewed-on: https://gerrit.libreoffice.org/29450 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com> (cherry picked from commit b16ba7314ef93b657dea4d6dd676b2dfd265bcaa) Reviewed-on: https://gerrit.libreoffice.org/29486 Reviewed-by: Marco Cecchetti <mrcekets@gmail.com> Tested-by: Marco Cecchetti <mrcekets@gmail.com>
2016-10-03Calc: fixed bug in parallel cell editingMarco Cecchetti
The background color by the wrong edit view was used causing a segmentation fault. Change-Id: Ife489989e382d6f4f905f0ca305928e64bbce588 Reviewed-on: https://gerrit.libreoffice.org/29415 Reviewed-by: Marco Cecchetti <mrcekets@gmail.com> Tested-by: Marco Cecchetti <mrcekets@gmail.com>
2016-10-03Calc: implemented parallel cell text editingMarco Cecchetti
Change-Id: If8cc7a637cee6ba66813d55b25160fee13a2a219 Reviewed-on: https://gerrit.libreoffice.org/29410 Reviewed-by: Marco Cecchetti <mrcekets@gmail.com> Tested-by: Marco Cecchetti <mrcekets@gmail.com>
2016-10-03Calc: edit engine could be accessed after being destroyedMarco Cecchetti
ScTabView <---------------- ScTabViewShell +ScViewData +ScInputHandler +EditView[4] +EditEngine +ImpEditEngine +vector<pointer<EditView>> On tab view shell destruction: ~ScTabViewShell -> ~ScTabView -> ScViewData::KillEditView -> EditEngine::RemoveView but it occurs after the following: ~ScTabViewShell -> ~ScInputHandler -> ~EditEngine since data members are destroyed before ancestor classes. Change-Id: Ida56b8009c0d8a3cd23952259d78318e96ae5124 Reviewed-on: https://gerrit.libreoffice.org/29409 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
2016-10-03LOK - when a view is enabled, the existing edit views are killedMarco Cecchetti
A view is notified about killing its own edit view, if any, in 4 cases: - before being deactivated - soon after being activated - when a 'cursor position changed' event occurs in any view - when a 'selection changed' event occurs in any view Now these notifications are skipped when LOK is active. Change-Id: I94020987a35b1450ec41e2fa5fcce8cfa7e92130 Reviewed-on: https://gerrit.libreoffice.org/28948 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
2016-10-03Use closure to simplify use of for_each.Kohei Yoshida
Change-Id: I4bca7bec32e194418b811244cbfb8a3ab4c0cdfa Reviewed-on: https://gerrit.libreoffice.org/29465 Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> Tested-by: Kohei Yoshida <libreoffice@kohei.us>
2016-10-03Avoid pointless single-line wrapper for OpenCL isnan()Tor Lillqvist
Change-Id: I4056a1afac1413616a06d0b2f03d4bdead6cad10
2016-10-03remove anchor test from the conditional format API testMarkus Mohrhard
Change-Id: Ifcbcdf03d0d178f865c156fc8a6299741f814bc2 Reviewed-on: https://gerrit.libreoffice.org/29460 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-10-03coverity#1373353 Uninitialized scalar fieldCaolán McNamara
Change-Id: Ifc65e3fbc2dd076f322482459f4ad96745f64882
2016-10-03add more dumpAsXml()Noel Grandin
and make it format the output nicely, so I don't have to use 'xmllint --format' before I can read it. Change-Id: I065ee93193f3c6c7bab87212ab96021fb0d7c5ed Reviewed-on: https://gerrit.libreoffice.org/29407 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-02add test for tdf#77873Markus Mohrhard
Change-Id: Ifd16c51029d2aa4deda0370f4d2867ed9c9e53d9 Reviewed-on: https://gerrit.libreoffice.org/29461 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-10-02support TargetFrame in url field import/export code, tdf#77873Markus Mohrhard
Change-Id: Id09ecbd10b8ee60371f223d62f2dd6fe1c2296ca Reviewed-on: https://gerrit.libreoffice.org/29459 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-10-02tdf#90937 Add a set of cell styles to calcJaskaran Singh
The styles that are are added by this commit were created by the design team. Special thanks to Yousuf Philips and Mattiaz Poldaru for taking initiative. These styles have been taken from the attachment posted on the bugzilla thread. A few necessary lines have been added to make it work. Change-Id: I7503ea9114e3908a4007a5e5d6a09486a32a3674 Reviewed-on: https://gerrit.libreoffice.org/29364 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jaskaran singh <jvsg1303@gmail.com>
2016-10-01Dump the stored formula results for debugging.Kohei Yoshida
Change-Id: Ib9edd7e8d61d7a83191e4848fea47b7c9b1b1766
2016-10-01Fix typosAndrea Gelmini
Change-Id: I9701cc93a9f4315e71c133237fdd96ef6964c8ff Reviewed-on: https://gerrit.libreoffice.org/29438 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-01Fix typosAndrea Gelmini
Change-Id: Icfc61fcc5ace717bca4bea988243674afe31e6f8 Reviewed-on: https://gerrit.libreoffice.org/29435 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-01add test for tdf#101910Markus Mohrhard
Change-Id: I3c0b98655a0a7a32e9022ce44a007d2303590e56 Reviewed-on: https://gerrit.libreoffice.org/29423 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-10-01avoid coverity#1371264 Missing move assignment operatorCaolán McNamara
Change-Id: I5085b0a04cf24b8d4678165371e44dc3556300e3
2016-10-01tdf#101910, mark ScRangeList updated when DeleteArea was usedMarkus Mohrhard
Change-Id: I98390b28c5a1bbbd391ff054b2f574951c7c00c4 Reviewed-on: https://gerrit.libreoffice.org/29422 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Jenkins <ci@libreoffice.org>
2016-09-30add RATE test caseZdeněk Crhonek
Change-Id: Id7da3c3e11ce05c2630d7ac6e9c715a92e554bb4 Reviewed-on: https://gerrit.libreoffice.org/28885 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-09-30add CONCAT test caseZdeněk Crhonek
Change-Id: Iea1601b8bb5979a10288cc1e768026b2388722df Reviewed-on: https://gerrit.libreoffice.org/29403 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-09-30add CHAR test caseZdeněk Crhonek
Change-Id: Ifb0eee3e011b66154fb74e729ae912f6a7f0b278 Reviewed-on: https://gerrit.libreoffice.org/29247 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-09-30fix perf bug (I think)Noel Grandin
In commit 93160bcb2dce54bbccb5935cd0a71b52ad5e5461 "convert PAINT constants to typed_flags", I removed two lines of code (based on faulty analyis), which appears to have caused a performance regression in the "ILmr" test Bug noticed and tracked down by Jochen Nitschke, I'm just testing and committing. Change-Id: I1c7dfc305765f7b20458421680f776a4a9324281
2016-09-30loplugin:constantparamNoel Grandin
Change-Id: Idbe8c8e6b3d44cacce296ec8c79b2b244281057c Reviewed-on: https://gerrit.libreoffice.org/29321 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-29reorg FillItemDataCaolán McNamara
Change-Id: Ia70bf1c7fb4bf524b92c3f97103cd74bccf46822
2016-09-29LOK: conditionally include part number in invalidation payloadMiklos Vajna
Since desktop/ code queues, compresses and only emits callbacks on idle, it's possible that two invalidations are in the queue, and there was a setPart() call between them. In this case it's impossible to tell what part the invalidation was sent for. Fix this by conditionally including the part number in the invalidation payload. It's off by default, a new feature flag is added to request this behavior. gtktiledviewer enables this feature flag by default, though just to show the part number in the debug output. Android doesn't enable it. Change-Id: I73e6def848c0eb61d64e71026002c7a0e750aab4
generated by cgit (git 2.34.1) at 2024-08-01 12:04:38 +0000