summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)Author
2018-09-30weld SvxLineEndDefTabPageCaolán McNamara
Change-Id: I3e947511bbffae4cd48388b17a8fb9a13d453bab Reviewed-on: https://gerrit.libreoffice.org/61139 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-30ofz#10406 fuzzing oomCaolán McNamara
reduce repeated allocations totalling 2.944G worth of allocations to 877.4M, peak usage remains unchanged at 4.2M Change-Id: I9840bdb25a72021f6085fa318b51a687d5f36149 Reviewed-on: https://gerrit.libreoffice.org/61155 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-29tdf#111980 sc optionbutton autoGroups different for form/activeXJustin Luth
This patch only affects calc. (Perhaps .xls* is the only format that supports non-activeX radio buttons?) Commit 9f969799629fe6bdf8b922d8cb922846aa646ece worried about form and activeX buttons sharing the autoGroup_. This patch prevents that. Change-Id: Ia57a14f1cdd6363aa5d6d991469668fcc56016ca Reviewed-on: https://gerrit.libreoffice.org/61095 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2018-09-28Added base as a data providerVikas
Change-Id: Iaf23b70f303cd05bcf6450fed1246de894285526 Reviewed-on: https://gerrit.libreoffice.org/57447 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-09-28weld ScStyleDlgCaolán McNamara
Change-Id: I67e6a6cd1f0b018012c3a373c856494c4fc02979 Reviewed-on: https://gerrit.libreoffice.org/61048 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-28weld ScAttrDlgCaolán McNamara
Change-Id: I11eb9001604a1997a8bfa80a144306ddcb913d93 Reviewed-on: https://gerrit.libreoffice.org/61011 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-28weld SvxNumberFormatTabPageCaolán McNamara
Change-Id: Ia6e6497d5c9b6c47e34e5cb5b3913d25e73c3a69 Reviewed-on: https://gerrit.libreoffice.org/60944 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-28loplugin:unusedmethodsNoel Grandin
Change-Id: I5f9ef043d76c55f2c761fd08a2bc1dae66b675c8 Reviewed-on: https://gerrit.libreoffice.org/61073 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-28tdf#111980 oox: connect empty radio groupsJustin Luth
affects doc, docx, xls, xlsx (at least). Handling optionbutton groups is new since 2017, so incremental enhancements are OK. In LO, if an option button with an empty groupName (like any form control which has no groupName option), then it stands alone, which is a ridiculous position to be in for a radio button. So, lets put them all together into an automatic group. In MSO, buttons without any explicit group stick together, so the effective group is the entire document, or entire sheet. One complication is that ActiveX radio buttons don't interact with Form radio buttons, even if all of them have no group name. That situation is not handled by this patch (and not very likely to happen since ActiveX defaults the group name to the sheet name). (A Group Box can also be used, which automatically groups all buttons fully within its area. That will be much harder to implement since every object will need to first be categorized as groupbox or optionControl - meaning that everything must first be imported. That implies a function call from every application doing the import.) Change-Id: I204adaea75ce99999a16c0cc4e9c3b8b08da9433 Reviewed-on: https://gerrit.libreoffice.org/61064 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2018-09-28loplugin:unusedfieldsNoel Grandin
Change-Id: I355fad84ed8765e8eb3fadb7c239b3b902ec1747 Reviewed-on: https://gerrit.libreoffice.org/61059 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-28loplugin:useuniqueptr in ScChartPositionMapNoel Grandin
Change-Id: I7c3209dff1c09c40d7a3bb57db0f0b26254318f2 Reviewed-on: https://gerrit.libreoffice.org/60996 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-28loplugin:useuniqueptr in ScDPResultTree::MemberNodeNoel Grandin
Change-Id: I835e37a99ddab174e45681fe6cf55edaa41a727c Reviewed-on: https://gerrit.libreoffice.org/60995 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-27UND->AND; ODER->ORMike Kaganski
Change-Id: I921db377c257dc50e3f39fe04f0ad093f3db6a81 Reviewed-on: https://gerrit.libreoffice.org/59896 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2018-09-27weld ScTablePageCaolán McNamara
Change-Id: I38d86705de3215a7e8c24f03c2d253751e66b2d8 Reviewed-on: https://gerrit.libreoffice.org/61040 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-27coverity#1439332 silence Identical code for different branchesCaolán McNamara
Change-Id: I9f477e063fd764fff24843562a2de34b5498d4c5 Reviewed-on: https://gerrit.libreoffice.org/61038 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-27loplugin:methodcycles more graph theory for the winNoel Grandin
implemeent a reduction approach, which is good at finding virtual methods that only themselves or their virtual partners. The accessibility GetVisArea stuff is dead since commit 891e41fac81fbd8d5cdb277b26639abfd25a7143 Date: Wed Apr 4 11:23:22 2018 +0200 dead code in AccessibleTextHelper_Impl::UpdateVisibleChildren Change-Id: I78d9d8bca585ecec8394f2c3fe2baa93db0e58f5 Reviewed-on: https://gerrit.libreoffice.org/60912 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-27loplugin:useuniqueptr in ScTable::FillAutoNoel Grandin
Change-Id: Ia75a0dc9aa567b00517c066a65e4a0d1536fa9bd Reviewed-on: https://gerrit.libreoffice.org/60999 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-27loplugin:useuniqueptr in Chart2PositionMapNoel Grandin
Change-Id: I6db63c66da67fa9133333b4d0cda2b2978140e77 Reviewed-on: https://gerrit.libreoffice.org/60998 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-27loplugin:useuniqueptr in ScAddInAsyncsNoel Grandin
Change-Id: I18086623378a6ffd9272b2255ea8060d301b6c43 Reviewed-on: https://gerrit.libreoffice.org/60997 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-26fix positioning within cellprotectpageCaolán McNamara
Change-Id: I9ae7fd7f6ff7b999018cc0ba13147dd69dc7e9ae Reviewed-on: https://gerrit.libreoffice.org/61010 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-25loplugin:useuniqueptr in SdrHdlListNoel Grandin
Change-Id: I83241bd2ed172594704f4b115b584dc39b234086 Reviewed-on: https://gerrit.libreoffice.org/60959 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-24tdf#42949 Fix IWYU warnings in include/comphelper/[a-l]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I22ba2c8aec235e34cd7835b8a0a716bf3057db7a Reviewed-on: https://gerrit.libreoffice.org/60837 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-09-24make all the related inheritences formatted the same wayCaolán McNamara
Change-Id: I2e0c060a86cd199a640589a7599fa5f01ef77e3b Reviewed-on: https://gerrit.libreoffice.org/60943 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-24weld ScTabPageProtectionCaolán McNamara
Change-Id: I85fa703ebe73987822f85ff722f02627751937ec Reviewed-on: https://gerrit.libreoffice.org/60909 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-24coverity#1438870 Big parameter passed by valueCaolán McNamara
Change-Id: I6ade72ed19b63b7f68c8f58c57bb409eab55e55c Reviewed-on: https://gerrit.libreoffice.org/60919 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-22tdf#45904 Move _XIndent Java Tests to C++Rahul Gurung
Change-Id: I65b594db595f0e08a50a9ea18baf44c496cf18e3 Reviewed-on: https://gerrit.libreoffice.org/60218 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-09-22Added Date and Time Transformation in data provider dlgManuj Vashist
Change-Id: Iead6b030d54983d08543656d2b62e42ba38b946e Reviewed-on: https://gerrit.libreoffice.org/58912 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-09-21coverity#1438870 Big parameter passed by valueCaolán McNamara
Change-Id: If170645fa09ffc41948d1770df65b38d35a3f71e Reviewed-on: https://gerrit.libreoffice.org/60856 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-21coverity#1401334 Uncaught exceptionCaolán McNamara
Change-Id: I2a74e0bcba46b730067b5baca5e934f95ba265ce Reviewed-on: https://gerrit.libreoffice.org/60854 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-21unused returnsCaolán McNamara
Change-Id: Ic5828b37951ed649a3d9abc18e1d44b979208d9b Reviewed-on: https://gerrit.libreoffice.org/60855 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-20Resolves: tdf#119954 do not copy the old parent, init with new parent insteadEike Rathke
The parent is always the ScDBCollection that contains the ScDBCollection::NamedDBs container, not the one the ScDBCollection::NamedDBs was copy-constructed from. Change-Id: Ia409347f3aeb9ad7a5e68da7af727adfac98d6a2 Reviewed-on: https://gerrit.libreoffice.org/60833 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2018-09-20weld header/footer SingleTabDialogCaolán McNamara
Change-Id: Ifbe3be21e3cd792a22fe0797076f1402bb736de6 Reviewed-on: https://gerrit.libreoffice.org/60820 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-20Replace SAL_OVERRIDE with override in internal codeStephan Bergmann
Change-Id: Ifa446647b11fd1f1b0dc6a991b752480545634db Reviewed-on: https://gerrit.libreoffice.org/60788 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-09-19Removed duplicated includeAndrea Gelmini
Change-Id: I4e499da70bc1f5656c49dba7c9261a6082b131bc Reviewed-on: https://gerrit.libreoffice.org/60635 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-09-19Avoid unused function in the !HAVE_FEATURE_SCRIPTING caseTor Lillqvist
Change-Id: I5ef5c1ce2be3de7390322a4f4f7b78a484fd7396
2018-09-19tdf#113235 - new attempt: More useful description for Calc option "Use legacyCor Nouws
cursor movement behavior when selecting" - thanks to the UX meeting for coming up with the solution Change-Id: Id400bcd83b77cab154d2d6cb82207bfe7e90da98 Reviewed-on: https://gerrit.libreoffice.org/60440 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-09-18weld ScParagraphDlgCaolán McNamara
Change-Id: I861fe82fb3e1f6d8be0a3dd191a27b27b90fbdaf Reviewed-on: https://gerrit.libreoffice.org/60530 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-18sc: Begin with upper case for labels of Number TransformationTakeshi Abe
Change-Id: I28b9af112d48fb6a39b7d61af3b49ee43db957fb Reviewed-on: https://gerrit.libreoffice.org/58953 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2018-09-18executeAction("BACKSPACE") doesn't do anythingCaolán McNamara
tests are working because of the previous ctrl+a Change-Id: Ib44351da1680484c3d4a9d0a8d6cb6ba6002d63b Reviewed-on: https://gerrit.libreoffice.org/60673 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-18loplugin:unusedfields improve search for unused collection fieldsNoel Grandin
look for collection-like fields that are never added to, and are therefore effectively unused Change-Id: Id52c5500ea5e3d2436fb5915aebb86278bf2d925 Reviewed-on: https://gerrit.libreoffice.org/60661 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-18weld ScCharDlgCaolán McNamara
Change-Id: Ie0fe76ef5c5c706007c2285b3a309d92ff4bc2b0 Reviewed-on: https://gerrit.libreoffice.org/60528 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-18Don't prematurely cast to sal_uInt8, to avoid UBStephan Bergmann
...e.g. during UITest_conditional_format (https://ci.libreoffice.org//job/lo_ubsan/1039/): > /sc/source/core/data/colorscale.cxx:524:48: runtime error: value -33.2609 is outside the range of representable values of type 'unsigned char' > #0 0x2b778b7d666d in (anonymous namespace)::GetColorValue(double, double, unsigned char, double, unsigned char) /sc/source/core/data/colorscale.cxx:524:48 > #1 0x2b778b7bd096 in (anonymous namespace)::CalcColor(double, double, Color const&, double, Color const&) /sc/source/core/data/colorscale.cxx:530:25 > #2 0x2b778b7bcb94 in ScColorScaleFormat::GetColor(ScAddress const&) const /sc/source/core/data/colorscale.cxx:625:20 > #3 0x2b778b8906a4 in ScConditionalFormat::GetData(ScRefCellValue&, ScAddress const&) const /sc/source/core/data/conditio.cxx:1830:33 > #4 0x2b778cb8968a in (anonymous namespace)::handleConditionalFormat(ScConditionalFormatList&, std::__debug::vector<unsigned int, std::allocator<unsigned int> > const&, CellInfo*, ScStyleSheetPool*, ScAddress const&, bool&, bool&, bool) /sc/source/core/data/fillinfo.cxx:301:34 > #5 0x2b778cb74e49 in ScDocument::FillInfo(ScTableInfo&, short, int, short, int, short, double, double, bool, bool, ScMarkData const*) /sc/source/core/data/fillinfo.cxx:581:54 > #6 0x2b77941656c0 in ScPrintFunc::DrawToDev(ScDocument*, OutputDevice*, double, tools::Rectangle const&, ScViewData*, bool) /sc/source/ui/view/printfun.cxx:539:5 > #7 0x2b77914e965b in ScDocShell::Draw(OutputDevice*, JobSetup const&, unsigned short) /sc/source/ui/docshell/docsh4.cxx:2032:9 > #8 0x2b76f7004296 in SfxObjectShell::DoDraw_Impl(OutputDevice*, Point const&, Fraction const&, Fraction const&, JobSetup const&, unsigned short) /sfx2/source/doc/objembed.cxx:229:5 > #9 0x2b76f7001b81 in SfxObjectShell::DoDraw(OutputDevice*, Point const&, Size const&, JobSetup const&, unsigned short) /sfx2/source/doc/objembed.cxx:176:9 > #10 0x2b76f6fd8fe3 in SfxObjectShell::CreatePreviewMetaFile_Impl(bool) const /sfx2/source/doc/objcont.cxx:168:5 > #11 0x2b76f6fd618b in SfxObjectShell::GetPreviewMetaFile(bool) const /sfx2/source/doc/objcont.cxx:115:12 > #12 0x2b76f55728ab in SfxPickListImpl::AddDocumentToPickList(SfxObjectShell*) /sfx2/source/appl/sfxpicklist.cxx:134:54 > #13 0x2b76f5576d93 in SfxPickListImpl::Notify(SfxBroadcaster&, SfxHint const&) /sfx2/source/appl/sfxpicklist.cxx:222:17 > #14 0x2b76fc444921 in SfxBroadcaster::Broadcast(SfxHint const&) /svl/source/notify/SfxBroadcaster.cxx:49:13 > #15 0x2b76f4eb062c in SfxEventAsyncer_Impl::IdleHdl(Timer*) /sfx2/source/appl/appcfg.cxx:119:5 > #16 0x2b76f4eaf705 in SfxEventAsyncer_Impl::LinkStubIdleHdl(void*, Timer*) /sfx2/source/appl/appcfg.cxx:114:1 > #17 0x2b7724e683b7 in Link<Timer*, void>::Call(Timer*) const /include/tools/link.hxx:84:45 > #18 0x2b7724e67599 in Timer::Invoke() /vcl/source/app/timer.cxx:77:5 > #19 0x2b7724c40779 in Scheduler::ProcessTaskScheduling() /vcl/source/app/scheduler.cxx:451:13 > #20 0x2b7724c3b168 in Scheduler::CallbackTaskScheduling() /vcl/source/app/scheduler.cxx:270:5 > #21 0x2b7725b02fac in SalTimer::CallCallback() /vcl/inc/saltimer.hxx:55:13 > #22 0x2b7725af43a5 in SvpSalInstance::CheckTimeout(bool) /vcl/headless/svpinst.cxx:206:21 > #23 0x2b7725afbc52 in SvpSalInstance::DoYield(bool, bool) /vcl/headless/svpinst.cxx:418:14 > #24 0x2b7724dafc3b in ImplYield(bool, bool) /vcl/source/app/svapp.cxx:471:28 > #25 0x2b7724d8a3ff in Application::Yield() /vcl/source/app/svapp.cxx:536:5 [...] Change-Id: I1650c2236a183c7b6349be6cb444d350e85ea8b6 Reviewed-on: https://gerrit.libreoffice.org/60654 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-09-17NB sync draw shapes between appsandreas kainz
Change-Id: Ibb1e11eb438607d26ebd06e7fb160cf850915d5b Reviewed-on: https://gerrit.libreoffice.org/60555 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-09-17tdf#42949 Fix IWYU warnings in sc/source/filter/inc/[xX]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I3211d2c8c35320a2e924cfe8bb561c315db4ef5e Reviewed-on: https://gerrit.libreoffice.org/60534 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-09-17Fix typoAndrea Gelmini
Change-Id: Id3f164a5b5016fd7f1e33a0cb9e94ee84c1df6e5 Reviewed-on: https://gerrit.libreoffice.org/60566 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-09-17rename to weld::ComboBox are they are not text only nowCaolán McNamara
Change-Id: Ice26d1fd2ad97a6959c6916fef428777efea9c2d Reviewed-on: https://gerrit.libreoffice.org/60500 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-17loplugin:staticconstfield improvementsNoel Grandin
Change-Id: Ia0a19736dfd4500bb17b04c072710f8ee8744031 Reviewed-on: https://gerrit.libreoffice.org/60526 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-17oovbaapi: hack Excel / OptionButton compatibility into Button for now.Michael Meeks
Change-Id: I22d2d545a6201cbb89d430c65f66e0fea8794d83 Reviewed-on: https://gerrit.libreoffice.org/60541 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2018-09-17add image support to weld::ComboBoxTextCaolán McNamara
Change-Id: Ie7f00ed4aef5318a525a526d0377bb7952bdd5a0 Reviewed-on: https://gerrit.libreoffice.org/60499 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-17cppcheck: variableScope in scJochen Nitschke
Change-Id: I9fe9c042a4990c6399765819f6b8e80c17dba9d2 Reviewed-on: https://gerrit.libreoffice.org/60551 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2024-07-17 00:05:51 +0000