summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)Author
2021-12-22tdf#145057 Fix saving color filter when multiple data ranges in sheetSamuel Mehrbrodt
When mutliple data ranges existed in one sheet, only the first one was considered when exporting color filters. Consider all of them, as any could hold a color filter. Change-Id: I13ae2018057eef7ef24fc8298c814a93df24f74b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127328 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2021-12-22tdf#143582: Avoid error on clearing leftover return value of a methodMike Kaganski
SbxValue::Clear happens to not error out on clearing string and some other types of objects, but for the rest, it calls SbxValue::Put, and the latter errors out if not CanWrite(). The original test implemented in commit 24d24debef4cda7de702c4b470a3707f1aae3ea3 only checked string return value, so happened to miss this problem. See similar code in SbiRuntime::FindElement. Change-Id: I7c17137cc9e7ee3133ee86a9f701559df66e53b6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127248 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-12-22Separate core drawinglayer func. into drawinglayercore libraryTomaž Vajngerl
This separates the drawinglayer core functionallity into a separate library, to keep a strict separation what is backend dependent and what is not. More strict separation can be done at a later date. This will make it possible to push part of drawinglayer (part of processor2d) directly into VCL. Change-Id: Ibc26580067e50bf20d7cdd37fa0e44eb10200878 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127286 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-21Fix formatting (wrong indentation)Samuel Mehrbrodt
Apply clang-format to this method Change-Id: I67fbdc4ca8b9c602ed85a57dbbde8ed47bdd45c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127215 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2021-12-20Recheck include/[e-r]* with IWYUGabor Kelemen
See tdf#42949 for motivation Change-Id: I44e4e3a88067c1c29ce9d563b22741e984b43576 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126964 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-12-19ofz#42605 Null-dereferenceCaolán McNamara
Change-Id: Ief752f20aa3e7672e4ed7f6cd1809ee56a096c43 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127087 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-12-19use more cppu::BaseMutexNoel Grandin
Change-Id: Ida8eb69bb90a2ce53a9a783595b1dc0b0c9f334c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127076 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-18tdf#103331: Add a test case for inherited font weight attributes.Kohei Yoshida
Change-Id: I8ebca3ab492313a3f7aa9019533bbb7eee2e4a89 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127019 Tested-by: Jenkins Reviewed-by: Kohei Yoshida <kohei@libreoffice.org>
2021-12-18Worth an assert (inserting the range name should not fail) not OSL_FAIL()Eike Rathke
Change-Id: I7178d7d9c3e4b86e3fca256031b9ee4de904e5c0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127020 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2021-12-17Fix typosAndrea Gelmini
Change-Id: I7f1636226c4fbe29d9d2ef850318a9d57f1b5450 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127009 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-12-17tdf#146019 Remove confirmation dialog about applying images EXIF rotationGabor Kelemen
Change-Id: I53553f91eeb5bd56bbad19b80421177a84625d96 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126616 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2021-12-17tdf#103331: Make styles attributes optional.Kohei Yoshida
Apply only those that are actually specified. Change-Id: Ib2e090fefe4dbfe3d4fca2b953bcf51d97d9ddec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126901 Tested-by: Jenkins Reviewed-by: Kohei Yoshida <kohei@libreoffice.org>
2021-12-17tdf#58125 sc: don't show comment notifier for hidden columnsJustin Luth
This fixes a LO 3.6-ish regression. Things have changed a lot since then. I assume that pCell was empty when it was hidden. The test for pCell was removed in commit c06dbbe7594c2a0b5a5b19f8e183d9c421e6e094, which was in the range that bibisect suggested. Change-Id: I0af137358335a808de901111a71f5c113fabcf24 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127001 Reviewed-by: Justin Luth <jluth@mail.com> Tested-by: Jenkins
2021-12-16Allow for some variance in results of some more Calc function callsStephan Bergmann
...similar to 04215f03492f6fce83d6bc64491749bf803c389a "Allow for presumably more precices results of some more Calc function calls", this time with gcc-c++-11.2.1-7.fc35.aarch64 and -O2: * row 74: actual 236.965090983394 vs. expected 236.965090983393 * row 75: actual 232.103818773718 vs. expected 232.103818773717 * row 84: actual 226.508770412418 vs. expected 226.508770412417 * row 85: actual 238.902033404946 vs. expected 238.902033404945 Change-Id: I348623fdd5c4c851cd002f1d62c5a8867b32e325 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126950 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-12-16tdf#126565: sc: Add UItestXisco Fauli
Reuse existing test I created earlier this week Change-Id: I4556d64f99a6aa498fc44f19aa2e39ca94b24218 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126918 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-12-16uitest: sc: make sure the tab number existsXisco Fauli
Otherwise, something like gridwin.executeAction("SELECT", mkPropertyValues({"TABLE": "100"})) would create a new tab called Sheet101 Change-Id: I052c68a1881bfe0a32e35a62f5c4f557ef10db8d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126917 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-12-16uitest: remove incorrect passXisco Fauli
Change-Id: If155962b14485b6a6cb812e562c555cabd60ef77 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126911 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-12-16Remove transitional header drawinglayer/primitive2d/polygonprimitive2d.hxxGabor Kelemen
follow up to commit 1103727fb24b368419ea0cfd2382560ef6b82f43 Change-Id: I227042f4703f3f4c18a8dc0355f044d2ad7dfb2b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126838 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-12-16Update liborcus to 0.17.2.Kohei Yoshida
Change-Id: I76c0d57da63c1e35f80b13071793dbbb27cb218a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126655 Tested-by: Jenkins Reviewed-by: Kohei Yoshida <kohei@libreoffice.org>
2021-12-16Resolves: tdf#126565 RefEditModified() preset current sheet for address-onlyEike Rathke
Change-Id: Ifa662a9d55fae10e3e1e3e115c9c5eb10972cbbe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126899 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2021-12-15uitest: sc: fix problematic testXisco Fauli
Change-Id: I3a445f48930e1d6c6f8d59d392bbf87cc9cb2cf6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126858 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-12-15Recheck include/[a-d]* with IWYUGabor Kelemen
See tdf#42949 for motivation Change-Id: I42475b8e75951d5dcae2fe6b0ad0bca64441e7f5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126837 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-12-15tdf#119178: sc: Add UItestXisco Fauli
Change-Id: I8737e95b1d45433168380f1564fe4c61eb4b3641 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126856 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-12-15uitest: simplify codeXisco Fauli
Change-Id: Id3355be0e763217a4915b53d22220c30536415e4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126852 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-12-14Stream::Tell returns sal_uInt64Noel Grandin
Change-Id: I02e49d4f59c17a9868c4111ac91b5dd2715e689c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126630 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-14tdf#124412: sc: Add UItestXisco Fauli
Change-Id: Ic0b8a6f8a8ccc3d63154be607e672e759b862714 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126841 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-12-14make sure text operations are not queried by (numeric) valueLuboš Luňák
E.g. SC_CONTAINS is, according to isPartialTextMatchOp(), a text-only operation, so query it as such and not as a numeric value. This fixes/allows e.g. substring queries on dates. Change-Id: I6c612d9934193828b7a7eabed92f2bfeb385e5a0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126767 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2021-12-14uitest: sc: Add test for the import xml source dialogXisco Fauli
Change-Id: Ic52148788c96a6d37def30145aa0a874d9847a41 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126805 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-12-13related tdf#92010 sc autoformula: ensure proper sorting orderJustin Luth
When typing "=a", autoformula was suggesting ACCRINT,ACCRINTM,ACOS instead of starting with ABS. [This has been true since these 3 suggestions started in LO 5.2.] Prior to this patch, the very first item in the sorted list (ABS) was placed at the end of the suggestion vector. That is because the loop immediately increments. Since the given initialization value is end(), it set begin() as the starting loop value and then immediately incremented to item 2. Item 1 was finally evaluated last, putting ABS after ZTEST. The backwards loop handled this properly, so do the same thing for the forward loop. Change-Id: I539c749ea43140a1480d74471787bc886dda671e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126723 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com> Reviewed-by: Eike Rathke <erack@redhat.com>
2021-12-13tdf#92010 sc autoFormula: prefer MRU formulasJustin Luth
Prior to 4.3, only MRU formulas were auto-completed. Then it changed to suggest all formulas - alphabetically for the most part. That 4.3 commit 5b0b7553241bb5150b12bbf7625b4b0b36970272 completely removed all reference to MRU. But it makes sense to prefer an MRU over a strictly alphabetical match. This patch depends on LO 7.4 patch "new ScTypedStrData: typically missed argument in CTOR" Change-Id: Id5d860d1401693f43833719977d1c1e4c386385c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126499 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com> Reviewed-by: Eike Rathke <erack@redhat.com>
2021-12-13NFC simplify sc: !(!A() const || B) is !B && A()Justin Luth
Not new AND Is the same tab is much easier to wrap your mind around than Not (Not the same tab OR New) Plus it allows avoiding a (trivial) const function call. Change-Id: Ie0d8a1e490fc3dffe6fc87c9b4d9bd1c41d34dc8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126733 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2021-12-13Revert "Disable CppunitTset_sc_*_functions_test for linux_aarch64 for now, too"Stephan Bergmann
This reverts commit 6cb20e0b298f41fe88984aebfe5454f936a0ae3a, now that the test failures have been identified as caused by -ffp-contract being enabled, and have been addressed with 19559ebbee160d1625d06feec7e6566772dad231 "Allow for a presumably more precise result of BESSELY(80,9)", 04215f03492f6fce83d6bc64491749bf803c389a "Allow for presumably more precices results of some more Calc function calls", and 72b25619960cdaa829c8ea10e27d9c0b20a2c26f "For now, disable tests giving dubious results on AArch64". Change-Id: I78f9ddb04362d4026a272db0b8bbf4717fd75093 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126737 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-12-13Remove dubious code in ui fileXisco Fauli
Introduced in f773e7aa8c96e070085ece95889f02590ed65f89 < Resolves tdf#144227 - Default command to switch UI > Change-Id: I1975d6d61a2fd225e87dffe65708a1f5e531f106 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126735 Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-12-13For now, disable tests giving dubious results on AArch64Stephan Bergmann
when built with -ffp-contract enabled (-ffp-contract=on default on Clang 14 trunk since <https://github.com/llvm/llvm-project/commit/f04e387055e495e3e14570087d68e93593cf2918> "Making the code compliant to the documentation about Floating Point", cf. 19559ebbee160d1625d06feec7e6566772dad231 "Allow for a presumably more precise result of BESSELY(80,9)"; and -ffp-contract=fast default when building with optimizations on GCC) on both Linux (with 6cb20e0b298f41fe88984aebfe5454f936a0ae3a "Disable CppunitTset_sc_*_functions_test for linux_aarch64 for now, too" reverted) and macOS. Change-Id: Ie867d999173410ec9868bd14c0ee04bbba371920 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126727 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-12-13lok: paint the inputwin directly to the device...Dennis Francis
...using the correct map mode with twips instead of using DrawOutDev() to scale what was drawn in a temporary vdev back to the original device. This fixes the issue: When window width is large (>3.5k pixels) the text in the window is not visible. This was because of the incorrect limiting of the paint area width to the paper-width of the editengine. Change-Id: I46a5c219a6ef07437789fe3de3cbaa245c0e7d72 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126626 Tested-by: Jenkins Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2021-12-11tdf#128895 sc xmlimport: create enough dynamic cols if propsJustin Luth
Since LO 6.3, only 64 columns are created by default, where previously it was a fixed 1024. A common user practice is to hide all columns not used, but this collapsed property was lost because only part of the columns were actually created and thus exported. In this example, import specifies 1017 hidden columns (H-AMJ), but since only 64 columns are created, export only specified 57. So ensure that on import, any column with defined properties is created - even if they don't contain any content. Change-Id: If928880baf5585613715a1f4361a9059584d1ad2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126540 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com> Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2021-12-10tdf#102506: sc: Add UItestXisco Fauli
Change-Id: I3b104623289bb18d13f75b90bffcda4e65c6707d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126653 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-12-10Allow for presumably more precices results of some more Calc function callsStephan Bergmann
...similar to 19559ebbee160d1625d06feec7e6566772dad231 "Allow for a presumably more precise result of BESSELY(80,9)", where at least on macOS ARM64 Clang 14 trunk (defaulting to -ffp-contract=on now) started to produce values that caused various CppunitTests to fail (and only one of which had been addressed in 19559ebbee160d1625d06feec7e6566772dad231, for starters). The discrepancies addressed by this commit are: * CppunitTest_sc_financial_functions_test: ** sc/qa/unit/data/functions/financial/fods/rate.fods: *** row 23: actual 0.250000095659014 vs. expected 0.250000092908987 * CppunitTest_sc_statistical_functions_test ** sc/qa/unit/data/functions/statistical/fods/chisq.test.fods: *** row 10: actual 1.66789802691648E-016 vs. expected 1.66789802691649E-16 ** sc/qa/unit/data/functions/statistical/fods/chisqinv.fods: *** row 58: actual 3.00000000000001E-001 vs. expected 0.299999999999999 ** sc/qa/unit/data/functions/statistical/fods/chitest.fods: *** row 10: actual 1.66789802691648E-016 vs. expected 1.66789802691649E-16 ** sc/qa/unit/data/functions/statistical/fods/forecast.ets.mult.fods: *** row 79: actual 268.59802115122 vs. expected 268.598021151221 Change-Id: I4439f59394feadd2d6406dc4c4f985f479cd8fe0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126640 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-12-10Related: tdf#146018 constrain submenu to window like toplevel menuCaolán McNamara
so under wayland it not go off-screen Change-Id: I69f4f71cffaf4e4ac4def87d71b947e2dd903a08 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126643 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-12-10Related: tdf#146018 allow user to grow/shrink autofilter checklist by a rowCaolán McNamara
Change-Id: If337f62032a8db6d1d01c66ae851a1111ad8b0bd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126636 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-12-10tdf#127341 Do not activate TextEdit at right-klick on URL in calcArmin Le Grand (Allotropia)
Change-Id: I1881c007a05f56d5cb7914da56243f551c2da1cc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126618 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2021-12-10Related: tdf#146018 move Top10 below empty/not-empty add add Bottom10Caolán McNamara
Change-Id: I3333c44b84dea8f8b1e61872606b50e9a384d8c0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126621 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-12-10restore autofilter to a row taller, now it has less menu itemsCaolán McNamara
Change-Id: Id6f8b5648eb10d8f44ed3c76836d3b96fd86103e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126533 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-12-10tdf#146018 group filtering options under a single dropdownCaolán McNamara
Change-Id: I91afb746485654ed8e1418d17d4b172332b3f1f5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126532 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-12-10sc a11y: Handle FOCUSED state for cellMichael Weghorn
Implement handling for the FOCUSED state of a cell, similar to how 'ScAccessibleSpreadsheet::IsFocused' does for a spreadsheet. (The fact that the state was not handled before turned out to be the cause for the NVDA and Orca screen readers no longer announcing the focused cell with some other local WIP changes to winaccessibility and qt5/qt6 accessibility in place.) Change-Id: I0334e98cd306189196cf3ee2e5e48f87eb3748c5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126619 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2021-12-10Generally determine Rdb content from gb_*_set_componentfile callsStephan Bergmann
...instead of by listing the content somewhat redundantly in the Rdb_*.mk files, to avoid duplication of logic for components that are only built conditionally (and thus should only be included conditionally in the corresponding Rdb). To achieve that, add an "rdb" parameter to gb_ComponentTarget_ComponentTarget (and to the gb_*_set_componentfile macros that internally call gb_ComponentTarget_ComponentTarget), which is used to make the appropriate gb_Rdb_add_component call internally from within gb_ComponentTarget_ComponentTarget. (As a special case, gb_CppunitTest_set_componentfile shall not call gb_Rdb_add_component, as that has already been done by the corresponding gb_Library_set_componentfile call, so allow the gb_ComponentTarget_ComponentTarget "rdb" parameter to be empty to support that special case.) Most Rdb_*.mk files are thus mostly empty now. One exception is i18npool/Rdb_saxparser.mk, which duplicates some of the Rdb_services content as needed during the build in CustomTarget_i18npool/localedata. 1c9a40299d328c78c035ca63ccdf22c5c669a03b "gbuild: create services.rdb from built components" had already tried to do something similar (in addition to other things) under a new --enable-services-rdb-from-build option. However, that approach had four drawbacks that this approach here addresses (and which thus partly reverts 1c9a40299d328c78c035ca63ccdf22c5c669a03b): 1 Rdb_services shall not contain the component files of all libraries that are built. While that commit filtered out the component files that go into Rdb_ure/services (ure/Rdb_ure.mk), it failed to filter out the component files that go into others like Rdb_postgresql-sdbc (connectivity/Rdb_postgresql-sdbc.mk). 2 The code added by that commit to Makefile.gbuild codified the knowledge that there is an Rdb_services, which is brittle. 3 The code added by that commit to solenv/gbuild/Rdb.mk codified the knowledge (for gb_Rdb__URECOMPONENTS) that there is an Rdb_ure/services, which is brittle. 4 Introducing an --enable-services-rdb-from-build option needlessly provided two different ways how the content of Rdb_services is assembled. The changes done here would leave --enable-services-rdb-from-build as a misnomer, as it no longer controls how Rdb_services is assembled. I thus renamed it to --enable-customtarget-components, as that is apparently what it still does now. Change-Id: Ia5e8df4b640146c77421fcec6daa11a9cd260265 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126577 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-12-10new ScTypedStrData: typically missed argument in CTOR, tdf#142910 follow-upJustin Luth
Pretty much any attempted use of eType was completely wrong and lost. Regression from commit f6b143a57d9bd8f5d7b29febcb4e01ee1eb2ff1d CommitDate: Wed Jul 7 17:44:46 2021 +0200 tdf#142910 sc filter: fix "greater than" or "smaller than" etc Most calls to this are missing the "rounded number" argument, so the enumator is actually accepted as the double fRVal, and the StringValue eType was left as the default value (Standard), instead of the intended enumerator. 0.0 looks too much like 0, 0 to even notice in casual code reading. This had rendered the type mostly irrelevant. Change-Id: If4fa69d4b3077981244a2c3a785f80b77f9f9501 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126453 Tested-by: Eike Rathke <erack@redhat.com> Reviewed-by: Eike Rathke <erack@redhat.com>
2021-12-10tdf#133353, Make 2nd argument optional for DCOUNT and DCOUNTA.Winfried Donkers
The functions accept empty second arguments, but the function wizard and hints stated that it was required. Change-Id: I74fcfcc31492ed776085d1bc6ee6a9ff22a87818 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126620 Tested-by: Eike Rathke <erack@redhat.com> Reviewed-by: Eike Rathke <erack@redhat.com>
2021-12-10Allow for a presumably more precise result of BESSELY(80,9)Stephan Bergmann
When Clang 14 trunk changed from defaulting to -ffp-contract=off to -ffp-contrace=on with <https://github.com/llvm/llvm-project/commit/f04e387055e495e3e14570087d68e93593cf2918> "Making the code compliant to the documentation about Floating Point" ("even when optimization is off", <https://github.com/llvm/llvm-project/commit/95edd7f53e77415ca30abefdcdc5ce723c292ebd> "Making the code compliant to the documentation about Floating Point"), at least a macOS ARM64 build started to fail CppunitTest_sc_addin_functions_test CPPUNIT_TEST_NAME=AddinFunctionsTest::testAddinFormulasFODS with > double equality assertion failed > - Expected: 1 > - Actual : 0 > - Delta : 1e-14 because in sc/qa/unit/data/functions/addin/fods/bessely.fods, BESSELY(80,9) evaluates to 0.0340917220777503, so comparing it against the expected 0.0340917220777493 with ROUNDSIG(...,12) fails. The expected value stored in bessely.fods has been like that ever since c3fc9ac6ef1be34e4683c0c5fb7f5f116da9c59e "add BESSELI,BESSELJ,BESSELK,BESSELY test case", and presumably is what Calc happened to produce for the test author (rather than taking the expected value from some authoritative source). And Calc presumably has no authoritative idea about the expected value of Bessel(80,9) anyway, beyond what the C++ source code happens to produce with a given C++ compiler and compiler optimization settings on a given hardware architecture. However, <https://functions.wolfram.com/webMathematica/FunctionEvaluation.jsp?name=BesselY&ptype=0&n=9&z=80&digits=15> gives 0.0340917220777507, and julia-1.7.0rc3-1.fc35.x86_64 gives 0.034091722077750686 (`using Pkg; Pkg.add("SpecialFunctions"); using SpecialFunctions; bessely(9, 80)`), which are both closer to the actual Clang 14 trunk macOS ARM64 value than to the stored expected value, making it likely that the actual value is more correct than the expected one (in line with the observation in the Clang documentation that with -ffp-contract=on "fused operations are permitted to produce more precise results than performing the same operations separately"). Change-Id: I3c3db4099c83c01d0f14e08a694fb0977cb6863c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126617 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-12-09flush pending menu close on queuing close of anotherCaolán McNamara
Change-Id: If57442e24336d855249413fc58587b776e251f66 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126614 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2025-02-27 22:18:41 +0000