summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)Author
2020-07-17lokit: add missing header and row-size invalidation calls...Dennis Francis
for ScUndoEnterData if there is a change in row height(s). Change-Id: I7d1e3a3ad8d55dcdb0cfbbc94521b83a7ac2b1ff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98891 Tested-by: Jenkins Reviewed-by: Dennis Francis <dennis.francis@collabora.com> (cherry picked from commit 2661685f4d73dac2997cc91a92f3e133b3518131) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98950 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2020-07-17lokit: Add missing sheet-geometry row-size invalidation callDennis Francis
Change-Id: I6e0c87de51fa64fd486c0d20bef65574fadd1560 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98890 Tested-by: Jenkins Reviewed-by: Dennis Francis <dennis.francis@collabora.com> (cherry picked from commit f9cb1968433121a4ef4953f198f645a56a3d786a) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98849 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2020-07-11Resolves: tdf#124454 exec the matrix operator on values converted from stringsEike Rathke
Effectively a fallout from the matrix operations rework started for tdf#89387 that did not convert strings at all and subsequent work converted the string according to settings but did not apply the current operator on the result. Change-Id: I90c8963021396fd9a46b063f6aee96283f89271a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98385 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit 7ead920f7015bb8e7a4343b863333bb26187d9a3) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98339 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98518 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2020-07-10Resolves: tdf#131424 separator in TableRef column specifier is validEike Rathke
Even only a separator or any operator single character. Change-Id: I102dd7fd49c1a6a7f1d8c39f4a6139a51dbebe51 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97535 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit 31951265f541c9f5acf424674e2d1d97c0f3b8c2) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97507 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98509 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2020-07-10don't add a cell to a non-existent column (tdf#104865)Luboš Luňák
This change also needs invalidating column position hints if the columns get changed by the copying of the cells. Change-Id: I4793e25f253c0197d88b313bc9336435cef649f4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97603 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com> (cherry picked from commit ee2d2184133b3bf47d38a03b14abab2caa15dad1) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97673 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> (cherry picked from commit 8765592db900fae22ff2a0440fe94842dcbd805f) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97684 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98506 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2020-07-08Don't reset reference marks when editing the formulaSzymon Kłos
This prevents us from hiding reference marks on switching sheets when formula is under edit. Change-Id: I4bf1e36967420c12bfa974b0aeefda537a26eed3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98364 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2020-07-08Get correct tab for current selectionSzymon Kłos
Change-Id: Ie3146675a5b6cca5357fccc668ce17b859836147 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98315 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2020-07-08Empty reference marks on selection resetSzymon Kłos
Change-Id: Id085b6b608335e1bcc085d7a8c972622a918f1ab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98316 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2020-07-06paintTile: Try to find a view that matches the tile-zoom requested...Dennis Francis
by iterating over first few shells to avoid switching of zooms in ScGridWindow::PaintTile and hence avoid grid-offset recomputation on all shapes which is not cheap. Change-Id: Ib086112ebd504087d80c6d6f2879a69dca8ce44f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98168 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2020-07-06reset all draw gridOffsets when zoom needs to change...Dennis Francis
so that these are recalculated on render, else the shape positions in the tiles will be wrong. It is not enough to reset for just the objects in the tile because the render code iterates over all objects and then decide whether to render them based on the position/size. An obvious optimization is to choose a view/window with its zoom matching the tile-request using some useful heuristic and avoid a linear scan of views. Change-Id: Iffa96d261bc3362af3a528fbf7d4d3bcafc6d497 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98167 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2020-07-06scPrintTwipsMsgs: Use print logical coordinates for draw objectsDennis Francis
as a result LOK_CALLBACK_GRAPHIC(_VIEW)_SELECTION messages will now be in print-twips. For tile-rendering, it needs the pixel-aligned coordinates of each object. The translation of print coordinates to pixel-aligned coordinates can be done behind the scenes by the ViewContact/ObjectContact/ViewObjectContact objects associated with the draw object which uses the cached "grid-offset" for each object (introduced in the patch "Refactor calc non-linear ViewToDevice transform"). For doing this, a subclass of FmFormView with a specialized "createViewSpecificObjectContact" method is used for tile-rendering. The createViewSpecificObjectContact creates a "proxy" object-contact object that delegates the grid-offsets queries to the actual ScDrawView generated ObjectContact. This is needed because currently there is no way to share the ObjectContact/ViewObjectContact instances between different SdrPaintWindow's without making changes ~everywhere. Change-Id: Ifdfb623c8d6dd81700ec4a5dfeeb6b2391a96154 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98166 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2020-07-06scPrintTwipsMsgs: Use print-twips paper-sizeDennis Francis
Paper size for the EditEngine is calculated based on per-cell pixel alignment. So lets use the exact print-twips version whenever we need it to compute/adjust output-area and visible-area of EditView. Change-Id: I7da6db9363d09965315ff5ca9d01f0fea141a533 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98066 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2020-07-06lokit: Avoid sending wrong edit-cursor/selection messages when...Dennis Francis
the EditView's output-area needs to be tweaked temporarily to render it to a tile which is meant for another view. Change-Id: I2b8fc1986c247ce65c18ea64e3b43d25625c7e9c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98065 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2020-07-06SetLOKSpecialOutputArea() call must precede SetOutputArea()Dennis Francis
The ordering matters at the moment (unfortunately), since EditView::SetOutputArea(), after updating the output-area it also sends the LOK messages(cursor/selection) immediately. So we need to update the print-twips version in EditView by calling SetLOKSpecialOutputArea() beforehand to avoid wrong messages. Change-Id: Ibff64ad1a92f332ad726452369ecb2c5b2aaae53 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98064 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2020-07-06ScGridWindow::UpdateEditViewPos: keep EditView's print-twips data updatedDennis Francis
Change-Id: I2f6fab371a107a4f16704030e341198a541020f8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98063 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2020-07-06ScViewData::EditGrowY: keep EditView's print-twips data updatedDennis Francis
Change-Id: I0207e65fc0386eb9a86de6ab4472780553eadd4a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98062 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2020-07-06ScViewData::EditGrowX: keep EditView's print-twips data updatedDennis Francis
Change-Id: Ia2470f98954859b191432d68db5742d13a61c802 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98061 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2020-07-06ScViewData::SetEditEngine: keep EditView's print-twips data updatedDennis Francis
whenever EditView::SetOutputArea() and EditView::SetVisArea() are called. Change-Id: I90a840b85d01d27427fbaa1101148ce1efb55db5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98060 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2020-07-06scPrintTwipsMsgs: No more view specific edit-cursor messagesDennis Francis
Change-Id: I2a07834568716ea1608a40613108d229699058b7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98059 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2020-07-06Allow edit-area computation in print-twips...Dennis Francis
via a optional flag bInPrintTwips (false by default) in ScViewData::GetEditArea() Change-Id: I9bf7465b703a2df817fe438db3671261d0d907a8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98058 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2020-07-06Allow print-twips version of ScEditUtil::GetEditArea()Dennis Francis
This will be used in the generation of edit-cursor/edit-selection messages in print twips for LOK clients. Change-Id: I91d48372551d1b6aca80aa793023c51b3c59d7ad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98054 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2020-07-06Allow print-twips version of ScDocument::GetNeededSize()...Dennis Francis
via an optional boolean argument bInPrintTwips which is false by default. This is needed for edit-area calculation in print twips which will aid in the generation of edit-cursor/edit-selection messages in print twips for LOK clients. Change-Id: Ibb15411278b9196d956ac952444d6e31c62dccda Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98053 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2020-07-06jsdialog: Add mobile version of data validation dialogSzymon Kłos
Change-Id: I8c59892196ae015852fff6004c72e1990b35c1af Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97762 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2020-07-06lokit: Do not assume 100% zoom for computing document-sizeDennis Francis
This fix prevents rendering issues (bottom/right area the sheet clipped off/extra spaces) at the bottom/right of sheets with certain non default zooms in online. Change-Id: I2778d6259f8caf5a99d9eab57ae7b87751304ce3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98052 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2020-07-06lokit: Adjust nSize* to agree with the definition in tools::RectangleDennis Francis
Change-Id: I6ebe539fe47403e4aa605c5ddfb6175080bd4655 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98051 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2020-07-04lokit: scPrintTwipsMsgs: LOK_CALLBACK_COMMENTDennis Francis
Allow print twips coordinates in LOK_CALLBACK_COMMENT Change-Id: I052dacb311c651c49d61fd9937951fa5b81b32d5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97967 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2020-07-04lokit: scPrintTwipsMsgs: LOK_CALLBACK_*SELECTION*Dennis Francis
Allow print twips coordinates in the below messages: LOK_CALLBACK_CELL_SELECTION_AREA LOK_CALLBACK_TEXT_SELECTION LOK_CALLBACK_TEXT_VIEW_SELECTION Change-Id: I267a636bbeab434b305a45abe3e21cb5afc4c1e9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97966 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2020-07-04lokit: scPrintTwipsMsgs: LOK_CALLBACK_CELL_VIEW_CURSORDennis Francis
Allow print twips coordinates in LOK_CALLBACK_CELL_VIEW_CURSOR Change-Id: I0373cbd2b87b4d1088af41453ab548274de6ca23 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97965 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2020-07-04lokit: scPrintTwipsMsgs: LOK_CALLBACK_REFERENCE_MARKSDennis Francis
Allow print twips coordinates in LOK_CALLBACK_REFERENCE_MARKS Change-Id: I1bf84c5aebe84ee034ac27932fa8a01d0a3ae831 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97964 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2020-07-04lokit: do not set an artificial cursor size when it is zero...Dennis Francis
when we send the message in print twips coordinates. It is important for the client to know the exact position and coordinates to allow client side print-twips -> tile-twips conversion when/if it is needed. Change-Id: I6699894758886f1b5648ac9bf3c9e6ab4192c72e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97963 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2020-07-04lokit: scPrintTwipsMsgs: LOK_CALLBACK_CELL_CURSORDennis Francis
Allow print twips coordinates in LOK_CALLBACK_CELL_CURSOR msg. Change-Id: Ib9de372db46db9d462983e15fb12d58624d066f5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97962 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2020-07-04Allow cell coordinates calculation in print twips tooDennis Francis
Change-Id: Ie8f23bd7ba8de57d7aab104add99501a54f08819 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97961 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2020-07-04use lcl_ExtendTiledDimension() in getRowColumnHeaders()Dennis Francis
to avoid code repetitions. Change-Id: If83b42175fb53132174fa33d169806e17a4a5cbe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96973 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2020-07-04use helper-class ScRangeProvider in getRowColumnHeader()Dennis Francis
and avoid some code repetitions. Change-Id: I3e006bc8d9880f3e1ec892aa8f2423edbf9bbf14 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96972 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2020-07-04lokit: scPrintTwipsMsgs: Extend the tiled-area limits...Dennis Francis
if the client visible area is "close" to these limits. Also send tile-invalidations for the new area uncovered. ** All this is done only if the flag scPrintTwipsMsgs is set. Change-Id: I3d6b8c6aaae1eb934030c5bdbc1094dc8be16a9f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96971 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2020-07-04lokit: add new callback type LOK_CALLBACK_INVALIDATE_SHEET_GEOMETRYDennis Francis
This is to notify the clients about changes in current sheet's geometry data. Use this to notify clients of various sheet geometry invalidations if the new feature flag scPrintTwipsMsgs is set. Change-Id: I478d2e646606320399905d7b15881a165a53146d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96969 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2020-07-04Resolves: tdf#134455 Let TIMEVALUE() use lax time recognitionEike Rathke
... to accept minutes or seconds >59 Prepare SvNumInputOptions as enum class in case further options would be needed for anything else. Change-Id: Ie9ae62adf68f9948e23f55ac32c09a6b992a36e2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97784 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit f106bb4471b6d3627311980ed727459b2da8e448) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97793 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-06-30tdf#133699 Slow sorting of a columnNoel Grandin
reserve inside a loop is a pessimization, since it breaks the logarithmic resizing of the std::vector data area. Also use the std::vector::insert method, instead of std::copy, since the insert method will perform less resizing operations. On my machine, this takes the sort operation from 25s to less than 1s. Change-Id: I30b99d42c56abc5a4ad5c133c7579fac3952173c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96929 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 97965876459d8cfda0b653551708eb14de36e632) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96885 (cherry picked from commit 0638adcb101d870b169a34d980d41ef4fc742a94) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96996
2020-06-30tdf#133629 calc, crash on format borders on multiple sheetsNoel Grandin
regression from commit 7282014e362a1529a36c88eb308df8ed359c2cfa tdf#50916 Makes numbers of columns dynamic. Change-Id: Ie862ec4a29d495c71aa3a21a1941f801fa3a789e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96957 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 8cad16207cb6d6df098d2a2f307df4fbc7519035) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96994 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-06-30tdf#133326 Crash after redoNoel Grandin
regression from commit 7282014e362a1529a36c88eb308df8ed359c2cfa tdf#50916 Makes numbers of columns dynamic. Change-Id: I6a3d6b35dbd442014c84785d97cbd7eae19244cc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96958 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 240758a972eb99dd4d26fa6040ff0b6614036621) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96995 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-06-29Attempt to fix three more places of just "hoping" that things work rightTor Lillqvist
Change-Id: I81c87740b36beeb1288649712f6415cb6074348f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97416 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-06-29Let's not run on hopeTor Lillqvist
Change-Id: If2fb2c55d53321ec2e5beff0ade9974c02811f7f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97120 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tor Lillqvist <tml@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97402
2020-06-29Avoid crash with multiple documents open in the iOS appTor Lillqvist
Also add a FIXME. Just 'hoping' is not good enough. But yeah, much of this code indeeed works mostly by accident. Change-Id: Ic6bcbc10229a0b7cdd8d696794efe152fca4faea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97117 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tor Lillqvist <tml@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97401
2020-06-26notebookbar: remember LOKWindowId in interim buildersSzymon Kłos
In case of notebookbar we need to remember the same id in every builder for each view to be able to use interim widgets. Then widgets are added to the same map as main notebookbar widgets. SfxViewShell is used as a common id as it is easily accessible. Change-Id: I4fbf2da320396efc80b08bcee9e341c165b1a290 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97199 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2020-06-26Revert "tdf#133858 opening spreadsheet with large array formula takes 10 ↵Noel Grandin
mins" (tdf#134234) This reverts commit 9a5f2961b085ce2f23ecdf0a03d1114bacac8e2c. Reason for revert: causes regression, see tdf#134234 Change-Id: I1cc3e6daa0e65231e8a4d7c1ae4a60cfdf106457 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97056 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-06-25lok: calc: messed up view when deleting from multiline contentMarco Cecchetti
To see the problem was enough to click on the cell with the multiline content (because of wrap text enabled), and press delete. Change-Id: I8288e7739c8513f5fa0bdee5f7eb414b4abac456 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96905 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97114 Reviewed-by: Marco Cecchetti <marco.cecchetti@collabora.com>
2020-06-24tdf#128502: Remove one more assertionTor Lillqvist
See bda60c9b1ca6a0fbfde9f3428489f33729cc81f1. Change-Id: If67f0696c56b0984dcfffdcf748d4f412874a64f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95061 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97026 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2020-06-24tdf#128502: Try to support multiple documents in LibreOfficeKit-using processTor Lillqvist
The LibreOfficeKit-specific code typically has assumed that all the "views" (SfxViewShell instances) are for the same document, because all LibreOfficeKit-based application processes (including the "kit" processes in Online and the iOS app) so far have only had one document open at a time. It is now possible to pass several document file names on the command line to gtktiledviewer and that is an easy way to demonstrate how badly it still works even with this patch. Introduce a unique numeric document id that is increased in the LibLODocument_Impl constructor. Add APIs to access that. When iterating over views, try to skip views that are not of the document visible in the "current" view, if we know what the "current" view is. Also add a couple of FIXMEs at places where it is a bit unclear (to me) whether it is correct to iterate over all views, or whether only views for the "current" document are what we would want. Change-Id: Id5ebb92a115723cdeb23907163d5b5f282016252 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95353 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97024 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2020-06-24tdf#128502: Remove assertions that fire for gtktiledviewer on two docsTor Lillqvist
If you run gtktiledviewer so that it opens a spreadsheet and a text document these assertions would fire. In each case the assertion is followed by code that just returns if the asserted condition doesn't hold, so it is unlikely that this change will break anything. There sure will be a lot of further changes needed to make such a use case work. (For starters, editing either of the two documents does not work.) But let's do it step by step. Change-Id: I4063dbbcac7c77b57e1f4cb3f05bd5096c08c0fe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95037 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97025 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2020-06-24weld ScNumberFormat ItemWindowCaolán McNamara
Change-Id: Ib019912e91be617edbbcdf2fafb92d6685487b98 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88174 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97015 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
generated by cgit (git 2.34.1) at 2024-06-30 02:28:03 +0000