summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)Author
2023-09-10using decls should come after #includeNoel Grandin
Change-Id: I058551e87bca42adede860f6f299b0f7ae2af3b5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156798 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-09-09disable more flaky navigator UITestNoel Grandin
Change-Id: Ieadd35fef7f709e9eaf0f26238f7613076aa8c52 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156775 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-09-08disable more flakey navigator UITestNoel Grandin
Change-Id: Icf6a28f1270fc95a4edfc81a06fc79d5d2da17df Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156720 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-09-08inline SC_QUERYINTERFACE macrosNoel Grandin
which means we need a few more cppu::queryInterface variants Change-Id: I5cf7805ab9576919bfd66a3b239917e48a7f8f61 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156701 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-09-08replace ScUnoHelpFunctions::VectorToSequence..Noel Grandin
with the more standard comphelper::containerToSequence Change-Id: I29a67e52e7c25c2d67b0cd617acc7068737bad5b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156702 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-09-07merge SvxFmDrawPage into SvxDrawPageNoel Grandin
it adds hardly any functionality. Change-Id: I82f5c52148222596d52f1fb41d726733ca1cf40d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156654 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-09-07lok: save to xlsx changes column sizeSzymon Kłos
When xlsx spreadsheet was opened in LOK on every save default column width was decreased. This doesn't happen in non-LOK case. Column width in Excel are defined by double value which specifies number of '0' characters which fit into the column. On export we use mnCharWidth from XclRootData to convert Calc twips size to number of characters. In LOK case it was 102 while in non-lok case 101. It was caused by different Reference Device used in ScDocument::GetRefDevice() because in LOK case we are in WYSWIG mode as introduced in ScModelObj::initializeForTiledRendering in commit c25062f: sc tiled rendering: Don't adjust the text width according to printer. Let's use for export purpose the GetVirtualDevice_100th_mm() Change-Id: I6709194d7924e8c7e0aaa75ff3901afbcc1f8c11 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156576 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> (cherry picked from commit 29f72210e92e0152d52b3a1d0253fbb5d8e2dead) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156604 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2023-09-06fix "variable 'nRow' set but not used [-Werror,-Wunused-but-set-variable]"Christian Lohmaier
as seen on non-debug builds with compiling for x86_64 with XCode 14.3.1 Change-Id: Ib0b97cfcf15cc58d08a90bc0b4aaf43fc1be3c05 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156614 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2023-09-06tdf#154271 Fix automatic cursor/screen jump in CalcHossein
Previously, when using ctrl+end, the screen/cursor jump was done to the middle of the screen. In this way, the available space of the screen was not optimally used. In this patch, the jump is adjusted to move the cursor to the end of the screen, and the visible/usable space will be all of the screen. In this patch, previous behavior for showing the search results and other purposes other than pressing ctrl+end to jump to the last cell are preserved, and in those cases, the selected cell will be in the middle of the screen, as before. Also, in the situations that the jump is done from a cell lower or right of the last cell (in other words, further than the last cell), the behavior is preserved. Change-Id: I25f308f84f096ec271c23df75998ddeea32119ea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156266 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org>
2023-09-06SAL_WARN->SAL_INFO in ScXMLAnnotationContextNoel Grandin
these attributes are mostly irrelevant, and do not constitute an error Change-Id: Iac35b25b0077a8e1efa3b6e0a406507c80d5bb0f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156588 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-09-04tdf#156985: sc_ucalc_formula2: Add unittestXisco Fauli
Change-Id: Iaf6d4310eb40bfc4880902f57a75b7f85a8af906 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156508 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-09-04sc: ui: view: Use conditional assignmentAron Budea
Change-Id: I51ba012079a955c139a0c55f12a4b141ba536aa6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156502 Tested-by: Jenkins Reviewed-by: Henry Castro <hcastro@collabora.com>
2023-09-04limit tests giving dubious results to x86_64Dan Horák
We have confirmed that ArrayFunctionsTest::testDubiousArrayFormulasFODS gives different results depending on the -ffp-contract setting on ppc64le and likely also on s390x in addition to aarch64. Thus limit the check only to x86_64 where it's known to give consistent results. Change-Id: Iedb63fb4340cfe9a88e374c7498d97574bcdfcc7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156453 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-09-04Related tdf#108976: Crash in: OutputDevice::GetOutputSizePixel()Julien Nabet
On pc Debian x86-64 with master sources updated today, I encountered this: 5 0x00007f68124533a2 in __assert_fail (assertion=0x7f67016aea9b "_pInterface != NULL", file=0x7f670156834a "/home/julien/lo/libreoffice/include/com/sun/star/uno/Reference.h", line=385, function=0x7f6701592970 "interface_type *com::sun::star::uno::Reference<com::sun::star::embed::XEmbeddedObject>::operator->() const [interface_type = com::sun::star::embed::XEmbeddedObject]") at ./assert/assert.c:101 6 0x00007f67023ed042 in com::sun::star::uno::Reference<com::sun::star::embed::XEmbeddedObject>::operator->() const (this=0x7ffe3b5f11c0) at include/com/sun/star/uno/Reference.h:385 7 0x00007f67030a7ba9 in ScClient::ViewChanged() (this=0x55fb3b69e7b0) at /home/julien/lo/libreoffice/sc/source/ui/app/client.cxx:191 8 0x00007f680f1d13db in SfxInPlaceClient::Invalidate() (this=0x55fb3b69e7b0) at /home/julien/lo/libreoffice/sfx2/source/view/ipclient.cxx:840 9 0x00007f680f1d59db in SfxInPlaceClient::SetObjArea(tools::Rectangle const&) (this=0x55fb3b69e7b0, rArea=...) at /home/julien/lo/libreoffice/sfx2/source/view/ipclient.cxx:764 10 0x00007f6703b74c30 in ScTabViewShell::ConnectObject(SdrOle2Obj const*) (this=0x55fb3ca0b880, pObj=0x55fb3c68b2c0) at /home/julien/lo/libreoffice/sc/source/ui/view/tabvwshb.cxx:107 See full bt here: https://bugs.documentfoundation.org/attachment.cgi?id=189332 Change-Id: I0b48f2e624b249438d8d4fbc53057f89f5877c05 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156509 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2023-09-02replace set(nullptr) with clear()Noel Grandin
It's a little easier to read, but mostly it makes an upcoming loplugin easier to implement Change-Id: I4ae7db8eda77795dab3255d1afd8ba4f20a8de76 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156451 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-09-02Apply font names and sizes to formatted strings via orcusKohei Yoshida
Change-Id: I6809a184652b278eb66ee104558af19ea4a22ed7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156459 Tested-by: Jenkins Reviewed-by: Kohei Yoshida <kohei@libreoffice.org>
2023-09-01various theme and complex color related fixesTomaž Vajngerl
Most of changes are a results of code reviews. Added comments and clarifications, removed unneeded methods, renamed variables to be more clear, protection against nullptr dereference,... Change-Id: Iae2b6abfa90b3bbd3f28328ca7fcf429765cbe9d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156203 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-09-01tdf#155799: lok: sc: fix extend reference markHenry Castro
In the tiled rendering case, the server sends a reference coordinates to client side, so extend the range end point reference if merged cells. Signed-off-by: Henry Castro <hcastro@collabora.com> Change-Id: Ie9611aea3f6645a6cf45514939ae6364afac0b1c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155564 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156417 Tested-by: Jenkins
2023-09-01Resolves: tdf#156985 Treat adding two KahanSum differentlyEike Rathke
When summing mixed formula cells and numeric cells, cell type runs are summed using KahanSum that when switching cell types are added. Using add() to explicitly add the rhs m_fError compensation value separately may had lead to effectively cancelling out the relation of sum and error, living on with an unrelated error value. Instead, add a "final" rhs sum+compensation. Change-Id: I751d3e0eeef9cd80482895c24f05b1ab667c3020 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156253 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2023-09-01sc: filter: rtf: add method "WriteFontTable"Henry Castro
Write the font table while visiting column/row and get the unique index to reference it. "The \fonttbl control word introduces the font table group. Unique \fN control words define each font available in the document, and are used to reference that font throughout the document." Signed-off-by: Henry Castro <hcastro@collabora.com> Change-Id: I20c5d1128972f5ec9b9b2e246f466bdb173ef8a4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154906 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156415 Tested-by: Jenkins
2023-09-01sc: filter: rtf: add method "AddFont"Henry Castro
Create a map font name associated with unique index. "The \fonttbl control word introduces the font table group. Unique \fN control words define each font available in the document, and are used to reference that font throughout the document".. Signed-off-by: Henry Castro <hcastro@collabora.com> Change-Id: I028226cb539865f1980f953385c887a3bd4b8e3f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154905 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156414
2023-09-01sc: filter: rtf: prefix m_* private membersHenry Castro
Signed-off-by: Henry Castro <hcastro@collabora.com> Change-Id: If8389b6e63a90616131d0dd9fbb5a7b8b96ffe3d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154904 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156413 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-09-01sc: filter: rtf: use a separate document streamHenry Castro
"An RTF file has the following syntax: '{' <header> <document>'}' " In order to build the header: <header> \rtf <charset> \deff? <fonttbl> <filetbl>? <colortbl>? <stylesheet>? <listtables>? <revtbl>? The font table should be created while visiting the column/rows. Signed-off-by: Henry Castro <hcastro@collabora.com> Change-Id: Id72a3c87acab6cfc7889cf81f7e83a0d73e378a2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154903 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156412 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-09-01sc: add ODF import/export of the Theme + testsTomaž Vajngerl
One missing thing is the support in calc to save the Theme into the ODS document and read that back. The theme element is added as a child element to the office:styles - the same as it already is added in Writer. Also adds "Theme" property as a top level document property so it is possible to get and set the theme in xmloff. Also tests have been added to cover this usecases. Change-Id: Ic214ff5e945b77d50e6c881def9d49509560a0e0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156363 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-08-31Related: tdf#156985 Adjust doc layout to what FunctionsTest::load() expectsEike Rathke
In case of failure to show failure details sc/qa/unit/functions_test.cxx FunctionsTest::load() assumes result in A, expected in B, check in C and formula in D. Change-Id: I48d9e123664da314a1f7791f949d89569150b0c6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156346 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2023-08-31tdf#150815 sc: fix repainting sparklineTibor Nagy
On Windows, if the input range of the sparkline is not in the same row as the output range, the sparkline wasn't repainted after changing the data within its range. Force the update to avoid of showing obsolete data. Change-Id: Id56209b20387ee68144507a0102d3a0d093ff1ea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156304 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2023-08-31Related: tdf#156985 Do not fail for first empty check cell in test failure caseEike Rathke
So we can actually find a detail if there are empty rows and not just bail out with "Sheet2.A1 '' result: 0, expected: 0" or such. Change-Id: I163f84edebfb98f6f0351ba3dc889d3fab0e6789 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156344 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2023-08-31disable failing inputline UITestNoel Grandin
this test fails here on jenkins about 30% of the time Change-Id: Ie82f4f2621b7d05b7a74bba1b0b5c96b98314b46 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156324 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-08-31Add support for rich-text string import via orcus interfaceKohei Yoshida
It was previously imported only as non-formatted strings. Font names and sizes are to be imported later. Change-Id: I93a313851e87f1d6d9ccc409ca9a9f1abff3de0d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156271 Tested-by: Jenkins Reviewed-by: Kohei Yoshida <kohei@libreoffice.org>
2023-08-30lok: avoid forcing expensive re-layout of the calc input bar.Michael Meeks
This occured on doc_setView and was unreasonably expensive - loading and de-compressing new PNGs as multiple users typed, re-sizing and re-rendering a toolbar that is not visible -> do nothing here. cf. cool#6893. Change-Id: I1980a3a4516fb2aa629da85de9d4628f29de5af7 Signed-off-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156270
2023-08-29tdf#49895: Add search functionality to Options dialogBayram Çiçek
- Search field added. - Dialog names of all treeview nodes with their parent names were included in searching. - Strings of labels, check buttons, radio buttons, toggle buttons, link buttons and buttons were included in searching. Change-Id: Idf67c160519402ee390d94b1b3135b56324f3990 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152519 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2023-08-29tdf#155495 sc: fix cursor positioning editing centered/right-aligned cellsCzeber László Ádám
It was not always possible to place the cursor in edited text by mouse clicking in case of centered and right-aligned cell content, i.e. when the edited content has been shown before the original (not edited) cell position. Now it's possible to place the cursor by mouse clicking before the left border of the not edited cell (instead of selecting other cells covered by the edited content). Change-Id: I23c59ca3ef67d223181a7e3dfd71b84f43fca32b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155579 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2023-08-28Shared string shouldn't account preserve space propertyParis Oplopoios
XLSX documents opened in Excel don't seem to account for the xml:space="preserve" value for whether the string is single line or not The test that was changed seems to have more accurate behavior now, where the second cell does not have multiple lines (like in Excel) Change-Id: Iad8f351c19102249e2cb1e1d063c8690dfb3d753 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156206 Tested-by: Jenkins Reviewed-by: Paris Oplopoios <parisoplop@gmail.com>
2023-08-28Related: tdf#156611 move long explanation string into tooltipCaolán McNamara
Change-Id: Iddd600855f97bc505f30d06ae364c0ae2a935a47 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156186 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-08-28sc: Fix wrapText not being applied correctly on exportParis Oplopoios
Change-Id: I03aaa36af8fe820fa07d2eea13c5b0f69ad74dad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155970 Tested-by: Jenkins Reviewed-by: Paris Oplopoios <parisoplop@gmail.com>
2023-08-28new loplugin:optionalboolNoel Grandin
which warns against using the 'operator bool' conversion of std::optional<bool> which can lead to interesting bugs The bugs that this plugin have been submitted independantly, so this change is just using has_value() in relevant places. Change-Id: I259b837feeecddcb8cd1d7e5db1e85bf505907cb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155978 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-08-27lok: notify only affected tabs on cell resizeSzymon Kłos
When row has automatic height and we type something into one cell - it may be resized. That caused sending document size changed callback to all the views, also affecting all the parts/tabs. This patch calls that only for affected views which are looking at modified parts. It will not invalidate all the tabs when only one is modified. Change-Id: I93e574cf967d608696c1a95ad8b5a7614973c3f5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154891 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156156 Tested-by: Jenkins
2023-08-27Change theme location to SdrModel and SdrPage (master page only)Tomaž Vajngerl
In Writer and Calc we only have one theme per document, so the theme can be stored inside the SdrModel. For Imporess/Draw the theme is defined per master page, so it needs to be stored on the master page. This changes the implementation to reflect that. In addition refactor all the usages in writer and calc to get and set the theme to SdrModel, when needed and rename the methods on the SdrPageProperties from {Get,Set}Theme to {get,set}Theme. Change-Id: I0cc3b332c029c28d15f8cda748c578c2a54a5c61 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156128 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-08-25svx: refactor text color theme changing and add undo supportTomaž Vajngerl
This refactors text theme color changing to use editeng directly and also makes it possible to add undo support. Some refactoring changes were also needed in Writer and Calc ThemeColorChanger implementations. Change-Id: I5cc21205aa3866f65f5b2132ecaa760292401263 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155819 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-08-25tdf#152724 Extend ODF for blank width "_x"Laurent Balland
Number format code "_x" is currently saved as a text string containing a number of spaces corresponding to the width of character "x". It may be confusing for user if its format code is modified. This change introduces a new XML tag XML_BLANK_WIDTH_CHAR to replace the previous text string if ODF version is extended <number:text> and <number:embedded-text>: the attribute is composed of a string containing the used character and its position in the text string (if position is 0, it is omitted). Several blank code characters are separated by '_'. Replacement blanks in the text string are preserved to enable compatibility. Example: format code "foo"_M_I_N"!"???,???.000_.000"!"_) is saved as: <number:number-style style:name="N173"> <number:text loext:blank-width-char="M3_I6_N7">foo !</number:text> <number:number number:decimal-places="6" number:min-decimal-places="6" number:min-integer-digits="6" loext:max-blank-integer-digits="6" number:grouping="true"> <number:embedded-text number:position="-4" loext:blank-width-char="."> </number:embedded-text> </number:number> <number:text loext:blank-width-char=")1">! </number:text> </number:number-style> Add QA test Change-Id: I785e1a14ecccc900e9fd5af88dd7b743fefcc48c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146582 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2023-08-25downgrade from assert to SAL_WARNCaolán McNamara
Change-Id: I78130d438fb9da60e929d7b6bad99bb6ec3d3e30 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156095 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-08-25Revert "use more Reference::query instead of UNO_QUERY_THROW"Noel Grandin
This reverts commit 7fc6063914432d58d86cfcbd728d967e7c86ebfd. sberg noticed that there is a difference now: there's a subtle difference now, in that if y was null originally, it would have thrown a (caught) exception, whereas now it will crash in the y.query<X>() call. Change-Id: Idbb5a08d635d15b5ca63f4822eddf05fb0a5afa0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156002 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-08-25sc: fix crash in ScAttrDlg::PageCreatedXisco Fauli
See https://crashreport.libreoffice.org/stats/signature/ScAttrDlg::PageCreated(rtl::OString%20const%20&,SfxTabPage%20&) Change-Id: I3f89cc917648462f819eb35461055096a6eb3853 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156093 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-08-25sc: fix crash in ScTransferObj::DragFinishedXisco Fauli
See https://crashreport.libreoffice.org/stats/signature/ScModule::GetDragData() Change-Id: Ic5cdc3e1796fa20ac84150a04bed539bc9ca7321 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156094 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-08-24Remove duplicated includeAndrea Gelmini
Change-Id: I5bfb0f4bbebdd21c3ceef04b6a7eb36bdd41c52c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156034 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2023-08-24Fix typoAndrea Gelmini
Change-Id: I86dbe2909b19a8a9108f3ba76529ef378c2d663e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156039 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-08-24Fix typoAndrea Gelmini
Change-Id: I1f4d28f834d7e9deb09460fde978bc30d05e351e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156037 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-08-24Fix typoAndrea Gelmini
Change-Id: Iab3ff5a5f9c8917d7de1d886aa331e6110b0ae4a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156040 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-08-24Fix typoAndrea Gelmini
Change-Id: Ief8634c54b5dcf8cdf92882e9026e42cf3e9935e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156038 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-08-23sd: add ThemeDialog to Impress/Draw, refactor ThemeColorChangerTomaž Vajngerl
Add "Theme" menu action, which starts the common ThemeDialog. Add Impress/Draw specific ThemeColorChanger and remove the one in svx, so that only the interface and common function remain. Rename the svx ThemeColorChanger files to THemeColorChangerCommon. Change-Id: Ibf07a443cadf0452747ab6685f65df37b145c984 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155682 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
generated by cgit (git 2.34.1) at 2025-01-22 00:14:47 +0000