summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)Author
2018-01-03tdf#45904 Move _Scenario Java tests to C++Jens Carl
Change-Id: I313f3a56fd99e7fb29e6f729cfe13e99adf1fed6 Reviewed-on: https://gerrit.libreoffice.org/47289 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-01-02Fix typosAndrea Gelmini
Change-Id: Ida13b0649f0b6b1bb25f906ca9ad3a891b45739d Reviewed-on: https://gerrit.libreoffice.org/47262 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-01-02clang-tidy modernize-use-equals-default in sc/source/core/toolJochen Nitschke
remove default-able copy-ctors/assignments Change-Id: I40255393899275a5825ffef4df3f08c6ce5348c2 Reviewed-on: https://gerrit.libreoffice.org/47140 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-01loplugin:passstuffbyref improved return in scNoel Grandin
Change-Id: I487cfe96e9fe65f9be39b2488880410bc7b4baea Reviewed-on: https://gerrit.libreoffice.org/47228 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-31improve const-correctness in ScCaptionPtrNoel Grandin
mostly to make my passstuffbyref loplugin happier Change-Id: I148b6b418100de860dfc49aaec6c544d0fe14c72 Reviewed-on: https://gerrit.libreoffice.org/47225 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-29Fix typosAndrea Gelmini
Change-Id: I0e56430afa65b6b5826d56212ac501c0244fce9b Reviewed-on: https://gerrit.libreoffice.org/47145 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-12-29Fix typosAndrea Gelmini
Change-Id: I3d16dc162e5fa2e08134d848a835eb392e64056e Reviewed-on: https://gerrit.libreoffice.org/47126 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-12-29simplify copy of ScQueryParamJochen Nitschke
define copy assignment for ScQueryParamBase and use default copy implementations for other structs. Change-Id: Ie384a4f9a3647e8492b4921055df0f2c6bff708e Reviewed-on: https://gerrit.libreoffice.org/47141 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-29loplugin:passstuffbyref improved return in svxNoel Grandin
Change-Id: I33bdbd416709ce46afb3c17aeab0d2e19a68ab30 Reviewed-on: https://gerrit.libreoffice.org/47150 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-27Fix typosAndrea Gelmini
Change-Id: Icebbbb392d9187a11837b72116c00036247e9b74 Reviewed-on: https://gerrit.libreoffice.org/47104 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-12-25coverity#1426922 Uninitialized scalar fieldCaolán McNamara
Change-Id: I6b45631448a447eb128f5e30a272f54651db77df Reviewed-on: https://gerrit.libreoffice.org/47039 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-24sc: compact ScColumnAshod Nakashian
Remove ScDocument* member from ScColumn and re-use the one in ScAttrArray. This saves 8 bytes and makes the code more homogenious by using GetDoc() member everywhere. (cherry picked from commit 1168a11278ed3c2a00058e1f802f6e44cb925318) Reviewed-on: https://gerrit.libreoffice.org/46680 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com> (cherry picked from commit dc3f0bde0bdef2a1e94055be146b433cb9fc54ba) Change-Id: I16a94b7ef7c45ef3af14e812b45f255f39939a6e Reviewed-on: https://gerrit.libreoffice.org/46990 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2017-12-23tdf#39593 deduplicate code in ScCellShelltagezi
Change-Id: Ia2a4219a9e21cdbaeaab99df52c79dfa1ce9e184 Reviewed-on: https://gerrit.libreoffice.org/47003 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-12-23Revert "unused SID commands in sc"Noel Grandin
This reverts commit 9c4350441191ccfd6af3d73e13b4eb59af7ed6d1. Eike Rathke: Odd, I don't even remember what these slots were used for.. Ugh.. now I think I know.. (very) old recorded Basic macros used slot:number with the dispatcher instead of the .uno:... commands, so removing/renumbering slots may actually break those. I'm not sure if we already deprecated the slot number thing in an earlier release or maybe it was already done back in OOo times, I simply don't remember. Must be at least 1.5 decades since slot numbers were replaced with .uno commands, but old recorded macros are still supported. However, our qaDevOOo tests and some other tests (in Java) still use slot:#### notation, git grep 'slot:[0-9]' I think best is to revert this change and abandon the other SID removals. Change-Id: I091cf71dd38772dac7491afd6f28951b54510eaf Reviewed-on: https://gerrit.libreoffice.org/46963 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-22tdf#39593 deduplicate code in ScCellShelltagezi
Change-Id: I240715d73c5ae320a3dfab786b446e229083ff4b Reviewed-on: https://gerrit.libreoffice.org/46941 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-12-22can just use default dtorsCaolán McNamara
Change-Id: I4f8974876df033f68f7207dfd66526e7af10a6b3 Reviewed-on: https://gerrit.libreoffice.org/46960 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-22coverity#1426736 Uninitialized scalar fieldCaolán McNamara
Change-Id: I6fbf7004cea04c61f89f3a720a24c9ee82f4b117
2017-12-21Have one getSkipEmptyCellsIndex(), assert array length, tdf#113979 follow-upEike Rathke
Change-Id: Iac38405ac7d246dfe13766b1eefc6310756bffe6
2017-12-21tdf#113979 Add option to Skip empty cellsLaurent BP
During "Txt to column", empty cells should erase previous content (see tdf#69981) But during paste, user may want to keep previous content. This option makes all users happy. During import of CSV file, this option is hidden. In the same time, I've tried to remove some duplicate code. Update: properties offsets are now enum and replace define const Change-Id: I88be2d0432ff804033cff050422e666fa2882efd Reviewed-on: https://gerrit.libreoffice.org/46651 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-12-21unused SID commands in scNoel Grandin
Change-Id: Ifb732e0a52ac7222e0dfb7054981708fa5722b35 Reviewed-on: https://gerrit.libreoffice.org/46886 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-12-21tdf#114603 highlights of EditField if a range is not validtagezi
Change-Id: Ie0576175aa51efe9a1dade1581af9898f66e92e5 Reviewed-on: https://gerrit.libreoffice.org/46866 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-12-21TypedWhichId in svx part 2Noel Grandin
Change-Id: Id927679c9f07f1dd820f4fdca9a45eb7aede037c Reviewed-on: https://gerrit.libreoffice.org/46850 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-21Fix typoAndrea Gelmini
Change-Id: I15b44b42d31eaebd2a8cea29fdaa843c9bd21b73 Reviewed-on: https://gerrit.libreoffice.org/46857 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-12-21no need to play define games with SID_DRAW_CHARTNoel Grandin
since it's only being used in sc/ Change-Id: I1efc54c1816dfb6b91b6bc407767a19cf795c168 Reviewed-on: https://gerrit.libreoffice.org/46885 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-21tdf#79077: Load/save PapersizeFromSetup into ODF for sw and scKatarina Behrens
Change-Id: I0fc1a771927dc7116768cfbb7f7e31006e41e1c8 Reviewed-on: https://gerrit.libreoffice.org/45332 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-12-21TypedWhichId in svx part 1Noel Grandin
and teach the idl compiler how to ignore the TypeWhichId<T1> part of the define Change-Id: I030f54080924d51e9f0ac09b19e14106648024db Reviewed-on: https://gerrit.libreoffice.org/46849 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-21Invert logic, include only known good, tdf#114251 relatedEike Rathke
Change-Id: Ic362ad6c35f7f6374fc262029251e48e4f82d778 Reviewed-on: https://gerrit.libreoffice.org/46863 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-12-20Exclude more special OpCode values from vectorizationEike Rathke
Namely those that have some reference assigned. Change-Id: Icd5f79612295f13d552a256233b8f1298e3e5359
2017-12-20coverity#1426736 Uninitialized scalar fieldCaolán McNamara
and coverity#1426737 Uninitialized scalar field coverity#1426740 Uninitialized scalar field coverity#1426741 Uninitialized scalar field coverity#1426743 Uninitialized scalar field Change-Id: I770b03e54758178f8fdf7128644ddb8c37bf1e83
2017-12-20Fix typosAndrea Gelmini
Change-Id: I28d73221ea83d89f73460f591723c6f80594ff15 Reviewed-on: https://gerrit.libreoffice.org/46822 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-12-19Uncheck Engineering notation checkbox on Scientific selectionJim Raykowski
In Calc, the Engineering notation checkbox in the Sidebar Properties deck Number Format panel can show checked when the cell number format does not contain engineering notation. Change-Id: Ia26fc430aecd7af2e0f614bf9314d99f8408e690 Reviewed-on: https://gerrit.libreoffice.org/46650 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-12-19wrap scoped enum around css::util::NumberFormatNoel Grandin
Change-Id: Icab5ded8bccdb95f79b3fa35ea164f47919c68fa Reviewed-on: https://gerrit.libreoffice.org/46339 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-12-19tdf#114545 Enabling/Disabling Ok button depending on correct formattagezi
Change-Id: Iab3c4363dda0260d16c7167946044c39c21b863a Reviewed-on: https://gerrit.libreoffice.org/46790 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-12-19Add UI config option to enable/disable threadingDennis Francis
Change-Id: I7a83d80c0db233a48026d1254021b926f28002f3 Reviewed-on: https://gerrit.libreoffice.org/46782 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-12-19Resolves: tdf#114539 only pop own parameters from stackEike Rathke
... and not another pending one.. Change-Id: Ief5c27ccfb0b4121f2ba019e0fb8770dabbf60cf
2017-12-19tdf#114479 : Use the SvNumberFormatter from ScInterpreterContextDennis Francis
This fixes one of the crash mentioned in the bug report, during loading of the bug document. The crash being the assert failure in ScDocument::GetFormatTable(). Change-Id: Iffb8ede1416f34f0cd9852fa3f8d1f199406c013 Reviewed-on: https://gerrit.libreoffice.org/46549 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2017-12-19remove unused typedefsNoel Grandin
Change-Id: I6fd7a9fed3a80c91a3766fceefd43c5db0aa5275 Reviewed-on: https://gerrit.libreoffice.org/46763 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-19inline use-once typedefsNoel Grandin
Change-Id: I5c3ffc03c26b3428f1f336e6ecba7838a1cf1157 Reviewed-on: https://gerrit.libreoffice.org/46764 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-19lok: sc: missing header invalidation on undo an autofilter actionMarco Cecchetti
Change-Id: Ibfa7602221ed0c115ad469bd8a61e62baaff0bdf Reviewed-on: https://gerrit.libreoffice.org/46715 Reviewed-by: Marco Cecchetti <mrcekets@gmail.com> Tested-by: Marco Cecchetti <mrcekets@gmail.com>
2017-12-19loplugin:singevalfieldsNoel Grandin
Change-Id: I28c9e436b9d434ce59394ee195ea39815ae49028 Reviewed-on: https://gerrit.libreoffice.org/46685 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-19loplugin:unusedenumconstantsNoel Grandin
Change-Id: I9dc4b369872a7c6c076ae9be1dcdf2f8385af8a7 Reviewed-on: https://gerrit.libreoffice.org/46684 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-19Fix typoAndrea Gelmini
Change-Id: Ib0773324983985f061e390a44702d426c06e18e4 Reviewed-on: https://gerrit.libreoffice.org/46667 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-12-19Fix typosAndrea Gelmini
Change-Id: Ibffe19c1dfda9d0f4ba8d2a0761ad1222491007f Reviewed-on: https://gerrit.libreoffice.org/46599 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-12-19Pick up sheet-local named expressions as well.Kohei Yoshida
Change-Id: I8a081b5f81740fa91f43ac152a950d73d031ed10 Reviewed-on: https://gerrit.libreoffice.org/46666 Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> Tested-by: Kohei Yoshida <libreoffice@kohei.us>
2017-12-18Defer cell value insertion until later.Kohei Yoshida
Because Calc's formula engine expects all named expressions to be present at the time of re-calculations, we need to delay insertion of cell values until after the named expressions are inserted into the document. Change-Id: I54c7d3dc86b3e2c5c192337b1cebfbdfb901ab1f Reviewed-on: https://gerrit.libreoffice.org/46665 Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> Tested-by: Kohei Yoshida <libreoffice@kohei.us>
2017-12-18Pick up global named expressions.Kohei Yoshida
Formulas with named expressions don't work yet since they get imported before the named expressions do. We need to insert formula cells after the named expressions. Change-Id: Id2d7c59194ce7c07a3580cc8d9afd9fdda660b24 Reviewed-on: https://gerrit.libreoffice.org/46664 Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> Tested-by: Kohei Yoshida <libreoffice@kohei.us>
2017-12-18Handle per-cell settings of cell formats.Kohei Yoshida
Change-Id: I500d01921d436643499a24d375d40a607d8fd576 Reviewed-on: https://gerrit.libreoffice.org/46663 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2017-12-18Implement a reference resolver for orcus.Kohei Yoshida
Orcus uses this to resolve cell addresses for some ops. Change-Id: I6ee9667ad994fb830e545ba3368004866a048c25 Reviewed-on: https://gerrit.libreoffice.org/46662 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2017-12-18Remove almost duplicate code blocks.Kohei Yoshida
Change-Id: Ib75d0caa41876908091bed374d3afd802928acf7 Reviewed-on: https://gerrit.libreoffice.org/46661 Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> Tested-by: Kohei Yoshida <libreoffice@kohei.us>
2017-12-18convert SVX_GRAPHICFILTER constants to scoped enumNoel Grandin
Change-Id: I220a2cfe9ea9ef2aa85e4ad8278be70c338891a5 Reviewed-on: https://gerrit.libreoffice.org/46705 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2025-03-01 20:19:52 +0000