summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)Author
2018-02-26convert corner case warningboxes with checkboxesCaolán McNamara
Change-Id: Ic8b58b792236a733b6687148eac5c06bbf734acf Reviewed-on: https://gerrit.libreoffice.org/50325 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-26Introduce enum comphelper::Hash::IterCount instead of boolEike Rathke
Clarifies intention, and with IterCount::NONE prepared to handle something like old PBKDF1, if anything actually used that. See https://tools.ietf.org/html/rfc8018#section-5.1 where iteration count is not part of the re-hash. Change-Id: I5f97ca7a91f611eced8ced0a0c64961c04535d36
2018-02-26convert remaining ErrorBox to weld::MessageDialogCaolán McNamara
and convert remaining QueryBox to weld::MessageDialog Change-Id: Ifb4c316dee8eabf57c4940c44e29c65a2781aa6c
2018-02-26use less RGB_COLORDATANoel Grandin
part of removing ColorData Change-Id: If31b5b88545529863377e9a178f45f4516bf6cbb Reviewed-on: https://gerrit.libreoffice.org/50345 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-26Prepare to handle OOXML Agile Encryption password hash as wellEike Rathke
... that prepends the iteration count to the hash instead of appending it Change-Id: I090393e6337c110029e35baaa259b40ef4e5d416
2018-02-26sc lok: Make the Validation "Invalid value." message box working.Jan Holesovsky
Change-Id: Ic0131fa6fc397ae440efed834266b8396aa9e619 Reviewed-on: https://gerrit.libreoffice.org/50160 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2018-02-26Move convenience abstractions to DocPasswordHelper, tdf#104250 follow-upEike Rathke
Change-Id: If0775ccf14b631918e51342a767412948e812c87
2018-02-26loplugin:useuniqueptr in SvxMSDffSolverContainerNoel Grandin
Change-Id: Ied7b60ac59cf1c869232a96e1b2ccb4e1b5cbf53 Reviewed-on: https://gerrit.libreoffice.org/49945 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-26loplugin:oncevar extend to tools/gen.hxx typesNoel Grandin
Change-Id: I5c75875da44334569c02e2ff039b33c38397a0a2 Reviewed-on: https://gerrit.libreoffice.org/50283 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-25convert remaining InfoBox to weld::MessageDialogCaolán McNamara
Change-Id: I91d828e38d96264cf4a76f30940942556b8f78d8 Reviewed-on: https://gerrit.libreoffice.org/50205 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-25uitest - calc's autofilter bugsZdeněk Crhonek
tdf#115046 tdf#94055 tdf#77479 tdf#112656 tdf#81124 tdf#73565 tdf#65505 tdf#74857 tdf#35294 tdf#55712 Change-Id: I98a79499c3b0eab27e0330e17b9e94f5ecc7ef14 Reviewed-on: https://gerrit.libreoffice.org/50009 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-02-25uitest Calc merged cells- tdf#51368 tdf#105412 tdf#37901 tdf#51368 tdf#63766Zdeněk Crhonek
Change-Id: Iecf46561b999bdb56a93a3412418332513fa83fd Reviewed-on: https://gerrit.libreoffice.org/49561 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-02-25convert all help responses to gtk's -11Caolán McNamara
and ok responses to gtk's -5 and cancel responses to gtk's -6 and close responses to gtk's -7 and yes responses to gtk's -8 and no responses to gtk's -9 Change-Id: Ia1a261a3a711ed9f5d8c0b0c639897c3064bb08c Reviewed-on: https://gerrit.libreoffice.org/50206 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-24Resolves: tdf#104250 import sheetProtection hash attributesEike Rathke
Change-Id: Ibae0934a84173b0933a03a6050abaaf3384404cb
2018-02-24Write ScOoxPasswordHash to OOXML if set, tdf#104250 prepEike Rathke
Change-Id: I51996c673e6c44bbfc27972800d78d9807fe67db
2018-02-24Handle mbEmptyPass and empty hash with OOXML hash value, tdf#104250 prepEike Rathke
Change-Id: Ib24102c442c4675cc5b256fcf8e9d81370aba11f
2018-02-24Add ScTableProtectionImpl::setPasswordHash() for OOXML, tdf#104250 prepEike Rathke
Change-Id: I9589f750cf2f69f4b725cd351aa9ef3749190431
2018-02-24Check also ScOoxPasswordHash::verifyPassword(), tdf#104250 prepEike Rathke
Change-Id: Idf1ec7a4b7cde674891df05aae369c403c028fee
2018-02-24Add ScOoxPasswordHash::verifyPassword(), tdf#104250 prepEike Rathke
Change-Id: Ife588fa0626b01336813e956a25e51541d1096e6
2018-02-24Consider ScOoxPasswordHash in isProtectedWithPass(), tdf#104250 prepEike Rathke
And clear in setPassword() Change-Id: Ib68bb5be8d6908909afc1e1d5bd6bbeccb6d0083
2018-02-24Fix typosAndrea Gelmini
Change-Id: Ie1cff6b690e69d23c16a1a60ef4271d6cf48c13b Reviewed-on: https://gerrit.libreoffice.org/50260 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2018-02-24Hold ScOoxPasswordHash at ScTableProtectionImpl, tdf#104250 prepEike Rathke
Change-Id: I8a3e7e0a29058708ac0a2c5b78afc69bf7bf04a6
2018-02-24Add ScOoxPasswordHash::clear(), tdf#104250 prepEike Rathke
Change-Id: Iaf3bb2ad74fe99435c74e9ea018168ff7e92a977
2018-02-24add test for deduplicating cond format against same formatMarkus Mohrhard
Change-Id: I9e21b5b53f7a3c579bdaf5dc0dd6102be805faf9 Reviewed-on: https://gerrit.libreoffice.org/50217 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-02-24better same document test for conditional format copy&pasteMarkus Mohrhard
Change-Id: Ic896202e072a036108c06768f29ba767d3ea7769 Reviewed-on: https://gerrit.libreoffice.org/50218 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-02-23Move OOXML password definitions to struct ScOoxPasswordHash, tdf#104250 prepEike Rathke
Change-Id: I595d5ae8db6f739900afdfdde1e36b0a0b1d2179
2018-02-23deduplicate cond format against source format if possibleMarkus Mohrhard
Change-Id: Ie4bbbb078f2d0456cd5f3ad6e2c5627aca9fbaa9 Reviewed-on: https://gerrit.libreoffice.org/50216 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-02-23add test for tdf#115835Markus Mohrhard
Change-Id: Ic07e35fcba503461793abb88b463b6e43ca61972 Reviewed-on: https://gerrit.libreoffice.org/50212 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-02-23new loplugin:doubleconvert to with ColorData workNoel Grandin
Change-Id: Ib8f2ef485f548645c4b0e7cf080b72b28c4e278d Reviewed-on: https://gerrit.libreoffice.org/50226 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-23copy multiple single row cond formats correctly, tdf#115835Markus Mohrhard
Change-Id: Ic20cc27f03edf3dbd27975f99c788bf5bffd4c48 Reviewed-on: https://gerrit.libreoffice.org/50211 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-02-23tdf#115933 set document read-only on presence of hashValue attributeEike Rathke
Though there's currently no way (password dialog) to edit the document other than saving it to a different file, this seems to be what is expected. Change-Id: Iafa8ac9f6e41c3011ed0ad4b19cc57382c9f2a75
2018-02-23Read algorithmName, hashValue, saltValue, spinCount, tdf#115933 prepEike Rathke
Change-Id: I799d4652099059fcd09088c02537ed5dec087259
2018-02-23Read algorithmName, hashValue, saltValue, spinCount, tdf#104250 prepEike Rathke
Change-Id: Idc68ad62e8420646d5aecd0d4126084390a1ed55
2018-02-23lok: Factor out the code for finding vcl::Window of a documentPranav Kant
This should also help with IME input on charts Change-Id: Ie513790a5d0c87397c39301a328a44b59d394a45 Reviewed-on: https://gerrit.libreoffice.org/50091 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: pranavk <pranavk@collabora.co.uk>
2018-02-23fix crash while trying to access icon set image fileMarkus Mohrhard
Change-Id: Iaad9b5aeb4163a5262bcaf0a414ee30fd9279a49 Reviewed-on: https://gerrit.libreoffice.org/50219 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-02-22weld native message dialogsCaolán McNamara
just the straight-forward MessageDialog cases first a) remove border_width from message dialog .ui so as to take the default border width b) retain 12 as default message dialog border for vcl widget case c) remove layour_style from message dialog button boxes so as to take the default mode (a no-op for vcl widget case) d) use gtk response ids (vcl builder will converts to vcl ones) Change-Id: I7de281093a1b64f92f71ca11e7cbba42bb658154 Reviewed-on: https://gerrit.libreoffice.org/50143 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-22Remove unused forward declarations from vcl/syswin.hxxStephan Bergmann
Change-Id: Ide4990afa32ba4cc7851d0e7d3d8d1247eb27b3b Reviewed-on: https://gerrit.libreoffice.org/50155 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-02-22loplugin:redundantcastNoel Grandin
Change-Id: I358e9673edcba81336b3895479e787d981fad7a5
2018-02-22Move include/sfx2/notebookbar/NotebookbarContextControl.hxx to include/vcl/Stephan Bergmann
...as it is included from other include/vcl/*.hxx files. (And moving it there helps the heuristic in an upcoming improvement of loplugin:dyncastvisibility.) Change-Id: I15e061fbaba8e82235afb5b312f7b38f26eec900 Reviewed-on: https://gerrit.libreoffice.org/50123 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-02-22loplugin:redundantcopy extend to ColorNoel Grandin
Change-Id: I224cc955d49ee100d328e0171da710f38068d2d4 Reviewed-on: https://gerrit.libreoffice.org/50114 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-22ColorData->Color in scNoel Grandin
and fix the sal_Int32() conversion operator in Color, which was always returning 0 Change-Id: I0aefaedc34ee0a8bccd43238ccfe8196d2dd5c5c Reviewed-on: https://gerrit.libreoffice.org/50051 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-21Limit ScColumnsRange::Iterator to available columns within boundsEike Rathke
Change-Id: Id5481a975dce99a51cc5619e200e5ea46ad3ad1b Reviewed-on: https://gerrit.libreoffice.org/50106 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2018-02-21Use iterator pre-increment/decrementEike Rathke
Change-Id: I079850116648dc69b8c92fa23b30233f63d9b6e7
2018-02-21Pass ScColumnsRange::Iterator as const&Eike Rathke
Specifically for each operator==() call two temporaries were copied, for operator!=() even twice as much.. in for(...:GetColumnsRange()) Change-Id: I4b426ae855454544e50efca35aa73303138f7ba7
2018-02-21ColorData->Color in sd..svxNoel Grandin
Change-Id: I70de56b6bfb1ea4655ec03510fad92bf6645f64e Reviewed-on: https://gerrit.libreoffice.org/50046 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-20Resolves: tdf#115879 treat NOT as the 1-parameter function that it isEike Rathke
... instead of a low precedence unary operator with an odd behaviour. This wasn't documented nor specified but maybe needed for old(est) binary file format compatibility. Generate an error for anything else than a context of a function with one argument. There might be some corner cases of documents where some old usage leads to error now, of which some may have worked by accident, but some not as intended. Related, the internal not exposed (but available) NEG was classified similar as a unary operator but corectly handled as function at all places. Classified as an ordinary 1-parameter function as well. Change-Id: I3d84a6382243c8d64313e37346f81c857e71be95 Reviewed-on: https://gerrit.libreoffice.org/50055 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2018-02-20Add one more test case for importing border colors.Kohei Yoshida
This one is also for the Excel 2003 XML format. Change-Id: I7c9725f4aa6d11523b647e56af634ca9245c44b6 Reviewed-on: https://gerrit.libreoffice.org/50022 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2018-02-20Add another test case for Excel 2003 XML import.Kohei Yoshida
This one is for importing border directions. Change-Id: I92666c30b629109a1061b7ae1fad31841850d34b Reviewed-on: https://gerrit.libreoffice.org/50021 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2018-02-20drop Color::SetColor(ColorData) in favour of operator=Noel Grandin
first stage of getting rid of ColorData Change-Id: I5e4e95eb958722814c43c8d1ebfef17ad18c29ec Reviewed-on: https://gerrit.libreoffice.org/49997 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-20add test for tdf#115530Markus Mohrhard
Change-Id: Ie1eb79d34ca79d1cf085e235e1ead4d886ea7df5 Reviewed-on: https://gerrit.libreoffice.org/49958 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
generated by cgit (git 2.34.1) at 2025-02-24 00:02:15 +0000