summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)Author
2021-04-15store ptr to the original entries in SfxItemPropertyMapNoel Grandin
instead of copying them to a new data structure that is practically identical. Helps startup time since we build a ton of these when loading documents. And use o3tl::sorted_vector as a dense map data structure to reduce allocations and improve cache friendliness, since this is a build-once thing. Change-Id: I950be03b1a21c0c81c40f2677d4215f5e8e256cf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114015 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-15loplugin:stringliteralvar look for assignmentsNoel Grandin
to O[U]String from char array literals, we can convert the char literals to O[U]StringLiteral and avoid a runtime allocation Change-Id: I15d8dddb2cd428b90740e39f20daf98e0941aa6d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114125 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-15Fix commentSamuel Mehrbrodt
Change-Id: Ia9af45c7e9a0805885eebc00e0540f2d69a1859b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114132 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-14Fix typosAndrea Gelmini
Change-Id: I93008d534b9b677ed131e4302e5df4391db4cafd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114090 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-04-14lok: sc: Desktop: Function wizard isn't properly asyncMarco Cecchetti
Open another view of the same spreadsheet when the function dialog is open. Note how the document in the new view can't be edited. This patch avoids to have a view locked after creation when in an other view the formula dialog is open. See also commit 009d275. Change-Id: Ie51f414c4ad83ef20526d10be3251e174158096c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98823 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114060 Tested-by: Jenkins Reviewed-by: Marco Cecchetti <marco.cecchetti@collabora.com>
2021-04-14Early return from ScInputWindow::setPosSizePixel() if no-opTor Lillqvist
This seems to fix https://github.com/CollaboraOnline/online/issues/1988 Change-Id: I5fd826647ce85b7ad2d93085fb0c2fa9db69e745 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114056 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114070 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2021-04-14tdf#126678 - Consider "Include formats" option during sortAndreas Heinisch
Change-Id: Ib972ad6c5042bde6b0c79bf10bace6baab1e935e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111234 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2021-04-13cid#1474366 Untrusted loop boundCaolán McNamara
Change-Id: I943a65dcd0b8d4b1fcd9e7b8626e225159fa1d41 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114017 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-13tdf#106852 (related) Remove stray manual button labelGabor Kelemen
This was (likely accidentally) added in 4c0c77f10c3967c720cb0511dc26986a5b003f33 This caused "Values Only" button to show up without an accelerator and translation Change-Id: I5e9de07583acc93410ab4ce774156d1c71c1042b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114034 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-04-13tdf#79591: No need to use getStr hereMike Kaganski
7ea1bbe712cef48a97faffdf03b45f2812a93e62 had abused the C-style strings, and relied on the names containing zero byte to be truncated on the byte. However, that would only work for names with zero bytes, not with other control characters. Additionally, that prevented the initial names from correct round-trip. This reverts the older fix, and makes sure to handle the attributes with zeroes correctly (using memcpy instead of strncpy). It also removes several similar unneeded uses of getStr. Change-Id: I6c52874d99fe9eb9ccbe0c9a9b57e3b51c45a19f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114040 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-04-13tdf#107586: sc_subsequent_export: Add unittestXisco Fauli
Change-Id: I9f69b179e227ffeb56f9cc207618880cdd00331b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114055 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-04-13tdf#130326 speed up row height calculatedNoel Grandin
for scaled rows. Teach the ForwardIterator to use the slightly faster normal search, and make getRangeData cache the resulting iterator even when doing a tree search. The combination of tree search for the first item, and then using a cached iterator to step through the row data is fairly fast. Take my load time from 23s to 22.3s Change-Id: Icd1aa3d3a8022a073b125dfc05a670b75da1837e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114045 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-13Calc: Send sheet invalidation for full row/col opsGökay Şatır
Change-Id: I4da476804d2dfaf11c1cfd6cbe11cc4a651e0f09 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113251 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114038 Tested-by: Jenkins Reviewed-by: Gökay ŞATIR <gokaysatir@collabora.com>
2021-04-13lok: formula bar: disable tunneled tooltipsMarco Cecchetti
Tooltips overlaps the entered text. Change-Id: If003217fe1270a4a3ebc0ba9eee71cb8f6765760 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95792 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit c4e26fb75f904fc56bd7bcaf200b3227b9065afa) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113999 Tested-by: Jenkins Reviewed-by: Marco Cecchetti <marco.cecchetti@collabora.com>
2021-04-13impress: don't exit textbox editing when new slide was addedSzymon Kłos
When new slide is added by other user before currently visible slide then SwitchPage is called and textbox editing is ended. Avoid any focus change when setPart is called just for rendering or SwitchPage is used on previously avtive slide (only slide numer changed). Change-Id: I7fef42b863e0079acc84dadfc3f891548652b48f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113144 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113806 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2021-04-13tdf#130326 no need to fill ScMatrix with zeros hereNoel Grandin
when we are about to overwrite the data anyway. Takes my load time from 24s ro 23s. The important change (for this test file) is in ScInterpreter::ScAmpersand but I changed all the other places that have the same problem. Change-Id: I95b8ac3b2c10a8b638551e13f6f582e793058833 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114041 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-13lok: formula input bar: get a function inserted in a not focused top viewMarco Cecchetti
Change-Id: Ia52ebbcad8d3febab85f19279859e901f8193c49 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89548 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95104 Tested-by: Marco Cecchetti <marco.cecchetti@collabora.com> Reviewed-by: Marco Cecchetti <marco.cecchetti@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93343 Tested-by: Jenkins
2021-04-13cid#1473844 Untrusted loop boundCaolán McNamara
and cid#1474351 Untrusted loop bound cid#1474118 Untrusted loop bound Change-Id: I060ebe5fbd6275fdd8b615a7cc0cdd7fce5f35bb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114016 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-12less copying in SfxItemPropertyMap::getPropertyEntriesNoel Grandin
we can just expose the map now, and avoid copying all the properties Change-Id: Icb22975508582268dfa96e41eb98ac01e7f51317 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113982 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-12update PCHsCaolán McNamara
Change-Id: Id3728ac0011d3deed7e56081e3a854c7fa5336f3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113959 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-12tdf#132869 - Show the error message in a tooltipAndreas Heinisch
In the define name dialog, the input itself should show the error message in a tooltip. In addition, the possibility to test the tooltip text in python was added. Change-Id: I9bd7d2b2be8300aa366971f8a1f115e8ae19fb98 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113513 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2021-04-12tdf#130326 speed up XLSX load in ScFlatSegmentsImplNoel Grandin
since we are iterating over the tree, use an iterator to speed up subsequent lookups. Takes my load time from 26.2s to 24.3s Change-Id: Iac86c9f60d447cb7679913a0585c9631f845c3e4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113948 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-11ofz#32908 avoid TimeoutCaolán McNamara
Change-Id: I560a5ff4caf204cc46d6cfb5f7680328295020fd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113949 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-11cid#1473782 silence Untrusted loop boundCaolán McNamara
Change-Id: I5c6bd57f2ffbce4a8adf794c46aeb62cae5c6604 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113947 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-11require only as much remaining data as is necessaryCaolán McNamara
Change-Id: If26562a7d5bede1dea414cbe24871b1dd75bfe23 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113943 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-10Related: cid#1474351 Untrusted loop boundCaolán McNamara
we read 6 bytes per loop but the guard is for 2 bytes available (which is the correct amount for for the ImportExcel::Mulblank case but presumably should be 6 for ImportExcel::Mulrk) Change-Id: Iba9c59c042c6fdd9794107e95c024f1763337186 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113928 Tested-by: Jenkins Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-10cid#1474380 silence Untrusted loop boundCaolán McNamara
Change-Id: Ic162a5aeed4b422a8db5ff1bdd89c4e098ffa248 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113908 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-09enable set_busy_cursor to stack up in the gtk version tooCaolán McNamara
Change-Id: Ib9f8ee5af3e40c7563561d0eebc59f4a4fafcfa4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113888 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-09[API-CHANGE] tdf#141543 VBA Range.Formula Range.FormulaR1C1 non-localizedEike Rathke
The VBA compatibility Range.Formula and Range.FormulaR1C1 properties wrongly used localized formula expressions as if they were Range.FormulaLocal and Range.FormulaR1C1Local. That worked in English UI and locales, but not in translated UI or with locale dependent different separators, imported Excel documents using these properties failed there. Instead, use English formula expressions and separators, and additionally implement Range.FormulaLocal and Range.FormulaR1C1Local for localized formula expressions. See https://docs.microsoft.com/en-us/office/vba/api/excel.range.formula https://docs.microsoft.com/en-us/office/vba/api/excel.range.formular1c1 https://docs.microsoft.com/en-us/office/vba/api/excel.range.formulalocal https://docs.microsoft.com/en-us/office/vba/api/excel.range.formular1c1local Unfortunately this change means for macros created in LibreOffice that relied on the erroneous beaviour in a localized environment those macros will cease to work, the remedy in these cases is to replace setting Formula and FormulaR1C1 attributes with FormulaLocal and FormulaR1C1Local instead. Obtaining formulas never worked reliably unless the document's native grammar was very similar to the API grammar (English UI function names, English locale and separators, address convention). For this to work a prerequisite is commit d0b4719ca3d4608bcb7431dbeb097146dd5a5127 CommitDate: Wed Apr 7 02:22:54 2021 +0200 Related: tdf#128334 Make VBA Range getFormula(R1C1) work not only by accident Change-Id: Ifce9ac7557b6a3703d47ee81b57dd8246f3fc3ca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113846 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2021-04-09tdf#105558: sc_macros: Add unittestrounak
to check BASIC currency format returns as a number instead of as a text string Change-Id: Ic618f49aa2a2641cde9ebc9e1c694397a74c4a40 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113621 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-04-09Fix Win64 buildMike Kaganski
... after bff456b37814303e386e86b9d395babaccf164db, which fails only on Win64, where tools::Long is not long Change-Id: Ia919b6371f8d8b6ba7c379992591bb9bcc2fe2ce Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113838 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-04-09Recheck include/ with IWYUGabor Kelemen
See tdf#42949 for motivation Change-Id: Ifc253bf800bb1468b5774663a93f4fb30bec81d3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113657 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-04-09tdf#141416: partial revert of the fix for tdf#81396Xisco Fauli
d4743045a0b320449d07a957463a76bb8b13f939 < the cells need to be imported before we handle charts, tdf#81396 > Import time of sample file in tdf#141416 goes from more than an hour to 1 minute while keeping tdf#81396 fixed Unittest for tdf#81396 added in 9a59068fc31d7150e255ada91c59b8299636f185 Change-Id: Ic15d57945069397076c483b6ef8f3070057db317 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113818 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-04-09tdf#140226: Make use of SfxPoolItems more typesafe by using StaticWhichCastAhmet Hakan Çelik
Change-Id: Ia6c71d84241093843e7efd12b6f0aceee3edaa61 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112190 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-04-09online: update calc inputbar position on changeSzymon Kłos
Change-Id: I9b340cb0f5d5d28b0cc683878ba8fad2c4d8a5af Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113307 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113807 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2021-04-09tdf#119457 - check for a valid range name and cell referenceAndreas Heinisch
Change-Id: If23eda52142ba5e59cfd354f2177b1ac1727efaa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113341 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2021-04-08update PCHsLuboš Luňák
Change-Id: Ia9d04447f927e270a55500e7f35723a729bc01dd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113801 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-04-08tdf#132293 removed all the unused imports from the folder swVatsal32
Change-Id: I5a37f30941a73c276bc238fa9fbdfcfd8381791f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112563 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-04-08tdf#141547: sc: Add UItestXisco Fauli
Change-Id: I97c3019c354b825d17a60c3dc964c8048b4164e2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113794 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-04-08tdf#141547: maQueryItems can be 0Mike Kaganski
E.g., fillQueryParam (sc/source/ui/unoobj/datauno.cxx) may clear it and leave empty if relevant input item is empty. Note how commit e4b924df8f9ad02c66549751cb8e123e420e8508 had changed the same checks in ScQueryEntry::IsQueryBy[Non]Empty. Change-Id: I552462c72e69ddce43711bcff645dc6c7b133db7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113783 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-04-07tdf#138089: sc: Add UItestXisco Fauli
Change-Id: Ib9baa24c899e40062da0347986cf8e5755cf2f0d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113751 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-04-07uitest: factor out common codeXisco Fauli
Change-Id: I4ca17db1ff7221290fedb94700bfb2257e9c647e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113749 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-04-07Updated README.md files to represent current code / use Markdown formatHossein
Previously, all of the README files have been renamed to README.md and now, the contents of these files were changed to use Markdown format. Other than format inconsistency, some README.md files lacked information about modules, or were out of date. By using LibreOffice / OpenOffice wiki and other documentation websites, these files were updated. Now every README.md file has a title, and some description. The top-level README.md file is changed to add links to the modules. The result of processing the Markdown format README.md files can be seen at: https://docs.libreoffice.org/ Change-Id: Ic3b0c3c064a2498d6a435253b041df010cd7797a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113424 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-04-07ScDocShell::GetActiveDialogParent instead of Application::GetDefDialogParentCaolán McNamara
which is more likely to be the relevant calc window Change-Id: I7c939c42752e103494a1df7154b3318643d5206c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113705 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-07tdf#141467 xmloff,sc,sw: ODF export: reorder flys' ZOrder/z-index harderMichael Stahl
Also keep the control layer distinct from the foreground, as a follow-up to tdf#133487. Try to improve the detection of already sorted indexes a bit to avoid unnecessary sorting. Hilariously the test docs require adding 3 additional items to the extension schema. Change-Id: I629d5b09294f679717677b9d89537d905ac4c404 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113696 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-04-07rtl::Static -> function local staticNoel Grandin
Change-Id: I2071c27bdf074403ec24e67f9278ac27f9491303 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113698 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-07lok: draw bgcolor lines for covering client grid...Dennis Francis
... that are over merged cells area. This is needed as client has no information about merged cells. Change-Id: I625d64cc3abd0ee1e60a8af9469a152286f25fd0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113145 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> (cherry picked from commit e3fa896aa14c03165190f0fef304ff0e8074d619) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113632 Tested-by: Jenkins Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2021-04-07Related: tdf#128334 Make VBA Range getFormula(R1C1) work not only by accidentEike Rathke
i.e. if document native grammar was very similar to the API grammar (English UI function names, English locale and separators, address convention). Also alloc and init second string and conversion only if necessary. These Formula and FormulaR1C1 properties still behave like FormulaLocal and FormulaR1C1Local, which is wrong, see https://bugs.documentfoundation.org/show_bug.cgi?id=128334#c12 Change-Id: I589b36c2cd51d5bbba767a309ccf61bd051928a4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113711 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2021-04-07Resolves: tdf#128334 Reset mnCurrentSheetEndPos, mnCurrentSheetTab in all casesEike Rathke
Encountered for a single decimal separator not being a value either, but could be for any condition within IsReference() returning false up to the IsSingleReference() call. Change-Id: I6222adf2a2d06904001175da8798b2ba9fdef99c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113697 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2021-04-06remove Application::GetDefDialogParent call in editengCaolán McNamara
and pass in an explicit parent to use Change-Id: I1aa768ec5ac13b2097b78499f964a3590a0ac14e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113695 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2024-08-09 21:45:14 +0000