summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)Author
2018-10-03unweld HeaderEditPage for nowCaolán McNamara
not ready yet Change-Id: I022b47c521a63fb18052274aa8e2020dc6210d9c Reviewed-on: https://gerrit.libreoffice.org/61289 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-03crash in calc page dialogCaolán McNamara
Change-Id: I06072af58b0e302930a8d305f2b667843c42cd03 Reviewed-on: https://gerrit.libreoffice.org/61284 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-03keep reset/standard orderCaolán McNamara
Change-Id: Idc047faf8ade81b3e6fce382b188ccfa97004b12 Reviewed-on: https://gerrit.libreoffice.org/61263 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-03loplugin:unusedmethodsNoel Grandin
Change-Id: I7db0c27ff2213210ed4b46ebbadc1a2f74a18257 Reviewed-on: https://gerrit.libreoffice.org/61249 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-03loplugin:mergeclass merge ScFullMatrix into ScMatrixNoel Grandin
ever since commit b26f83b1cc184a79caa9e9c0ae15717ef61dde4a Date: Fri Aug 10 21:43:32 2018 +0200 loplugin:unusedmethods mostly this seems to be fallout from commit 089a4f245325a5be5cd5951d85305d791b4d9cb6 Date: Mon Aug 6 14:55:04 2018 +0200 remove Calc's software interpreter Change-Id: Id1cb89bb3d95521b7ddf7d072ee9392053e5a52b Reviewed-on: https://gerrit.libreoffice.org/61257 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-03loplugin:unusedfieldsNoel Grandin
Change-Id: Idf6f7f2946eecada64d2a586194533840ec8cc63 Reviewed-on: https://gerrit.libreoffice.org/61248 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-02-Werror,-Wunused-private-fieldStephan Bergmann
...ever since the code's introduction in 278b1de21f8395ab2a6c49377cf4aec4c16f05c6 "Added base as a data provider" Change-Id: I3ccd1d699e0888cb010e46735f8816eea8b41e34 Reviewed-on: https://gerrit.libreoffice.org/61250 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-10-02Silence new Clang trunk -Wdefaulted-function-deletedStephan Bergmann
This mostly affects explicitly defaulted functions that had recently been user- declared to silence new GCC trunk -Wdeprecated-copy. It is not entirely clear to me what the best approach is overall, see my mail <http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20181001/245321.html> "Re: r343285 - [cxx2a] P0641R2: (Some) type mismatches on defaulted functions only", but lets just explicitly delete those functions for now. Change-Id: If8c72f612f67a8feb8b03c2fb988c807e704ef03 Reviewed-on: https://gerrit.libreoffice.org/61259 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-10-02Fix typoAndrea Gelmini
Change-Id: I34e0e97b165b8335e58bcc5713d2140b31ee94ed Reviewed-on: https://gerrit.libreoffice.org/61225 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2018-10-02tdf#120174 : Always copy mbValueCached flag in Assign()Dennis Francis
so that fast result return maintains correctness. Although not necessary for fixing this bug, lets take advantage of fast result return in the case of empty result token by setting mfValue to 0.0 and setting mbValueCached flag. The fast result return was implemented in :- <commit-header> commit 77f7b4768a79e5a8489b163670e0ce10fbd07c49 Author: Dennis Francis <dennis.francis@collabora.co.uk> Date: Wed Jul 11 17:19:28 2018 +0530 Allow fast result return for formula-cells with... "double" result which is a very frequent use-case. This improves overall running times in most cases, not just for the threaded path. Change-Id: I18d10ee3cea613923e2057e746a6a8187bb18647 Reviewed-on: https://gerrit.libreoffice.org/59395 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com> </commit-header> Also added a ui-test for the fix. A normal unit test would have sufficed, but I could not get it to reproduce the issue from a ucalc environment somehow. Change-Id: I9b95b571b596a7bb68768ea0de8ee4334448b540 Reviewed-on: https://gerrit.libreoffice.org/61140 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins
2018-10-02tdf#120227 'standard' button missing from .uiCaolán McNamara
and 'standard' just has to exist, doesn't need to be translatable Change-Id: I1e5157781ea81c40952c462253a2e3d53557aecb Reviewed-on: https://gerrit.libreoffice.org/61229 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-02Cater for --without-java in CppunitTest_sc_dataproviderStephan Bergmann
...which appears to still work if you just disable the components that are not present because they require Java. Found by <https://ci.libreoffice.org/job/lo_tb_random_config_linux/1514/>. Change-Id: I1a7f27a9f44d2a82953e4230c974f19e98127550 Reviewed-on: https://gerrit.libreoffice.org/61226 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-10-02consistent 3.18 version require in .uisCaolán McNamara
Change-Id: I5102c218c969cf9302405e4146f92e187c1998ce Reviewed-on: https://gerrit.libreoffice.org/61215 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-02make all notebooks scrollable and enable_popupCaolán McNamara
Change-Id: I16a6d556ca4c6b3f876dc0c8380d01fe3022209e Reviewed-on: https://gerrit.libreoffice.org/61195 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-02weld SvxLineTabDialogCaolán McNamara
Change-Id: Icb13a6eb2e8c6f6dbd3cf477051bc0bd682e2e7a Reviewed-on: https://gerrit.libreoffice.org/61193 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-02tdf#115262 sc: fix cumulative placement error of imagesMiklos Vajna
Commit 708d1c5ab242b545ced598879233fc662d7e6cc0 (sc lok: emit RowColumnHeader info in twips, 2015-11-02) improved precision of the twip -> pixel conversion ratio, but ignored the detail that limited precision used to silence cumulative errors that appear with larger precision. The original use-case was better precision of row/column headers for the LOK API, so keep that as-is, but go back to the original behavior on the desktop. Change-Id: Ide169ab1745a9a9299caf3334559884ff7223cbe Reviewed-on: https://gerrit.libreoffice.org/61219 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-10-01pass menuitem ident around directly, instead of deriving from itemidCaolán McNamara
sidestepping the while duplicate itemids in separate submenus problem Change-Id: Icb57ac805f3c8c4fc3a68341e318375c6492cbb1 Reviewed-on: https://gerrit.libreoffice.org/61189 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-01tdf#119580 contextmenu ole is now synced between different appsandreas kainz
writer changed to objectalign and arrangement is like in graphic all sw context menues oleobject.xml are 100% the same draw layout is similar to writer character and paragraph was removed cause text features are needed in drawtext not in ole impress layout is the same than draw with interaction instead of name Change-Id: I388e9f531f99ef739799a99c011b6aa3f57f08df Reviewed-on: https://gerrit.libreoffice.org/60128 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-10-01tdf#119411 where needed added PasteUnformatedandreas kainz
checked all different apps and options. this it what will work now maybe in the future additional options will be available but now it's fine with this patch Change-Id: I27671e80c9ec3d1304605405ff79cb19c3f4c88c Reviewed-on: https://gerrit.libreoffice.org/60062 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-10-01tdf#119412 contextmenu graphic is now synced between different appsandreas kainz
all sw context menubars graphic.xml are 100% the same calc layout is similar to writer with edit hyperlink and assign macro draw layout is similar too with name cause you may want to rename items for navigator impress has interaction instead of rename the other items are 100% like draw Change-Id: I573af9de4b1dc9572048f7d39160bce6ca1b66dd Reviewed-on: https://gerrit.libreoffice.org/60097 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-10-01Change all font-based tests to depend on ooo_fontsJan-Marek Glogowski
Instead of depending on individual font packages. Most didn't depend on fonts at all. Change-Id: I190295bbecb1b44aa34aaf0874afadd35b5daeb4 Reviewed-on: https://gerrit.libreoffice.org/61159 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-10-01loplugin:useuniqueptr in ScCondFormatDataNoel Grandin
Change-Id: I93c906bfb84143ff101577e8e1ef8f5ffb07a0a7 Reviewed-on: https://gerrit.libreoffice.org/61114 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-30weld SvxLineEndDefTabPageCaolán McNamara
Change-Id: I3e947511bbffae4cd48388b17a8fb9a13d453bab Reviewed-on: https://gerrit.libreoffice.org/61139 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-30ofz#10406 fuzzing oomCaolán McNamara
reduce repeated allocations totalling 2.944G worth of allocations to 877.4M, peak usage remains unchanged at 4.2M Change-Id: I9840bdb25a72021f6085fa318b51a687d5f36149 Reviewed-on: https://gerrit.libreoffice.org/61155 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-29tdf#111980 sc optionbutton autoGroups different for form/activeXJustin Luth
This patch only affects calc. (Perhaps .xls* is the only format that supports non-activeX radio buttons?) Commit 9f969799629fe6bdf8b922d8cb922846aa646ece worried about form and activeX buttons sharing the autoGroup_. This patch prevents that. Change-Id: Ia57a14f1cdd6363aa5d6d991469668fcc56016ca Reviewed-on: https://gerrit.libreoffice.org/61095 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2018-09-28Added base as a data providerVikas
Change-Id: Iaf23b70f303cd05bcf6450fed1246de894285526 Reviewed-on: https://gerrit.libreoffice.org/57447 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-09-28weld ScStyleDlgCaolán McNamara
Change-Id: I67e6a6cd1f0b018012c3a373c856494c4fc02979 Reviewed-on: https://gerrit.libreoffice.org/61048 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-28weld ScAttrDlgCaolán McNamara
Change-Id: I11eb9001604a1997a8bfa80a144306ddcb913d93 Reviewed-on: https://gerrit.libreoffice.org/61011 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-28weld SvxNumberFormatTabPageCaolán McNamara
Change-Id: Ia6e6497d5c9b6c47e34e5cb5b3913d25e73c3a69 Reviewed-on: https://gerrit.libreoffice.org/60944 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-28loplugin:unusedmethodsNoel Grandin
Change-Id: I5f9ef043d76c55f2c761fd08a2bc1dae66b675c8 Reviewed-on: https://gerrit.libreoffice.org/61073 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-28tdf#111980 oox: connect empty radio groupsJustin Luth
affects doc, docx, xls, xlsx (at least). Handling optionbutton groups is new since 2017, so incremental enhancements are OK. In LO, if an option button with an empty groupName (like any form control which has no groupName option), then it stands alone, which is a ridiculous position to be in for a radio button. So, lets put them all together into an automatic group. In MSO, buttons without any explicit group stick together, so the effective group is the entire document, or entire sheet. One complication is that ActiveX radio buttons don't interact with Form radio buttons, even if all of them have no group name. That situation is not handled by this patch (and not very likely to happen since ActiveX defaults the group name to the sheet name). (A Group Box can also be used, which automatically groups all buttons fully within its area. That will be much harder to implement since every object will need to first be categorized as groupbox or optionControl - meaning that everything must first be imported. That implies a function call from every application doing the import.) Change-Id: I204adaea75ce99999a16c0cc4e9c3b8b08da9433 Reviewed-on: https://gerrit.libreoffice.org/61064 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2018-09-28loplugin:unusedfieldsNoel Grandin
Change-Id: I355fad84ed8765e8eb3fadb7c239b3b902ec1747 Reviewed-on: https://gerrit.libreoffice.org/61059 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-28loplugin:useuniqueptr in ScChartPositionMapNoel Grandin
Change-Id: I7c3209dff1c09c40d7a3bb57db0f0b26254318f2 Reviewed-on: https://gerrit.libreoffice.org/60996 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-28loplugin:useuniqueptr in ScDPResultTree::MemberNodeNoel Grandin
Change-Id: I835e37a99ddab174e45681fe6cf55edaa41a727c Reviewed-on: https://gerrit.libreoffice.org/60995 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-27UND->AND; ODER->ORMike Kaganski
Change-Id: I921db377c257dc50e3f39fe04f0ad093f3db6a81 Reviewed-on: https://gerrit.libreoffice.org/59896 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2018-09-27weld ScTablePageCaolán McNamara
Change-Id: I38d86705de3215a7e8c24f03c2d253751e66b2d8 Reviewed-on: https://gerrit.libreoffice.org/61040 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-27coverity#1439332 silence Identical code for different branchesCaolán McNamara
Change-Id: I9f477e063fd764fff24843562a2de34b5498d4c5 Reviewed-on: https://gerrit.libreoffice.org/61038 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-27loplugin:methodcycles more graph theory for the winNoel Grandin
implemeent a reduction approach, which is good at finding virtual methods that only themselves or their virtual partners. The accessibility GetVisArea stuff is dead since commit 891e41fac81fbd8d5cdb277b26639abfd25a7143 Date: Wed Apr 4 11:23:22 2018 +0200 dead code in AccessibleTextHelper_Impl::UpdateVisibleChildren Change-Id: I78d9d8bca585ecec8394f2c3fe2baa93db0e58f5 Reviewed-on: https://gerrit.libreoffice.org/60912 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-27loplugin:useuniqueptr in ScTable::FillAutoNoel Grandin
Change-Id: Ia75a0dc9aa567b00517c066a65e4a0d1536fa9bd Reviewed-on: https://gerrit.libreoffice.org/60999 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-27loplugin:useuniqueptr in Chart2PositionMapNoel Grandin
Change-Id: I6db63c66da67fa9133333b4d0cda2b2978140e77 Reviewed-on: https://gerrit.libreoffice.org/60998 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-27loplugin:useuniqueptr in ScAddInAsyncsNoel Grandin
Change-Id: I18086623378a6ffd9272b2255ea8060d301b6c43 Reviewed-on: https://gerrit.libreoffice.org/60997 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-26fix positioning within cellprotectpageCaolán McNamara
Change-Id: I9ae7fd7f6ff7b999018cc0ba13147dd69dc7e9ae Reviewed-on: https://gerrit.libreoffice.org/61010 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-25loplugin:useuniqueptr in SdrHdlListNoel Grandin
Change-Id: I83241bd2ed172594704f4b115b584dc39b234086 Reviewed-on: https://gerrit.libreoffice.org/60959 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-24tdf#42949 Fix IWYU warnings in include/comphelper/[a-l]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I22ba2c8aec235e34cd7835b8a0a716bf3057db7a Reviewed-on: https://gerrit.libreoffice.org/60837 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-09-24make all the related inheritences formatted the same wayCaolán McNamara
Change-Id: I2e0c060a86cd199a640589a7599fa5f01ef77e3b Reviewed-on: https://gerrit.libreoffice.org/60943 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-24weld ScTabPageProtectionCaolán McNamara
Change-Id: I85fa703ebe73987822f85ff722f02627751937ec Reviewed-on: https://gerrit.libreoffice.org/60909 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-24coverity#1438870 Big parameter passed by valueCaolán McNamara
Change-Id: I6ade72ed19b63b7f68c8f58c57bb409eab55e55c Reviewed-on: https://gerrit.libreoffice.org/60919 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-22tdf#45904 Move _XIndent Java Tests to C++Rahul Gurung
Change-Id: I65b594db595f0e08a50a9ea18baf44c496cf18e3 Reviewed-on: https://gerrit.libreoffice.org/60218 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-09-22Added Date and Time Transformation in data provider dlgManuj Vashist
Change-Id: Iead6b030d54983d08543656d2b62e42ba38b946e Reviewed-on: https://gerrit.libreoffice.org/58912 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-09-21coverity#1438870 Big parameter passed by valueCaolán McNamara
Change-Id: If170645fa09ffc41948d1770df65b38d35a3f71e Reviewed-on: https://gerrit.libreoffice.org/60856 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2025-02-25 16:16:15 +0000