summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)Author
2016-04-24remove comment about old compiler issueJochen Nitschke
left change in place as it improves readability original commit was 59433cfbff6eba5a13051945f34b827ddc66917e move scope of variable Change-Id: I86f7a7c741556d75079bd4cb3cfecafcdd229d24 Reviewed-on: https://gerrit.libreoffice.org/24325 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-04-23FormulaByteToken(ocClose) was always wrongEike Rathke
... should be FormulaToken(svSep,ocClose) instead. Though it didn't hurt at the end of a formula where this was generated for auto-correction. Change-Id: I71bd8270ccc268e645eb60298e84acffe39d3a0d
2016-04-23SC_OPCODE_STOP_... values are exclusiveEike Rathke
... didn't harm here though as there are gaps between sections. Change-Id: If3f4e9e5c41233dc47fde18219c8eb5bc5796d9e
2016-04-23use FormulaToken::DeleteIfZeroRef() instead of Delete() at some placesEike Rathke
The array overflow detecting places that unconditionally deleted the token in case of overflow should do so only if no reference is held, i.e. the token was allocated with new and passed immediately without being assigned to a FormulaTokenRef. Just to be on the safe side. Change-Id: If2ccabec3725ac73fe82c23f51a291246847cfdb
2016-04-23simplify the ReplaceToken() offset logic to absolute offsetsEike Rathke
Change-Id: I8d02fb63bc0c5cb48aabaf7a8800f5f9ac95cbf5
2016-04-22Avoid reserved identifiersStephan Bergmann
Change-Id: I782784f34975d708fdf179d098ce6654aad7a976
2016-04-22remove unused BiffStringFlagsJochen Nitschke
users are gone since bb5fa5773461e14de153266ccfa36e5f454ff9b8 Change-Id: I8a73fdbec0df467bcaa3dc26fae5c965fd5bc612 Reviewed-on: https://gerrit.libreoffice.org/24266 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-04-22Fix typosAndrea Gelmini
Change-Id: Iea11112a1bf1ff934de0e355b9e81979aa1966a3 Reviewed-on: https://gerrit.libreoffice.org/24286 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-04-21Resolves: tdf#99360 can't select filter criteria with mouseCaolán McNamara
regression since commit 6610ad9aee0c8299880cd1da6cd6a756860ccad9 Author: Jaskaran <jvsg1303@gmail.com> Date: Wed Mar 2 07:51:40 2016 +0530 original body of this method were protected by "if (IsActive())" before conversion, adding that back into the new version makes things apparently work again Change-Id: Id7e89c7724ed804d0330645c4e05dee113ce2079
2016-04-21loplugin:salbool: sal_Bool[] -> bool[]Stephan Bergmann
Change-Id: I3c5bf7a53c9ae173f8fce885ecf022f092aa43a9
2016-04-21lokit: add getPartHashHenry Castro
In the tiled rendering case, the slides, no matter if it is inserted or deleted, the part names always return sequential names i.e. Slide 1, Slide 2, ..., Slide N. However the client side needs to know what slides had been deleted or inserted, so it is necessary to send the hash codes. Change-Id: I0e9caeec660c3e42dd9f751bdce7690f9ad365a1 Reviewed-on: https://gerrit.libreoffice.org/24267 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-04-21new plugin stylepoliceNoel Grandin
check for local variables which follow our member field naming convention, which is highly confusing Change-Id: Idacedf7145d09843e96a584237b385f7662eea10
2016-04-20loplugin:salbool: Automatic rewrite of sal_False/TrueStephan Bergmann
Change-Id: I9b99327d58a63dfa5c292784cefb4894ee6d7fa8
2016-04-20tdf#99361 Separate checkbox in SidebarLaurent Balland-Poirier
"Thousands Separator" and "Engineering notation" used the same checkbox, so help tips texts were the same. This commit creates a second checkbox which is hiden/shown according to category selected Change-Id: I804c2c7b4625497da8e423a952b357fbd8bbfa19 Reviewed-on: https://gerrit.libreoffice.org/24173 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-04-20clang-tidy clang-analyzer-deadcode.DeadStoresNoel Grandin
suspect that some of these may reveal latent bugs.... Change-Id: I9de9aabbda9c8952715631577c29c1830df1eb71 Reviewed-on: https://gerrit.libreoffice.org/24200 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-20Resolves: tdf#91778 drawing the background over an active cursorCaolán McNamara
will overwrite it, which means that when it toggles "off" afterwards, it uses invert on the freshly drawn background which will visually make it appear "on" and not off Just explictly turn it off and restore it and avoid the whole potential problem. Change-Id: Ie21d77e9d704124011e43b42c98b26eaf208eef2
2016-04-20character spacing control possible to use outside sidebarSzymon Kłos
Change-Id: Ic0c6458268b529bd0107d6ed5a35f49241cfb833 Reviewed-on: https://gerrit.libreoffice.org/24146 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2016-04-19tdf#99329 : By default show sum and average statusbar functions...Dennis Francis
and correctly handle the non-default profiles from <= 5.1.*. Change-Id: If230364a81774e43836956eb38fb8257ddf176b2 Reviewed-on: https://gerrit.libreoffice.org/24118 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Joel Madero <joel.madero@gmail.com> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-04-19cppcheck: silence known conditions warnings in scJochen Nitschke
Change-Id: Ibb9f05d2166d75c50f91f65905b3018a5fdb2455 Reviewed-on: https://gerrit.libreoffice.org/24203 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-04-19const as const can, tdf#99322 follow-upEike Rathke
Change-Id: I8c9714e6c6b15fbb1068b79d2efae48927a1fa77
2016-04-19sc: fix loplugin:passstuffbyrefMiklos Vajna
Change-Id: I6716817b0ca439b63cc7b49eb7a611c2c15a9b00
2016-04-19call StartNeededListeners() only on affected columns, tdf#99322 follow-upEike Rathke
Iterating over the entire document is an unnecessary performancce penalty if the set of affected columns is already known. Change-Id: I84598066f878ca4615d6a5e1d6c70ebaa686e446
2016-04-19use the column style for as default, tdf#71897Markus Mohrhard
Change-Id: I583235c28957a203df843d65887b4ca05f2a81ae Reviewed-on: https://gerrit.libreoffice.org/24230 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-04-19setting the properties through uno is not necessary anymoreMarkus Mohrhard
Change-Id: Icdd78ffb386b6b5222558dde0a6a9439b1431781 Reviewed-on: https://gerrit.libreoffice.org/24229 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-04-19hard code value for scrollbar to tabbar ratio, tdf#89058Markus Mohrhard
The regression was introduced with 1d1d1c62caf2ee6a96946e96d782e03f3ef80439 which traded interoperability for some UX "gain". Change-Id: I36517fc550e12714ad5855ce0bc5883f7a948a51
2016-04-19don't try to open in new window by default, tdf#70959Markus Mohrhard
This fixes a regression from 99932fa89be0e041abf5ce5da3271600c841ff19 Change-Id: Idcee34c97173fb79503a560f5246230a9bfaeb51
2016-04-18Resolves: tdf#99322 re-establish group area listeners after update referenceEike Rathke
Change-Id: If2ec5f938c7278ce817de3d89dc84cc0584507ac
2016-04-18tdf#99371 fix for DDE link update via Function WizardMartin Nathansen
With this fix the DDE links can be edited again without producing additional wrong DDE links. However below the updated DDE link there is still a unnecessary table added which should be fixed. Change-Id: I51e5a7ec84d2fc1429e68554dc131e4e456540df Reviewed-on: https://gerrit.libreoffice.org/24213 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-04-18cppcheck: silence known condition warning in sc vbahelperJochen Nitschke
Change-Id: I5afc4563fa119a71069daa608020cd215477b872 Reviewed-on: https://gerrit.libreoffice.org/24205 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-04-18tdf#90290: use custom asserter for formula checkStefan Weiberg
Change-Id: Ic31d54b2929ce731a9330dca86256ac973375dfd Reviewed-on: https://gerrit.libreoffice.org/24215 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-04-18Avoid reserved identifier (_CreateShape -> CreateShape)Stephan Bergmann
Change-Id: Idcdd35302e60392fae9f63de1828e1a41ab89610
2016-04-18clang-tidy performance-unnecessary-copy-initializationNoel Grandin
probably not much performance benefit, but it sure is good at identifying leftover intermediate variables from previous refactorings. Change-Id: I3ce16fe496ac2733c1cb0a35f74c0fc9193cc657 Reviewed-on: https://gerrit.libreoffice.org/24026 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-18clean-up: unused using declarations and includesJochen Nitschke
Searched source for using declarations. Checked if those symbols reappear in the source file, even in comments or dead code but not in #include statements. If they don't reappear, remove the declaration. Remove includes whose symbol got removed. Change-Id: Ibb77163f63c1120070e9518e3dc0a78c6c59fab0 Reviewed-on: https://gerrit.libreoffice.org/24148 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-17remove define for ERRORBOXMarkus Mohrhard
Change-Id: I6b5695fb36143b36d72b4c7a4b072d41d94f6501 Reviewed-on: https://gerrit.libreoffice.org/24167 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-04-16fix last mdds perf problem in MatConcat, tdf#88849Markus Mohrhard
Change-Id: Idf00ff11e1aa4a3439e17938570385ee3b25726c Reviewed-on: https://gerrit.libreoffice.org/24125 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-04-16fix crash in perfcheckMarkus Mohrhard
Change-Id: I8e053f5f0c6994c44485f61f5b3dc489271b8c5f
2016-04-16switch to a row based storageMarkus Mohrhard
The row based approach fits better with mdds Change-Id: I2a03ccadffaa499c17084c6b131aa3f8eaf66573 Reviewed-on: https://gerrit.libreoffice.org/24123 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-04-16make the test case smaller to limit runtimeMarkus Mohrhard
Change-Id: I374f33d2001f872075d2d0be1527d19f1be1175a
2016-04-16add test case for smaller MatConcat case, related tdf#88849Markus Mohrhard
Change-Id: I8faf836e87ae371a156e07ec7a5bc274ccf32efd Reviewed-on: https://gerrit.libreoffice.org/24124 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-04-16add missing test fileMarkus Mohrhard
Change-Id: I92c879c4efc84115556801fc9a3095ef6b876348
2016-04-15tdf#97499 Fixed containers parameters clearing #5tymyjan
Change-Id: If9868734b255605f2376c30e66ca144e6fd8b803 Reviewed-on: https://gerrit.libreoffice.org/24034 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-04-15add test for tdf#88849Markus Mohrhard
Change-Id: Id72d94799e20f0b290d5d5b05fb2b351d0750178
2016-04-15fix calc perfcheck buildMarkus Mohrhard
Change-Id: Ied1ca0c9c3e2c7cd34c4d21e27a95df21ab80bf9
2016-04-15add test for tdf#72240Markus Mohrhard
Change-Id: Ia27b84094e21758286422921e2bd017f9874dc06 Reviewed-on: https://gerrit.libreoffice.org/24104 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-04-15fix InsertTab and DeleteTab in ScMarkData, tdf#72240Markus Mohrhard
Change-Id: Id3168e4cac6c52b36833b454518cce55b51e36b4 Reviewed-on: https://gerrit.libreoffice.org/24103 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-04-15add CVE-2016-0122 testCaolán McNamara
Change-Id: I065f6d7c62ffa604fc5cc3e522c991068652c8bb
2016-04-15typo: Aggegration -> AggregationAndras Timar
Change-Id: Ica0bef9d0ac4a5d6a2c01a1f5abf859817713f85
2016-04-14-Werror=logical-op (GCC 6)Stephan Bergmann
"logical ‘or’ of equal expressions", as RTL_TEXTENCODING_DONTKNOW is defined to be zero Change-Id: I1df1579734a3b9b5ecce5a072916cd57dbcd1458
2016-04-14loplugin:passstuffbyref in scNoel Grandin
Change-Id: I75c483972db787ea9c941eaac0df023f1929b09c
2016-04-14no need to call rowHidden and rowFiltered repeatedly, tdf#90659Markus Mohrhard
Change-Id: Ie104a0d6c2ee0a88363fb461762e2bcca00976dd Reviewed-on: https://gerrit.libreoffice.org/24052 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
generated by cgit (git 2.34.1) at 2024-07-08 09:35:55 +0000