summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)Author
2016-03-30tdf#98893 Remove expensive calls to GetCellType + GetValue/... in calcAleksas Pantechovskis
Change-Id: Ie9a16fa1b44d41cc9d10b50c37ba15f3b7e786c8 Reviewed-on: https://gerrit.libreoffice.org/23561 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-03-30add TODO comment for a bugMarkus Mohrhard
This bug is the first one that was discovered because it is now much easier to see which parts of the code work on cells, pattern areas and whole columns/rows. Change-Id: I8f22bf421298947d65bfc2fc9c986d85169e6545 Reviewed-on: https://gerrit.libreoffice.org/23636 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-03-30extract another function from ScDocument::FillInfoMarkus Mohrhard
Change-Id: Ief094beebbff2bce9f087853cbda6adeeafe07fc Reviewed-on: https://gerrit.libreoffice.org/23635 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-03-30stylistic changes in ScDocument::FillInfoMarkus Mohrhard
Change-Id: I98bb25d414106259a809698941a000d6d0bc35e0 Reviewed-on: https://gerrit.libreoffice.org/23634 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-03-30limit scope of another variable in ScDocument::FillInfoMarkus Mohrhard
Change-Id: Ic53bcaa5e33f221a643de4e854990769b5c04a74 Reviewed-on: https://gerrit.libreoffice.org/23633 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-03-30limit the scope of a few variable in ScDocument::FillInfoMarkus Mohrhard
This makes the code at least a little bit easier to read as we can now see much easier when a variable is used to transport state between loops and when it is just a variable local to a loop Change-Id: Ib92ff1596bda35f9892accc820bc3596bafb7d96 Reviewed-on: https://gerrit.libreoffice.org/23632 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-03-30extract another function from ScDocument::FillInfoMarkus Mohrhard
Change-Id: Iac607e1fe915c8bc90316508c98855a60117d435 Reviewed-on: https://gerrit.libreoffice.org/23631 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-03-30extract another function from ScDocument::FillInfoMarkus Mohrhard
Change-Id: If6f898d514dc454a7f1c5448769a95269e9066d7 Reviewed-on: https://gerrit.libreoffice.org/23550 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-03-29that should not have become part of the previous commitMarkus Mohrhard
Change-Id: Ia116e5f9fdbd34cd1017ec1f2dabf6e581c4c707
2016-03-29extract another function from ScDocument::FillInfoMarkus Mohrhard
Change-Id: Ifd39ec5ad7aebac532ea7145274005507a5b177f
2016-03-29Bin pointless commentTor Lillqvist
The history of the file can be browsed using the version control system. Change-Id: Ibf087fb476a91bd36d5cafe62def4120ddece1a1
2016-03-29tdf#96099 fixes trivial typedefs, ::std::vector<OUString>Apachev Ivan
Change-Id: If01819b43c6cf4665e0aca90f9fb2b4363feae69 Reviewed-on: https://gerrit.libreoffice.org/23060 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-03-29ScOpenCLTest is not a FiltersTestTor Lillqvist
Remove unneeded derivation and thus the load() function implementation too. Change-Id: If796741198fea141c0d68505893a7f70f048d515
2016-03-29Avoid running out of memory on Windows when OpenCL is availableTor Lillqvist
Call Clear() on the ScDocShellRef (derived from tools::SvRef) members of the ScOpenCLTest object in tearDown(). Otherwise the memory used by the ScDocShellRef objects in each ScOpenCLTest object would be held until when all the ScOpenCLTest objects are destroyed in the end. (CppUnit creates all the ScOpenCLTest objects in advance, then calls the test functions on them, and then destroys them.) The issue was a side-effect of the (otherwise nice) fix for tdf#89267. Change-Id: Ie5c59f2f089386c0abc135136397e1653c975fdc
2016-03-29set translatable property in .ui files (bin/ui-translatable.sh)Andras Timar
Change-Id: I8b382bddac208d12216842ace6511b8b9127f205
2016-03-29Avoid reserved identifiersStephan Bergmann
Change-Id: I759939aa74570be63f5d41814c22aad1851d65c4 Reviewed-on: https://gerrit.libreoffice.org/23587 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-03-27tdf#98893 Remove expensive calls to GetCellType + GetValue/... in calcAleksas Pantechovskis
Conflicts: sc/source/core/tool/cellform.cxx Change-Id: Id949800f6e13e268df798d2f1868f26deff66191 Reviewed-on: https://gerrit.libreoffice.org/23543 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Jenkins <ci@libreoffice.org>
2016-03-27extract function from ScDocument::FillInfoMarkus Mohrhard
A first step in breaking the function into smaller pieces. Change-Id: I94aeb11fd9c44a7eaa198cb39f208b574ef2758d Reviewed-on: https://gerrit.libreoffice.org/23548 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-03-27mark the reference as constMarkus Mohrhard
Change-Id: I66ee342205acb9875899af9a65da9eb9cd5ecc74
2016-03-27don't inherit from std::mapMarkus Mohrhard
Change-Id: I50e9b27c45f6f7bd52af9e0c8a188124d6413cbc
2016-03-26sc: replace local macrosJochen Nitschke
inline one time use macros convert other macros to local helpers HMM2XL(x) probably means hundredth millimetres to excel or xls. Excels seems to use pixel and the ratio of 1/100th mm per pixel happens to be 26.483 hmm/px @ 96dpi Change-Id: I84de6106b24daa7bd1fb355fc9bc4c355bc285c7 Reviewed-on: https://gerrit.libreoffice.org/23478 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-26remove debug functionsMarkus Mohrhard
Change-Id: I7a3aaa223c08d9fc79baeed59546d7268bd8e57b
2016-03-26no need to iterate through all cellsMarkus Mohrhard
Change-Id: I4621e58032a79b8438b4094b8c66d5d7a104e8af
2016-03-26also test that we are not still listening to the old areaMarkus Mohrhard
Change-Id: I7ad84ec75f435e3171b064eaaf60a819b09aeb02
2016-03-26add a few unit tests for conditional format reference listeningMarkus Mohrhard
Change-Id: I0609bf9033a7a2dd40afaae9effbfa06de5e4c83
2016-03-26fix indentationMarkus Mohrhard
Change-Id: Ibd65797b70cac33eb3302ad2020ffe38a01a2d85
2016-03-26add a few unit tests for ScFormulaListenerMarkus Mohrhard
Change-Id: Ie6c26967167a2dffa0e2047a78eb2b44b6c502f3
2016-03-26switch to a listener based cond format update, tdf#95437Markus Mohrhard
Change-Id: Iaee665a37a9637c40cd02a89a19240ade6e5af37
2016-03-25unit test for copying sheet-local names before original positionEike Rathke
Change-Id: I3a70539480b5b1d85b717fd6638359aa9ce5075a
2016-03-25sheet-local names' references of original sheet are updated laterEike Rathke
... in contrast to global names that are already updated before content is copied. So don't modify the token's original sheet number before adjusting the copied sheet-local names' references. Change-Id: I3edfb53370a5e8811d7301af95238a865ff38f0c
2016-03-25use the ScRefCellValue already available, tdf#97989Markus Mohrhard
Change-Id: Iccfff23f72d33ee012f91a230f2598b8fe3131cf Reviewed-on: https://gerrit.libreoffice.org/23514 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-03-25use the ScRefCellValue that is already available, tdf#93405Markus Mohrhard
Change-Id: I68a2ddbe5049d10b5c11c2d77b26dce8dc55ab28
2016-03-25we already pass the ScRefCellValue as parameter, tdf#93405Markus Mohrhard
Change-Id: I27f7e8ffe93545fe872a0c5b64f26dc90cb70e6f
2016-03-25these two methods are identical copies, related tdf#93405Markus Mohrhard
This already gives a 15% improvement as we now only query the cell twice instead of three times. Change-Id: I2e0533f05ace6773ad0710b2c586ca325aeae91b
2016-03-24MM: remove lock from saved documentsJan-Marek Glogowski
Actually we have to call DoSaveCompleted to get rid of the locking. Instead this adds a parameter to skip the recent file registration used in non bCreateSingleFile modes. Change-Id: I57151f08ad8d737007da84c4566685cc37612dfb
2016-03-24const as const canEike Rathke
Change-Id: I6826c2f12d601a91462af454b90272ea7a7e932f
2016-03-24unit test for copying global names to sheet-local names, tdf#75372Eike Rathke
Change-Id: Ice179cfcbb81b6455648d67e6f8aec516f7c8576
2016-03-24tdf#75372 rework sheet-copy names for converting global names to sheet-localEike Rathke
This during copying a sheet copies global names that from a copied formula cell reference the copied sheet and converts the copied global names to sheet-local names. References to the original sheet are updated to point to the new sheet. It works for names used in formula cells copied but needs enhancement to pick up nested names, i.e. names used in names that do not reference the sheet but the nested name does. Change-Id: I1aa16cb28c9f7b3581bec289435492c21e6fcd73
2016-03-24tdf#98657: Fix a corner case when NaN's were added to ScFullMatrix.Jan Holesovsky
Change-Id: Id3befb82c39f9caacc908d664d42365ce6996054
2016-03-24don't sanitize value to an insane value, tdf#97863Markus Mohrhard
Change-Id: I0e4de6b676fb61536dadefc96a719cf50be128ed
2016-03-24use FindRangeNameByIndexAndSheet()Eike Rathke
Change-Id: I94c0ba0d613e235c538cd7bdd3c36c98618fec42
2016-03-24loplugin:constantparam in scNoel Grandin
Change-Id: I8608a6cb47972e9b838cc5ea431863348758ded0
2016-03-24werror: loplugin:staticcallMarkus Mohrhard
Change-Id: Ifce20e96dc088b982307fc60ba185f5dddfc28cc Reviewed-on: https://gerrit.libreoffice.org/23481 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-03-24don't allocate and destroy a LocaleDataItem for each cell, tdf#97989Markus Mohrhard
Change-Id: I8bcdc7a42c87d17fde1dc9c79bc361bb625f992b Reviewed-on: https://gerrit.libreoffice.org/23480 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-03-23sc - added fixed and variable array formula range perf testsMarco Cecchetti
Change-Id: If1efa2340e4ed8acca6fde08dcd422f4bd5fd531 Reviewed-on: https://gerrit.libreoffice.org/22721 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-03-23add test for new ScMatConcat codeMarkus Mohrhard
Change-Id: I084e08575e8efd27bebdd9ae9880322913789ba4 Reviewed-on: https://gerrit.libreoffice.org/23440 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-03-23better use mdds in matrix concat, tdf#88849Markus Mohrhard
Change-Id: I6155b86d0afbefafdf982962ffd0216334834379 Reviewed-on: https://gerrit.libreoffice.org/23425 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-03-23sc: sc_mark_test can just link to scqahelperMichael Stahl
Change-Id: I90a5ca71ab8e2306eae337493a30ff0a56d5394f
2016-03-23add a recursion guard to lcl_FindRangeNamesInUse()Eike Rathke
Change-Id: Ia4a8f0273bb30b696b3499e75fa70e5c1a0981f1
2016-03-23loplugin:constantparam in scNoel Grandin
Change-Id: I437367b8c6960db730a69c020ba82792a9170d01