summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)Author
2020-07-21tdf#133026: Additions - Parameter support to UNO CommandYusuf Keten
After this patch, parameter support to uno command(.uno:AdditionsDialog) will be available. To use parameter, add "?AdditionsTag:string=YourParameter" to UNO command. Parameters are the tags of extensions on webpage. Change-Id: I0072c7340bda14ee13c21c347e06a04545cba69a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99007 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-07-21tdf#114427: sc_macros_test: Add unittestXisco Fauli
Change-Id: Ic1474051ff389e155d07546ad820ae3bb1f4e6dd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99124 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-07-21loplugin:constantparamNoel Grandin
Change-Id: Id5144e95ac0120b3125258cdde46e4f7f6e1690b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99109 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-20tdf#31231: don't set charts modified state when !IsEnableSetModifiedMike Kaganski
Modified state of the chart is part of modified state of owner document: see SfxObjectShell::IsModified. So when the document is loading, any updates to its charts don't make the document modified. Change-Id: Ie7643ff55bd44f1afe3f796f72c2508ea57f65d0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99102 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-07-19compact namespace: scNoel Grandin
Change-Id: I70e518a219a72cfc4ff4cdb7b7b60e1732e4aaa1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99005 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-17tdf#134817 XLSX export: fix partially lost header/footerAttila Szűcs
When header/footer text contain text portions with different font setting, only the last text portion was exported. Co-authored-by: Tibor Nagy (NISZ) Change-Id: Id4cba2b9188459cdaa0ade30c2217d8f59fe6316 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98938 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-07-17tdf#134459 XLSX export: fix missing font color in header/footerAttila Szűcs
Co-authored-by: Tibor Nagy (NISZ) Change-Id: I7aacbad1c4052b2480630d0b98175b46cf2aeed0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98873 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-07-17jsdialog: Add mobile version of data validation dialogSzymon Kłos
Change-Id: I8c59892196ae015852fff6004c72e1990b35c1af Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97762 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98902 Tested-by: Jenkins
2020-07-17Add UI for blur radius in shadow panelA_GAN
Update shadow property panel with spin button to control blur radius of the shadow. Change-Id: I5856e86a7963682c81d9e53a1bef857aba2f3c21 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98718 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-07-16lokit: add missing header and row-size invalidation calls...Dennis Francis
for ScUndoEnterData if there is a change in row height(s). Change-Id: I7d1e3a3ad8d55dcdb0cfbbc94521b83a7ac2b1ff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98891 Tested-by: Jenkins Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2020-07-16lokit: Add missing sheet-geometry row-size invalidation callDennis Francis
Change-Id: I6e0c87de51fa64fd486c0d20bef65574fadd1560 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98890 Tested-by: Jenkins Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2020-07-16lok: calc: messed up view when deleting from multiline contentMarco Cecchetti
To see the problem was enough to click on the cell with the multiline content (because of wrap text enabled), and press delete. Change-Id: I8288e7739c8513f5fa0bdee5f7eb414b4abac456 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96905 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97114 Reviewed-by: Marco Cecchetti <marco.cecchetti@collabora.com> (cherry picked from commit 464dcf45a085bffbe9b8368162f94606558605cb) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98889 Tested-by: Jenkins Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2020-07-16tdf#134332, tdf#134796: sc_subsequent_export_test: Add unittestXisco Fauli
Change-Id: I4b67937dbec76c32c61a85ed24ca67bfcf3f83a8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98743 Tested-by: Luboš Luňák <l.lunak@collabora.com> Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-07-15tdf#107885: sc_macros_test: Add unittestAndreas Heinisch
Split unit test for auto filter into two separate functions testing string and numeric conditions. Change-Id: I940718215bf3d1de490726a6e430b3cdd7b62f2f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98694 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-07-15Don't reset reference marks when editing the formulaSzymon Kłos
This prevents us from hiding reference marks on switching sheets when formula is under edit. Change-Id: I4bf1e36967420c12bfa974b0aeefda537a26eed3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98364 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> (cherry picked from commit 5fc0cea87be4b439bb3d3a5281984fd16b05dc28) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98349 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98815 Tested-by: Jenkins
2020-07-15Empty reference marks on selection resetSzymon Kłos
Change-Id: Id085b6b608335e1bcc085d7a8c972622a918f1ab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98316 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> (cherry picked from commit 7e8bcf38f00b3c45a78ba7a60aeb9e6dee11a23e) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98341 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98813 Tested-by: Jenkins
2020-07-15Get correct tab for current selectionSzymon Kłos
Change-Id: Ie3146675a5b6cca5357fccc668ce17b859836147 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98315 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> (cherry picked from commit 88417fb01bf03969970b574421a7688768dff6ef) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98340 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98814 Tested-by: Jenkins
2020-07-13cid#1465274 Dereference before null checkCaolán McNamara
Change-Id: I40337228b8591ac4f5367e581a0d2fa7575f0143 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98623 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-13drop unused forward declaresCaolán McNamara
Change-Id: I54136a8aa6e5544b2dbad013a74ffa991e16253b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98608 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-12Fix typoAndrea Gelmini
Change-Id: I6e7adbf15e108d4a044a1b6a784687c20e721b7f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98471 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-07-12update pchesCaolán McNamara
Change-Id: I75602277a5a26b012a12f2c4f4b7ff5bb663b0b9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98474 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-12cid#1465256 silence Uncaught exceptionCaolán McNamara
Change-Id: I1356f311b8eb71549ab9570ae7e568f52c301070 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98581 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-12cid#1465252 Dereference null return valueCaolán McNamara
Change-Id: I8884218bb93a5684fb8f0754013fa00215bbc002 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98578 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-11cid#1465255 Unchecked dynamic_castCaolán McNamara
Change-Id: I564bcde3ee6a96307ae133e550888f41b610e904 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98575 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-11paintTile: Try to find a view that matches the tile-zoom requested...Dennis Francis
by iterating over first few shells to avoid switching of zooms in ScGridWindow::PaintTile and hence avoid grid-offset recomputation on all shapes which is not cheap. Change-Id: Ib086112ebd504087d80c6d6f2879a69dca8ce44f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98168 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Dennis Francis <dennis.francis@collabora.com> (cherry picked from commit f54d3aa9bee7bc794b18b968835c6d6393f350ea) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98163 Tested-by: Jenkins
2020-07-11reset all draw gridOffsets when zoom needs to change...Dennis Francis
so that these are recalculated on render, else the shape positions in the tiles will be wrong. It is not enough to reset for just the objects in the tile because the render code iterates over all objects and then decide whether to render them based on the position/size. An obvious optimization is to choose a view/window with its zoom matching the tile-request using some useful heuristic and avoid a linear scan of views. Change-Id: Iffa96d261bc3362af3a528fbf7d4d3bcafc6d497 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98167 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Dennis Francis <dennis.francis@collabora.com> (cherry picked from commit 22d458164ae903f502e82f471c22ff8e1ebbb839) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98162 Tested-by: Jenkins
2020-07-11scPrintTwipsMsgs: Use print logical coordinates for draw objectsDennis Francis
as a result LOK_CALLBACK_GRAPHIC(_VIEW)_SELECTION messages will now be in print-twips. For tile-rendering, it needs the pixel-aligned coordinates of each object. The translation of print coordinates to pixel-aligned coordinates can be done behind the scenes by the ViewContact/ObjectContact/ViewObjectContact objects associated with the draw object which uses the cached "grid-offset" for each object (introduced in the patch "Refactor calc non-linear ViewToDevice transform"). For doing this, a subclass of FmFormView with a specialized "createViewSpecificObjectContact" method is used for tile-rendering. The createViewSpecificObjectContact creates a "proxy" object-contact object that delegates the grid-offsets queries to the actual ScDrawView generated ObjectContact. This is needed because currently there is no way to share the ObjectContact/ViewObjectContact instances between different SdrPaintWindow's without making changes ~everywhere. Change-Id: Ifdfb623c8d6dd81700ec4a5dfeeb6b2391a96154 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98166 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Dennis Francis <dennis.francis@collabora.com> (cherry picked from commit 345f9480618d0867f6b42a83a7ae1d62c8ef9c0c) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98161 Tested-by: Jenkins
2020-07-10tdf#107902: sc_macros_test: Add unittestXisco Fauli
Change-Id: I6fb494944c51a06ffec955e900f146e748f8f2f9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98522 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-07-10tdf#107885: sc_macros_test: Add unittestXisco Fauli
Change-Id: I059dc2ead51506098f37dbb3aaac0ab1436a17ec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98482 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-07-10replace usage of blacklist with excludelist for IWYUThorsten Behrens
Background and motivation: https://tools.ietf.org/html/draft-knodel-terminology-02 Change-Id: I2f22d455d2a936a85750eaab1fda215ebb6d9d48 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98182 Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-07-10replace usage of blacklist with denylistThorsten Behrens
.. and a few cases of instead doing blacklist->excludelist where that made more sense. Background and motivation: https://tools.ietf.org/html/draft-knodel-terminology-02 [API CHANGE] officecfg::Office::Canvas::DeviceBlacklist -> DeviceDenylist [API CHANGE] officecfg::Office::Canvas::BlacklistCurrentDevice -> DenylistCurrentDevice [API CHANGE] officecfg::Office::Common::Misc::OpenCLBlackList -> OpenCLDenyList Change-Id: Ia35e25496bf0cc0692d5de4cb66bfc232d3a869e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98180 Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-07-09tdf131562: sc_macros_test: Add unittestXisco Fauli
Change-Id: I08e8dd0230a6c900d0a88a015d066bffc2e8e8b5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98475 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-07-09cid#1401334 Uncaught exceptionCaolán McNamara
Change-Id: I6530f653f80bb3db73cef28340db2ffcac3573d1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98421 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-09tdf#124454: sc: Add unittestXisco Fauli
Change-Id: Id7b606c0e7e3621ea855af325c755876e11ebc66 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98429 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-07-09Use OUString::toChar(), tdf#107885 follow-upEike Rathke
Change-Id: I7615f878d800ae0ad68b68dd1ffedb0471c537f9
2020-07-09tdf#107885 - VBA AutoFilter can't compare stringsAndreas Heinisch
During the creation of table fields from an auto filter search criteria, check if the search text is numeric in order to search either for strings or numeric values. Change-Id: I6f334e7fd06c03850a535a0d54438577d15ccac4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91834 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2020-07-09tdf#134688 run error dialog async and keep the events in the one event loopCaolán McNamara
instead of a sub loop which helps to not lose the mouse release where the dialog was shown on the mouse press Change-Id: If0baf15e85aff7a28ca058e2626b58802d0dad08 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98439 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-09cid#1465236 Uncaught exceptionCaolán McNamara
Change-Id: I1303fe8ac9a5eecc06d9622893c8643d87120a58 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98407 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-09lokit: Avoid sending wrong edit-cursor/selection messages when...Dennis Francis
the EditView's output-area needs to be tweaked temporarily to render it to a tile which is meant for another view. Change-Id: I2b8fc1986c247ce65c18ea64e3b43d25625c7e9c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98129 Tested-by: Jenkins Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2020-07-08Resolves: tdf#124454 exec the matrix operator on values converted from stringsEike Rathke
Effectively a fallout from the matrix operations rework started for tdf#89387 that did not convert strings at all and subsequent work converted the string according to settings but did not apply the current operator on the result. Change-Id: I90c8963021396fd9a46b063f6aee96283f89271a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98385 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2020-07-08scPrintTwipsMsgs: Use print-twips paper-sizeDennis Francis
Paper size for the EditEngine is calculated based on per-cell pixel alignment. So lets use the exact print-twips version whenever we need it to compute/adjust output-area and visible-area of EditView. Change-Id: I7da6db9363d09965315ff5ca9d01f0fea141a533 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98130 Tested-by: Jenkins Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2020-07-08uitest : Add demo for Calc-commentsAhmed ElShreif
This patch test the support that added to this patch: https://gerrit.libreoffice.org/c/core/+/96837 Change-Id: If7444813f65bd90d62d0eb3504dcfc588c3f4e32 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97074 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2020-07-08uitest : Add support to Calc - commentsAhmed ElShreif
This patch has the implementation of the support for Calc comments . Now you can use these lines to use comments in calc: * Open Comment Window : >> gridwin.executeAction("COMMENT",mkPropertyValues({"OPEN":""})) * Then Type text as normal : >> gridwin.executeAction("TYPE",mkPropertyValues({"TEXT":"any"})) * Close Comment Window : >> gridwin.executeAction("COMMENT",mkPropertyValues({"CLOSE":""})) * Write Comment without opening comment window: >> gridwin.executeAction("COMMENT",mkPropertyValues({"SETTEXT":"any"})) You can also check the comment text by this line: >> get_state_as_dict(gridwind)["CurrentCellCommentText"] I will provide a test case in another patch. Change-Id: Ie3fc4efffb07827e742bdaa99dd5147c8b9711d3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96837 Tested-by: Jenkins Reviewed-by: Ahmed ElShreif <aelshreif7@gmail.com> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2020-07-08distinguish between dialog screenshoting and rendering a widgetCaolán McNamara
Change-Id: I43ee0c68d72c97a15d26e2ffea577c2a44ba91e8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98326 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-08SetLOKSpecialOutputArea() call must precede SetOutputArea()Dennis Francis
The ordering matters at the moment (unfortunately), since EditView::SetOutputArea(), after updating the output-area it also sends the LOK messages(cursor/selection) immediately. So we need to update the print-twips version in EditView by calling SetLOKSpecialOutputArea() beforehand to avoid wrong messages. Change-Id: Ibff64ad1a92f332ad726452369ecb2c5b2aaae53 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98128 Tested-by: Jenkins Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2020-07-07Use std::optional to allow optional inclusion of attributesMike Kaganski
... instead of converting the O(U)String objects to char*. Eventually this could allow to drop variants of *Element that take XFastAttributeListRef. Change-Id: Ib2748fcd93e655c55a176c00410fdcc7f052930d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98179 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-07-07ScGridWindow::UpdateEditViewPos: keep EditView's print-twips data updatedDennis Francis
Change-Id: I2f6fab371a107a4f16704030e341198a541020f8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98127 Tested-by: Jenkins Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2020-07-07ScViewData::EditGrowY: keep EditView's print-twips data updatedDennis Francis
Change-Id: I0207e65fc0386eb9a86de6ab4472780553eadd4a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98126 Tested-by: Jenkins Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2020-07-07ScViewData::EditGrowX: keep EditView's print-twips data updatedDennis Francis
Change-Id: Ia2470f98954859b191432d68db5742d13a61c802 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98125 Tested-by: Jenkins Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2020-07-07ScViewData::SetEditEngine: keep EditView's print-twips data updatedDennis Francis
whenever EditView::SetOutputArea() and EditView::SetVisArea() are called. Change-Id: I90a840b85d01d27427fbaa1101148ce1efb55db5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98124 Tested-by: Jenkins Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
generated by cgit (git 2.34.1) at 2024-06-18 11:57:37 +0000