summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)Author
2023-01-17tdf#152989 sc: fix oversized rectangle of edited embedded objectTünde Tóth
Editing resulted unusably oversized OLE objects. Keep its original size to fix the UX problem. Note: lost zoom is still a problem. See also commit fdf95de18ef1891862bdce26669d1ce2c6f24764 "tdf#152991 sd: fix oversized rectangle of edited embedded object" Change-Id: I6b73d1aea76ea4addc24ff978403893c3cbd3dac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145432 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2023-01-17tdf#91265 Use same plot area distance as used in MSOGülşah Köse
Changes the postion calculation for pie charts, where the margin min distance is now constant for pie charts, but unchanged for other chart types. This changes the positions of various pie charts used in tests, which have been changed to the new value after the cases have been checked. Added a new test with all 3 use cases (chart area width equals height, width is greater than height, width is less than height). Change-Id: I51f98f336a7c64a3e6762144fc7dc8d9df80f696 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143179 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-01-17XUnoTunnel->dynamic_cast in ScHeaderFooterContentObjNoel Grandin
Change-Id: I3edc648a4a0afbfd2922befc9e1962df0a22b54f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145637 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-01-16cid#1519051 silence Unchecked dynamic_castCaolán McNamara
and cid#1519050 Unchecked dynamic_cast cid#1519049 Unchecked dynamic_cast cid#1519047 Unchecked dynamic_cast Change-Id: I3feb25cda71c459c549f0e64558935d1030ed309 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145541 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-01-16tdf#147122 - Return cell object when a simple selection is mergedAndreas Heinisch
Change-Id: I4ddd3b3a804f8300a5ec15526f4c9c77aaf45fc5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145378 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2023-01-16tdf#112417 Insert Sheet called when clicking anywhere on the footerRadhey Parekh
Change-Id: I7524ac11729d1c80254c84c27211de3efaa622c9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145102 Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Tested-by: Jenkins
2023-01-15tdf#152774 Fix incorrect result with HLOOKUP and VLOOKUP.Winfried Donkers
Use case now complies with ODF 6.9.5 (HLOOKUP) and 6.9.12 (VLOOKUP). Added use case to unit test. Change-Id: I19df718b6446098f614136f462662c753a515036 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145514 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2023-01-15Merge SvXMLAttributeList to comphelper::AttributeListMike Kaganski
And simplify the latter, to always use "CDATA" type (as the former did). "CDATA" was used in all cases but one, where an empty string was used. Change-Id: I1b3bfae40e29628e4094d9a6e58a69a66865874c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145526 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-01-15tdf#117266 sc oox: macro button unit testJustin Luth
Change-Id: I50b8b5a2d29a5892490a7dbd4cc428786147d500 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145519 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2023-01-15tdf#117266 sc oox: export vml button with a correct nameJustin Luth
Without a correctly formatted ID, LO was unable to import the shape into the spreadsheet. Now at least the button shows up and can be pressed. MS Word already showed the button before the patch, so nothing there has changed. That suggests that our problem may be more during import. This code path is also followed by DOC and DOCX formats, but they do completely different things with the results. This is super nasty code... Change-Id: I383736a7de9c3e94b427d5747e5949c0348dcecd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145509 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2023-01-14tdf#117266 sc oox: import local macro without reference idJustin Luth
This is what LO exports - a macro without a local ([0]!) or remote ([2]!) reference. It must be at least somewhat valid because MS Word imports these just fine. So why don't import what we export... Change-Id: I8f69c373552b559efcfe7cbb06ea3a706d8ad0d4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145511 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2023-01-14tdf#117266 sc oox: export vml button with a correct labelJustin Luth
This might also be an import problem with LO, but at least by exporting this inside of a font like it is supposed to be, LO then imports the caption OK. Identified by trial and error and repetition. Change-Id: I4b403a3c8392654fabbf00574cb837c92c7f6230 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145510 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2023-01-14XUnoTunnel->dynamic_cast in SvXMLExportNoel Grandin
Change-Id: I68e4691ac0a58e2320b534d15934ff177feb124d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145493 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-01-13XUnoTunnel->dynamic_cast in TransferableHelperNoel Grandin
which leads us to find that we can skip all the dynamic_cast'ing altogether in SwView_Impl Change-Id: I8914f78df6bfdd743df370c0017d5b8521863594 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145483 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-01-13tdf#39650: move UItest to CppUnittestXisco Fauli
Change-Id: I2ff89c53309d7e3a4da11d652aafeb38cbc41205 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145480 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-01-13tdf#102525: move UItest to CppUnittestXisco Fauli
Change-Id: If7881b49cc006157e177559308048a0f2d2c10b2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145473 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-01-13tdf#95306: move UItest to CppUnittestXisco Fauli
Change-Id: Ic999c9d10d9a3ae16de0df70b435a5d822035193 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145471 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-01-13XUnoTunnel->dynamic_cast in VCLXDeviceNoel Grandin
Change-Id: I9fa06600d3b9a2172a1818f89a3b9c06d65c8c54 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145467 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-01-12sc: move different UItests to CppUnittestXisco Fauli
it seems Jenkins fails sometimes with this test https://ci.libreoffice.org/job/gerrit_linux_clang_dbgutil/131248/ this commit might help TODO: convert the remaining test Change-Id: Ib3fb48e2e457a9168fa16c8f9f2ac9f98beabcf3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145422 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-01-12CppunitTest_sc_uicalc: remove leftoverXisco Fauli
from commit 3756e3145c39ace4454d2569709c2c0d64ad389a "CppunitTest_sc_uicalc: combine external reference tests" Change-Id: I0c34ae8bd1668aa6ecc02d420aa767f7d631bef4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145404 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-01-12tdf#152774 Fix incorrect result with MATCH.Winfried Donkers
Use case now complies with ODF 6.9.14 (MATCH). Added use case to unit test. Change-Id: I749a979135fbc01a3bb1583092fb6d6a100e2d2d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144883 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2023-01-12override GetModel in ScDocShellNoel Grandin
so we can avoid dynamic_cast and XUnoTunnel in various places Change-Id: I1f524270a8030106a2058691c3d89b90d46ed26f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145391 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-01-12tdf#152717: sc: Add UItestXisco Fauli
I tried to implement this as a CppUnittest but =DDE formula returns nothing Change-Id: I4649a7842de516fc1867ddd214b323ff77f66317 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145362 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-01-10Resolves: tdf#152950 don't set_active while frozenCaolán McNamara
Change-Id: I7db73e37ed426aae2282a6bf1564e5d3843442cf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145261 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-01-10Related: tdf#152948 Align AddInMap English names to Add-In implementationEike Rathke
... of scaddins/source/analysis/analysishelper.cxx for the few (4) functions with the _EXCEL2003 suffix. The compiler's symbol map for English contained both, but the reverse map contained only the (first added) ..._ADD name, so GCD_EXCEL2003() was displayed as GCD_ADD(), that still worked but was unexpected. Change-Id: I8c866dc73d0146d75b29f8212a7e561a3f38fce4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145247 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2023-01-10Resolves: tdf#152948 Do not use GetExcelName() to obtain English function nameEike Rathke
As the function name says, it's the Excel compatibility name and not the Calc UI visible name and thus does not have the _ADD or _EXCEL2003 suffixes. Theoretically the names may even be completely different. Change-Id: I5f52dee77009123ebc3762defe08c937a3a59a18 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145246 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2023-01-08Revert "Resolves tdf#143100 - Disable cell style commands when sheet is ↵Heiko Tietze
protected" This reverts commit a3cb71ac80c0c2971e97c033d212cf4e464fa8f0. Reason for revert: tdf#149857 Change-Id: I5ea780b986073a8db16d5dc2ea503aa30da7ef27 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145118 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2023-01-05sc : use std::mutex for CharClass initialisationArnaud VERSINI
Change-Id: I0427109da1bfed1d3d467455ab1ab3c68569f60b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144886 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2023-01-05Change variable name from rData to pDataofftkp
Change-Id: Ied27e34b35a22b1f2a7521fb58035170651b1ca3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144001 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2023-01-05tdf#56973 - Copy/paste (single) sheet is checked but not enabledAndreas Heinisch
Enable the "copy" radio button in the move/copy sheet dialog, if there is just a single sheet in a spreadsheet document. Otherwise, users get the impression that a single sheet cannot be copied because the "copy" radio button is selected but not enabled, i.e., greyed out. Change-Id: Icf98973585491b0c8c9a74aad3900f6cc2895d11 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145064 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2023-01-05Revert all the recent loplugin:unocast changesStephan Bergmann
...as obsoleted by ef533553559fe09b4afab651fc692885d1acf4ed "Rudimentary support for dynamic_cast on UNO proxy objects". This reverts all of: 4cfcc9ac37b90ce64c8402a41eb4638adb185b5c "loplugin:unocast (framework::Desktop)" 03efbf72f4ddf7a84aa8aabef348331bd4b75e8a "loplugin:unocast (vclcanvas::TextLayout)" 80099fdd51a69eaa6c36ca88ef772810e4a777fa "loplugin:unocast (SalGtkXWindow)" cc147f576d8687fb79c77d47d41dc4ba1678a469 "loplugin:unocast (sdext::presenter::CachablePresenterView)" 40db42be1d8fd0f9c6c8c5ba3767ddb9ee2034c2 "loplugin:unocast (vclcanvas::CanvasFont)" 2d1e7995eae29e2826449eb5179f5fae181794a5 "loplugin:unocast (CairoColorSpace)" 4c0bbe4bd97636207cf71a6aa120c67698891da9 "loplugin:unocast (canvas::ParametricPolyPolygon)" 89803666621c07d1b1ac9d3bd883f0ca192a91a0 "loplugin:unocast (vclcanas::CanvasBitmap)" d5e0c2c8db71878d21c2a7255af08cf5f9a6dd04 "loplugin:unocast (sfx2::DigitalSignatures)" c0c4519e0d5b555f59bbc04cc616454edfd1f4ce "loplugin:unocast (VCLXAccessibleComponent)" feb8b833a6245d42400f42a0bc789dc84594ee6f "loplugin:unocast (VCLXDialog)" 1fa58cc6cc9c3849753342a5d9a6ddfa461b5e66 "loplugin:unocast (VCLXMultiPage)" f481f036deb1b1b46f3038074c4659f3a91b9c6c "loplugin:unocast (DocumentSettingsSerializer)" 73df933f5fa5932f94e5a1b338a3eda00a9ce354 "loplugin:unocast (css::embed::EmbeddedUpdate)" 420165ab0ef03c0467f9d17f504de2d2fc78f0e6 "loplugin:unocast (canvas::tools' StandardColorSpace, StandardNoAlphaColorSpace)" 9abe8ee067e6c00f19d8a13346d53c4641c27166 "loplugin:unocast (MutableTreeNode)" 9f3022ceb036f23b4b0994c3e2fbd1001bff225a "loplugin:unocast (VCLXTabPage)" 1be70dda02c12a60778b7607cff2520ae1aa611e "loplugin:unocast (vcl::unotools::VclCanvasBitmap)" d6a70bb641b96e8e5616448c2378131ed62658b4 "loplugin:unocast (basegfx::unotools::UnoPolyPolygon)" 5a14f009e6782c077463c8cbb8e9cea3d7950107 "loplugin:unocast (xmlsecurity::Certificate)" 99009c9535dfa3e0d838989ccc7d84bfa2320ff4 "loplugin:unocast (sd::Annotation)" 0c7585c5fa78887e5459885ed744e8044fd76137 "loplugin:unocast (sd::TextApiObject)" 24e14afd1bfcaed6c200ab081973fba7e47267ca "loplugin:unocast (SignatureVerifierImpl)" 1a7ad0c10d286ce9ae2700ceb2fd50eed1fb43a4 "loplugin:unocast (pcr::PropertyEventTranslation)" a97e2d2702d9a6f37775ccee2c08c4f3b2479c4b "loplugin:unocast (RangePageBreaks)" 19dfdf86ad1f5b08041d8b7a9f196caf881231ab "iloplugin:unocast (pcr::OFormattedNumericControl)" f9785ea595fd8e911f6370e836fa579225b9e571 "loplugin:unocast (frm::OInterfaceContainer)" 5e5f40a4a92a31b0932c690219d002fcf18598cf "loplugin:unocast (ScVbaShapes)" 27b35b2c215b4832d4378ec3a7ecbba926552d06 "loplugin:unocast (ScVbaShapeRange)" cb3108f860065928552a86cf8acc4b3a95718ecf "cid#1517812 Dereference null return value" feba0ddb1521d1142560fe54b7d7696ee910237f "loplugin:unocast (weld::TransportAsXWindow)" 4d6c23216559eb48f9943bb49d6e475a6d64ba15 "loplugin:unocast (oox::ForumlaImExportBase)" 4844c096a8ab6a9a620c410a0949d4499f12a504 "loplugin:unocast (cairocanvas::SurfaceProvider)" 9a0b523e0a84d403b9092176ccec4b3e3efe42d0 "loplugin:unocast (cairocanvas::CanvasBitmap)" 8a5648d8e59b4b007dbbf3824777c19a21efc61e "loplugin:unocast (cairocanvas::TextLayout)" 28c27a0623bc78a0590858f97d03b620985bc84c "loplugin:unocast (cairocanvas::CanvasFont)" 53bc223cb3288e32a417696ee61c29e5f01f209d "loplugin:unocast (cairocanvas::RepaintTarget)" 5f70b0b9f6bc4ab145ddbd9155590ed4a3b1b9ec "loplugin:unocast (SvXMLImport)" 068187a898cdd2e26e9b16c348ecc1ed2dee3f29 "loplugin:unocast (VCLXWindow)" 88b4f966202717cd4ad38a30a8eda22c3e69ed35 "loplugin:unocast (sfx2::sidebar::SidebarController)" f1b7a69b280aefe2f1b3b0f32193494fd765f2bd "loplugin:unocast (SvxLineStyleToolBoxControl)" ba76f0ba7e8de4d2953739c952004b7d9af47197 "loplugin:unocast (i18npool::Calendar_gregorian)" 840154daf934d8df52ead1cb7acd798c4d30f007 "loplugin:unocast (framework::AddonsToolBarWrapper)" b0e9c4c5f063cefa9557810e3349bdb9c7493091 "loplugin:unocast (GrammarCheckingIterator)" 8ee6cfc9655ce9de4617cea1a0d9cb9d7a4fbfac "loplugin:unocast (ucb::ucp::ext::Content)" 5b8cd77c112bc8c0e92b8fec215c3c8e802bbc0a "loplugin:unocast (basic::SfxScriptLibraryContainer)" 9e73ff9fce12e102bb3c3cea8d8bb96c88f2c9ad "loplugin:unocast (sdext::presenter::PresenterNotesView)" a98acca8fbc38d3fd5600ae5056a8e42b6d8a40d "loplugin:unocast (SelectionChangeHandler)" c0b59ad6e35b0cb0dea0821e95f95569739078c1 "Consistently use comphelper::getSomethingImpl<I>(aIdentifier, this)" 276e3ccbdd3259ec3daf8a1a98fa7f406b14e21c "loplugin:unocast (vclcanvas::RepaintTarget)" Change-Id: I37c73e3422a5154bf6cb647640d2d3f23db8bc34 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145063 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-01-04use sal_uInt8 for maMatFlagNoel Grandin
which is way more cache-dense than double Change-Id: I04503eb3a4054cce5312a7a0048c9b6679a8fd16 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145018 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-01-04Related: tdf#150339 remove SID_ATTR_COLOR_STRCaolán McNamara
re: https://gerrit.libreoffice.org/c/core/+/144866 "ColorString is not needed anymore (we used that in LOK previously)." Change-Id: I50a2f0e2ad254afb8ede33b05c89ae40bfeb4d3b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144967 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-01-03jsdialog: fix validation error dialog in CalcSzymon Kłos
Change-Id: Ie6551e386cd53f6b4bf4cceb6d7bd6170a2072ea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143599 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Rashesh Padia <rashesh.padia@collabora.com> Reviewed-by: Aron Budea <aron.budea@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144951 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2023-01-01Resolves: tdf#151886 Use default locale with English function names againEike Rathke
Automatically switching to en-US locale when using English function names caused too much confusion. There also might be the possibility that the '.' dot decimal separator clashes with the inline array column separator in some locales. A proper solution would make this user-specified and if set also adjust the separators to the common English ones. For now keep the default locale again as it previously was the case. Change-Id: Ic4712c6609c14f35cf0d1d842ac7443806a6e115 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144924 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2022-12-30optimise SUMPRODUCT(IF..) where we have entire column/row rangesNoel Grandin
following the same pattern as for SUM, set those ranges to shrink to available data. Takes it from 3s to <500ms on my test spreadsheet. Change-Id: I53ada996393a063b12ef7dd0f9bff40c90ecc8be Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144850 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-12-30optimise SUMPRODUCT(IF..) a littleNoel Grandin
Move the AddSub calculation inside ScMatrix so we can use an iterator to walk the matrix and avoid lookup cost for each element. Shaves 50% off the time spent here in my test sheet. Change-Id: I171d7dd4ae86419a563342a4120d14106e8d71db Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144826 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-12-29tdf#152717: ScDdeLink::DataChanged may get OUString directlyMike Kaganski
... after commit 94df17f58fe6269452b7252b712a89978c444bec (tdf#151429: don't convert OUStrings to system encoding, 2022-10-08) Change-Id: Ie9d6eb2a4465a576eefe0840a30636e898fa9028 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144810 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-12-22tdf#152535 Provide better localization for "Grand" subtotal stringsRafael Lima
As discussed in the bug report, having the word "Grand" hardcoded first in subtotals is not great for translation, since for some languages the translation of "grand" would come second. This patch creates separate strings for each case of Grand, f.i. "Grand Count", "Grand Sum" and so on. Now each of them will have their own translation. Change-Id: Ib875bc1a7b2fcc8934ad85bfe09374f8d9d9a179 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144666 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2022-12-21qa: hint about tolerance in namesXisco Fauli
As suggested by Mike in https://gerrit.libreoffice.org/c/core/+/144171 Change-Id: I653118985b781ebb1eed71587ae19efe45e1c800 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144691 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-12-21sc: fix null deref in ScInputHandler::InputChangedXisco Fauli
See https://crashreport.libreoffice.org/stats/signature/EditView::ShowCursor(bool,bool,bool) and https://crashreport.libreoffice.org/stats/signature/EditEngine::GetText(LineEnd) Change-Id: Ib1486161c722c213ccc64809010f54e9ab4dc52e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144684 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-12-21Use ScCellRangesBase's existing XUnoTunnelStephan Bergmann
Change-Id: I1323a0aad06118397f39eec0f42494491df93f23 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144680 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-12-21Use ScModelObj's existing XUnoTunnelStephan Bergmann
Change-Id: I2f0a6bbc5fe382a64d0a32ba955a28f44dad388c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144681 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-12-21Use ScNameRangeObj's existing XUnoTunnelStephan Bergmann
Change-Id: I968484d9c140dd9407732c07b2bbc042f0342725 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144679 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-12-21loplugin:unocast (RangePageBreaks)Stephan Bergmann
(See the upcoming commit introducing that loplugin:unocast on why such dynamic_casts from UNO types are dangerous.) Change-Id: I16297c96e60d76a15b59aedc4e88164bb782c61e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144652 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-12-20crashtesting: assert on import of forum-mso-en4-253564.xlsxCaolán McNamara
source document contains a timestamp formatted as: 2011-010-31T00: 00:00Z ^^^ Change-Id: I604ffa69189280faf9d7f55dae472cf9fe1b6763 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144614 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-12-20tdf#152581 SC: fix export of conditional border colorAttila Szűcs
Call XclExpDxf::mpBorder->SetFinalColors(..) during export, before SaveXml(). It will calculate the prepered colors from mnLeftColorId to mnLeftColor, so saveXml() will be able to save it. Change-Id: I1a1eccccd621c6d0e883cb9016e60ae0b344bf90 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144576 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2022-12-20loplugin:unocast (weld::TransportAsXWindow)Stephan Bergmann
(See the upcoming commit introducing that loplugin:unocast on why such dynamic_casts from UNO types are dangerous.) On macOS, where we implicitly use -fvisibility-inlines-hidden-static-local-var since <https://github.com/llvm/llvm-project/commit/d46f2c51e4c849683434bb5a0fb6164957474b8f> "Make -fvisibility-inlines-hidden apply to static local variables in inline functions on Darwin", the static id local var in weld::TransportAsXWindow::getUnoTunnelId cannot be in an inline function implicitly hidden via -fvisibility-inlines-hidden. Explicitly marking the function as VCL_DLLPUBLIC would help, but would in turn cause MSVC error 2487 ("member of a dll interface class may not be declared with dll interface"). So just make the function non-inline in a new vcl/source/window/weldutils.cxx (which would arguably be the best approach for the whole class, anyway). Change-Id: Ib5615f6aae19346ea05b8b85ff77c0e5ea860994 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144331 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-12-19sc: check ScDocShell::GetViewData()Xisco Fauli
ScDocShell: :GetViewData() can return nullptr Change-Id: I39bb2dce1ab233f39b0ec687ed71089b35537f9c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144467 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-12-19Fix typoAndrea Gelmini
Change-Id: Ibd4381e8e1f38588706a9cb093a63a9673776d52 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144504 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
generated by cgit (git 2.34.1) at 2024-06-21 22:21:08 +0000