summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)Author
2014-10-17Consistency around SdrAngleItem in svx/sxciaitm.hxxStephan Bergmann
...similar to what has been done for svx/sdtmfitm.hxx in 68969cc61adecac481ae9656978ef952f435b310 "Consistency around SdrMetricItem." Change-Id: I8e76e4751e50f5952c6dfff9ee10362166bf0523
2014-10-16fdo#73080: Fix the single cell reference cases as well.Kohei Yoshida
Change-Id: Ib9a8ae04733c5bcb982ef4d337112eb8249d0ee0
2014-10-16fdo#73080: Write another test case for single cell reference cases.Kohei Yoshida
Change-Id: I8dff6850c7088b483d1ad669867da6cef454d9a2
2014-10-16fdo#85050 - MENU: change related menu items shouldnt be separated find itemsYousuf Philips
Change-Id: I5921cbeadbfb6fdfd6e4a89e39a616d25954bc51 Reviewed-on: https://gerrit.libreoffice.org/11984 Reviewed-by: Cor Nouws <oolst@nouenoff.nl> Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-10-16fdo#84854 it seems long is not enough on 32 bitDavid Tardon
Fraction used BigInt internally for computations, rational does nothing like that. Change-Id: I3e9b25074f979bc291208f7c6362c3c40eb77ff5
2014-10-16Resolves: fdo#81496 crash in calc format pageCaolán McNamara
Change-Id: Ic70f6f605e13a5c95b504f1bf0322e11313a21e7
2014-10-15fdo#73080: Correctly count blank cells in COUNTBLANK.Kohei Yoshida
Especially when formula cells are involved. Change-Id: I40950e7108778821c17d08354f01bb157b1551e6
2014-10-15fdo#73080: Write test for this first.Kohei Yoshida
Change-Id: Ia2a32f4be3ef2c09ac68fe03ee9a7c9d31aef7ed
2014-10-15fdo#83141: also optimize ScTable::HasAttribSelectionLaurent Godard
applying same strategy than 1e721077b43de84edab2a3ed2f316ddcbec6e3ec Change-Id: I8c226d5d66ba8371ea1baec73e72b3e50886bb4f Reviewed-on: https://gerrit.libreoffice.org/11877 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-10-15More -Werror,-Wunused-private-fieldStephan Bergmann
...detected with a modified trunk Clang with > Index: lib/Sema/SemaDeclCXX.cpp > =================================================================== > --- lib/Sema/SemaDeclCXX.cpp (revision 219190) > +++ lib/Sema/SemaDeclCXX.cpp (working copy) > @@ -1917,9 +1917,10 @@ > const Type *T = FD.getType()->getBaseElementTypeUnsafe(); > // FIXME: Destruction of ObjC lifetime types has side-effects. > if (const CXXRecordDecl *RD = T->getAsCXXRecordDecl()) > - return !RD->isCompleteDefinition() || > - !RD->hasTrivialDefaultConstructor() || > - !RD->hasTrivialDestructor(); > + return !RD->hasAttr<WarnUnusedAttr>() && > + (!RD->isCompleteDefinition() || > + !RD->hasTrivialDefaultConstructor() || > + !RD->hasTrivialDestructor()); > return false; > } > > @@ -3517,9 +3518,11 @@ > bool addFieldInitializer(CXXCtorInitializer *Init) { > AllToInit.push_back(Init); > > +#if 0 > // Check whether this initializer makes the field "used". > if (Init->getInit()->HasSideEffects(S.Context)) > S.UnusedPrivateFields.remove(Init->getAnyMember()); > +#endif > > return false; > } to warn about members of SAL_WARN_UNUSED-annotated class types, and warn about initializations with side effects (cf. <http://lists.cs.uiuc.edu/pipermail/cfe-dev/2014-October/039602.html> "-Wunused-private-field distracted by side effects"). Change-Id: I3f3181c4eb8180ca28e1fa3dffc9dbe1002c6628
2014-10-15fdo#84938: replace SYMBOL_TYPE constants with enumNoel Grandin
Change-Id: Ib3763f20d74c22e28d519a9ac47f6f3ab4e31f51 Reviewed-on: https://gerrit.libreoffice.org/11983 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-15nDrehWink -> nRotationAngleMiklos Vajna
Change-Id: I33ca88f38210140931b12a05e426d1373243156e
2014-10-15remove duplicated call to mpChildrenShapes->SelectionChanged()Eike Rathke
Found when investigating performance bottlenecks of fdo#75486, after the selection is completed ScTabViewObj::getSelection() is called multiple times, each creating a ScCellRangesObj of the range list of filtered ranges, which then is used for ScChildrenShapes::FindSelectedShapesChanges() The duplicated call was introduced with b41332475783c31136673fb44cf4c411bb0148f8 but IMHO does not make any sense at all unless it has obscure side effects, it only slows down things even more. Change-Id: I3cee2e3e62c24ad72efb8cc2021e74d0afc70b69
2014-10-15speed up simple range list joins that could be appends, fdo#75486 relatedEike Rathke
Change-Id: I734ff88bc4c0633875c9e9c19a817b8b08511c83
2014-10-15speed up range list generation from multi marks, fdo#75486 relatedEike Rathke
Change-Id: Id2114652948d12c92b0e7be7afa304bfffc8fbe0
2014-10-15sc: fix temp file leak in ScHTMLExportTestMichael Stahl
Change-Id: Iab385ce8b24dd24985ec9b2d0c9d2a4e603d0fd0
2014-10-15sc: fix temp file leaks in ucalc TestMichael Stahl
Change-Id: Id5243aa37578cf9ed534603f3b27e83f0678c3fb
2014-10-15sc: fix temp file leak in ScFiltersTestMichael Stahl
Change-Id: I1920fa405f377abafe793b4bbec52b8b141459f6
2014-10-15sc: fix temp file leak in ScExportTestMichael Stahl
Change-Id: I9b9944fa1b9e00989a499f7a8fac74097ae9d61b
2014-10-14coverity#735315 Unchecked return valueCaolán McNamara
Change-Id: If2e8d3cfe49a039cc27035ae9c0f037c2d60b122
2014-10-14coverity#982180 Unchecked return valueCaolán McNamara
Change-Id: Ida858f633f1e9afcc1a5a06f503f0ab06d2d3e74
2014-10-14coverity#1242430 Dereference after null checkCaolán McNamara
Change-Id: If1c59d6d06a9e4601731f13a69b1ac2603c0014b
2014-10-14do not forward-declare templatesDavid Tardon
Change-Id: I3b0a145f70406f0c8a12b6c4b7876c4148f76e93
2014-10-14Use C++11 std::thread::hardware_concurrency()Stephan Bergmann
...and hope it gets past our various tinderboxes. Change-Id: I4dd95e77c4a74ae58e66f98753fcf5e438080146
2014-10-14don't execute ScOpenCLTest::testFinacialIRRFormula on OSXNoel Grandin
it has intermittent failures which causes the tinderboxes to unnecessarily spam my inbox Change-Id: I689b9d8c5da169dc6572250afe686b79039fba34
2014-10-13create a macro library for implementing bit-flags typesNoel Grandin
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>, changed from a macro- to a template-based solution. (Unfortunately MSVC 2012 does not support explicit conversion operators. Worked around that with explicit #ifs rather than some HAVE_EXPLICIT_CONVERSION_OPERATORS and SAL_EXPLICIT_CONVERSION_OPERATOR ainticipating we hopefully soon move to a baseline that requires unconditional support for them.) Change-Id: I4a89643b218d247e8e4a861faba458ec6dfe1396
2014-10-13fdo#84872 give each SheetDataContext a new FormulaParserCaolán McNamara
Change-Id: I120a9d0943db38571892defe1b5d3169158e3e42
2014-10-13vcl: Make ImplFontCharMap a pImpl and move functions to FontCharMapChris Sherlock
To do this, I've made FontCharMap a friend class for ImplFontCharMap, and have moved the functions directly into FontCharMap. In this patch, I am attempting to stop the direct use of ImplFontCharMap by anything other than FontCharMap. However, FontCharMap itself requires a refcounter, so we will use FontCharMapPtr to access the font character map. Change-Id: I509b990a8cbd911c5cc1572c7d24fc5348ca06d9 Reviewed-on: https://gerrit.libreoffice.org/11823 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2014-10-12coverity#735322 Unchecked return valueCaolán McNamara
Change-Id: I12f9392813f5fdd6f2d36398ea00a5cad812cd26
2014-10-12coverity#735321 Unchecked return valueCaolán McNamara
Change-Id: I3733471b72e96c8d020b8b5238fdb5fc4bfcacce
2014-10-12fdo#83901: Write a test for this.Kohei Yoshida
Change-Id: If805ba07baa36cbf94ee22f77f98ef4057d8b306
2014-10-12fdo#83901: ROW() and COLUMN() to be properly recalculated on cell move.Kohei Yoshida
For cases where ROW or COLUMN references another cell that has shifted. Change-Id: Ic4bef8672dab811ceff6886d9af0388306a66485
2014-10-11fdo#39468 Translate German Comments - sc/source/filter/inc/ leftoversChristian M. Heller
Change-Id: I0fe5c0165e1c430861028175c82ff116bac969aa Reviewed-on: https://gerrit.libreoffice.org/11926 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-11Cleanup.Kohei Yoshida
Change-Id: Ic39043d0453830d348ac3bc8a027b862e4bbdfd8
2014-10-11fdo#80846: Broadcast changes before EndUndo().Kohei Yoshida
EndUndo() calls PostDataChanged(), which renders the recalculated formula cells. Not broadcasting before EndUndo causes some dependent formula cells to not get recalculated. This one unfortunately is not currently unit-testable as this behavior depends on the presence of ScTabViewShell.... Change-Id: I86288608b7f2627cda7c74be27a18029832775ef
2014-10-11fdo#84912 - MENU: Addition of AutoSpellcheck to Tools menuYousuf Philips
Change-Id: I5e16f68f8565a26857f4ef233e06a002209e2566 Reviewed-on: https://gerrit.libreoffice.org/11915 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2014-10-11convert SFX_CALLMODE constants to SfxCallMode enum classNoel Grandin
and fix a couple of bugs in SC and SW where the call mode was being passed to the hints parameter by accident Change-Id: Ief805410b3f7035e012e229e77f92d5832430f58 Reviewed-on: https://gerrit.libreoffice.org/11916 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-11convert vcl StateChangedType to enum classNoel Grandin
Change-Id: Ifa46523619ae7fb8d112525b8df594836e51bb8f Reviewed-on: https://gerrit.libreoffice.org/11843 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-11fdo#75757: remove inheritance to std::mapTakeshi Abe
from oox::core::Relations. Change-Id: If2e0109a2ad6598436177b7638cb6d568fb2d3d6 Reviewed-on: https://gerrit.libreoffice.org/11899 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-10-10Have ScViewFunc::DeleteContents() to call ScDocFunc's.Kohei Yoshida
If bSimple = true, call DeleteCell(), otherwise call DeleteContents(). Change-Id: Ic08d9501797b537430bef0b6f3d920c3b497104b
2014-10-10Add DeleteCell to ScDocFunc, which is a variant of DeleteContents ...Kohei Yoshida
for a single cell case. This is equivalent of ScViewFunc::DeleteConents with bSimple = true. Change-Id: I5eccce21843f4cb21b29f96b0360617a180aebee
2014-10-10typo: follwing -> followingAndras Timar
Change-Id: Ia201473c84dc0923e8f4bee6329ad926cd6addd6
2014-10-10Adapt sorting unit tests for new default.Michael Meeks
Change-Id: I9885e2712753390f0597233c404ab80c0ad2b537
2014-10-10fix coverity#1242413 Logically dead codeCaolán McNamara
Change-Id: Ic56eff808cd4254448f63127da9b5b1d54c733a0
2014-10-10coverity#1244942 Dereference null return valueCaolán McNamara
Change-Id: I50e453bf9e31f4afc60096ad3888062c365f54c6
2014-10-09InsertCurrentTime: in input mode inherit matching format if setEike Rathke
In case a date or time cell format was set, inherit that format for Ctrl+; or Ctrl+: date/time insertion while editing the cell. Change-Id: If13e680fc74ab36611f8c11d992dba4b9c91ddb4
2014-10-09remove warning: ‘nIndex’ may be used uninitializedLaurent Godard
Change-Id: I317c2f4409f556ab967e4f08caa99cffcfce26cc Reviewed-on: https://gerrit.libreoffice.org/11876 Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> Tested-by: Kohei Yoshida <libreoffice@kohei.us>
2014-10-09fdo#84810 Avoid calc crash when using Paste Special - LinkMatthew J. Francis
Change-Id: I52c072578ccc0b9f75a850613056e74d400eb532 Reviewed-on: https://gerrit.libreoffice.org/11867 Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> Tested-by: Kohei Yoshida <libreoffice@kohei.us>
2014-10-09fdo#81356: convert Fraction to boost::rational<long> - wipJuan Picca
* Added rational util functions used by Fraction class not available in the boost::rational class. * Replaced usage of Fraction by boost::rational<long> * Removed code that relies on: 1. fraction.IsValid() -- rational only allow valid values, ie denominator() != 0 2. rational.denominator() == 0 -- always false 3. rational.denominator() < 0 -- always false but implementation detail: http://www.boost.org/doc/libs/release/libs/rational/rational.html#Internal%20representation * Simplified code that relies on: 1. rational.denominator() != 0 -- always true * BUGS EXIST because Fraction allows the creation of invalid values but boost::rational throws the exception boost::bad_rational Change-Id: I84970a4956afb3f91ac0c8f726547466319420f9 Reviewed-on: https://gerrit.libreoffice.org/11551 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2014-10-09typo: formual -> formulaAndras Timar
Change-Id: I39b4c2fc4edd7d609b15fc289dd1b053c749f435
generated by cgit (git 2.34.1) at 2025-01-19 14:30:28 +0000