summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)Author
2019-01-10make format->page dialog asyncNoel Grandin
Change-Id: Ie2c63e2bac176002bc6616578aef2d4c763245c7 Reviewed-on: https://gerrit.libreoffice.org/66074 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-10tdf#121978 use round again for Calc function SECOND.Winfried Donkers
Round was inadvertedly replaced by floor in commit 273b3e10eab70ebc084cb62568bd699fddfb376e. Change-Id: Ie0824e228c62509952a11b866638482a409c851d Reviewed-on: https://gerrit.libreoffice.org/65579 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2019-01-10Related: tdf#44076 do not leave cast to int to undefined behaviourEike Rathke
... if the double is an out-of-int-range value. Also catch domain and pole and range errors. Move this to it's own sc::power() function that can be reused for example by ScMatrix::PowOp() to be congruent. Change-Id: I88331e02e6cdfb5e1dcbf81622d3fc7ce4510478 Reviewed-on: https://gerrit.libreoffice.org/65986 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2019-01-10pass ScTokenArray around by unique_ptrNoel Grandin
Change-Id: I611554b1c4cbc506dbfc32748e9f14c9e8eb5156 Reviewed-on: https://gerrit.libreoffice.org/66022 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-10tdf#42949 Fix IWYU warnings in sc/source/filter/xml/*cxxGabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I39b7da64f92520f1fb583b2a2f038955e5de2f24 Reviewed-on: https://gerrit.libreoffice.org/65690 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-01-10use unique_ptr in ScRangeUtil::IsAbsTabAreaNoel Grandin
Change-Id: I3a5f88eef1e7a8241921f2fed15a1ebc2c4c3445 Reviewed-on: https://gerrit.libreoffice.org/66006 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-10sc: Drop empty reordermap.cxxTakeshi Abe
Change-Id: I6d3183cf281363538c603d126660064a205cda5b Reviewed-on: https://gerrit.libreoffice.org/66058 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-01-09use unique_ptr in ScViewOptions::CreateGridItemNoel Grandin
Change-Id: I350e606b14a5a7f269fecca1d176f40c4343c344 Reviewed-on: https://gerrit.libreoffice.org/66005 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-08Simplify containers iterations in sc/source/ui/[f-u]*Arkadiy Illarionov
Use range-based loop or replace with STL functions Change-Id: Ia117ee3bea76c1cee84c0d2bb43195c59764fe93 Reviewed-on: https://gerrit.libreoffice.org/65961 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-08use unique_ptr in ScXMLImportWrapperNoel Grandin
Change-Id: I98e29a832509f4ea0453f92ccd6fb274e39b5afc Reviewed-on: https://gerrit.libreoffice.org/65956 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-08convert "*xxx.get()" to "*xxx"Noel Grandin
Change-Id: Ic307226591ff9702957ccdec486ccf70357eb6d9 Reviewed-on: https://gerrit.libreoffice.org/65951 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-07Resolves: tdf#122301 ReferenceOrForceArray for FREQUENCY() parametersEike Rathke
It's yet unclear whether ECMA-376-1:2016 OOXML 18.17.7.127 FREQUENCY "A call to FREQUENCY shall be an array formula." indicates that the entire formula expression should be in array mode as well, see https://bugs.documentfoundation.org/show_bug.cgi?id=122301#c8 If so, that will need a follow-up change. Change-Id: Ic302d25631fb870b46989b922c95912ab5d123df Reviewed-on: https://gerrit.libreoffice.org/65940 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2019-01-07Resetting all fields for all dims corrupts pivot cacheKatarina Behrens
test case is exporting ooo55266-3 (contains data grouped in numerical intervals) to xlsx and without closing the document, opening filter on 1st pivot table (kaboom!) ClearGroupFields corrupts the cache bc it resets Field.mpGroup items for all dimensions, not just the one present in ScDPDimensionSaveData (all this happening in ScDPCollection::SheetCaches::getCache). Consequently, accessing or rebuilding pivot cache may crash bc mpGroup now points nowhere. I split and renamed ScDPCache::ClearGroupFields into 2 parts, one of them clears maGroupFields, the other resets mpGroup ptrs in maFields. When adding data to cache, the former is used (bc group ptrs get reset almost immediately afterwards) Change-Id: I96e8d234a17da0f3cc65c0625aa47b12284b98b8 Reviewed-on: https://gerrit.libreoffice.org/65329 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2019-01-07tdf#42949 Fix IWYU warnings in include/vcl/[v-x]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I98f49765c6b74808dcbd692e0f375dd2848fcfd4 Reviewed-on: https://gerrit.libreoffice.org/65614 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-01-07Simplify containers iterations in sc/source/ui/{unoobj,vba}Arkadiy Illarionov
Use range-based loop or replace with STL functions Change-Id: Ia8a8cfb71047e5612aa62c817c76ae0dfb7b3fa2 Reviewed-on: https://gerrit.libreoffice.org/65903 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-03uitest for bug tdf#99069Zdeněk Crhonek
Change-Id: Ic117937629b465227c564158b7c24270997cce78 Reviewed-on: https://gerrit.libreoffice.org/65839 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2019-01-03Get rid of ScStringUtil::GetQuotedTokenCount()Matteo Casalin
Change-Id: If50beb8edaf2c0bb0d336c81b4144ff58147771f Reviewed-on: https://gerrit.libreoffice.org/65657 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2019-01-02uitest for bug tdf#45020Zdeněk Crhonek
Change-Id: I1a177fa309e7cf20ab432f302fe9c8fb0f7cfb05 Reviewed-on: https://gerrit.libreoffice.org/65809 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2019-01-01uitest for bug tdf#44861Zdeněk Crhonek
Change-Id: I9532fc3c5a5924fbe3cc6b76a095ff28e5b15f73 Reviewed-on: https://gerrit.libreoffice.org/65770 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2019-01-01uitest for bug tdf#35020Zdeněk Crhonek
Change-Id: I2a124a124882c65bfda0d413a6f3a1cd4e46792a Reviewed-on: https://gerrit.libreoffice.org/65775 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2018-12-31uitest for bug tdf#39959Zdeněk Crhonek
Change-Id: Ibe33f5fd3e66f53815429eaeaea5d64fc4984730 Reviewed-on: https://gerrit.libreoffice.org/65774 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2018-12-31uitest for bug tdf#49531 tdf#49520Zdeněk Crhonek
Change-Id: Ief075273f6a1331ca5290e0e21386e4e6e16f54e Reviewed-on: https://gerrit.libreoffice.org/65773 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2018-12-30tdf#112484: repeat-item-labels is invalid in odf1.2 strictJulien Nabet
Change-Id: I23d204ef3d4e466876bb3416d616dc1f3682ad4c Reviewed-on: https://gerrit.libreoffice.org/65740 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2018-12-30tdf#114919: fix ods export in ODF 1.2 strictJulien Nabet
See Valgrind trace here: https://bugs.documentfoundation.org/attachment.cgi?id=147891 which contains bt Due to a8b7c72425aabae87bfd2e141aa06f06319ae11c " add error to office:value-type for calc cells and fdo#51810 For cached value import we need the information which cells are error cells. For ODF 1.2 extended we therefore export now calcext:office-value with the additional value "error". " Change-Id: I13547ecc7ef8c1c4e1a236229d3b19d51f12470b Reviewed-on: https://gerrit.libreoffice.org/65728 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-12-27Use appropriate STL function for searching in sorted listArkadiy Illarionov
48b35ed43db87d21a943e66cfa4f59213dcfe3a1 follow-up, see discussion in https://gerrit.libreoffice.org/65572 Change-Id: Ic60b21be6093a44e17252a2a34e38bf2411ab07d Reviewed-on: https://gerrit.libreoffice.org/65608 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-26tdf#122331 Autofilter disappeared after export to XLSXNoel Grandin
regression from commit c135f51b050dfa7ef095fe8a5b73cde37219a8dd loplugin:returnconstant in XclExpAutofilter Change-Id: Iea7ac925aff47699292b4c3d758e99cd2d081560 Reviewed-on: https://gerrit.libreoffice.org/65625 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-25Simplify containers iterations in sc/source/ui/{view,xmlsource}Arkadiy Illarionov
Use range-based loop or replace with STL functions Change-Id: I5604325cd25c099d3b5580956417620f298faa1e Reviewed-on: https://gerrit.libreoffice.org/65572 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-24Fix CppunitTest_chart2_xshape failing with Display Scaling on WindowsMike Kaganski
See thread starting at https://lists.freedesktop.org/archives/libreoffice/2018-December/081589.html Regression from commit 7263d223ddf42cc39d10a501159c7b04ef48df96. That change has made unit tests DPI-aware; and then some tests started failing on systems with resolutions other than 96 DPI. It has been suggested that the proper fix would be to do for Windows what commit ada20402efa81273e03e46cbedc21f25b9daeeac did for macOS. Another approach would be to fix all the tests to be DPI-aware. I cannot do the first mentioned fix; so I have fixed testFDO74215 test in sw_ooxmlexport4; and added DPI checks to the other failing tests in chart2_xshape and sc_subsequent_filters_test to skip testing when using non-default DPI. This is not ideal, of course, and conditionally skipped tests need to be re-enabled unconditionally once a proper fix arrives. Change-Id: I5c92cfe93ae65f53a8a180fcaec49231df377b8a Reviewed-on: https://gerrit.libreoffice.org/65595 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-12-24tdf#120703 PVS: V560 A part of conditional expression is always true/falseMike Kaganski
Change-Id: I5ca32214bab4b26208aecaa98eecc2a6297d9093 Reviewed-on: https://gerrit.libreoffice.org/65592 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-12-22Rework Data -> Statistics dialog, add WithReplacement and KeepOrderEike Rathke
* Add "With replacement" checkbutton * checked: WR (with replacement, put back after draw), larger sample size than population size possible * mutually exclusive with "Keep order" * unchecked: WOR (without replacement, do not put back after draw), sample size limited to population size * automatically unchecked for "Periodic" samples * Add "Keep order" checkbutton * checked: samples are drawn in order of population data * WOR method mutually exclusive with "With replacement" * automatically checked for "Periodic" samples * unchecked: samples are drawn in random order * Limit "Sample size" and "Period" input fields to size of population for all WOR methods * when limiting, increment "Sample size" and "Period" up to their last known value when enlargening the population size Previously, for "Periodic" samples the "Period" field was never limited, which for populations of smaller size makes no sense. The new recent implementation for "Random" without "Keep order" and without "With replacement" set (WOR) strictly needs "Sample size" limited to population size. Change-Id: I3c0bef402afb775bca7ae877e6424f4a4eaae359 Reviewed-on: https://gerrit.libreoffice.org/65574 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2018-12-22Fix typo in codeAndrea Gelmini
It passed "make check" on Linux Change-Id: I23bb5e475c5b769e91f47bea19dc57994fbca091 Reviewed-on: https://gerrit.libreoffice.org/65565 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-12-21Data -> Statistics: sample random values in random orderEike Rathke
The previous implementation sampled random values in the order of the population data. This may be unexpected and is also not what other spreadsheet implementations do. Instead, pick the random values in random order. Keeping order can be made an option as future feature. Code is prepared to sample WR (WithReplacement) as well, additionally to the now (and previously) implemented WOR (WithOutReplacement). Change-Id: I83734d36605b28cf44c0cc2bbc2dfcafaef025f4 Reviewed-on: https://gerrit.libreoffice.org/65559 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2018-12-21uitest for bug tdf#106667Zdeněk Crhonek
Change-Id: Icbcd21ed159e9e560536ff5166f82bba0d39786f Reviewed-on: https://gerrit.libreoffice.org/65556 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2018-12-21uitest for bug tdf#117276Zdeněk Crhonek
Change-Id: Ib61eee95d7ed4e6ede9455b058406eccd140e31c Reviewed-on: https://gerrit.libreoffice.org/65555 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2018-12-21pass ScAddress around using boost::optionalNoel Grandin
no need to store such a small object on the heap Change-Id: I610551156de9a00cc9d4a57c73a9450b7121d360 Reviewed-on: https://gerrit.libreoffice.org/65535 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-21loplugin:unusedfieldsNoel Grandin
Change-Id: Ib41c168817c30ce11baf99c3f43005313fe484ff Reviewed-on: https://gerrit.libreoffice.org/65496 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-21loplugin:unusedmethodsNoel Grandin
Change-Id: I63f03bd1a0510bf411341e1a04a40eb7fce2d57e Reviewed-on: https://gerrit.libreoffice.org/65495 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-21Rename PerformRandomSampling() to PerformRandomSamplingKeepOrder()Eike Rathke
The implementation draws samples keeping the order of the population data. That may not exactly be what is expected, but might be offered as an option once random sampling in random order is implemented. Change-Id: Ic850d37a53e4a5f25f91c6fb6610d2244e70d897
2018-12-20Resolves: tdf#114695 limit width of this comboCaolán McNamara
Change-Id: I3bcb880d05b9b2b6a7faf7b3646b169f3b11a46b Reviewed-on: https://gerrit.libreoffice.org/65507 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-12-20sc: Simplify RemoveSubTotalsHandler using std::setTakeshi Abe
instead of std::vector. Change-Id: I5927e061b5d2944cad68b96e313934738c63c321 Reviewed-on: https://gerrit.libreoffice.org/65400 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2018-12-20tdf#42949 Fix IWYU warnings in include/vcl/[t-u]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ib32ea54a3fa690a0722fa75ddb4121ec78c0b64f Reviewed-on: https://gerrit.libreoffice.org/65386 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2018-12-19Add XServiceInfo tests to ScTableRowsObjJens Carl
Change-Id: I9ebf0c3664c56f99a4e423c409c5d1621b8ea082 Reviewed-on: https://gerrit.libreoffice.org/65402 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-12-19Fix typo in QA pathAndrea Gelmini
Change-Id: I866611929f75dd322ce81ec54a63ec08002f55cc Reviewed-on: https://gerrit.libreoffice.org/65401 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-12-19tdf#45904 Move XTableRows Java tests to C++Jens Carl
Move XTableRows Java tests to C++ for ScTableRowsObj. Change-Id: I765d213e0a3e95a3925f1fc179a8a3f6c6611739 Reviewed-on: https://gerrit.libreoffice.org/65398 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-12-19tdf#120859 bad column span in .ui leads to overlapping checkbuttonsCaolán McNamara
possibly(?) since... commit d999b55e28d0445df870f69b3a269964e3635def Date: Sun Dec 10 10:56:38 2017 +0530 tdf#114200 : added 'Trim space' feature in 'Text Import' made a checkbox to Trim extra white spaces from both ends while using seperators in 'Text Imort' Change-Id: I280c5daacdc823ea26d02890ddbc4685a5382e6c Reviewed-on: https://gerrit.libreoffice.org/65427 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-12-19tdf#42949 Fix IWYU warnings in sc/source/filter/oox/*cxxGabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ibf5b7a813910f2ab37d8705b99bd8a9a19706c43 Reviewed-on: https://gerrit.libreoffice.org/65061 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2018-12-19tdf#45904 Move XEnumerationAccess Java test to C++Jens Carl
Move XEnumerationAccess Java test to C++ for ScTableRowsObj. Change-Id: Ic2d37c7b918faff3af7a682f72a1f2b04857c5d7 Reviewed-on: https://gerrit.libreoffice.org/65373 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-12-19tdf#45904 Move XElementAccess Java tests to C++Jens Carl
Move XElementAccess Java tests to C++ for ScTableRowsObj. Change-Id: Iefe5024cbde5f1583a560d8569e9aa460b68e42e Reviewed-on: https://gerrit.libreoffice.org/65372 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-12-19Turn OSL_ENSURE(IsCalculated()) into assert()Eike Rathke
That is a programming error if precondition is not fulfilled. Change-Id: I9eb04cc99d10c27f193321ecaee74cc1b41ce531 Reviewed-on: https://gerrit.libreoffice.org/65359 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2018-12-19tdf#45904 Move XIndexAccess Java tests to C++Jens Carl
Move XIndexAccess Java tests to C++ for ScTableRowsObj. Change-Id: I90dc592ba7901dab9c402b56e9e992fe7593c71c Reviewed-on: https://gerrit.libreoffice.org/65371 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
generated by cgit (git 2.34.1) at 2025-02-27 10:05:29 +0000