summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)Author
2017-09-19ofz: disable more config related codeCaolán McNamara
Change-Id: I2458000c5d46a371cec0a17fb0bfd86a2444dc42 Reviewed-on: https://gerrit.libreoffice.org/42472 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-19ofz: survive missing configCaolán McNamara
Change-Id: Ie09544ffefcd1789aef7a7f6193aaaddd3ad1896 Reviewed-on: https://gerrit.libreoffice.org/42467 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-19ofz: survive missing configCaolán McNamara
Change-Id: I9d05602b6e3af2bb54e1c82668090d71153b3c9d Reviewed-on: https://gerrit.libreoffice.org/42463 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-19fix SequenceOutputStream constnessNoel Grandin
Change-Id: I6e1039c077602b2cb42702cb4131f9503ef533c2
2017-09-18ofz#3412 SYLK import: check ;X;Y;C;R col/row validity earlyCaolán McNamara
Change-Id: I91fcd2571e528201e01467f3bcdbbff30cdfb50c Reviewed-on: https://gerrit.libreoffice.org/42423 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-18convert SvxDateFormat to scoped enumNoel Grandin
And simplify the code in sd/headerfooterdlg, no need for the complex encoding of date and time when we can just index into a static array. Change-Id: I677400bf1f956c81eba665b71dbda9183b63f55c Reviewed-on: https://gerrit.libreoffice.org/42346 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-16convert SvxTimeFormat to scoped enumNoel Grandin
and make the numerators look more like our internal formatting codes Change-Id: I3b3d448cec913e72c7ffb6cc3e7754241af36d93 Reviewed-on: https://gerrit.libreoffice.org/42345 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-16convert SvxTimeType to scoped enumNoel Grandin
Change-Id: Ic5ca8c50ccd74837cd0521a13e1f5eaa8e326ff3 Reviewed-on: https://gerrit.libreoffice.org/42344 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-16convert SvxURLFormat to scoped enumNoel Grandin
Change-Id: Ie2199cf0bcfb6d649f8aa33325ab645b18e7c000 Reviewed-on: https://gerrit.libreoffice.org/42343 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-16Removed duplicated includeAndrea Gelmini
Change-Id: I574313da20851417c7659ce7b5bcc687ac3c97a3 Reviewed-on: https://gerrit.libreoffice.org/42339 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-09-15Fix loplugin:redundantcast's VisitCXXFunctionalCastExprStephan Bergmann
...when t1 is ElaboratedType sugar (which isn't only used when the type is written with an elaborated type keyword, but also when it is written with a qualified name). (I originally wrote testArithmeticTypedefs to track down a different issue, which turned out to be a non-issue, with this fix as fall-out. So that test doesn't quite match the theme of this commit, but is a worthwhile addition nonetheless.) Change-Id: Ic447da4399853d7d045e3e2e7ade8ddf52d89749
2017-09-15Test joining two disjoint ranges into one by adding a third inbetweenTor Lillqvist
In particular, the case where the third one even overlaps one of the existing ones, not just borders it. Change-Id: I3a0dff51a68b048b615f60e579e6e698518cf1bd
2017-09-15borderline: Extended decomposeArmin Le Grand
Decompose of BorderLinePrimitive2D extended to take care of non-perpendicular line endings for matching. Improved matching, one error in calc fixed Change-Id: I869a75385711b58e6725daba0f22be8a98158ad9
2017-09-15borderline: Adapt ViewContactOfTableObjArmin Le Grand
Adapted to usage of svx::frame::Style helpers for primitive creation, need much less SvxBorderLine classes and less overhead. Class SdrBorderlinePrimitive2D completely removed. Working on Array::DrawRange to get it using the Coodinate Systems which are available and include the rotation. Solved problems in BorderLinePrimitive creation in DrawRange and DrawArray by completely restucturing these. Also changed to now return a sequence of primitives to the caller instead of handing over a primitive renderer and using it for each single primitve. This is a preparation for later buffering these and not re-create for each paint. Have now a working version that uses the Cell used by the Style and creates all info on the fly, so that the correct coordinate systems will be used. Works in Calc and it's dialogs with one or multiple cells.
2017-09-15borderline: Abstraction of BorderLinePrimitiveArmin Le Grand
As preparation for more detailed definition of BorderLine primitives I have adapted the BorderLine definition to work with motre possibilities to define the LineStartEnd definitions in a BorderLineExtend class. That one is flexible to hold all kinds of definitions - from none to all four possible extends (Start/End, Left/Right of vector) Cleanup of DiagStyle and others: DiagStyle is not needed anymore due to no longer using angles calculated, but being based on vectors defining the geometry. Also cleaned up quite a bit of no longer needed calculation stuff for the control.
2017-09-15Handle also the case where a range extends an existing one with overlapTor Lillqvist
Check for a new range being joined Extending an existing one in any of four directions (up, right, down, left), within a tab (sheet), that is. And add unit test for this. Change-Id: I4bd0525c2837f8b4b9d5a8967e0d5d661c6a5e2f Reviewed-on: https://gerrit.libreoffice.org/42304 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2017-09-15convert SvxFileType to scoped enumNoel Grandin
Change-Id: Iec1c67f7f0f9b2244b1d6ef52921ddd09f944fbb Reviewed-on: https://gerrit.libreoffice.org/42314 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-15convert SvxFileFormat to scoped enumNoel Grandin
Change-Id: Ia75c86a89c89bb22759e1d588ce603701cb7fad5 Reviewed-on: https://gerrit.libreoffice.org/42313 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-15convert SvxCellVerJustify to scoped enumNoel Grandin
Change-Id: I9d1cdb4ddfee43b7a0990624d7d16e06679343c4 Reviewed-on: https://gerrit.libreoffice.org/42276 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-14Replace some lists by vectors (sc/filter)Julien Nabet
Change-Id: Id5e5702045ef597db9ad1a44f99624152128f7a9 Reviewed-on: https://gerrit.libreoffice.org/42257 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-09-14Add test for joining a range totally contained in an existing oneTor Lillqvist
It is supposed to be "swallowed". Change-Id: I6184e5ff8560e5ad0c97dce1481123b9acecfabc
2017-09-14Add debugging output operator<< for ScRangeTor Lillqvist
2017-09-14InsertMatrixFormula,InsertTableOp: assert valid cols/rowsEike Rathke
We don't check and return without operation for these, so the caller is responsible for handling bad prerequisites. Change-Id: I47bf5dc171c2362bf7096022058a51460c6e50e0
2017-09-14improve redundantcast lopluginNoel Grandin
to find c-style casts where the expression is a templated method Change-Id: Ifbd1e2cdc72d906fc95a7ec0f9408c3f6d2a836b Reviewed-on: https://gerrit.libreoffice.org/42275 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-14ofz#3362 SYLK import: check ;X;Y;C;R col/row validity earlyEike Rathke
Change-Id: I37d5ce67f975b6b89c4b8a9baefae2467da2eb84
2017-09-14convert SvxCellOrientation to scoped enumNoel Grandin
Change-Id: Ia4c75c6394b47805f24a7daca593e0074a8ddf0b Reviewed-on: https://gerrit.libreoffice.org/42268 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-14simplify calls to IsStreamValid/SetStreamValidNoel Grandin
just add a short-circuit check inside SetStreamValid, and we can simplify all of the call sites Change-Id: Ib3d19455c60fe9569faf548b1fefbc274d03574c Reviewed-on: https://gerrit.libreoffice.org/42267 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-14convert ScAttrArray to use std::vectorNoel Grandin
instead of re-implementing it ourselves. Which lead to some changes in Xf::AttrList since the import process wants to donate it's array to ScAttrArray. Change-Id: I176148131fb5f163e25691ad690f63398ba1a556 Reviewed-on: https://gerrit.libreoffice.org/42205 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-13tdf#107267: Fix grand total calculationJean-Sebastien Bevilacqua
To fix the grand total calculation, we add another step. This step loop through all row to find the min and max of each value. These min and max are then used by the grand total. Patch by Linagora Change-Id: If3200840764d0ad9cb63231ac9f67b5d5ed197f1 Reviewed-on: https://gerrit.libreoffice.org/42042 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-09-13tdf#109096 Allow 0 as argument value(s) to GEOMEAN()Winfried Donkers
Both ODFF1.2 and the mathematical definition allow 0 as value(s). Excel does not allow 0 as argument value(s), but IMHO this is to be regarded as an aberration of Excel. Also added tests for no arguments or negative arguments, which is not allowed by ODFF1.2. Change-Id: I330206b6e817e0ec092fe19f713b044578da41d1 Reviewed-on: https://gerrit.libreoffice.org/42107 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-09-13no need to call GetNumerator() / GetDenominator() for FractionNoel Grandin
simplify the calculations - why have a Fraction and then just split it up for the calculation? Change-Id: I81af95e1ee1633f77e088c0990f308b1c169a6a2 Reviewed-on: https://gerrit.libreoffice.org/42242 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-13Fraction: make conversion operators and constructor explicitNoel Grandin
and simplify some of the calculations that needed to be changed. Which resulted in one unit test needing to change by one pixel, let's hope not an indication of a real problem. Change-Id: Ie56434f35f4e58d21ee6f671392e93dc7542fca3 Reviewed-on: https://gerrit.libreoffice.org/42240 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-13having context in strings is not enough, it should also be ~uniqueChristian Lohmaier
using the same context as in datastreams.ui causes duplicate (identical) strings in pot files, and some translation tools stumble over those see also tdf#109258 Change-Id: I88b083f56a45123a6cf7521ceaaefa89f77e0477
2017-09-13This return value is unused nowTamás Zolnai
Change-Id: I6145e9bd5736b5c48683d0a85d13ad02d66d5084 Reviewed-on: https://gerrit.libreoffice.org/42227 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-09-13Enable -Wunreachable-codeStephan Bergmann
...motivated by <https://gerrit.libreoffice.org/#/c/41565/2> adding dead code at the end of a switch statement, after the last case's "break". -Wunreachable-code appears to work well on Clang, while it appears to have no effect on GCC. Most of the affected places are apparently temporary/TODO/FIXME cases of disabling code via "if (false)", which can be written with an extra set of parentheses as "if ((false))" to silence -Wunreachable-code on Clang (which thus needed loplugin:unnecessaryparen to be adapted accordingly). In some cases, the controlling expression was more complex than just "false" and needed to be rewritten by taking it out of the if statement to silence Clang. One noteworthy case where the nature of the disabled code wasn't immediately apparent: Sep 12 16:59:58 <sberg> quikee, is that "if (false)" in ScExponentialSmoothingDialog::ApplyOutput (sc/source/ui/StatisticsDialogs/ExponentialSmoothingDialog.cxx) some work-in- progress or dead code? Sep 12 17:02:03 <quikee> sberg: WIP, but you can remove it Sep 12 17:04:47 <sberg> quikee, I'll wrap the false in an extra set of parentheses for now, to silence -Wunreachable-code (I wouldn't want to remove it, as I have no idea whether I should then also remove the "Initial value" comment preceding it) Sep 12 17:07:29 <quikee> sberg: both are different ways to calculate the "intital value"... so no Another case where the nature of the dead code, following while (true) loops without breaks, is unclear is sd/source/ui/remotecontrol/BluetoothServer.cxx, where I added TODO markers to the workarounds that silence the warnings for now. basic/source/sbx/sbxvalue.cxx had a variable of type double, of automatic storage duration, and without an initalizer at the top of a switch statement. Clang warning about it is arguably a false positive. Apart from that, this didn't find any cases of genuinely dead code in the existing code base. Change-Id: Ib00b822c8efec94278c048783d5997b8ba86a94c Reviewed-on: https://gerrit.libreoffice.org/42217 Tested-by: Stephan Bergmann <sbergman@redhat.com> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-09-13rename ScAttrEntry.nRow to nEndRowNoel Grandin
since it's the last row that the pattern applies to Change-Id: I80d6d5787768b1e98e958d7adc4c13c37c560ccd Reviewed-on: https://gerrit.libreoffice.org/42211 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-13Replace list by vector in TableFillingAndNavigationTools (sc)Julien Nabet
Change-Id: I6d9426c66b0952a3eac7d418a187ec4e3759eea6 Reviewed-on: https://gerrit.libreoffice.org/42221 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-09-12tdf#112348: Pivot table: page field filtering is not imported from XLSTamás Zolnai
Change-Id: I3477cd17f679bdfefb9340656999630380713d3f Reviewed-on: https://gerrit.libreoffice.org/42201 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-09-12Revert "tdf#108299: Limit the size of bitmap created for clipboard..."Dennis Francis
This reverts commit 157d1a774086d7344d443005442682f2ca3c01a9. Fix for the root cause coming up soon. Change-Id: Ia66432c8b1ed3f2063a3a091976812e2a479ab12 Reviewed-on: https://gerrit.libreoffice.org/42191 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Dennis Francis <dennis.francis@collabora.co.uk>
2017-09-12Prefix one more member of ScDocument: pDrawLayerTor Lillqvist
Change-Id: I8b2fdca8a58db6c6633d7708ed42ca218799c53b
2017-09-12Prefix one more member of ScDocument: pVirtualDevice_100th_mmTor Lillqvist
Change-Id: Idf82b514eac385ff3e9f9dc373d0e7fd41d00819
2017-09-12Prefix one more member of ScDocument: pPrinterTor Lillqvist
Change-Id: I9a67be61661f90633398a303ee467cafa7bdd548
2017-09-12Bin noise commentTor Lillqvist
Change-Id: I03fc61a36c6815705e496d9cbccda20cd999d6c0
2017-09-12tdf#112337: Pivot table: empty / blank item is not imported from XLSTamás Zolnai
Change-Id: I7ed9e5cacdf6df80b2f100d040cbbeda33b085d3 Reviewed-on: https://gerrit.libreoffice.org/42181 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-09-12Revert "Make two slightly mysterious static local variables thread_local"Tor Lillqvist
There still is at least one tinderbox Mac with an obsolete Xcode. This reverts commit 2652ce62f2ed4259e95578bc24af52fc48f197d5.
2017-09-12Make two slightly mysterious static local variables thread_localTor Lillqvist
IRC discussion about them: tml_: erAck: any idea why in ScFormulaCell::GetMatrixEdge those nC and nR are static? tml_: seems to have been since initial import in 2000 (then in a different file, and of type USHORT) tml_: let's assume it is just random insanity tml_: hmm, no, making them non-static actually breaks a unit test. wow erAck: tml_: they are reused when the call is for the same matrix origin as the last one to not have to recalculate the same thing tml_: erAck: ah ok Change-Id: Ib0fe322492917b5224937ec6ef527707ca2e07f7 Reviewed-on: https://gerrit.libreoffice.org/41658 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-09-12clang-tidy modernize-use-emplace in scNoel Grandin
Change-Id: Ifc38e1fc188fe957a0c717aec19cdd6637e4c658 Reviewed-on: https://gerrit.libreoffice.org/42183 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-12use more GetColumnsRangeNoel Grandin
Change-Id: If6995480d6196378279b757bfa717c772f0be448 Reviewed-on: https://gerrit.libreoffice.org/42174 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-12tdf#112328: Pivot table, XLS: Popup button for column fields is missingTamás Zolnai
...after round trip in Calc Wrong heading row was exported. Change-Id: I410eeeff7d7af408de1ea8128b6b21ac0cc76ea5 Reviewed-on: https://gerrit.libreoffice.org/42175 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-09-11remove constant bool variableJochen Nitschke
had no meaning since introduced in commit 11b5e05a827851e287315345bf563fda7e24d151 Date: Tue Nov 14 14:57:04 2006 +0000 INTEGRATION: CWS aw024 (1.26.134); FILE MERGED Change-Id: Ia2de3d1af4e8aa1f73fd20592aa4d9664d6fbf74 Reviewed-on: https://gerrit.libreoffice.org/42169 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2025-02-06 17:58:45 +0000