summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)Author
2014-10-10fix coverity#1242413 Logically dead codeCaolán McNamara
Change-Id: Ic56eff808cd4254448f63127da9b5b1d54c733a0
2014-10-10coverity#1244942 Dereference null return valueCaolán McNamara
Change-Id: I50e453bf9e31f4afc60096ad3888062c365f54c6
2014-10-09InsertCurrentTime: in input mode inherit matching format if setEike Rathke
In case a date or time cell format was set, inherit that format for Ctrl+; or Ctrl+: date/time insertion while editing the cell. Change-Id: If13e680fc74ab36611f8c11d992dba4b9c91ddb4
2014-10-09remove warning: ‘nIndex’ may be used uninitializedLaurent Godard
Change-Id: I317c2f4409f556ab967e4f08caa99cffcfce26cc Reviewed-on: https://gerrit.libreoffice.org/11876 Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> Tested-by: Kohei Yoshida <libreoffice@kohei.us>
2014-10-09fdo#84810 Avoid calc crash when using Paste Special - LinkMatthew J. Francis
Change-Id: I52c072578ccc0b9f75a850613056e74d400eb532 Reviewed-on: https://gerrit.libreoffice.org/11867 Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> Tested-by: Kohei Yoshida <libreoffice@kohei.us>
2014-10-09fdo#81356: convert Fraction to boost::rational<long> - wipJuan Picca
* Added rational util functions used by Fraction class not available in the boost::rational class. * Replaced usage of Fraction by boost::rational<long> * Removed code that relies on: 1. fraction.IsValid() -- rational only allow valid values, ie denominator() != 0 2. rational.denominator() == 0 -- always false 3. rational.denominator() < 0 -- always false but implementation detail: http://www.boost.org/doc/libs/release/libs/rational/rational.html#Internal%20representation * Simplified code that relies on: 1. rational.denominator() != 0 -- always true * BUGS EXIST because Fraction allows the creation of invalid values but boost::rational throws the exception boost::bad_rational Change-Id: I84970a4956afb3f91ac0c8f726547466319420f9 Reviewed-on: https://gerrit.libreoffice.org/11551 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2014-10-09typo: formual -> formulaAndras Timar
Change-Id: I39b4c2fc4edd7d609b15fc289dd1b053c749f435
2014-10-09make streamtimeout a config variable instead of an env. var.xukai
Change-Id: I6c82142265a0a149206d15fbc267ad61e6b9cf3b
2014-10-08Move this one to a common place too.Kohei Yoshida
Change-Id: I7f4e007cfc861dc323b42be353c6ba11091e8fa1
2014-10-08Share undo doc creation code.Kohei Yoshida
Change-Id: I55f27b61637ba0284479c63c2fa48b0bd8938c0f
2014-10-08Start sharing common code between DeleteContents of ScViewFunc/ScDocFunc.Kohei Yoshida
The goal is to have ScViewFunc::DeleteContents() simply call ScDocFunc::DeleteContents() while doing the view only stuff in the ScViewFunc variant. This is just a step toward that goal. Change-Id: I2e574f9eb2b2be5340dbfb6f10739dfc2406faae
2014-10-08fdo#83141: optimize slow performance after when using replaceall or searchallSeyeong Kim
- problem was hang after replaceall or searchall function - fix slow performance by looping only selected cols. Change-Id: Ic0178af33bf381e52584bd4366bff9e128891b64 Reviewed-on: https://gerrit.libreoffice.org/11829 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Matthew Francis <mjay.francis@gmail.com> Tested-by: Matthew Francis <mjay.francis@gmail.com> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-10-08Resolves: fdo#48405 GetString can call a macro which modifies the documentCaolán McNamara
causing m_aDataArray to be cleared, so the rItem the result of GetString is being assigned to is invalid Change-Id: I1dc30d675233ddc53234bdb5349c5f374b036ca8
2014-10-08convert ParamType enum in SC to enum classNoel Grandin
mostly to get the NONE constant out of the global namespace, so I can convert other enums which also want to use the NONE constant Change-Id: I988d5d7e5316dd5e4ca0be0cc8f043f69bbb900c Reviewed-on: https://gerrit.libreoffice.org/11848 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-08spelling: instanciated -> instantiatedNoel Grandin
Change-Id: I99f3010e30f81786b938dc11736ea1597cd5530d
2014-10-07disambiguate uniform_int_distributionCaolán McNamara
Change-Id: Ifa0c1b1983d1cc7f22d55b15dee88b7f709dbcf8
2014-10-07java: remove some unnecessary intermediary object creationNoel Grandin
Change-Id: Id4949fa08546e710fbf9bd0c7e3bf62979f29c83
2014-10-07Don't call comphelper::rng::uniform_real_distribution(a,b) with a==bTor Lillqvist
Change-Id: I95a3ac8da83e02001de13af8d31a04fe0d654dc0
2014-10-06avoid use of ref. to possibly deleted objectDavid Tardon
Change-Id: If5977b280fed8d8b053f59852d3984a59ce61a69
2014-10-06Resolves: fdo#80101 inserting non-chart as chart -> unhandled exceptionCaolán McNamara
Change-Id: I4d5438292d9a5c49f1336304ebd3dc4e155dd212
2014-10-06use comphelper::rng::uniform_*_distribution everywhereCaolán McNamara
and automatically seed from time on first use coverity#1242393 Don't call rand coverity#1242404 Don't call rand coverity#1242410 Don't call rand and additionally allow 0xFF as a value coverity#1242409 Don't call rand coverity#1242399 Don't call rand coverity#1242372 Don't call rand coverity#1242377 Don't call rand coverity#1242378 Don't call rand coverity#1242379 Don't call rand coverity#1242382 Don't call rand coverity#1242383 Don't call rand coverity#1242402 Don't call rand coverity#1242397 Don't call rand coverity#1242390 Don't call rand coverity#1242389 Don't call rand coverity#1242388 Don't call rand coverity#1242386 Don't call rand coverity#1242384 Don't call rand coverity#1242394 Don't call rand Change-Id: I241feab9cb370e091fd6ccaba2af941eb95bc7cf
2014-10-06fdo#73151 Always open Styles&Formatting dialog in the sidebarSamuel Mehrbrodt
Change-Id: I05b63dc00023945d92fd837bd64042135d3f9aed Reviewed-on: https://gerrit.libreoffice.org/11648 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-10-06fdo#39468 Translate German Comments - sc/source/filter/inc/Christian M. Heller
Change-Id: I26eacb2f8ab02c788e82aa6fdcb76d8fa07f64fb Reviewed-on: https://gerrit.libreoffice.org/11803 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-05coverity#1231669 Unchecked return valueNorbert Thiebaud
Change-Id: I60b7c8267c81b0545c2bcc367ad6cac43aefad64
2014-10-05coverity#1231670 Unchecked return valueNorbert Thiebaud
Change-Id: I29a751b2d44e86ccf115015b0ede8bae2e702eea
2014-10-05related fdo#70998 use plural for Objects/Images optionStanislav Horacek
Change-Id: Ia76021bcb9044a10b880c12fcbf67e86b837ebd4 Reviewed-on: https://gerrit.libreoffice.org/11811 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-10-04coverity#704002 Unchecked return valueNorbert Thiebaud
Change-Id: Ibf506a219df7d0ad67959b3d266a037003fceea4
2014-10-04coverity#1242368: Unchecked return valueNorbert Thiebaud
Change-Id: I6aaad60cf08349aee6c07621764a1a6c071ad2b6
2014-10-04coverity#1242369: Unchecked return valueNorbert Thiebaud
Change-Id: Ib5a938d9a8a0ac1f2f5dfb299c948951bb845349
2014-10-04Add menu entry for the "formula to value" feature.Kohei Yoshida
Not sure 100% if that's the best place for this. Feel free to move it to a better place. Change-Id: Id66a92e1184e988bd71f7d845ea370b021c02c21
2014-10-04coverity#1242413: logically dead codeNorbert Thiebaud
Change-Id: I6e5e5025df4ad8eef6ff6a7910cb9c3ab5fc3c4e
2014-10-04coverity#124890,1242726 Unused ValueNorbert Thiebaud
Change-Id: I1d32b7d68ac0ec3752364e855390af21be3f4496
2014-10-04coverity#1242818 Unused valueNorbert Thiebaud
Change-Id: I487026489937679978e7ed403edb7125eb2c7fcf
2014-10-04coverity#1242771 Unused valueNorbert Thiebaud
Change-Id: I86455a041c98f010724ac6878e78a1b14cd26899
2014-10-04coverity#1242781 Unused ValueNorbert Thiebaud
if nLen2 is 0 then bNextNum is set and nLen1 is then 0, and the if(nLen1 || nLen2) can only be true if nLen2 is non zero and bNextNum get overriden... so the line bNextNum = !bLastAlp is useless. Change-Id: Ice62562bf321e5389f2118677e72d1b421816858
2014-10-04fdo#39468 Translate German Comments - difimp and htmlimpChristian M. Heller
Change-Id: I221d07c56822905c500f11f3f738231259743acd Reviewed-on: https://gerrit.libreoffice.org/11802 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-03Let's consistently spell OpenCL as 'OpenCL'.Kohei Yoshida
Change-Id: I8bdcf0667b326b77d11001efeeefd5247987ebdc
2014-10-03Let's not omit 'virtual' keyword here.Kohei Yoshida
Change-Id: Idf4ccbb6415852325acab673a3d81f758e50c880
2014-10-03Make these non-inline.Kohei Yoshida
Change-Id: I1cc28c16796934f20afc53c6f6f083f372b7ce69
2014-10-03Run 'beautify' on these files as well.Kohei Yoshida
And some trivial manual fixing afterward... Change-Id: Ib60411f689b7971a2dd1acd1541864f38b34b570
2014-10-03coverity#1242443 Identical code for different branchesCaolán McNamara
Splitter derives from Window and doesn't override MouseMove so both branches are the same Change-Id: Id74f12e2efb458ac2ae183686a57befdf0225778
2014-10-03coverity#1242454 Identical code for different branchesCaolán McNamara
Splitter derives from Window and doesn't override MouseButtonUp so both branches are the same Change-Id: I9072d24b60dacfdb1d3e9ca1c97f08002f7e24ba
2014-10-03coverity#1242431 Explicit null dereferencedCaolán McNamara
Change-Id: I96cbc59931400ad2f348ffb44925e8fe34b782ed
2014-10-03coverity#1242477 Dereference null return valueCaolán McNamara
Change-Id: Ic2d8dab00d5af47f6274433ee811f567f990400b
2014-10-03coverity#1242849 Unused valueCaolán McNamara
status gets overwritten after the switch ends Change-Id: I60d4f61e6e1f31f9dd79c178c9a6f7060d154013
2014-10-03WaE: private fields 'mnTab' and 'mnCol' are not usedTor Lillqvist
Change-Id: I449b85b00aeaf690644e17be0a6b2b9398a3cd3f
2014-10-02Another test case for this feature.Kohei Yoshida
Change-Id: Ia406baec2867605bf515dac0ba090500e2bbd1ce
2014-10-02Write the first test for this formula-to-value feature.Kohei Yoshida
Change-Id: I545328a1c126b3bfeee8c1f662c5eb9a471d33ca
2014-10-02New feature to allow converting formula cells to static values.Kohei Yoshida
You used to have to convert formula cells to static values by copying them and pasting them as values onto the original place. Why not just allow converting them in place? This is something I've always wanted to implement.
2014-10-02Scope reduction by early bail-out.Kohei Yoshida
Change-Id: Iacbf9f46a1b5683b6de5dd93002a69078af46951