Age | Commit message (Collapse) | Author |
|
Change-Id: Iac924b0b6932863f7f9cc088f996e0b07c340d2c
|
|
Change-Id: I0e5e54b517d3fb3cb28eb133b2cbe5bf5ca6b1d6
|
|
Change-Id: Ia4da886b050397831383005131ff9f21570934ad
|
|
Change-Id: Ib5f1865cfd5d62f45919af8119d4ab691811225b
Reviewed-on: https://gerrit.libreoffice.org/12021
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Broadcasting it here and marking formula cells dirty prevents them
from being entered into the formula tree at the end. They get marked
"postponed dirty" during reference update, and are supposed to be
set dirty at the end.
Change-Id: I65977300ee4ee26b6166d170acd2145abcbbf288
|
|
Change-Id: I2fe455fc627e4b358507b58f08a3198ac62edad0
|
|
Change-Id: I4f9bc7ba26d42bfd3982efeb69bc221fc028c629
|
|
...similar to what has been done for svx/sdtmfitm.hxx in
68969cc61adecac481ae9656978ef952f435b310 "Consistency around SdrMetricItem."
Change-Id: I8e76e4751e50f5952c6dfff9ee10362166bf0523
|
|
Change-Id: Ib9a8ae04733c5bcb982ef4d337112eb8249d0ee0
|
|
Change-Id: I8dff6850c7088b483d1ad669867da6cef454d9a2
|
|
Change-Id: I5921cbeadbfb6fdfd6e4a89e39a616d25954bc51
Reviewed-on: https://gerrit.libreoffice.org/11984
Reviewed-by: Cor Nouws <oolst@nouenoff.nl>
Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
|
|
Fraction used BigInt internally for computations, rational does nothing
like that.
Change-Id: I3e9b25074f979bc291208f7c6362c3c40eb77ff5
|
|
Change-Id: Ic70f6f605e13a5c95b504f1bf0322e11313a21e7
|
|
Especially when formula cells are involved.
Change-Id: I40950e7108778821c17d08354f01bb157b1551e6
|
|
Change-Id: Ia2a32f4be3ef2c09ac68fe03ee9a7c9d31aef7ed
|
|
applying same strategy than 1e721077b43de84edab2a3ed2f316ddcbec6e3ec
Change-Id: I8c226d5d66ba8371ea1baec73e72b3e50886bb4f
Reviewed-on: https://gerrit.libreoffice.org/11877
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
...detected with a modified trunk Clang with
> Index: lib/Sema/SemaDeclCXX.cpp
> ===================================================================
> --- lib/Sema/SemaDeclCXX.cpp (revision 219190)
> +++ lib/Sema/SemaDeclCXX.cpp (working copy)
> @@ -1917,9 +1917,10 @@
> const Type *T = FD.getType()->getBaseElementTypeUnsafe();
> // FIXME: Destruction of ObjC lifetime types has side-effects.
> if (const CXXRecordDecl *RD = T->getAsCXXRecordDecl())
> - return !RD->isCompleteDefinition() ||
> - !RD->hasTrivialDefaultConstructor() ||
> - !RD->hasTrivialDestructor();
> + return !RD->hasAttr<WarnUnusedAttr>() &&
> + (!RD->isCompleteDefinition() ||
> + !RD->hasTrivialDefaultConstructor() ||
> + !RD->hasTrivialDestructor());
> return false;
> }
>
> @@ -3517,9 +3518,11 @@
> bool addFieldInitializer(CXXCtorInitializer *Init) {
> AllToInit.push_back(Init);
>
> +#if 0
> // Check whether this initializer makes the field "used".
> if (Init->getInit()->HasSideEffects(S.Context))
> S.UnusedPrivateFields.remove(Init->getAnyMember());
> +#endif
>
> return false;
> }
to warn about members of SAL_WARN_UNUSED-annotated class types, and warn about
initializations with side effects (cf.
<http://lists.cs.uiuc.edu/pipermail/cfe-dev/2014-October/039602.html>
"-Wunused-private-field distracted by side effects").
Change-Id: I3f3181c4eb8180ca28e1fa3dffc9dbe1002c6628
|
|
Change-Id: Ib3763f20d74c22e28d519a9ac47f6f3ab4e31f51
Reviewed-on: https://gerrit.libreoffice.org/11983
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: I33ca88f38210140931b12a05e426d1373243156e
|
|
Found when investigating performance bottlenecks of fdo#75486, after the
selection is completed ScTabViewObj::getSelection() is called multiple
times, each creating a ScCellRangesObj of the range list of filtered
ranges, which then is used for
ScChildrenShapes::FindSelectedShapesChanges()
The duplicated call was introduced with
b41332475783c31136673fb44cf4c411bb0148f8
but IMHO does not make any sense at all unless it has obscure side
effects, it only slows down things even more.
Change-Id: I3cee2e3e62c24ad72efb8cc2021e74d0afc70b69
|
|
Change-Id: I734ff88bc4c0633875c9e9c19a817b8b08511c83
|
|
Change-Id: Id2114652948d12c92b0e7be7afa304bfffc8fbe0
|
|
Change-Id: Iab385ce8b24dd24985ec9b2d0c9d2a4e603d0fd0
|
|
Change-Id: Id5243aa37578cf9ed534603f3b27e83f0678c3fb
|
|
Change-Id: I1920fa405f377abafe793b4bbec52b8b141459f6
|
|
Change-Id: I9b9944fa1b9e00989a499f7a8fac74097ae9d61b
|
|
Change-Id: If2e8d3cfe49a039cc27035ae9c0f037c2d60b122
|
|
Change-Id: Ida858f633f1e9afcc1a5a06f503f0ab06d2d3e74
|
|
Change-Id: If1c59d6d06a9e4601731f13a69b1ac2603c0014b
|
|
Change-Id: I3b0a145f70406f0c8a12b6c4b7876c4148f76e93
|
|
...and hope it gets past our various tinderboxes.
Change-Id: I4dd95e77c4a74ae58e66f98753fcf5e438080146
|
|
it has intermittent failures which causes the tinderboxes
to unnecessarily spam my inbox
Change-Id: I689b9d8c5da169dc6572250afe686b79039fba34
|
|
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>,
changed from a macro- to a template-based solution. (Unfortunately MSVC 2012
does not support explicit conversion operators. Worked around that with
explicit #ifs rather than some HAVE_EXPLICIT_CONVERSION_OPERATORS and
SAL_EXPLICIT_CONVERSION_OPERATOR ainticipating we hopefully soon move to a
baseline that requires unconditional support for them.)
Change-Id: I4a89643b218d247e8e4a861faba458ec6dfe1396
|
|
Change-Id: I120a9d0943db38571892defe1b5d3169158e3e42
|
|
To do this, I've made FontCharMap a friend class for ImplFontCharMap,
and have moved the functions directly into FontCharMap. In this patch,
I am attempting to stop the direct use of ImplFontCharMap by anything
other than FontCharMap. However, FontCharMap itself requires a
refcounter, so we will use FontCharMapPtr to access the font character
map.
Change-Id: I509b990a8cbd911c5cc1572c7d24fc5348ca06d9
Reviewed-on: https://gerrit.libreoffice.org/11823
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
|
|
Change-Id: I12f9392813f5fdd6f2d36398ea00a5cad812cd26
|
|
Change-Id: I3733471b72e96c8d020b8b5238fdb5fc4bfcacce
|
|
Change-Id: If805ba07baa36cbf94ee22f77f98ef4057d8b306
|
|
For cases where ROW or COLUMN references another cell that has shifted.
Change-Id: Ic4bef8672dab811ceff6886d9af0388306a66485
|
|
Change-Id: I0fe5c0165e1c430861028175c82ff116bac969aa
Reviewed-on: https://gerrit.libreoffice.org/11926
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: Ic39043d0453830d348ac3bc8a027b862e4bbdfd8
|
|
EndUndo() calls PostDataChanged(), which renders the recalculated formula
cells. Not broadcasting before EndUndo causes some dependent formula
cells to not get recalculated.
This one unfortunately is not currently unit-testable as this behavior
depends on the presence of ScTabViewShell....
Change-Id: I86288608b7f2627cda7c74be27a18029832775ef
|
|
Change-Id: I5e16f68f8565a26857f4ef233e06a002209e2566
Reviewed-on: https://gerrit.libreoffice.org/11915
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
|
|
and fix a couple of bugs in SC and SW where the call mode was
being passed to the hints parameter by accident
Change-Id: Ief805410b3f7035e012e229e77f92d5832430f58
Reviewed-on: https://gerrit.libreoffice.org/11916
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: Ifa46523619ae7fb8d112525b8df594836e51bb8f
Reviewed-on: https://gerrit.libreoffice.org/11843
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
|
|
from oox::core::Relations.
Change-Id: If2e0109a2ad6598436177b7638cb6d568fb2d3d6
Reviewed-on: https://gerrit.libreoffice.org/11899
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
If bSimple = true, call DeleteCell(), otherwise call DeleteContents().
Change-Id: Ic08d9501797b537430bef0b6f3d920c3b497104b
|
|
for a single cell case. This is equivalent of ScViewFunc::DeleteConents
with bSimple = true.
Change-Id: I5eccce21843f4cb21b29f96b0360617a180aebee
|
|
Change-Id: Ia201473c84dc0923e8f4bee6329ad926cd6addd6
|
|
Change-Id: I9885e2712753390f0597233c404ab80c0ad2b537
|