summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)Author
2018-10-19clang-tidy readability-container-size-emptyNoel Grandin
Change-Id: I1df70b7dff5ebb6048f7fc618789faa15ca5d422 Reviewed-on: https://gerrit.libreoffice.org/61967 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-19Turn ScGridWin::AutoFilterMode into scoped enumStephan Bergmann
...to avoid -Werror,-Wshadow from Clang trunk with <https://reviews.llvm.org/D52400> "Improve -Wshadow warnings with enumerators", warning about shadowing of SortAscending/Descending in enum SvSortMode in include/svtools/treelist.hxx Change-Id: I7022d3c6338c5ff50edf6362577f89f6609cd3e9 Reviewed-on: https://gerrit.libreoffice.org/61960 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-10-19clang-tidy readability-misleading-indentationNoel Grandin
Change-Id: I4673fc7c694924b41d048a1918ddb8b0e0af1f79 Reviewed-on: https://gerrit.libreoffice.org/61935 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-19clang-tidy modernize-redundant-void-argNoel Grandin
Change-Id: Ia25ac2e40f29e5b766a4c5c013fb53274196f656 Reviewed-on: https://gerrit.libreoffice.org/61934 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-19Revert "Notebookbar: add context-Printpreview to calc tabbed NB"Christian Lohmaier
This reverts commit 3f9c477929c261a8862411c00153e4c7d0d0ae7c. Breaks the JunitTest_sc_unoapi tests with clang
2018-10-18NB: Rename Menu entries for drop down menuesandreas kainz
Change-Id: Iee8cbf1d3be4f205c975d5100a8b3f2506653e26 Reviewed-on: https://gerrit.libreoffice.org/61954 Reviewed-by: andreas_kainz <kainz.a@gmail.com> Tested-by: andreas_kainz <kainz.a@gmail.com>
2018-10-18add test for bug tdf#73081Zdeněk Crhonek
Change-Id: I96f56cee0cab3fa18992281e3745164377adade3 Reviewed-on: https://gerrit.libreoffice.org/61939 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2018-10-18Sync Image/Graphic Tabb and context menuandreas kainz
NB: sync MenuImage in tabbed toolbar context menu: sync graphic.xml context menu in writer, calc, impress and draw Change-Id: Idab90ae9af7ac68815fe689811d6c11f948063ca Reviewed-on: https://gerrit.libreoffice.org/61938 Reviewed-by: andreas_kainz <kainz.a@gmail.com> Tested-by: andreas_kainz <kainz.a@gmail.com>
2018-10-18Notebookbar: add context-Printpreview to calc tabbed NBandreas kainz
Change-Id: Iee6c83ae03ead7ae0b2c33f6cf364c1c3c59528f Reviewed-on: https://gerrit.libreoffice.org/61892 Reviewed-by: andreas_kainz <kainz.a@gmail.com> Tested-by: andreas_kainz <kainz.a@gmail.com>
2018-10-18loplugin:staticvar in scNoel Grandin
Change-Id: I9f1d66e9af454a27a341e56bbe50a558898b65a1 Reviewed-on: https://gerrit.libreoffice.org/61900 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-18clang-tidy readability-simplify-boolean-exprNoel Grandin
Change-Id: I78fa01a6c803dec782488490b730af3a11814d64 Reviewed-on: https://gerrit.libreoffice.org/61902 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-17Remove unused FormulaLogger::maMessageStephan Bergmann
Change-Id: Ie1bc5cf4db6b46160fd950f471c9baf9ec51ebf7 Reviewed-on: https://gerrit.libreoffice.org/61873 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-10-17tdf#42949 Fix IWYU warnings in include/tools/*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I9dc920e9388f9e2aa4dcae1f0b3f7562d08f7f70 Reviewed-on: https://gerrit.libreoffice.org/61809 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-10-17Silence more Clang trunk -Wdefaulted-function-deletedStephan Bergmann
...similar to 3db830d354de80b319fb818a0373365a1e647264 "Silence new Clang trunk -Wdefaulted-function-deleted", after fb1d3b580763a333bbbfe115d09e1b5cd8849675 "loplugin:constfields in sc" Change-Id: I8358e862e53dd8f57169ba2d2f2c543edb93e2a5 Reviewed-on: https://gerrit.libreoffice.org/61867 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-10-17ScTable::CopyTable drop defaults from paramsNoel Grandin
so I can change the signature of this method safely Change-Id: I91574cc1660c14408f2dcd9dbd18c0faa1a1e5c5 Reviewed-on: https://gerrit.libreoffice.org/61864 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-17clang-tidy readability-redundant-smartptr-getNoel Grandin
redundant get() call on smart pointer Change-Id: Icb5a03bbc15e79a30d3d135a507d22914d15c2bd Reviewed-on: https://gerrit.libreoffice.org/61837 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-17loplugin:singlevalfieldsNoel Grandin
tighten up the handling of binary operators Change-Id: I262ec57bf7142fa094d240738150a94d83fd15ee Reviewed-on: https://gerrit.libreoffice.org/61777 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-17Notebookbar: sync tabbedbarandreas kainz
Change-Id: I6441f66f7cd078dae0c81cb1a5c62b5130187536 Reviewed-on: https://gerrit.libreoffice.org/61858 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-10-17Notebookbar: update calc tabbed notebookbarandreas kainz
Add Printpreview, Object, Media, Update Image, Draw Context tab Change-Id: I4433ba838ca734f2214679f9bdfa50427edfcc71 Reviewed-on: https://gerrit.libreoffice.org/61856 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-10-16tdf#45904 Move _XTableChartsSupplier Java Tests to C++Rahul Gurung
Change-Id: I4cd0b25cefce60e8253df65d5136d15d690dbc38 Reviewed-on: https://gerrit.libreoffice.org/61540 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-10-16coverity#1440303 use emplace_back instead of push_backCaolán McNamara
Change-Id: I51457423fdd8d39b5c11d02b450d31fa59127952 Reviewed-on: https://gerrit.libreoffice.org/61840 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-16Related: tdf#120612 help response missing from other help buttonsCaolán McNamara
Change-Id: I982b4190f5af2715f797ecd9bf798e4b4af0ecda Reviewed-on: https://gerrit.libreoffice.org/61828 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-16Notebookbar: update tabbed toolbar for calcandreas kainz
remove separator in other tabbedbars Change-Id: I99c83cd09e5fa8bde2809680d5ef138c4ef499de Reviewed-on: https://gerrit.libreoffice.org/61803 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-10-16Unit test deleting shared formula group top cell, tdf#119623Eike Rathke
Change-Id: I9a497b9d9ae09c8764f62549a60c8a2a952bc9e9 Reviewed-on: https://gerrit.libreoffice.org/61822 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2018-10-16Resolves: tdf#119623 record group positions also for top cellsEike Rathke
So listeners can be re-established for remaining grouped cells if top cell is deleted (which ends listening and probably was the cause to exclude them here). Change-Id: Ic91b74c65013452d56b5cfbc132722c4314743c8 Reviewed-on: https://gerrit.libreoffice.org/61808 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2018-10-16tdf#42949 Fix IWYU warnings in sc/source/ui/inc/[a-e]*Gabor Kelemen
Also files starting with capital letters. Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ia79de45524315e2aaa1283ee6e42c54c9e14a31e Reviewed-on: https://gerrit.libreoffice.org/61735 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-10-15Introduce and use ScConditionalFormatList::empty() instead of size()Eike Rathke
Change-Id: If42fdfbcac74ef2a04bd5d006272a5c1a4f510e2 Reviewed-on: https://gerrit.libreoffice.org/61804 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2018-10-15tdf#120087 Disable unuseable items in Manage DialogAbhyudaya Sharma
Fix behaviour for 'Remove' and 'Edit' buttons for the Manage Conditional Formatting dialog in Calc Change-Id: Id8fc37262464232ab8fbb76c5a9609af5982e222 Reviewed-on: https://gerrit.libreoffice.org/61475 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2018-10-15loplugin:staticconstfield improvementsNoel Grandin
And fix ScXMLCachedRowAttrAccess::Cache which was never setting its mnTab field, and hence would never be hit. And fix oox::xls::CellBlockBuffer, which was never setting mnCurrRow. Change-Id: I2c46aa050b9ebe3c2dc2e52579555f97945dd61c Reviewed-on: https://gerrit.libreoffice.org/61772 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-15Conditional formatting: Use the nElements from g_IconSetMap.Jan Holesovsky
And also kill some copy'n'paste when at that. Change-Id: Ice38b738f31e486008fdae450c9534306f3a9613 Reviewed-on: https://gerrit.libreoffice.org/61705 Tested-by: Jenkins Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2018-10-15clang-tidy bugprone-copy-constructor-initNoel Grandin
message is "calling a base constructor other than the copy constructor" these constructors are not in use, so just remove them Change-Id: Ic8cede1eb153a6ae97fd1ca9c96ca8c1f43e3399 Reviewed-on: https://gerrit.libreoffice.org/61784 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-15sc: Let SKEW/SKEWP raise #!DIV/0 when < 3 numbers are givenTakeshi Abe
as ODF 1.2 mentions such constaints of these functions, and Excel's documentation also admits it with more specific remark: <https://support.office.com/en-us/article/skew-function-bdf49d86-b1ef-4804-a046-28eaea69c9fa> <https://support.office.com/en-us/article/skew-p-function-76530a5c-99b9-48a1-8392-26632d542fcb> Change-Id: If19350997ddcb6f0fb36e29e090e260c3ae3d262 Reviewed-on: https://gerrit.libreoffice.org/61130 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2018-10-15sc: Make KURT() return #DIV/0! when <4 arguments are givenTakeshi Abe
as Excel does: <https://support.office.com/en-us/article/kurt-function-bc3a265c-5da4-4dcb-b7fd-c237789095ab> Change-Id: I1059e6e5dd9f01688219492e76af6dbbe97be41a Reviewed-on: https://gerrit.libreoffice.org/61286 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2018-10-15Redundant variableMike Kaganski
Change-Id: I0ceeea25b35b144e2cb4567939a7e9b01a723320 Reviewed-on: https://gerrit.libreoffice.org/61569 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2018-10-15clang-tidy misc-redundant-expressionNoel Grandin
Change-Id: I708b0b486a233071f95592ccdb97f27fc35a23c4 Reviewed-on: https://gerrit.libreoffice.org/61783 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-15loplugin:unusedmethodsNoel Grandin
Change-Id: I0226d33cbe224519cf2ed9ea5143ffe68fdbc884 Reviewed-on: https://gerrit.libreoffice.org/61775 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-15tdf#120429 - Functions Insert Columns Exist Two Timesheiko tietze
Legacy UNO commands InsertRows and InsertCols hidden from customization Commands are still accessible via macro Also fixed terminology in Draw/Impress for Insert Columns from Left/Right to Before/After Change-Id: I29a6b2fdb7481db43ad1a8ad25be5e9107558bd6 Reviewed-on: https://gerrit.libreoffice.org/61579 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-10-15tdf#42949 Fix IWYU warnings in include/basegfx/*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ifd59a5d93cfe7dc232891a681002014cd825035a Reviewed-on: https://gerrit.libreoffice.org/61546 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-10-15add SvStream::TellEndNoel Grandin
and simplify callsites to use it instead of the current "seek to end, find pos, seek back to original pos" pattern Change-Id: Ib5828868f73c341891efc759af8bd4695ae2f33c Reviewed-on: https://gerrit.libreoffice.org/61738 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-15loplugin:constfields in scNoel Grandin
Change-Id: If326175d571d15752efd1b63df45b2bc785f7541 Reviewed-on: https://gerrit.libreoffice.org/61653 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-14MoreButton is solely used by toolkitCaolán McNamara
Change-Id: Ieb436b49be3598e316d59a6d89cb211879d061c1 Reviewed-on: https://gerrit.libreoffice.org/61766 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-14drop unnecessary vcl/group.hxx includesCaolán McNamara
Change-Id: I09d86ee7e156ac71d7c1f9fd58d43751037d2629 Reviewed-on: https://gerrit.libreoffice.org/61761 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-13Fix a weird checkbox label in Calc’s recalculation promptAdolfo Jayme Barrientos
GTK+’s dumb defaults strike again! Similar to 7da61ec6d8ab6312b45ef7d683f3ec24e6b2b570. Found while triaging tdf#120513. Change-Id: I9ade695184cbcc9f1de9f11b20aa751754263586
2018-10-12coverity#1440239 Uncaught exceptionCaolán McNamara
Change-Id: I2b744d70ab426fbf26bcb3762aafaa569d0aafc7 Reviewed-on: https://gerrit.libreoffice.org/61675 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-12Simple translation passing by...Andrea Gelmini
Change-Id: I643e8bdf6b88d53f41008e41ac04fbf49696c3a2 Reviewed-on: https://gerrit.libreoffice.org/61707 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2018-10-12Conditional formatting: Allow to set the icon set CF via .uno: command.Jan Holesovsky
When .uno:IconSetFormatDialog gets a parameter, it directly creates the icon set conditional formatting with pre-selected values. Change-Id: I75dda90e5ea9c191254acc24c564cda7b27243a5 Reviewed-on: https://gerrit.libreoffice.org/56429 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk> Reviewed-on: https://gerrit.libreoffice.org/61669 Tested-by: Jenkins Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2018-10-11tdf#119580 sc: Use the regular object popupmenu for chartsMaxim Monastirsky
Context menu of a chart is supposed to be the same as for other ole objects, except the additional .uno:ExportAsGraphic. Given that .uno:ExportAsGraphic is hidden when non-chart object is selected, we can just place it in the regular ole object popupmenu (done already), and use that menu also for charts. Discussion is in https://gerrit.libreoffice.org/60128 . Change-Id: I8a07c550998e1db0d2af7f87c625dbd258454bdd Reviewed-on: https://gerrit.libreoffice.org/61678 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2018-10-11Remove superfluous separatorMaxim Monastirsky
Change-Id: I12f7ebf8cb40c5c1ea40509ac38ae977e1abca89 Reviewed-on: https://gerrit.libreoffice.org/61677 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2018-10-11tdf#120528: check for empty mpMouseEvent in ScDataTableView::MouseButtonUpMike Kaganski
The preceeding mouse button down event could happen in a different (closing) window, like context menu. Change-Id: I630b827fb5fe05399ca8436ea79210f4642a56d4 Reviewed-on: https://gerrit.libreoffice.org/61691 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-10-11Resolves: tdf#120476 need to be resizable if number of tabs is variableCaolán McNamara
across runs Change-Id: Ie77512557c10f564ed9d2dab837b134e9b4834a1 Reviewed-on: https://gerrit.libreoffice.org/61672 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2024-07-17 19:06:42 +0000