summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)Author
2023-02-14tdf#153510: STYLE: try harder to detect when there's nothing to doMike Kaganski
1. Find the real style names early, to avoid re-triggering style application when STYLE arguments use wrong case; 2. Also check a (rare) case when both immediate and delayed styles are the same as currently applied. Change-Id: Id8ab2e321ede6d0f8f05ac5d1e63ade0212e5865 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146775 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit 208a4ecafafa97ea7fcc5a135fa8160e91ea0a74) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146768 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-02-13sc: avoid divide by zero in ScEEImport::GraphicSizeXisco Fauli
See https://crashreport.libreoffice.org/stats/signature/ScEEImport::GraphicSize(short,long,ScEEParseEntry%20*) Change-Id: Ia5acccb1118aff2486d23eabd536053e67f346ba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146917 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-02-13Flatten ScInterpreter::ScStyleMike Kaganski
Change-Id: I64c622d2c2cacccc7eda02e8739657fe345f9be8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146777 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit 2844670d2a47c606cbebb99f73389f30154a3c5e) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146767 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-02-13tdf#153514: try to find exact match, even when searching case-insensitivelyMike Kaganski
Change-Id: Ib3bec382ef80a9078ffde8612c395cb0154fd476 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146747 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit 2a984c77ccb1aa77d9bbd02218d4dc76aaff4a9e) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146766 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-02-13Resolves: tdf#139934 always apply cellXfs xf explicits (tdf#123139 related)Eike Rathke
Change-Id: Id1e12ee8677a25a645bfd53b4968a17c9a1eabe5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146599 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit 909a25d30b09ebd3a023105a9c3cc4d20add094a) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146614 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-02-13Related: tdf#153510 Avoid modification of iterated containerMike Kaganski
A crash is seen when resizing a document locally; the problem is range-based for loop, which indirectly modifies its range: sclo.dll!ScAutoStyleList::AddInitial(const ScRange & rRange, const rtl::OUString & rStyle1, unsigned __int64 nTimeout, const rtl::OUString & rStyle2) Line 81 C++ sclo.dll!ScDocShell::Notify(SfxBroadcaster & __formal, const SfxHint & rHint) Line 685 C++ svllo.dll!SfxBroadcaster::Broadcast(const SfxHint & rHint) Line 41 C++ sclo.dll!ScInterpreter::ScStyle() Line 2628 C++ sclo.dll!ScInterpreter::Interpret() Line 4441 C++ sclo.dll!ScFormulaCell::InterpretTail(ScInterpreterContext & rContext, ScFormulaCell::ScInterpretTailParameter eTailParam) Line 1947 C++ sclo.dll!ScFormulaCell::Interpret(long nStartOffset, long nEndOffset) Line 1619 C++ sclo.dll!ScFormulaCell::MaybeInterpret() Line 470 C++ sclo.dll!ScFormulaCell::IsValue() Line 2763 C++ sclo.dll!ScConditionEntry::Interpret(const ScAddress & rPos) Line 670 C++ sclo.dll!ScConditionEntry::IsCellValid(ScRefCellValue & rCell, const ScAddress & rPos) Line 1238 C++ sclo.dll!ScConditionalFormat::GetData(ScRefCellValue & rCell, const ScAddress & rPos) Line 1836 C++ sclo.dll!`anonymous namespace'::handleConditionalFormat(ScConditionalFormatList & rCondFormList, const o3tl::sorted_vector<unsigned long,std::less<unsigned long>,o3tl::find_unique,1> & rCondFormats, ScCellInfo * pInfo, ScTableInfo * pTableInfo, ScStyleSheetPool * pStlPool, const ScAddress & rAddr, bool & bHidden, bool & bHideFormula, bool bTabProtect) Line 297 C++ sclo.dll!ScDocument::FillInfo(ScTableInfo & rTabInfo, short nCol1, long nRow1, short nCol2, long nRow2, short nTab, double fColScale, double fRowScale, bool bPageMode, bool bFormulaMode, const ScMarkData * pMarkData) Line 569 C++ sclo.dll!ScGridWindow::Draw(short nX1, long nY1, short nX2, long nY2, ScUpdateMode eMode) Line 556 C++ sclo.dll!ScGridWindow::Paint(OutputDevice & __formal, const tools::Rectangle & rRect) Line 458 C++ vcllo.dll!PaintHelper::DoPaint(const vcl::Region * pRegion) Line 313 C++ vcllo.dll!vcl::Window::ImplCallPaint(const vcl::Region * pRegion, ImplPaintFlags nPaintFlags) Line 617 C++ vcllo.dll!PaintHelper::~PaintHelper() Line 553 C++ vcllo.dll!vcl::Window::ImplCallPaint(const vcl::Region * pRegion, ImplPaintFlags nPaintFlags) Line 623 C++ vcllo.dll!PaintHelper::~PaintHelper() Line 553 C++ vcllo.dll!vcl::Window::ImplCallPaint(const vcl::Region * pRegion, ImplPaintFlags nPaintFlags) Line 623 C++ vcllo.dll!PaintHelper::~PaintHelper() Line 553 C++ vcllo.dll!vcl::Window::ImplCallPaint(const vcl::Region * pRegion, ImplPaintFlags nPaintFlags) Line 623 C++ vcllo.dll!PaintHelper::~PaintHelper() Line 553 C++ vcllo.dll!vcl::Window::ImplCallPaint(const vcl::Region * pRegion, ImplPaintFlags nPaintFlags) Line 623 C++ vcllo.dll!PaintHelper::~PaintHelper() Line 553 C++ vcllo.dll!vcl::Window::ImplCallPaint(const vcl::Region * pRegion, ImplPaintFlags nPaintFlags) Line 623 C++ vcllo.dll!vcl::Window::ImplCallOverlapPaint() Line 646 C++ vcllo.dll!vcl::Window::ImplHandlePaintHdl(Timer * __formal) Line 668 C++ vcllo.dll!vcl::Window::LinkStubImplHandlePaintHdl(void * instance, Timer * data) Line 648 C++ vcllo.dll!Link<Timer *,void>::Call(Timer * data) Line 111 C++ vcllo.dll!Timer::Invoke(Timer * arg) Line 81 C++ vcllo.dll!vcl::Window::ImplHandleResizeTimerHdl(Timer * __formal) Line 684 C++ vcllo.dll!vcl::Window::LinkStubImplHandleResizeTimerHdl(void * instance, Timer * data) Line 674 C++ vcllo.dll!Link<Timer *,void>::Call(Timer * data) Line 111 C++ vcllo.dll!Timer::Invoke(Timer * arg) Line 81 C++ vcllo.dll!vcl::Window::GetSizePixel() Line 2420 C++ sclo.dll!ScTabView::GetGridWidth(ScHSplitPos eWhich) Line 3032 C++ sclo.dll!ScViewData::CellsAtX(short nPosX, short nDir, ScHSplitPos eWhichX, unsigned short nScrSizeX) Line 2634 C++ sclo.dll!ScViewData::VisibleCellsX(ScHSplitPos eWhichX) Line 2710 C++ sclo.dll!ScTabView::PaintArea(short nStartCol, long nStartRow, short nEndCol, long nEndRow, ScUpdateMode eMode) Line 2386 C++ sclo.dll!ScTabViewShell::Notify(SfxBroadcaster & rBC, const SfxHint & rHint) Line 63 C++ svllo.dll!SfxBroadcaster::Broadcast(const SfxHint & rHint) Line 41 C++ sclo.dll!ScDocShell::PostPaint(const ScRangeList & rRanges, PaintPartFlags nPart, unsigned short nExtFlags) Line 172 C++ sclo.dll!ScDocShell::PostPaint(short nStartCol, long nStartRow, short nStartTab, short nEndCol, long nEndRow, short nEndTab, PaintPartFlags nPart, unsigned short nExtFlags) Line 106 C++ sclo.dll!ScDocShell::DoAutoStyle(const ScRange & rRange, const rtl::OUString & rStyle) Line 1580 C++ sclo.dll!ScAutoStyleList::InitHdl(Timer * __formal) Line 92 C++ sclo.dll!ScAutoStyleList::LinkStubInitHdl(void * instance, Timer * data) Line 84 C++ vcllo.dll!Link<Timer *,void>::Call(Timer * data) Line 111 C++ vcllo.dll!Timer::Invoke() Line 76 C++ vcllo.dll!Scheduler::CallbackTaskScheduling() Line 481 C++ vcllo.dll!SalTimer::CallCallback() Line 55 C++ vclplug_winlo.dll!WinSalTimer::ImplHandleElapsedTimer() Line 166 C++ vclplug_winlo.dll!ImplSalYield(bool bWait, bool bHandleAllCurrentEvents) Line 525 C++ vclplug_winlo.dll!WinSalInstance::DoYield(bool bWait, bool bHandleAllCurrentEvents) Line 581 C++ vcllo.dll!ImplYield(bool i_bWait, bool i_bAllEvents) Line 475 C++ vcllo.dll!Application::Yield() Line 560 C++ vcllo.dll!Application::Execute() Line 453 C++ sofficeapp.dll!desktop::Desktop::Main() Line 1604 C++ vcllo.dll!ImplSVMain() Line 203 C++ vcllo.dll!SVMain() Line 236 C++ sofficeapp.dll!soffice_main() Line 94 C++ soffice.bin!sal_main() Line 51 C soffice.bin!main(int argc, char * * argv) Line 49 C ScAutoStyleList::InitHdl iterated over aInitials, and called pDocSh->DoAutoStyle, which eventually called ScAutoStyleList::AddInitial, which modified aInitials, resulting in dangling reference rInitial back in the ScAutoStyleList::InitHdl. Change-Id: Id4e2aac2f5b0b27a7a57f22c0c9cdf8a1e950f30 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146690 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit a80630b6ee6e7636d2c93c42724ce815c991311c) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146709 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Jenkins (cherry picked from commit a01f4a1c317520a7a3090cfb2f1c9f21bbc50922) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146756 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-02-09crashtesting: crash on forum-mso-en4-719754.xlsx with fPercentile ~== 1Caolán McNamara
input is fPercentile of near 1 where approxFloor would give nIndex of nSize-1 resulting in a non-zero tiny negative fDiff, when the assumption is fDiff will be 0 or some positive value. Change-Id: I8fe5520f2b3c68f3204d435337df527185dcb0d3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146218 Tested-by: Jenkins Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 1371ba2bcbcce57ba5cbd7a199ae8feceb22d0d0) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146204 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-01-19sc: fix crash in ScViewData::GetCurXForTab()Miklos Vajna
Crashreport signature: program/libsclo.so ScViewData::GetCurXForTab(short) const sc/source/ui/view/viewdata.cxx:1431 program/libsclo.so ScViewFunc::OnLOKInsertDeleteColumn(short, long) sc/source/ui/view/viewfunc.cxx:1552 program/libsclo.so ScDocFunc::InsertCells(ScRange const&, ScMarkData const*, InsCellCmd, bool, bool, bool) source/ui/docshell/docfunc.cxx:2256 program/libsclo.so ScViewFunc::InsertCells(InsCellCmd, bool, bool) sc/source/ui/view/viewfunc.cxx:1658 Seeing that e.g. ScViewData::WriteUserDataSequence() already checks if the pointer in maTabData is a nullptr, do the same here. Change-Id: I0ebdba8c8a5bedd3c3c57c36bdf0632e2fee45c9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145697 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com> (cherry picked from commit 1f8c02353d653a6d4a72d918aaf6be5f367137c9) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145730 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-01-19Resolves: tdf#153096 Split change track content action into columns againEike Rathke
Old SvTreeList did split a string on embedded \t Tab characters, the new weld::TreeView does not but needs column text set explicitly. Regression from commit 56dd851cfc77c362c3db5c0aae4a490c7f6782cc CommitDate: Sat Apr 27 12:41:14 2019 +0200 weld cluster of change tracking dialogs that did the necessary changes for ScAcceptChgDlg::AppendFilteredAction() but not for ScAcceptChgDlg::AppendChangeAction() and ScAcceptChgDlg::InsertChangeActionContent(). Odd that no one reported this in all the time.. Additionally, the "Changed contents" label being used instead of "Row inserted"/"Column inserted"/"Row deleted"/"Column deleted" as soon as cell content change is present depending on such action, was a copypasta fallout from commit e7c76b30bd2ef802ce08f8739eac186253c79696 CommitDate: Mon Aug 29 17:21:12 2011 -0400 String to rtl::OUString. Change-Id: I855c527da61723c104c743e3b3f159fb026917df Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145749 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit fc441f3886330c4ae2abeb67c0758b935ba23f47) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145725 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2023-01-18tdf#153006 ordering of date/time formats in report builderNoel Grandin
regression from commit 17d2247a66b6a9e3105b0a8b8e6d6b5bea5e3ed4 Author: Noel Grandin <noelgrandin@gmail.com> Date: Fri Aug 13 19:03:23 2021 +0200 formatter maps can use unordered_map Change-Id: Ibc4bc71776a48c61fb9b651672404f9507c1f082 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145566 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit db28a0cc2e11e1319509e13172fadf4b54d50ecf) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145715 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145738
2023-01-12Revert "Resolves tdf#143100 - Disable cell style commands when sheet is ↵Heiko Tietze
protected" This reverts commit a3cb71ac80c0c2971e97c033d212cf4e464fa8f0. Reason for revert: tdf#149857 Change-Id: I5ea780b986073a8db16d5dc2ea503aa30da7ef27 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145118 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> (cherry picked from commit 3babbc31bf4bba35924c25c5fbd59e1c314d3627) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145130 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> (cherry picked from commit 9d6ae0b8d2ebb3931b3c46147e14939e7ed3f3ed) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145229
2023-01-11Resolves: tdf#151886 Use default locale with English function names againEike Rathke
Automatically switching to en-US locale when using English function names caused too much confusion. There also might be the possibility that the '.' dot decimal separator clashes with the inline array column separator in some locales. A proper solution would make this user-specified and if set also adjust the separators to the common English ones. For now keep the default locale again as it previously was the case. Change-Id: Ic4712c6609c14f35cf0d1d842ac7443806a6e115 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144924 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit cf8cfee9d4e64dba6a14dde16f08a7699fdff863) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144906 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-01-11Related: tdf#152948 Align AddInMap English names to Add-In implementationEike Rathke
... of scaddins/source/analysis/analysishelper.cxx for the few (4) functions with the _EXCEL2003 suffix. The compiler's symbol map for English contained both, but the reverse map contained only the (first added) ..._ADD name, so GCD_EXCEL2003() was displayed as GCD_ADD(), that still worked but was unexpected. Change-Id: I8c866dc73d0146d75b29f8212a7e561a3f38fce4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145247 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit f98d04571c99b70ff753d322b1f43adc8e0433ba) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145298 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-01-11Resolves: tdf#152950 don't set_active while frozenCaolán McNamara
Change-Id: I7db73e37ed426aae2282a6bf1564e5d3843442cf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145231 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-01-10Resolves: tdf#152948 Do not use GetExcelName() to obtain English function nameEike Rathke
As the function name says, it's the Excel compatibility name and not the Calc UI visible name and thus does not have the _ADD or _EXCEL2003 suffixes. Theoretically the names may even be completely different. Change-Id: I5f52dee77009123ebc3762defe08c937a3a59a18 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145246 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit b5cca905c6f3e090dae6e649381664925474a04a) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145226 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-12-30tdf#152717: ScDdeLink::DataChanged may get OUString directlyMike Kaganski
... after commit 94df17f58fe6269452b7252b712a89978c444bec (tdf#151429: don't convert OUStrings to system encoding, 2022-10-08) Change-Id: Ie9d6eb2a4465a576eefe0840a30636e898fa9028 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144810 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit 37723413115baafdc7d13ad26d11aa5f917c2036) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144813 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-12-21sc: fix null deref in ScInputHandler::InputChangedXisco Fauli
See https://crashreport.libreoffice.org/stats/signature/EditView::ShowCursor(bool,bool,bool) and https://crashreport.libreoffice.org/stats/signature/EditEngine::GetText(LineEnd) Change-Id: Ib1486161c722c213ccc64809010f54e9ab4dc52e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144684 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> (cherry picked from commit 8efbc3e7f667bc1f04db4bcf908df905a1f34e06) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144668
2022-12-21sc: check ScDocShell::GetViewData()Xisco Fauli
ScDocShell: :GetViewData() can return nullptr Change-Id: I39bb2dce1ab233f39b0ec687ed71089b35537f9c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144490 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144579 Reviewed-by: Eike Rathke <erack@redhat.com>
2022-12-20tdf#152082 ODS: fix import of Empty filter operatorTünde Tóth
Bad import of the Empty filter operator resulted shifted filter settings, e.g. selected "A" and "B" instead of "empty" and "A" from the range "empty", "A" and "B". Regression from commit f6b143a57d9bd8f5d7b29febcb4e01ee1eb2ff1d "tdf#142910 sc filter: fix "greater than" or "smaller than" etc". Change-Id: I33082d77fb9e707aa474fb22753a001960341d66 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143776 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org> (cherry picked from commit 1f30f9cf012cee6823029ef5a96a1d91a0e16cdc) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144481 Tested-by: Jenkins
2022-12-19tdf#151152 sc filter: fix string entry checkingTünde Tóth
When a column was filtered for values that included 0, the all string entries were always checked in the Autofilter dropdown (because their conversion to number, i.e. value 0 was used to check their existence in the filtered values instead of their string value). Regression from commit f6b143a57d9bd8f5d7b29febcb4e01ee1eb2ff1d "tdf#142910 sc filter: fix "greater than" or "smaller than" etc". Change-Id: Ib659aba9d6f3d6bc3557547b1a27963f51e3eca3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143777 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org> (cherry picked from commit 2298087db28ee1b4251cac6e12c1d4806b395a1e) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144480 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-12-19tdf#151755 fix export of borders of contentless cellsAttila Szűcs
Change-Id: I650aeebb4d021911c1f14d4867c5beee84020155 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143880 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit c57d113e9ef8608f5690e8707a97879cb4f6a185) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144424 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144459
2022-12-19lok: protect sc from null ScViewData.Michael Meeks
Working hypothesis is this happens after a failed spreadsheet load, or from a race during load. <crash> ScModelObj::getPartInfo(int) sc/source/ui/unoobj/docuno.cxx:602 doc_getPartInfo desktop/source/lib/init.cxx:3531 ... KitSocketPoll::kitPoll(int) coolforkit SvpSalInstance::DoYield(bool, bool) vcl/headless/svpinst.cxx:492 Change-Id: I06870336d4e64ebfc69bce64e280821c25e1b1e1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144308 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com> (cherry picked from commit 39ffd246450cbf5feb68d7f5ab058b92a951066a) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144433 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-12-19check SfxObjectShell::Current()Caolán McNamara
SfxObjectShell::Current() can return null, it's based on the equally vile SfxViewFrame::Current() Change-Id: Ia5c7783680e9d8e5d3075078f16a2c15cb6f7a47 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144355 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144457
2022-12-16sc: fix null deref in ScDocShell::ExecuteXisco Fauli
See https://crashreport.libreoffice.org/stats/signature/ScViewData::GetDispatcher() Change-Id: I3271738b3c7f456adad1309c52195d98646f1acc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144302 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-12-14crashtesting: null deref see on loading forum-mso-en4-531817.xlsxCaolán McNamara
Change-Id: I8fb92edc32cabecd0f1ff5090f1b102e090aa840 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143969 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-12-13crashtesting: use of uninitialized data in forum-mso-en4-93354.xlsCaolán McNamara
Change-Id: I678a22289827e0a9c305ac49f7f046ae2a91184c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143956 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Jenkins
2022-12-12crashtesting: assert seen on loading forum-mso-en4-497867.xlsxCaolán McNamara
Change-Id: Ifa5e2711981097a648d7127d2dc777bc96b04edb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143967 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-12-11tdf#152455: Strings not translatable in paste special dialogJulien Nabet
Change-Id: I0c8834813af22f3de2da1f80a8895d518f66dada Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143908 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit a12cf7902d8139e8a7a9d30dd9a9360a05411b8c) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143926 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-12-08Resolves: tdf#152421 'GTK_IS_LABEL (label)' assertion failureCaolán McNamara
Change-Id: I33d76f4a84d7ef1cd14cb5f2597f38385eff2e2a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143725 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2022-12-08Resolves: tdf#152325 initial "select" may not set the cursor to that posCaolán McNamara
but setting the cursor will 'select' for the default "single" selection mode. Change-Id: Ib7c3dfcce72bad69741b5bc3eb159a6ed3bc8142 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143723 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2022-12-02Related: tdf#46444 tdf#152081 sc: add unit test for note hidingBalazs Varga
Add unit test for column hiding with notes and undo that. Change-Id: I880ca1565dbefea5e8776b0d137da409ce816ac1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143299 Tested-by: Jenkins Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de> (cherry picked from commit c9807faad6a154b57a99adfdf9b02bd9e588250f) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143266 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-11-29tdf#67866 sc,sd: PDF/UA export: set language in CatalogMichael Stahl
sw already does this, and it's recommended in https://www.w3.org/WAI/GL/WCAG20-TECHS/PDF16.html Change-Id: I0ce36442ec1b223c40f53fac3683ad7bb0e2bc6f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143307 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit 0e4ff2261f3c2c9dada5816f11095652e028c3dd) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143435 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-11-28tdf#70293 XLSX export: fix lost grouping of shapesTibor Nagy
SaveDrawingMLObjects() needs to skip all the grouped objects, including subgroups of a group to avoid of broken export. Fixing this and reverting the old workaround commit c323e60157422ae264e798b9a279a532fe9997af "ignore the (unsupported ) group customshape when exporting xlsx", Calc keeps the grouped state of the objects now. Change-Id: Ic320248a1c646d8adb9ce55bb2e5dcd880c1df6f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143142 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143306 Tested-by: Jenkins
2022-11-23tdf#46444 tdf#152081 sc: hide notes in hidden rows or columnsBalazs Varga
Hide notes in hidden rows or columns just like we do in case of other sdrobjects. TODO: unit test Change-Id: Ib136324d5d0dd8777fc0912af6d8b9ac39935ac1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143024 Tested-by: Jenkins Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de> (cherry picked from commit b71303fe1b06c1711ad80e5a0269d41ccaaad8e1) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143070 Reviewed-by: Eike Rathke <erack@redhat.com>
2022-11-17Resolves: tdf#152053 GetOptimalColWidth() obtain number format from next rowEike Rathke
... if 1st or 2nd row doesn't have one applied, i.e. is header. Change-Id: I4b33fa4abcbe74b02d416cfa494c0813a8f0086e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142744 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit 8309f94001ec29faff288cb8f920ee00978bb85a) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142687 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-11-15Resolves: tdf#151947 Merging separators must not scan for field endEike Rathke
Regression introduced with commit cf777cfcb22647b1f2d6ace307fbcc4f6d2cca30 CommitDate: Sun Oct 2 17:07:06 2022 +0200 Resolves: tdf#125110 tdf#151211 Disentangle the convoluted CSV/TSV-clip import a copy-paste replacement logic error. Change-Id: Ibd699a4edfa9f88da26d888afa8567ee34e78a5e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142572 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit 5db9d8356c8fdc732942357cd2171ba27eda8647) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142527 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-11-13Resolves: tdf#152014 When reusing interpreter context slot clear lookup cacheEike Rathke
... if different doc As is, unthreaded the same slot gets reused for every calculation. That could benefit from keeping 2-3 documents cached to not throw away the lookup cache each time when alternating between documents. Change-Id: Id024333f72bcdcd6109042dec1104f3029955d3b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142639 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit f86a0666ac337363b470c9c67fa0970a330b26a2) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142630 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-11-09tdf#124098: sc, ods import: do not recalculate row heightsBalazs Varga
if we have already optimal heights in the xml, because it is not necessary and it takes a lot of time loading a file. Citing here for completeness: a) if there is no height attribute and the "use_optimal-row-height" attribute is set then calculate the row height b) if there is a height attribute just use it and do not recalculate. Maybe TODO for later: optimize row height calculation more in sc Change-Id: I9d964aad744970e5d36f239c0ce39ce98c00f273 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141204 Tested-by: Jenkins Tested-by: Balazs Varga <balazs.varga.extern@allotropia.de> Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de> (cherry picked from commit e8fae4d0fb2994a7b4ac00e9da35e1deccb296dd) (cherry picked from commit b57307e8f3553fcb292c9c11fcf58bcef3a6cb3c) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141317 Reviewed-by: Eike Rathke <erack@redhat.com>
2022-11-09tdf#122188 border colors should be the same regardless of the desktop themeCaolán McNamara
Change-Id: Ifc0297135981b315ce8646e0ca2fe8a899d49f32 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142423 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 2e97f7596c2d933e87391a5648341f885975c51b) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142481
2022-11-09tdf#151610 chart colors should be the same regardless of the desktop themeCaolán McNamara
Change-Id: I47ae80f744401bd13452ec8879cb8f420e35b9ce Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142383 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit f8ad054de38a6592b60ab850e938e6e81ec4cc0d) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142310 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-11-02Resolves: tdf#147141 style:header-first/footer-first only ODF 1.3|1.2-extendedEike Rathke
For ODF 1.2-extended write with loext namespace, for ODF 1.2 and earlier do not write them at all. LO versions <7.2.5 not having the fix for tdf#144940 need ODF 1.2 written (without header-first and footer-first) to not lose the header/footer. Change-Id: Id856459eac487ddd8ba0c6963db5d4e227d82093 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142127 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit 71081a2a79a7b5a1eefec60fc687c533a95d190d) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142140 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-11-01tdf#151484 Data Validity list looses separation when saving as XLSNoel Grandin
regression from commit fbb41798b86c5ed35eb80aa07a5ee7c9866ac4e8 Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Fri Mar 18 09:46:52 2022 +0200 tdf#133603 remove some string copying Change-Id: Ie241a7d5e54673b35c643c7c20dc100ba7925647 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141808 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 9ff56812741029ad17204cff53357751687d9b6c) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141834 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-11-01tdf#148934 PDF/UA export: add Contents entry to Link annotationsMichael Stahl
* Specification: ISO 14289-1:2014, Clause: 7.18.5, Test number: 2 Links shall contain an alternate description via their Contents key as described in ISO 32000-1:2008, 14.9.3. These links are created all over the code, in some cases it's a bit dubious what the content/alt-text should be, but let's try to use the most suitable looking bit of text in whatever the context is. * Specification: ISO 14289-1:2014, Clause: 7.18.3, Test number: 1 Every page on which there is an annotation shall contain in its page dictionary the key Tabs, and its value shall be S. Change-Id: I7b63feb759f0c75047f854ed9997918f829a537e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141826 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit fa3f04bdd4f73a1b3be70dfb709c44638ef7e3d9) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141873 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-10-24Resolves: tdf#140554 Function Wizard, FIXED() second parameter is optionalEike Rathke
Change-Id: I1d559601f0cace4719aa6f8adc4e4230494e905d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141766 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit 633db8a099e3041bc10fb1709311bd6055ab61a2) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141744 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-10-24Resolves: tdf#150780 Overtyping is not editingEike Rathke
Change-Id: Ie83245479e4f356cf120dae1da39d35a9bb1a2e3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141676 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit 9d1d668a608cc5b406601c2f7f3d8581e8f47d1c) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141593 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-10-20CppunitTest_sc_vba_macro_test: Do not test specific file on WindowsXisco Fauli
tb39 fails now with C:/cygwin64/home/tdf/lode/jenkins/workspace/gerrit_windows/sc/qa/extras/vba-macro-test.cxx(605) : error : Assertion Test name: VBAMacroTest::testVba equality assertion failed - Expected: OK - Actual : Test Results ============ Failed: : Test change event for Range.Clear set: Failed: : Test change event for Range.ClearContents set: Failed: : Test change event for Range.Replace: Failed: : Test change event for Range.FillRight: Tests passed: 4 Tests failed: 4 - script reported failure in file Ranges-3.xls Change-Id: If226dfc201f124712abeec422cf79a675d25b9fb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141365 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> (cherry picked from commit a42c8923031522284c3199bed397c9e9639a71b5) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141413
2022-10-13tdf#150664 Initialize input line correctlySamuel Mehrbrodt
Initialize code was not called when xlsx file was loaded (line count is only stored in ods format). Change-Id: I5b01f6079921af77ffd6da09ae5d5388b8beff1c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141281 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de> (cherry picked from commit f13606b613585b5e6611429dc3e699740dfeed5a) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141193 Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2022-10-13improve setup/teardown handling in VBAMacrosTestNoel Grandin
do the same thing that the other UnoApiTest subclasses are doing, seems to fix the problem for me Change-Id: I0d5288b638a5c8d6994fae5ae5d99f2f29bcf377 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141155 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141300
2022-10-13tdf#125363, tdf#123095 - Use CaseTransliteration for autofilterAndreas Heinisch
Change-Id: Ib6f1edebe26a69d3316a901e00d2bc6e0c66695f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141047 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141288
2022-10-13CppunitTest_sc_vba_macro_test: unify the way tests are setup and teardownXisco Fauli
Some tests were using mxComponent and some other tests where using their own xComponent Hopefully this will fix the CppunitTest_sc_vba_macro_test failures on windows Change-Id: I75fa51edf273582057201f50847b2c1a3ed1fcc9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139948 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141299 Tested-by: Jenkins
generated by cgit (git 2.34.1) at 2024-07-03 13:41:42 +0000