summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)Author
2019-04-19sc: Get rid of the Idle hack in the Special Filter Dialog.Jan Holesovsky
The problem is that with LOK, the creation of Idle here causes a deadlock when the dialog is being opened and its first paint is requested. No real idea what change now causes the problem (this used to work), but given that the use of the Idle is a hack in the first place, let's use the GetFocus/LoseFocus handlers instead, and act accordingly only when the focus of the interesting controls changes. Change-Id: Ib6c0267a064cb31438544e47fe3e0869b575ef7c Reviewed-on: https://gerrit.libreoffice.org/70948 Tested-by: Jenkins Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2019-04-19tdf#45904 Move XChartData Java tests to C++Jens Carl
Fix tdf#43309: Move XChartData Java tests to C++ for ScCellRangeObj. Change-Id: I6b57db53fdddab2ff382354d32809404224a2e1e Reviewed-on: https://gerrit.libreoffice.org/70956 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-04-19Further cleanup to not use FSEND and useless string conversionsMike Kaganski
... in XclExpXmlStream::WriteAttributes Change-Id: Ideae6685e7f035970850d86bcaea74c525f1ec81 Reviewed-on: https://gerrit.libreoffice.org/70957 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-18C++11-ify XclExpXmlStream::WriteAttributesMike Kaganski
This gets rid of some macro mess; and also enables passing OUString as attribute values. Change-Id: I25a8af4adabd905e0016c604d6710c9c5d2f889d Reviewed-on: https://gerrit.libreoffice.org/70952 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-18tdf#124822 CRASH: cutting and undoingNoel Grandin
regression from commit 7282014e362a1529a36c88eb308df8ed359c2cfa Date: Fri Feb 1 15:15:16 2019 +0100 tdf#50916 Makes numbers of columns dynamic. Change-Id: I17312ca978a83a431dfaf6edda2c98e6302eb2d1 Reviewed-on: https://gerrit.libreoffice.org/70938 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-18weld ScOptSolverDlgCaolán McNamara
Change-Id: Ie2b43377f950cb16e143f6e9ef7081bf92277088 Reviewed-on: https://gerrit.libreoffice.org/70903 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-18tdf#124818 CRASH selecting all and switching spreadsheetNoel Grandin
regression from commit 7282014e362a1529a36c88eb308df8ed359c2cfa Date: Fri Feb 1 15:15:16 2019 +0100 tdf#50916 Makes numbers of columns dynamic. Change-Id: I033bcae2bdc97c3aae24557c5949c7759041b3bc Reviewed-on: https://gerrit.libreoffice.org/70925 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-18tdf#124815 CRASH: inserting a columnNoel Grandin
regression from commit 7282014e362a1529a36c88eb308df8ed359c2cfa Date: Fri Feb 1 15:15:16 2019 +0100 tdf#50916 Makes numbers of columns dynamic. Change-Id: If82689218344d1fea025d7d6e409dd5ec9e2d3b3 Reviewed-on: https://gerrit.libreoffice.org/70924 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-18tdf#87459 bring back HyperlinkDialog againandreas kainz
Change-Id: I0938894681e73aaadf8bd353185dc4c6a125e0e2 Reviewed-on: https://gerrit.libreoffice.org/70920 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-04-18crashtesting: failure on import of ooo6593-5.stcNoel Grandin
since commit 7282014e362a1529a36c88eb308df8ed359c2cfa Date: Fri Feb 1 15:15:16 2019 +0100 tdf#50916 Makes numbers of columns dynamic Change-Id: I858e61b3a1158bf47b5855e56d63c77cc87aa09b Reviewed-on: https://gerrit.libreoffice.org/70902 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-18crashtesting: failure on export of ooo118068-1.ods to odsNoel Grandin
since commit 7282014e362a1529a36c88eb308df8ed359c2cfa Date: Fri Feb 1 15:15:16 2019 +0100 tdf#50916 Makes numbers of columns dynamic Change-Id: Ib8dc06b80beed81a2543f343483599c425e87369 Reviewed-on: https://gerrit.libreoffice.org/70901 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-17m_mapRefWindow is unneeded nowCaolán McNamara
Change-Id: I68811d64ed340f3b5f86d7c13289455009eea74e Reviewed-on: https://gerrit.libreoffice.org/70890 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-17boil incomprehensible template spew down to its simpler realityCaolán McNamara
Change-Id: I6a428b6515bffb69b6890ddcf8990c2c773b506c Reviewed-on: https://gerrit.libreoffice.org/70889 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-17weld ScTPValidationValue and ScValidationDlgCaolán McNamara
Change-Id: I74b1569fe378f42c1cc78ca8d9b758c6e585c979 Reviewed-on: https://gerrit.libreoffice.org/70845 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-17tdf#124778 View - Comments causes crashNoel Grandin
regression from commit 7282014e362a1529a36c88eb308df8ed359c2cfa Date: Fri Feb 1 15:15:16 2019 +0100 tdf#50916 Makes numbers of columns dynamic. Change-Id: I5ecc52dd709455718a2f3e245b1d41e0c30e7f80 Reviewed-on: https://gerrit.libreoffice.org/70862 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-17tdf#124772: export data field number format to XLSXMike Kaganski
... otherwise Excel would reset data formatting e.g. from currency to plain numbers upon refresh. Excel relies on per-field format setting in pivot tables, while Calc takes fields formatting from source. Change-Id: Ia8cdf3f8fcd23720e3daaf989152c170057b339c Reviewed-on: https://gerrit.libreoffice.org/70860 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-17use DeactivateCaolán McNamara
which is closer to how it was before welding Change-Id: If43e2109d9c511a3e8f191b7704dc42aa06b7353 Reviewed-on: https://gerrit.libreoffice.org/70858 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-17drop newly unused ScFilterOptionsMgrCaolán McNamara
and rename FilterOptionsMgr back to ScFilterOptionsMgr Change-Id: Ieada679e0c96dfdf9d62732550302f3b5f2a444d Reviewed-on: https://gerrit.libreoffice.org/70833 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-17tdf#123645 XLSX export: fix hyperlink inserted to charttundet
Hyperlink inserted to chart lost after export. chart_hyperlink.xlsx: Test file from Excel 2016. Change-Id: Ideca10e544193ba43d7c2ef6e9dd8e393383edc1 Reviewed-on: https://gerrit.libreoffice.org/70648 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2019-04-17loplugin:sequentialassign in scNoel Grandin
Change-Id: I9287d266cd5267e194f2539f95a7efff3824e9b1 Reviewed-on: https://gerrit.libreoffice.org/70715 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-17weld ScSpecialFilterDlgCaolán McNamara
Change-Id: Iecf88c5720f2407654d85a1a70a04faed43fd690 Reviewed-on: https://gerrit.libreoffice.org/70832 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-17tdf#45904 Move XTextField Java tests to C++Jens Carl
Move XTextField Java tests to C++ for ScEditFieldObj_Header (formerly ScHeaderFieldObj). Change-Id: I36b723945d9306720846b4a4e2d3eaddb1a1c063 Reviewed-on: https://gerrit.libreoffice.org/70841 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-04-16weld ScFilterDlgCaolán McNamara
Change-Id: I8bb8860d398af2ee9d6dd434c50f914e78b8021b Reviewed-on: https://gerrit.libreoffice.org/70801 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-16tdf#124736: Sort group field itemsMike Kaganski
Excel expects the group field items to be in ascending order starting from "<01/02/2010", then "Jan", "Feb", ..., then end with ">01/02/2020". Change-Id: I29e9b55f43091ed007f59e10dec64f46a37c7d5f Reviewed-on: https://gerrit.libreoffice.org/70800 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-15tdf#124649 sc menubar: show icons for most importent itemsandreas kainz
Change-Id: I9e31f78a3d2d811088162f9dbac7fc92abf12c19 Reviewed-on: https://gerrit.libreoffice.org/70780 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-04-15Rename ScCellFieldsObj to ScHeaderFieldsObjJens Carl
Correct class name to mirror the name of the object we are testing against. Change-Id: I72f29c765990b1693533de8150bfbededf045925 Reviewed-on: https://gerrit.libreoffice.org/70753 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-04-15tdf#42949 Fix IWYU warnings in include/editeng/[a-e]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I81917d697adf79b1bd0de4cc262d3cd6bc8eb36f Reviewed-on: https://gerrit.libreoffice.org/70710 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-04-15Report failing document in ScMacrosTest::testVbaMike Kaganski
Change-Id: I7ce2e8ab0bdc4b6799cd351828b7b3c24ebb1a96 Reviewed-on: https://gerrit.libreoffice.org/70757 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-15improve loplugin simplifyconstructNoel Grandin
to find stuff like OUString s = OUString("xxx") Change-Id: Ie7ed074c1ae012734c67a2a89c564c1900a4ab04 Reviewed-on: https://gerrit.libreoffice.org/70697 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-15Related: tdf#50916 create valid empty ScHorizontalCellIterator when...Mike Kaganski
completely outside allocated area. Prevents crash in spell checker when scrolling into unallocated area, where first visible column number is greater than maximal allocated column number. The crash happened when std::vector::reserve threw std::length_error, and Scheduler::ProcessTaskScheduling abort()ed catching that in std::exception handler. Change-Id: Id74706f4a5fedfcc5e4e316c7aea7f5a4fe110be Reviewed-on: https://gerrit.libreoffice.org/70756 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-15Remove unnecessary calls to Reference::is() after an UNO_QUERY_THROWJens Carl
Change-Id: I43f7e328b45d0058f867f3296c5a34740d51b4da Reviewed-on: https://gerrit.libreoffice.org/70752 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-04-15tdf#45904 Remove obsolete ScPageObj testsJens Carl
As mentioned i#84653 ScPageObj and ScDrawPageObj are supporting the same service and the later one was convert to C++ with commits ed6a71eafa61bade50219d2ff6233a42ab6d1c17, f897e80d063436be07356049f595efe5afb04859, eb0653ee80ad7249fde9ff752b56316fb98c4592, ee503c36199d225f4c906fe43c927f911c2097c7 and b99ea0ff33b78ba76d1ae436895efac490252e0f. Change-Id: Icb05b2a03893f47e5f3816366cb9f3c94fd6faeb Reviewed-on: https://gerrit.libreoffice.org/70751 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-04-14weld ScConsolidateDlgCaolán McNamara
Change-Id: I7d52aea1917503a37cdc7d1ae16d7d2377397f30 Reviewed-on: https://gerrit.libreoffice.org/70714 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-14tdf#120703 PVS: V581 ifs with identical conditionsMike Kaganski
V581 The conditional expressions of the 'if' statements situated alongside each other are identical. Change-Id: I18562d60e33c7ecff14807976dde4cbcae3f665b Reviewed-on: https://gerrit.libreoffice.org/70731 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-14tdf#120703 PVS: Silence V522 warningsMike Kaganski
V522 There might be dereferencing of a potential null pointer. Change-Id: Ie4bc74a734a6d5a73838a27e0d80cc8e51595839 Reviewed-on: https://gerrit.libreoffice.org/70730 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-13Resolves: tdf#124693 Crash modifying chart data range with mouse selectionCaolán McNamara
Change-Id: I95c621615c197687552147b8328c769fdd47befa Reviewed-on: https://gerrit.libreoffice.org/70711 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-13weld ScTabOpDlgCaolán McNamara
Change-Id: I515c756451539527faff59b67e0a8d1ee64c1347 Reviewed-on: https://gerrit.libreoffice.org/70686 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-13use more std::make_uniqueNoel Grandin
Change-Id: I7d85cbc9105c5e0c4a8d9a69c4ac9d6dfc07eabd Reviewed-on: https://gerrit.libreoffice.org/70663 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-13Fix typoAndrea Gelmini
Change-Id: I2a73e84c9292dabeb5129b4261bb08c959b6b3e4 Reviewed-on: https://gerrit.libreoffice.org/70691 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-04-12loplugin:unusedfieldsNoel Grandin
Change-Id: I321c8eefdc43979ef5fd3774c7094ac0dbcac417 Reviewed-on: https://gerrit.libreoffice.org/70657 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-12tdf#113908: Implement exporting pivot tables' groups fields to XSLXMike Kaganski
Two tests in sc/qa/unit/pivottable_filters_test.cxx were extended to also test round-trip of group fields in XLSX. Change-Id: I70b7c15b09040c64fa1da2f88001af7ba16f2c6f Reviewed-on: https://gerrit.libreoffice.org/69653 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-12rename ScRangeManagerTable back to RangeManagerTableCaolán McNamara
Change-Id: Ie9dec478c38c484d47720e488427d797269f228f Reviewed-on: https://gerrit.libreoffice.org/70664 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-12Resolves: tdf#124613 stray .05 at end of GtkAdjustment lower valueCaolán McNamara
Change-Id: If42b676c3321d73455771b6ea62aefb806caccd2 Reviewed-on: https://gerrit.libreoffice.org/70661 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-12weld ScSolverDlgCaolán McNamara
Change-Id: I35fa2f63eb47f18289892ffcf042d041752bfbd7 Reviewed-on: https://gerrit.libreoffice.org/70653 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-12weld ScColRowNameRangesDlgCaolán McNamara
Change-Id: I976fb892f8ac1dedb0c2c3110dce17c1211de238 Reviewed-on: https://gerrit.libreoffice.org/70652 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-12loplugin:unusedmethodsNoel Grandin
Change-Id: Ie90e53583484ee4f378ec92634adf3be7cd9ecbb Reviewed-on: https://gerrit.libreoffice.org/70650 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-12crashtesting: failure on import of tdf90694-1.otsCaolán McNamara
since... commit 7282014e362a1529a36c88eb308df8ed359c2cfa Date: Fri Feb 1 15:15:16 2019 +0100 tdf#50916 Makes numbers of columns dynamic Change-Id: I7a624f391c85f9c7af07f951c9da3914460b7526 Reviewed-on: https://gerrit.libreoffice.org/70602 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-12weld ScPrintAreasDlgCaolán McNamara
Change-Id: I1e1d31551b623453a1bade9c932ef1c9e1060f35 Reviewed-on: https://gerrit.libreoffice.org/70600 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-12crashtesting: failure on import of gnome545630-1.xlsxCaolán McNamara
since... commit 7282014e362a1529a36c88eb308df8ed359c2cfa Date: Fri Feb 1 15:15:16 2019 +0100 tdf#50916 Makes numbers of columns dynamic Change-Id: Ib42b770282753350b9c4016fe7c9f57f68e6c209 Reviewed-on: https://gerrit.libreoffice.org/70603 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-12tdf#117276 sc: autofilter was unexpected reset with OK pressedSerge Krot
Change-Id: I53331434bb4d5e2f13e9f2ab5b768e9880aecca8 Reviewed-on: https://gerrit.libreoffice.org/68765 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
generated by cgit (git 2.34.1) at 2024-08-07 20:09:53 +0000