summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)Author
2019-04-27tdf#42949 Fix IWYU warnings in include/svx/[a-D]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I9770343f31f882427c9ae13e363b59cd1fb47e98 Reviewed-on: https://gerrit.libreoffice.org/71295 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-27Fix variable nameAndrea Gelmini
Change-Id: I2628e74f0db7275091db2df2d271080367448b28 Reviewed-on: https://gerrit.libreoffice.org/71420 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-27tdf#124997: only skip parsing non-empty cells for unallocated columnsMike Kaganski
Otherwise, not-yet-allocated columns have STD_COL_WIDTH (1280), while normal columns have widths like 82 (pixel), making the oversized grid look as if the columns not having vertical lines at all. Also, we need to consider default attrubutes here, to properly render cell properties like borders and background for unallocated columns. Regression after commit 7282014e362a1529a36c88eb308df8ed359c2cfa Change-Id: Ibb37c0c621d009bda2c5c0176cf5d3b238c45964 Reviewed-on: https://gerrit.libreoffice.org/71408 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-27weld cluster of change tracking dialogsCaolán McNamara
Change-Id: I42ca7acb41699df91b91a9f59fc68cd30972a397 Reviewed-on: https://gerrit.libreoffice.org/70988 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-27uitest for bug tdf#124816Zdeněk Crhonek
Change-Id: I658e7eb6eef88a23f3e86acd616d26c3fe793a82 Reviewed-on: https://gerrit.libreoffice.org/71393 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2019-04-27uitest for bug tdf#124822Zdeněk Crhonek
Change-Id: Ia856b58c868e49ce2b293e95fd9503f1296bdcab Reviewed-on: https://gerrit.libreoffice.org/71392 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2019-04-27tdf#85482 FILEOPEN: very slow loading of .ODSNoel Grandin
On my machine, this takes the loading from 21s to 8s. We can delay doing line height calculation till after load, since we run the calculation over all rows after load Change-Id: I5c0d02297fb10bada28105a82da10c498ce8f6cf Reviewed-on: https://gerrit.libreoffice.org/71378 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-26Fix typosAndrea Gelmini
Change-Id: I693355a38f5bea33346d988015851d3a9cf8d1d4 Reviewed-on: https://gerrit.libreoffice.org/71387 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-26Fix typoAndrea Gelmini
Change-Id: Ib1b8341776ed79c85cd1f8287c06a9fe8ed8ca3d Reviewed-on: https://gerrit.libreoffice.org/71389 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-26remove unnecessary separate function objectsNoel Grandin
which just makes the code harder to read Change-Id: Id9269554b4e29a2562cbdd06f42a143c2f028795 Reviewed-on: https://gerrit.libreoffice.org/71360 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-26tdf#119650 slow saving spreadsheet with comments, part 2Noel Grandin
Reduce the number of items we set items/itemsets on the caption, which reduces the number of times editeng does text layout. Takes time from 151s to 78s Change-Id: Iecfb123768fd8f87ffe162b35fe6bcd6b56b8700 Reviewed-on: https://gerrit.libreoffice.org/71359 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-26ScPatternAttr needs to be a complete type here (Windows --disable-pch)Stephan Bergmann
Change-Id: Iafbdd3b7e872cd15718879e5c7f1256069156d5f Reviewed-on: https://gerrit.libreoffice.org/71343 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-04-26flatten ScPostIt::CreateCaptionFromInitDataNoel Grandin
Change-Id: I109fd4a9f58f604852622e3dca87e1beadcad858 Reviewed-on: https://gerrit.libreoffice.org/71303 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-26Related tdf#43309 Enable testJens Carl
Enable test sc.ScCellRangeObj::com::sun::star::chart::XChartData as of commit eb7a731bcfbacec15b77889f0ac545d36ef5ad19 the test is ported to C++ and discussed with sberg in https://bugs.documentfoundation.org/show_bug.cgi?id=43309#c7. Change-Id: I2652122bd61f7586d6afa190eaece8edf938e28d Reviewed-on: https://gerrit.libreoffice.org/71335 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-04-26Fix typosAndrea Gelmini
Change-Id: I81d85cb8ae8b0075929beb01e8991d895b94d0c4 Reviewed-on: https://gerrit.libreoffice.org/71314 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2019-04-25Cut down on -pthread/-lpthread proliferationStephan Bergmann
Building against libstdc++ effectively always requires -pthread anyway (as various standard C++ headers require it, see the comment added to solenv/gbuild/platform/unxgcc.mk), so many explicit uses of -pthread/-lpthread can be removed. Doing a (partial) test build on Linux with Clang -stdlib=libc++ suggests that libc++ indeed doesn't need -pthread as libstdc++ does. The remaining uses of -pthread/-lpthread are mostly in configure.ac for the various BSDs (which somebody else might want to clean up now), and related to external projects. I tried to be careful to remove -pthread/-lpthread from makefiles only when C++ object files are involved (so -pthread will now be included on the link command line by default). Change-Id: I936e082839cb9a434bd273ce5a1f187a4245dfa1 Reviewed-on: https://gerrit.libreoffice.org/71291 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-04-25tdf#50916: XLS: make sure to set default widths to all columnsMike Kaganski
See https://lists.freedesktop.org/archives/libreoffice/2019-April/082479.html Ths partially reverts commit 1463625ae26900d2461fd72a5a2c894b9f1b8726 Change-Id: I36ec01c8d331d879143f60e12dc239158a8822ec Reviewed-on: https://gerrit.libreoffice.org/71301 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-25WIP: Further preparations for deeper Item changesArmin Le Grand
(1) Migrated all still existing binary load/save stuff in SfxPoolItem to legacy files. Isolated from Item implementations. Adapted all usages. No more methods Create/Store needed, also GetVersion removed (2) Removed operator= for SfxPoolItem. Adapted all usages. Goal ist to handle Items more as Objects ('Object-Oriented') in the sense to move/handle instances, not to copy one instance over another one (which is more and more problematic with hard to copy content as UNO API stuff or similar). This lead to much more usages of std::shared_ptr which correlates well with future plans fr Items (see dev branch). Next logic step will be to also remove copy constructor Linux build and corrections done Fixed Writer test and removed unused defines Fixed another unused m,acro Started to unify the AutoFormat stuff Changes to OUString constructor usages, tests completely No idea why, but SfxStringItem constructor which takes a OUString& now insists of not getting ::OUString's handed in - changed all 'SfxStringItem.*OUString.*".*"' accordingly Change-Id: Ibed7358b18fb019994a7490332b9d797a6694c29 Reviewed-on: https://gerrit.libreoffice.org/71075 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2019-04-25Re-arrange the conditions to avoid the dynamic_castXisco Fauli
Similar to 88be8aa14d52ad102dc6b01c1c962d4e6cac4941 Change-Id: Ia6f725fd6c6cee3135191a998ea43c1e6f90fc23 Reviewed-on: https://gerrit.libreoffice.org/71287 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-04-25calc: extra unittest for rows autoheight on loadVasily Melenchuk
Change-Id: Ie5310d3c3d4fde59a0718dbda228c638b7e0c366 Reviewed-on: https://gerrit.libreoffice.org/71235 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-04-25tdf#124572 TabBar new look, protected icon, width and heightTomaž Vajngerl
This is the first try of a new TabBar look - borders have been removed, selected tab doesn't change the font to bold, adjustment to the selected tab line. Width and height of a tab item has been adjusted to make it better to fit the icons in and to not be so cramped. Draw "protected" status of an tab icon (in Calc) as an icon and not as a unicode glyph. Change-Id: If2ee930a573343166fbe9efcd94ae5159a620f22 Reviewed-on: https://gerrit.libreoffice.org/71238 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-04-25tdf67629 FILEOPEN Particular .xlsx hangs SpreadsheetNoel Grandin
Seems like this is a somewhat pathological document, has lots of duplicated ranges. Checking for duplicates makes it load in <10s on my machine Change-Id: I25da24e0f8b1d4ad99d00474be168c75586ea579 Reviewed-on: https://gerrit.libreoffice.org/71251 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-25tdf#45904 Move TableColumn Java tests to C++Jens Carl
Move TableColumn Java tests to C++ for ScTableColumnObj. Change-Id: I3f17fa1f25c2676124b56c384364e36736fac849 Reviewed-on: https://gerrit.libreoffice.org/71261 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-04-24simplify condition (remove always true part)Mike Kaganski
Change-Id: If846bb08ec6eceb307228bc628a4b186a3058051 Reviewed-on: https://gerrit.libreoffice.org/71230 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-24simplify call sites of SfxItemPool::PutNoel Grandin
use template to make return type match input type, so we don't need to cast at the call sites Change-Id: I1e65f362c67f74c9a230cdbc1db12545b28eb499 Reviewed-on: https://gerrit.libreoffice.org/71216 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-24tdf#124896 CRASH: deleting sheetNoel Grandin
regression from commit 7282014e362a1529a36c88eb308df8ed359c2cfa Date: Fri Feb 1 15:15:16 2019 +0100 tdf#50916 Makes numbers of columns dynamic. Change-Id: I3913e14cadc11efa1d9e7405cdbaf96fe094508a Reviewed-on: https://gerrit.libreoffice.org/71220 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-24tdf#124741: export default column width to XLSXMike Kaganski
For some reason, we have never exported the default column width to XLSX, although we have such export for XLS. This led to bugs like tdf#100946. Workarounds applied to those bugs have made LO to export columns which shouldn't have been exported, abusing "customWidth" attribute in XclExpColinfo::XclExpColinfo depending on if the column has size different from an app-global default; after that, sheet-local default was determined, and then columns which have mbCustomWidth set (i.e., different from app default), as well as those different from sheet-local default, were stored. Effectively, the hack had disabled the removal of defaults from maColInfos in XclExpColinfoBuffer::Finalize. We even had unit tests explicitly testing that we export those columns that Excel skips. The effect of that is not only unnecessary data in the file; the data was actually wrong (customWidth actually means that the width was edited manually by user, even if equal to the default, thus changing Excel handling of the column); and also Calc initializes all columns to the right of last used column for such a file. Only in case when app-global default happened to match sheet-local one, columns would have properties allowing them to be removed from maColInfos in the end of XclExpColinfoBuffer::Finalize, which still resulted in problems similar to the workarounded one. This patch implements proper export of the default column width to XLSX, thus partially reverting changes made for tdf#100946 in commit 40d892a2db4d750aaf0562c63004e693c028273c. Actually, our export to XLSX does not depend on the 5-pixel correction (see ECMA-376-1:2016 18.3.1.81), since the exported default depends only on most-used column width. XclExpDefcolwidth implementation was edited to only take the correction into account when exporting to XLS (to keep status quo; it's clear that XLS widths export and import implementation is incorrect: some empirical formula is used in XclTools::GetXclDefColWidthCorrection, that was introduced in commit 555d702903fb0857122024e1ab78a72d122d3f16 for i#3006, that doesn't match any documentation, and changes widths of columns in exported XLS - something to be fixed independently). Change-Id: I227aca17e56247cbb839444717066a898987c4f1 Reviewed-on: https://gerrit.libreoffice.org/71132 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-24tdf#81765 slow loading of .ods with >1000 of conditional formats, part 4Noel Grandin
This takes the loading time from 13s to 10.5s Avoid expensive text-invalidation while we are loading Change-Id: Ia74b84575fbf635b5ab5618c74ea2efc9f6ad827 Reviewed-on: https://gerrit.libreoffice.org/71043 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-23Skip clipboard queries while the document is still loadingKatarina Behrens
Use-case here is .ods document with 16k tracked changes. For every tracked change, Calc generates a formula cell. For every formula cell, clipboard content is queried (via ScDocument::IsClipboardSource, ScModule::GetClipDoc respectively). This is dog-slow on Windows Therefore don't query clipboard content while the document is in the process of being loaded. Instead return from ScDocument:: IsClipboardSource early and return 'false' because at this point of time it can't be reliably determined whether this doc is a clipboard source anyway Change-Id: If5aa62cbfb62fb326a3c73b4d9be839127d3c03b Reviewed-on: https://gerrit.libreoffice.org/71121 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-04-23fix bad comparison in StrCmp/StrLessNoel Grandin
comment from Miklos: > Won't this do a comparison of two null-terminated strings, while > the strings here are utf16, i.e. abc is a\0b\0c\0? That would mean > in practice you compare the first char only. introduced in commit 003d11f410b7e515981b3efbd65d936d94d87121 Date: Sat Apr 20 08:32:33 2019 +0200 tdf#81765 slow loading of .ods with >1000 of conditional formats Change-Id: I60ea18772753f50f880c65d8cff594267d724e76 Reviewed-on: https://gerrit.libreoffice.org/71114 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-23multiple concatted AcceptChgDat stored in configCaolán McNamara
FillInfo is called more often than Initialize, so we've ended up with multiple AcceptChgDat strings Change-Id: I99e9398757d63e2c6315ec9c3101910d5978b13b Reviewed-on: https://gerrit.libreoffice.org/71119 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-23tdf#113266 slow opening XLS with 45 MB drawingNoel Grandin
Some hot-spots around dynamic_cast of SdrHint, so avoid that by creating special SfxHintId::ThisIsAnSdrHint The most common CPU hot-spot was in SvxShape::Notify, the other changes are just for consistency. Also remove some dead code in ScShapeChildren, the Notify method was doing nothing useful. Change-Id: I696db1fcafc09bb10bf23ac673de292746141491 Reviewed-on: https://gerrit.libreoffice.org/71108 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-23tdf#42949 Fix IWYU warnings in include/editeng/[f-x]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ic14d2e66434817bcb7bd1e2b707f81d720d596b6 Reviewed-on: https://gerrit.libreoffice.org/71007 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-04-23Fix typos in codeAndrea Gelmini
Change-Id: I5a39d89ad33d447f952d6c4c32923d387c47fd06 Reviewed-on: https://gerrit.libreoffice.org/71083 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-22uitest for bug tdf#120660Zdeněk Crhonek
Change-Id: I73845626b9cc2872f3a38b6e6b13e05dde174113 Reviewed-on: https://gerrit.libreoffice.org/71076 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2019-04-22tdf#124883: don't drop data field names on importMike Kaganski
The name attribute of dataField element was already read in PivotTable::importDataField; and then it was ignored in PivotTableField::convertDataField. ScDataPilotFieldObj had no handler for name in its ScDataPilotFieldObj::[gs]etPropertyValue, although it has [gs]etName for that - so this change puts pieces together to allow to use the imported name correctly. Change-Id: I5357601b26e6635ab132ff6a1294645995aff97e Reviewed-on: https://gerrit.libreoffice.org/71068 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-22crashtesting: failure on export of ooo40197-1.sxc to xlsxCaolán McNamara
Change-Id: I8e3122045fbf22d4ec0b6960d6268bb5f429f600 Reviewed-on: https://gerrit.libreoffice.org/71042 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-22tdf#124881: Provide a non-empty name for pivot table's data fieldMike Kaganski
Otherwise, the empty string is used by Excel, so the field arrives unnamed, disappearing from pivot table's cells upon refresh, etc. Change-Id: I2e0f9fad2d766829f2b06425bec24ff182e3a869 Reviewed-on: https://gerrit.libreoffice.org/71065 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-22Simplify parameter pack handling: use if constexpr to drop extra functionMike Kaganski
Change-Id: I09b7c4b90d28dc69c9788c645e057762af586879 Reviewed-on: https://gerrit.libreoffice.org/71063 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-21bug tdf#120697Gagandeep Singh
add drop down containing formulas in autosum button in calc Change-Id: I1da8116ba2f6073bec153979282161fbaa286427 Reviewed-on: https://gerrit.libreoffice.org/70058 Tested-by: Jenkins Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2019-04-21tdf#81765 slow loading of .ods with >1000 of conditional formats, part 3Noel Grandin
This takes the loading time from 14s to 13s Use a o3tl::sorted_vector to reduce searching time Change-Id: I947a3e5001fe1058cf9bffc9509d026af4122ef4 Reviewed-on: https://gerrit.libreoffice.org/71035 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-21tdf#45904 Move XPropertySet Java tests to C++Jens Carl
Move XPropertySet Java tests to C++ for ScTableColumnObj. Change-Id: Id77c4162acfe849993e7ffa392e9428b4f52bdd0 Reviewed-on: https://gerrit.libreoffice.org/71034 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-04-21tdf#45904 Move XNamed Java tests to C++Jens Carl
Move XNamed Java tests to C++ for ScTableColumnObj. Change-Id: I6037db86d917a5a64f19dc799d80e175e971b90d Reviewed-on: https://gerrit.libreoffice.org/71033 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-04-21tdf#81765 slow loading of .ods with >1000 of conditional formats, part 2Noel Grandin
This takes the loading time from 15s to 14s. Reduce unnecessary allocation/copying by passing down ownership of the newly created ScPatternAttr to the item pool Change-Id: Iec38bbff572d10ff8d86f5e65fbe9a96b6a5a706 Reviewed-on: https://gerrit.libreoffice.org/71010 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-20tdf#45904 Move XCellRange Java test to C++Jens Carl
mOve XCellRange Java test to C++ for ScTableColumnObj. Change-Id: I165e5752fb679be6790c305a99f35da644e17d56 Reviewed-on: https://gerrit.libreoffice.org/70968 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-04-20tdf#81765 slow loading of .ods with >1000 of conditional formatsNoel Grandin
This takes the loaing time from 1m38 to 15s. Speed up finding existing pool items in the pool by storing a sorted_vector, sorted by a compare operator on the item. memcmp is faster than operator< on std::vector because operator< seems to be trying to use some kind of lexicographical compare Change-Id: Id72527106d604adb8cd2d158bb42f89e2b16a85d Reviewed-on: https://gerrit.libreoffice.org/71009 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-20simplify SfxPoolItemArray_Impl (tdf#81765 related)Noel Grandin
Since we want to look up items by pointer, just store them in a std::unordered_set, which allows fast find(). This dramatically simplifies most operations on this data structure. Fix a dodgy sd test that was relying on items with the same whichid being in the pool being in a certain order. Change-Id: I4d79fc718f95e3083a20788be1050fbe9fca7263 Reviewed-on: https://gerrit.libreoffice.org/70881 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-20Fix typoAndrea Gelmini
Change-Id: Ib61a8a14923864757ed83e3914bcb4ac1aae6a22 Reviewed-on: https://gerrit.libreoffice.org/70991 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-20tdf#124810: Roundtrip pivot table style info from XLSX.Mike Kaganski
Also provide a default pivot table style for those tables that don't have a style info. Let's use the style settings that Excel uses. Change-Id: I8006a33a0aa0e92629f7db0a9c24a6ff52d17945 Reviewed-on: https://gerrit.libreoffice.org/70933 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-19Further cleanup of FastSerializerHelper's startElement/singleElement[NS]Mike Kaganski
Drop FSEND_t: C-style varargs code was replaced since version 6.0 in commit d43fc40718217d89cc95cc3c0bc0b8e7926abcc0, so it's time to remove the last bits. Drop int-to-string macros that are simple wrappers over OString::number. Avoid unnecessary string type conversions. Change-Id: I86478577b8e469f99b5a90619e5f78a61f4f23fb Reviewed-on: https://gerrit.libreoffice.org/70964 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
generated by cgit (git 2.34.1) at 2024-08-05 02:32:41 +0000