summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)Author
2017-10-23loplugin:includeform: scStephan Bergmann
Change-Id: I2ed763e0584a188032c80fde60890de3c6985cbd
2017-10-23We still have to build and run on 32-bitEike Rathke
Change-Id: Id8840b001beae7de72beace5c0c14f0d304ce1fc
2017-10-23tdf#96505 Get rid of cargo cult long integer literalsudareechk
Removed 0L, 1L and 2L Change-Id: Icb38de1cdd8e1215a86118b0c8af993025fd790e Reviewed-on: https://gerrit.libreoffice.org/42567 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2017-10-23Assume 6GB memory could be consumed by matricesEike Rathke
... if SC_MAX_MATRIX_ELEMENTS is not set. Change-Id: I27100d5fc75e2d5288892c54997147854de781e7
2017-10-23Move GetElementsMax() to .cxxEike Rathke
Nothing else is using it so we don't need it in .hxx Change-Id: I0df879a7be2c56a70c30f50f44a92bb527b5a9ed
2017-10-23Simplify some includesStephan Bergmann
...where the relevant path is already found via -I settings Change-Id: I9cb13b7b648ff2b1983a8b80d5047c4d9da9f515
2017-10-23ofz: cluster of oom with multiple large ScMatrixCaolán McNamara
Change-Id: I39b628ad2014f69d88c1a32d0dbd2a4c4d8c695e Reviewed-on: https://gerrit.libreoffice.org/43576 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-10-23Translate German function names in Calc (financial)Johnny_M
The affected parts of names of functions correspond to German function names in Calc and were translated to their English equivalents. For used translations, see, e.g., https://translations.documentfoundation.org/de/libo54_help/translate/#search=GDA&sfields=target&soptions=exact,case Note: The translation here is equal to the translation of variables done on https://gerrit.libreoffice.org/43078 , etc. Change-Id: If3043a9a10366dbf11269d72708404e350d58166 Reviewed-on: https://gerrit.libreoffice.org/43691 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-10-23ofz: avoid configCaolán McNamara
Change-Id: I1fa1c2cb9c755822c2a80453ac3f0424f2c91ffe
2017-10-23overload std::hash for OUString and OStringNoel Grandin
no need to explicitly specify it anymore Change-Id: I6ad9259cce77201fdd75152533f5151aae83e9ec Reviewed-on: https://gerrit.libreoffice.org/43567 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-22sc lok: fix spell checking languages in CalcHenry Castro
Change-Id: Iadcc3b55a30ce2a2c785366fb3807ff6e4bda1fe Reviewed-on: https://gerrit.libreoffice.org/43581 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Henry Castro <hcastro@collabora.com>
2017-10-21coverity#1401307 document checked 'Uncaught exception'Caolán McNamara
markup std::unique_ptr where coverity warns a dtor might throw exceptions which won't throw in practice, or where std::terminate is an acceptable response if they do Change-Id: Icc99cdecf8d8b011e599574f0a05b59efd1c65c2 Reviewed-on: https://gerrit.libreoffice.org/41561 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-10-20Disable CppunitTset_sc_*_functions_test for linux_aarch64 for now, tooStephan Bergmann
> Oct 20 10:21:31 <sberg> erAck, when "Testing > file:///run/build/libreoffice/sc/qa/unit/data/functions/array/fods/linest.fods" > in CppunitTest_sc_array_functions_test fails with non-informative expected 1 > vs. actual 0, how can I reasonably debug that? (and no, I don't have an X11 > connection to the relevant machine, to see what opening that .fods with LO > would look like there) > Oct 20 10:25:04 <erAck> sberg: sigh.. we're still lacking an "analyze steps" > in the functions test loader, so far only loading the doc and inspecting > provides that; maybe getting individual cell results via UNO would work So disable these tests for aarch64 for now too, to get Flathub builds unstuck, until somebody finds a way to actually debug this. Change-Id: I9bf30d0d7185497f9ad4b04b60b6a67f34a8c44e
2017-10-20tdf#112100 Select shape name in NavigatorTamas Bunth
After the selection of a shape the shape name is selected in the Navigator tab under the Drawing Objects entry. It scrolls to the corresponding entry as well in case the scrollbar is visible. Change-Id: I298e8fe6bdab01eb20c53e1730812192c46770c5 Reviewed-on: https://gerrit.libreoffice.org/43566 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2017-10-19tdf#113211: fix calculations with big integersMike Kaganski
... and munbers with few fractional bits Change-Id: I86c3e8021e803fed498fae768ded9c9e5337c8bd Reviewed-on: https://gerrit.libreoffice.org/43477 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-10-19Resolves: tdf#113179 merge language attributes early, tdf#108795 follow-upEike Rathke
Merging attributes from table to top EditEngine has to be done before colorizing with the range finder, as the resulting merged default item set *overwrites* the items set. Change-Id: I6561201de11344161f61d7d4cf6a7b79d76ba493
2017-10-19tdf#113268: Pivot table: Missing popup button after opening a ODSTamás Zolnai
Wrong row number was calculated here. This ++nCurRow is usefull only when headerlayout flag is set. It's a MSO compatibility flag so it's not there by default in LO created tables. Change-Id: Id7989d898f2647f1ba45ed95e0aa615e3b4fa311 Reviewed-on: https://gerrit.libreoffice.org/43552 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-10-19It's a simple assignmentTamás Zolnai
Change-Id: I7b85a5ce93685013c28c9cb8047093fe7403da53 Reviewed-on: https://gerrit.libreoffice.org/43553 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-10-19tdf#113159: Pivot table: tabular mode is converted to oultine modeTamás Zolnai
... after RT XLSX in Calc Change-Id: I9725ca55aed973133db1d5fe47463575148e00b8 Reviewed-on: https://gerrit.libreoffice.org/43537 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-10-19Fix assertion to check the right thingTor Lillqvist
We want to assert that the token separator character is not one of the quote pair characters. Change-Id: Ic6114238f4a45a4f1ed7d255e7e9da3519479148
2017-10-19dyncolcontainer: convert nRight to std::vectorNoel Grandin
Change-Id: Ie1c081250b22d80ece3c8f5a21e9728c14d7bdb1 Reviewed-on: https://gerrit.libreoffice.org/43516 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-18use rtl::Reference in sc/../uno/*Noel Grandin
instead of manual reference counting Change-Id: I60798316f2b63800a9f539cb719305c00d91ecc5 Reviewed-on: https://gerrit.libreoffice.org/43491 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-18svx: remove pointless duplicate SdrFitToSizeTypeMichael Stahl
Change-Id: I7a59ecfdb8d09ecbc0b760003dbc453ac5646d1c
2017-10-18add CVE-2017-0199 test-casesCaolán McNamara
Change-Id: I562c16a1dfcf4d8ba6b893da71ae557c4811ac24 Reviewed-on: https://gerrit.libreoffice.org/43480 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-10-18dyncolcontainer: convert aColWidthPath to std::mapNoel Grandin
Change-Id: Ifb86372de3671b81c0438c0096b375b07d2f6754 Reviewed-on: https://gerrit.libreoffice.org/43468 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-18dyncolcontainer: use std::map in DifAttrCacheNoel Grandin
Change-Id: Ic3280c5548555ceeb722788dc0a90f8898f46c2e Reviewed-on: https://gerrit.libreoffice.org/43467 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-17turn implicit container explicit in buildable notebooksCaolán McNamara
as in interim measure for SfxTabDialogs we throw away the TabPage if its not suitable for reuse Change-Id: Ic5776ca3d2a8cb6bf41f33df01b211f81c62a842 Reviewed-on: https://gerrit.libreoffice.org/43134 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-10-17remove unused ScCompressedArray constructorNoel Grandin
Change-Id: Ida4d8abe50885d10288169024b597fa946d1c26b Reviewed-on: https://gerrit.libreoffice.org/43438 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-17Simplify ScCompressedArray constructorNoel Grandin
nobody is setting a custom delta Change-Id: I5dd9ac691fb226697eb8cb2b6b0b673552a4f049 Reviewed-on: https://gerrit.libreoffice.org/43437 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-17use rtl::Reference in ScAddInListenerNoel Grandin
instead of manual ref counting Change-Id: I04bdb5b34921da9ab08a55a95b99ff1635a9cda6 Reviewed-on: https://gerrit.libreoffice.org/43420 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-17dyncolcontainer: use ScBitMaskCompressedArray for pColFlagsNoel Grandin
Change-Id: I5df10fe7477e05424eb5e8a3544073a264568aac Reviewed-on: https://gerrit.libreoffice.org/43409 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-17dyncolcontainer: use ScCompressedArray for pColWidthNoel Grandin
and enhance ScCompressedArray with an iterator to avoid O(n^2) "for" loops. Change-Id: I7d8fda8306b0a5c73bf373b3991e1c07271bc9d9 Reviewed-on: https://gerrit.libreoffice.org/43387 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-16Translate German variable names in Calc (financial)Johnny_M
These names of variables correspond to German function names in Calc and were translated to their English equivalents. For used translations, see, e.g., https://translations.documentfoundation.org/de/libo54_help/translate/#search=GDA&sfields=target&soptions=exact,case Change-Id: I58be84b37e045ac15bcdf15032def7591be53de7 Reviewed-on: https://gerrit.libreoffice.org/43078 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-10-16use rtl::Reference for SvXMLGraphicHelperNoel Grandin
Change-Id: I0052b29660fb6157f7e98c4e124f030ba439d304 Reviewed-on: https://gerrit.libreoffice.org/43417 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-16tdf#105853 improve layout Options > Calc > Formula ... separatorCor Nouws
thanks Olivier for help with mastering Glade ;) Change-Id: If2e2381168a98d5b04c28d6625800d03b0c5e868 Reviewed-on: https://gerrit.libreoffice.org/43352 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2017-10-14ofz#3634: add a SC_MAX_MATRIX_ELEMENTS to limit max matrix elementsCaolán McNamara
Change-Id: Ib2b1a36d56cc8ac63cf28a18fa20ad2f075dcf21 Reviewed-on: https://gerrit.libreoffice.org/43394 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-10-14implement new more user friendly data provider dlgMarkus Mohrhard
This is still a work in progress. Change-Id: I1e68c86acc810eec068b1f184b2307c51d9b58df Reviewed-on: https://gerrit.libreoffice.org/43259 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-10-13derive size of tab bar in Calc from TabFont (in pixels).Bernhard Widl
Change-Id: I3a35850cb6a66b06ae6568b54c008669ee2f391a Reviewed-on: https://gerrit.libreoffice.org/43328 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-10-13Replace lists by vectors in chart2uno (sc)Julien Nabet
+ remove useless 'using ::std::list' in externalrefmgr (sc) Change-Id: Iacff73fafe5a048b47abea865a77645a960e1a0d Reviewed-on: https://gerrit.libreoffice.org/43355 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-10-12Translate German variable names in Calc (financial)Johnny_M
These names of variables correspond to German function names in Calc and were translated to their English equivalents. For used translations, see, e.g., https://translations.documentfoundation.org/de/libo54_help/translate/#search=RMZ&sfields=target&soptions=exact,case Note: This is an alignment of the function declaration to the definitions in /core/sc/source/core/tool/interpr2.cxx, some of which were translated on f8b9b8ec5686c1453e335d895aa78faba5fdf268, while others were already in English. Change-Id: Ifb01992e42af707a08a02139ffb8313d3b92701c Reviewed-on: https://gerrit.libreoffice.org/43077 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-10-12adapt dataprovider to the requirements of the new UIMarkus Mohrhard
Change-Id: If10a68a27591f3195ef85c21ea98324903819b36 Reviewed-on: https://gerrit.libreoffice.org/43256 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-10-11Replace list by vector "DataPilotSort" from dbfunc3 (sc)Julien Nabet
Change-Id: Ib8754d7e459d1019ed2d5f49ce593e20af0b7f0c Reviewed-on: https://gerrit.libreoffice.org/43315 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-10-10use std::swap instead of own implementationMarkus Mohrhard
Change-Id: Iabc0eee868a2ad5623a1ac39b26bb2bc5981e829 Reviewed-on: https://gerrit.libreoffice.org/43249 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-10-09sc, implement HAVE_FEATURE_AVMEDIAjan Iversen
iOS does not support avmedia, therefore HAVE_FEATURE_AVMEDIA is set, however not all sources test for it. Change-Id: I627d1a45420d4af093c57bc53d716d48bf3a4b00
2017-10-09update notebookbar to add ExportDirectToPDF and ExportDirectToEPUBandreas kainz
Change-Id: I6b161cc7d5e56b1a6507d6a513f1d3d70e8671c9 Reviewed-on: https://gerrit.libreoffice.org/43271 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2017-10-09tdf#45904: Move _XAreaLinks Java to C++Jens Carl
This allows to re-activate the test and fixes #i84701. Change-Id: Ifd295e9521a04e88a68aa96fad8f9e8e32f927fa Reviewed-on: https://gerrit.libreoffice.org/41855 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-10-09make sure to include all relevant header filesMarkus Mohrhard
Change-Id: I313d3a7dce5143ad8703e8ef8c2d066e652a4483 Reviewed-on: https://gerrit.libreoffice.org/43248 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-10-09prevent crash in the new dataprovider UI when adding a new columnMarkus Mohrhard
Change-Id: I3f87d2dac75662ab1da6049579d33d6b39e1da0c Reviewed-on: https://gerrit.libreoffice.org/43257 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-10-09document how formulas are stored in the cacheMarkus Mohrhard
Change-Id: I1a4f8dd16bb739eb84087e596278fbd4cdc8db7c Reviewed-on: https://gerrit.libreoffice.org/43255 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-10-09document a few method parametersMarkus Mohrhard
Change-Id: I08273d2a84c335e5eb9998e41a67b3b7340f348d Reviewed-on: https://gerrit.libreoffice.org/43250 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>