summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)Author
2015-10-21boost::ptr_vector -> std::vectorNoel Grandin
no need to store uno::Reference on the heap Change-Id: Iec3abe2190648e85a37b22763c8d19ba29634373
2015-10-21remove untyped Link<>Noel Grandin
Change-Id: I809f9e10309ceadda0a82c3818277323b34ec61b Reviewed-on: https://gerrit.libreoffice.org/19491 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-20Avoid some confusing uses of "document name" instead of "document URL"Stephan Bergmann
Change-Id: I88258d3aaa2a18315a5a38ea01e77bdfd4bc1a84
2015-10-20adapt comments to realityEike Rathke
Change-Id: Idfeca4a683ebb9616c19a42de650c4871f733ef5
2015-10-20Resolves: tdf#84713 do not substitute separator in R1C1 notation hyperlinksEike Rathke
During import, in hyperlinks all Sheet!xxx were converted to Sheet.xxx to fit CalcA1 notation, but in this case Sheet!R1C1 was used and Sheet.R1C1 is not a valid address notation, so the hyperlink didn't work. Do not attempt to convert R1C1 notation, the hyperlink handler does handle all known notations. On Excel export, handle that the separator can be both, '.' and '!'. Change-Id: I8428b2240912f42fd6789d249c90982127ee7c01
2015-10-20loplugin:defaultparamsStephan Bergmann
Change-Id: If189c1e4254ae00725ec76a5ca6354d24df2d351
2015-10-20tdf#89694 Password dialog for opening OOXML shows url-encoded pathTomofumi Yagi
We need to convert a path string to decoded it for OOXML with a password as ODF is so. This patch adds the converting process for OOXML. In addition, this patch moves the decoded-point of URL into css.task.Document[MS]PasswordRequest ctor from the outside. This decoded-point of URL into ctor is common for OOXML and ODF. (notes: Strange to say, css.task.Document[MS]PasswordRequest ctor needs "aDocURL", but methods in interaction-handler use "aDocumentName" as the parameter. Probably this will be fixed in near future.) Change-Id: I0ecfddf0f70ea5810df52d9ca8637f483a26df2f Reviewed-on: https://gerrit.libreoffice.org/14677 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2015-10-19loplugin:defaultparamsStephan Bergmann
Change-Id: I9bfa7be4a8035d6dfbd0bd13505ba13c3d085455
2015-10-19tdf#94908 : Autofilter ok button is blockedDennis Francis
Change-Id: I0a1ad60cb6eea26899604641f981642943b06347 Reviewed-on: https://gerrit.libreoffice.org/19375 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2015-10-19Seems that people prefer this to be CPPUNIT_ASSERT() instead of assert()Tor Lillqvist
My thinking was that there is a slight difference in meaning; that assert() checks that the code (or, in this case, data) in the test *itself* is as expected while CPPUNIT_ASSERT() checks that the functionality *somewhere else* works as expected. But whatever. Change-Id: I93f7f8cf2b3aac9e8fc35baf2dcbad1a4003773f
2015-10-19convert remaing DBG_WARNING to SAL_INFONoel Grandin
and drop the macro Change-Id: I452ca373d0c277166e94928c1bce78bf37e39d7c
2015-10-19cleanup some local var declarationsNoel Grandin
found with git grep -nP '(\w+)\s+=\s+\g1\(' | lots-of-hand-filtering Change-Id: I598b0cfa6607823eaef09d95e610e05145c727f7
2015-10-19cppcheck:nullPointerRedundantCheckNoel Grandin
second time lucky Change-Id: I1ff8c750f5845180a0bcd23ac5017e8cd0331409
2015-10-19remove unused header fileNoel Grandin
Change-Id: Icfd6c9a23d6d6f4f8b4ee8462134a3b08573fe50
2015-10-19convert Link<> to typedNoel Grandin
Change-Id: I04987cc8c3eab52a7191d75cf0a9cde9049bfbd4
2015-10-19Revert "cppcheck:duplInheritedMember"Noel Grandin
This reverts commit a55496a9e88ac3da821b0ae0d334866d669540c6.
2015-10-19cppcheck:duplInheritedMemberNoel Grandin
Change-Id: Ie525330eb79a80fd47a6bfe46343aa25ae0aeb5c Reviewed-on: https://gerrit.libreoffice.org/19419 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-18tdf#94924: If we can't handle strings, don't try to thenTor Lillqvist
Fixes the VLOOKUP problem reported in tdf#94540 by falling back to non-OpenCL for such a case, where one of the columns passed to the VLOOKUP contained strings. And since a while, we don't claim to handle strings in VLOOKUP. Which is true. Change-Id: I4140c86bf8166beb8201aa90c075d9f4432d9173
2015-10-17ignore "current document" values at module level, tdf#92256 follow-upEike Rathke
Change-Id: I3540ccce9bee652f838efc86dc9abc6fc2416819
2015-10-16tdf#92256, c#19: Implement "current doc only" switchKatarina Behrens
that'll save calculation settings into current document only, not into global user profile Change-Id: I50ab31b679f712ff512f85a2cd58319d356462ea Reviewed-on: https://gerrit.libreoffice.org/19318 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2015-10-16tdf#39468 translated german comments in tabvwsh9.cxxAlbert Thuswaldner
Change-Id: Iaab7081df2f15e7228f7f99184a048abd26decc7 Reviewed-on: https://gerrit.libreoffice.org/19307 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2015-10-16tdf#39468 translated german comments in tabvwsh3.cxxAlbert Thuswaldner
Change-Id: I483c1aafe68da805ce194968153f1e6506327c51 Reviewed-on: https://gerrit.libreoffice.org/19300 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2015-10-16tdf#39468 translated german comments in tabvwsh8.cxxAlbert Thuswaldner
Change-Id: Iae5d5138e8a030bb6beb0ec646949892b96e2a63 Reviewed-on: https://gerrit.libreoffice.org/19301 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2015-10-16use rtl::toAsciiUpperCase() instead of home baked lcl_toupper()Eike Rathke
Change-Id: I73dcf0d9f7741409c4dbf1c75f2d7f43649889bb
2015-10-16don not use libc toupper() because it might yield unexpected resultsEike Rathke
Change-Id: I6202d14b78d153e74b973f1f9fa523ad92f507a7
2015-10-16sfx items: Kill the unreadable & misplaced SFX_ITEMSET_ARG too.Jan Holesovsky
Change-Id: I1e0f96dce2b9cf9da32f4f577cf76e1d8824d37a
2015-10-16sfx items: Kill the unreadable SFX_REQUEST_ARG, use a template param instead.Jan Holesovsky
Change-Id: I7130f7a84077a63cdc0ca1e131a4d90469eac90d
2015-10-16sfx items: The bDeep parameter of SFX_REQUEST_ARG is always false.Jan Holesovsky
Change-Id: I6d4f4cd09c83f94b26dd90577bdc6bc3226f58ab
2015-10-16sfx items: The bDeep parameter of SFX_ITEMSET_ARG is always false.Jan Holesovsky
Change-Id: Ifdffc82c9b4ec2e534204294575a78e34e0338c1
2015-10-16convert Link<> to typedNoel Grandin
Change-Id: Icbba339dac0be31e30dff021bba06a219f8aecd6 Reviewed-on: https://gerrit.libreoffice.org/19405 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-16unit tests for formula error propagation, tdf#94869 relatedEike Rathke
Change-Id: Ia80de96f40d0abe391a530f74ef2b17a1dc2baae
2015-10-16Resolves: tdf#94869 propagate error from scalar double to matrixEike Rathke
Minimal invasive fix for the problem, further work on error propagation in array/matrix cases may be needed. Change-Id: Ia6a7fe8138b98b78ffbe89572eb51ab8e9c0fdca
2015-10-15add test for tdf#88179Markus Mohrhard
Change-Id: I8407a05e89129b533f62439d3ffedecd3248ec87
2015-10-15store external range names in the cache, td#88179Markus Mohrhard
Change-Id: I00b41f9b1fc2aec6f66c613cc02328b2968dca8d
2015-10-15WaE: variable set but not used, in NDEBUG buildTor Lillqvist
Change-Id: I9c88c1a43228a98a355d8ba17b0a06de0c5418c4
2015-10-15tdf#94924: Fix thinko from bdef079b39d273d2985d360a52597672c96b43fcTor Lillqvist
Change-Id: Iadeb311c364324d26acab8a856358e0a5c5673dc
2015-10-15tdf#94924: Add a more systematic OpenCL unit testTor Lillqvist
Avoid the horrible convention of hard-coding in a C++ unit test code addresses of data in the spreadsheet document being tested. Instead, mark the expected (= as calculated by Excel) and calculated (by LibreOffice) formula results, rectangular blocks of data, so that the C++ code can easily find it, and then compare. This is much more flexible. No need to edit hardoded row and column numbers in the C++ code when adding more test data. The systematic.xls file has documentation on how to maintain it. Change-Id: I4fb088fe21831dd3b3213d21916460a708aa0842
2015-10-15tdf#94924: Return correct result 0 from OpenCL MIN and MAX when all args emptyTor Lillqvist
Used the same style as existing code, added a new virtual isMinOrMax() and add some special casing in Reduction::GenSlidingWindowFunction(), and fsim_count() and fmax_count() functions that count how many non-NaN numbers we actually see. As such, I am not sure at all that this is an ideal way to do this, but will have to do for now. Change-Id: I846a8d24f4563f8fae1a45971a4ce202ed918487
2015-10-15tdf#94924: Return correct #DIV/0! error from AVERAGE in the OpenCL caseTor Lillqvist
Change-Id: If7326fd1242d90ff92e62d141714960476198605
2015-10-15tdf#94924: Fix handling of empty cells in OpenCL divisionTor Lillqvist
Not sure why the code from f5e7207053b857b6903a0ab9c161bed9ad7bcee9 did not produce correct results any longer. Anyway, now OpenCL division works right in case of empty or zero cells. Clearly I need to add unit tests to make sure this stuff keeps working. In later commits. Change-Id: I93b787ad5da453af1601768308fb614a332ed142
2015-10-15tdf#94924: Fix handling of empty cells in OpenCL subtractionTor Lillqvist
We get correct result by simplifying the code;) No need to have the outer "if (gid0 < X)" test around the calculation code generated by Reduction::GenSlidingWindowFunction(). The lhs and rhs check the gid0 range themselves and that leads to the desired result for subtraction. While fixing this I noticed that the handling of empty cells in division is also wrong. Will fix in another commit. Change-Id: Ia45bd81e692a17b0453cc79cd4673a00e119562a
2015-10-15tdf#93044 - fix silly calc copy/paste lifecycle issue.Michael Meeks
Change-Id: Ic3d26f45251ff27bacd572f0cb7a7aadf091e808
2015-10-15calling IsSet() before Call() on Link<> is unnecessaryNoel Grandin
the Call() already does a check Found with: git grep -A 1 -w 'IsSet()' | grep -B 1 '.Call(' | grep ':' | cut -d ':' -f 1 Change-Id: Ia7248f5d62640b75f705e539c3d1183e39c0d847
2015-10-15convert Link<> to typedNoel Grandin
Change-Id: I6c55c74d47b13149c2fa210bb9de4e8c430c57cc
2015-10-14tdf#93318 reintroduce first/last button in Calc tab barTomaž Vajngerl
Seems that first/last button are still useful when there are a lot of tabs. Using ctrl+click is not discoverable enough for the users so for now bring the buttons back. Also turn on enabling/disabling buttons when they have some effect (this was turned off for Calc for unknown reasons). Change-Id: I6bbb04d44066ebc6b89fe3d941ecafdbb378284a
2015-10-14Improve performance by using the ScCalcOptions for OpenCL.Michael Meeks
Use the new configurationlistener to track the relevant setting. Change-Id: I9decea55df25f7eb34cd2fef94743d1907360d16 Reviewed-on: https://gerrit.libreoffice.org/19377 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2015-10-14java:remove unused importsNoel Grandin
Change-Id: I9529bf81dcfcd6761485af5d66789c1a9a83eeec
2015-10-14coverity#1326130 Logically dead codeCaolán McNamara
Change-Id: I77453452183c0f3cb9b3a03c37142264d49a7d3a
2015-10-14LOK: include part numbers in CALLBACK_SEARCH_RESULT_SELECTION payloadMiklos Vajna
Without that, the result in Calc/Impress is ambiguous. Change-Id: I8dfd8dafc996102ed583688fddd721c7600dc48c
2015-10-14unit test for tdf#94514Eike Rathke
Change-Id: I36f3eb19c096b838969ddd5ff10470f2c2e2f18f