summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)Author
2017-03-03Remove redundant 'inline' keywordStephan Bergmann
...from function definitions occurring within class definitions. Done with a rewriting Clang plugin (to be pushed later). Change-Id: I9c6f2818a57ccdb361548895a7743107cbacdff8 Reviewed-on: https://gerrit.libreoffice.org/34874 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-03-03tdf#42982 improve error reporting in sc unoobjAlex P
Change-Id: I35a4142f4f1bdaa4ebb5c5c0f1d4e7201301ee8d Reviewed-on: https://gerrit.libreoffice.org/34762 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-03-03tdf#95612: Print preview: page numbering starts with 1 (not 0)Katarina Behrens
unless otherwise specified. It was okay for 1st page & broken everywhere else. Possibly resolves tdf#95206 as well ... Change-Id: Ie69f770a28dd69f90d4f04ad4fa9e701fa2d56e2 Reviewed-on: https://gerrit.libreoffice.org/34759 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-03-03drop SvxNumType and rename SvxExtNumType->SvxNumTypeNoel Grandin
Both of them are abstractions over the css::style::NumberingType constants. SvxNumType serves no useful purpose, since it's just a typedef to sal_Int16. At least SvxExtNumType wraps up the css::style::NumberingType constants in a nice enum. Change-Id: I7b3f97cd42b0aa23aff7a4db4930da86149d4f4e Reviewed-on: https://gerrit.libreoffice.org/34816 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-03remove unused CreateDefault methodsNoel Grandin
Change-Id: Ifbdd7d41f0938e9a03693f88416792ff8087f8c2 Reviewed-on: https://gerrit.libreoffice.org/34850 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-03tdf#90856 Hide "Format Area" command for line objects in CalcGulsah Kose
Change-Id: If9e4828f5f0073fba126f9e017a596034efd6348 Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/34834 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Tested-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-03-03LOK: Calc: autocomplete makes view to jump to a different placeMarco Cecchetti
We disable auto-complete feature as a workaround. Change-Id: I25fa7591231836e0673e97fdf2c3ca72ab20e1e4 Reviewed-on: https://gerrit.libreoffice.org/34835 Reviewed-by: Marco Cecchetti <mrcekets@gmail.com> Tested-by: Marco Cecchetti <mrcekets@gmail.com> (cherry picked from commit 917aac7aa689dc7279ee492e7102d33a9030d929) Reviewed-on: https://gerrit.libreoffice.org/34836 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2017-03-03Fix typosAndrea Gelmini
Change-Id: Iedca07be5300c68e180e0c71d2d6eb0052f5cced Reviewed-on: https://gerrit.libreoffice.org/34801 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-03Remove uses of SAL_CONSTEXPR in LIBO_INTERNAL_ONLYStephan Bergmann
Change-Id: I9a7dc7c83302b3361f056fcf6636bbba7672f15f Reviewed-on: https://gerrit.libreoffice.org/34840 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-03-03convert SfxEnumItem to type-safe template classNoel Grandin
and drop the SvxChartTextOrientItem class, unused. Change-Id: I99100837d1beb953450f57b2cda47d165df1620c Reviewed-on: https://gerrit.libreoffice.org/34747 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-02tdf#60874 Set custom HID for Protect Document windowGabor Kelemen
The window has its own help page but the SfxPasswordDialog has a default help page as well. We need to use custom help IDs here. The Password entry already has a custom HID however it is used on the default help page of SfxPasswordDialog. We need to set a custom help ID for the Confirm entry and use it in the scalc/01/06060200.xhp file like the one belonging to the Password entry. Change-Id: I9344c85cf362a1829202664315f8c8be0a265b59 Reviewed-on: https://gerrit.libreoffice.org/34501 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-03-02Tests for "Precision as shown" following tdf#105657 tdf#106052Laurent Balland-Poirier
I was unabled to add these test svl/qa/unit/svl.cxx because they required ScDocument::RoundValueAsShown() Found that other formats are not supported by "Precision as shown" option: - engineering tdf#106252 - thousand tdf#106253 Change-Id: Iaf98c404cabec0f5c69f94f2bf863351487fe9d7 Reviewed-on: https://gerrit.libreoffice.org/34750 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-03-02tdf#104117 set template parameter sal_Int64 for randomTomaž Vajngerl
Change-Id: Ie8cef4375608df160b383ff74c32838f00e60aba Reviewed-on: https://gerrit.libreoffice.org/34777 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2017-03-02use std::vector::insert when inserting multiple of the same thingNoel Grandin
instead of looping Change-Id: I7b8c1663e303449302e0b96dc5b483367c2a52ba
2017-03-02add test for own basic functionZdeněk Crhonek
Change-Id: I9c42195c7338300964e111e2a3fbc8d61cac6186 Reviewed-on: https://gerrit.libreoffice.org/34770 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2017-03-01add T.INV test caseZdeněk Crhonek
Change-Id: I0cdd009a444c0c2363d74b9b09ddd8c09c906acb Reviewed-on: https://gerrit.libreoffice.org/34734 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2017-03-01typesafe wrappers for css::i18nutil::TransliterationModulesNoel Grandin
and related css::util::SearchOptions2 The TransliterationModules enum has it's constants spread over multiple UNO enum/constant-collections - TransliterationModules and TransliterationModulesExtra, which means that most code simply uses sal_Int32. Wrap them up into a better bundle so that only the lowest layer needs to deal directly with the UNO constants. Change-Id: I1edeab79fcc7817a4a97c933ef84ab7015bb849b Reviewed-on: https://gerrit.libreoffice.org/34582 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-28in decRefAndDestroy() the remaining element must be one and only oneEike Rathke
So head can be destroyed already there and removeFromList() take a short cut. Change-Id: I8f53d252c4e0ad867674ee410ecfaa300ac0c731
2017-02-28dissolve() needs to delete head now that it's not a list element anymoreEike Rathke
Change-Id: I9949a1006e6d1b4b50dd5350106ad69b643e833c
2017-02-28assert that nullptr captions are not in a listEike Rathke
Change-Id: I0c286891454d290ec4373dbc37e31d65c22c746d
2017-02-28new loplugin unoanyNoel Grandin
Change-Id: I5d6c4a67cb2a09e7cd5bd620c6b262d188701b89 Reviewed-on: https://gerrit.libreoffice.org/34714 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-28tdf#48140 Replace CellRangeAddress with ScRangeBartosz Kosiorek
Change-Id: I5aa1dabf938e1567d386fceb153e2986862f70a6 Reviewed-on: https://gerrit.libreoffice.org/34707 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-02-27move assign() into operator=() and add the relevant bits to copy-ctorEike Rathke
Change-Id: Iac606a8e5e4fc9beb019d95d2a05f0ab9d9dad34
2017-02-27rework ScCaptionPtr to have a distinct head elementEike Rathke
Not only saves a pointer per list element, but future versions could hold a document pointer and/or drawing layer's draw page as well. Change-Id: I85e05981239223bec88c47f2ebe4c22e50cd9a0d
2017-02-27sc: make tabview3 more readableTomaž Vajngerl
- add some curly-braces - join consecutive if statements - declare variables inside for statement Change-Id: I369452cdd684f71a7bd30b5dc072831b982ee1b3 Reviewed-on: https://gerrit.libreoffice.org/34686 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2017-02-27uitest: move all the conditional format tests into an own testMarkus Mohrhard
Change-Id: I5673341b05c8352bc1d46f1483c265ccdc6a1cc5 Reviewed-on: https://gerrit.libreoffice.org/34667 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-02-25add TINV test caseZdeněk Crhonek
Change-Id: Ic9b8398d935e32e529252f55fb09fac5e800e578 Reviewed-on: https://gerrit.libreoffice.org/34647 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2017-02-25add CHISQ.DIST.RT T.DIST.RT testcaseZdeněk Crhonek
Change-Id: I146e08bbe6984db0fba9e5da93db8ce8d0ef5826 Reviewed-on: https://gerrit.libreoffice.org/34630 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2017-02-25add CHISQ.TEST,CHISQDIST,CHISQINV,CHITEST,SEARCH test caseZdeněk Crhonek
Change-Id: Ib0fcb9756049bc741b21fb608e1985c1f7c6e7d6 Reviewed-on: https://gerrit.libreoffice.org/34631 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2017-02-25xPoolHelper is empty in a clipboard docMarkus Mohrhard
Found by the crashreporter: http://crashreport.libreoffice.org/stats/signature/ScDocument::IsClipboardSource() Change-Id: I3fb030921b653396deb46a9e98d30d5df9c9ce15
2017-02-24tdf#50916 Allow dynamically increase number of columns according to needsBartosz Kosiorek
Change-Id: I08b1d70b6aafb01738bb5dec3f4eafd7b21e6bb5 Reviewed-on: https://gerrit.libreoffice.org/33724 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2017-02-24adapt comment to realityEike Rathke
The code now does what the original questioning comment suggested. Change-Id: I359c99a30d2e6822fe9164bb9f903876095c9f6f
2017-02-24grml.. and do that rightEike Rathke
Change-Id: I71bc423bde1f7df576175120741c8a08100b08dd
2017-02-24replace a leftover OSL_DEBUG_LEVEL >1Eike Rathke
Change-Id: Ic5e5e72a2c79e68752c3108de9f3722fbcb8e7b3
2017-02-24vector::data seems more natural than &vector::frontCaolán McNamara
Change-Id: I0ce48075ad186cf1f9bd3e13fa76269fa9819af1
2017-02-24correct descriptionEike Rathke
Change-Id: I830e81985243e7a552716ede163466bf7adfcd9a
2017-02-24a first stab against the note caption ownership messEike Rathke
This should not change any existing behavior, but may help tracking down what happens where and when. The final goal is to let ScCaptionPtr also handle deletion of caption objects once they're unreferenced and guard against dangling pointers and double delete, and/or to manage transfer of ownership to the drawing layer. Further improvement to the structure could involve a head data element so that the duplicated (and unused except in head) mnRefs field could be eliminated and the walk simplified when removing an element from the list. Change-Id: Ifbb2fb1d9dc4d2594a1eae2a8489270dd1fe0d0c Reviewed-on: https://gerrit.libreoffice.org/34616 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-02-24maybe try ROUNDSIG(...,9) ...?Eike Rathke
Change-Id: Ib72c2776c54f905f369be756a4a14a25c3149616 Reviewed-on: https://gerrit.libreoffice.org/34615 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-02-24Remove SC_DPOUT_MAXLEVELS limit in PivotJulien Nabet
by using vectors instead of fixed arrays Change-Id: I4bd070e05ccc464c80722ffd05e70b7acac17d5f Reviewed-on: https://gerrit.libreoffice.org/34408 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2017-02-23let's try if using the new ROUNDSIG(...,12) helpsEike Rathke
... against sporadic tinderbox failures. Change-Id: I54dab5665575802b5fe9051d215399c3554e8fd8 Reviewed-on: https://gerrit.libreoffice.org/34578 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-02-23All ScAxisPosition values that meAxisPosition can take on are coveredStephan Bergmann
...so all of pInfo's members are initialized, so no need to first zero- initialize it Change-Id: I9cc7a0cc038aec59dca4121d16164843483737fc
2017-02-22less ugly ClosingClipboardSource()Eike Rathke
Change-Id: Ie53837e4dd5f779255eac25e090b23e49c3786ce
2017-02-22lok: these are not always plain asciiPranav Kant
Change-Id: I9783b6b2839805189015dbad8a97128c89e0a4a9
2017-02-22use std::unique_ptrCaolán McNamara
Change-Id: I11a58aa38f931c7912e2e5ac6df46f98e6bb681e Reviewed-on: https://gerrit.libreoffice.org/34539 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-02-22Revert "Fix typos"jan iversen
This reverts commit ffd7f8fcfc2b551509e9cb31c0920e0f64292ea7. Caused some problems, need to be broken down. Change-Id: Iee816a266c32e7cebe623d36300c13d079e77c52 Reviewed-on: https://gerrit.libreoffice.org/34534 Reviewed-by: jan iversen <jani@libreoffice.org> Tested-by: jan iversen <jani@libreoffice.org>
2017-02-22Fix typosAndrea Gelmini
Change-Id: I61764094dd6f8e13f29ca554373d30d1d5def447 Reviewed-on: https://gerrit.libreoffice.org/34476 Reviewed-by: jan iversen <jani@libreoffice.org> Tested-by: jan iversen <jani@libreoffice.org>
2017-02-21do not test for different caption pointers ...Eike Rathke
... if it's not guaranteed they may not be identical. Change-Id: Ieb4b0eb07a1b1832df65dde3c2e5a92b5121a162
2017-02-21this should be GetOrCreateCaption()Eike Rathke
... as the caption object has to be created after the note was pasted from a clipboard where the caption was forgotten.. Change-Id: I9b04f0146a7609ac44973dc181fa2ab6b11295b9
2017-02-21tdf#105772 apply all ODFF constraints with function SEARCH.Winfried Donkers
Now the function both complies with ODFF1.2 and behaves the same as Excel does. Change-Id: Ic49af48cacedbac54688266a916c5fa6e28bb5c4 Reviewed-on: https://gerrit.libreoffice.org/34037 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-02-21tdf#105885 fix incorrect result with CHISQ.DIST.RT.Winfried Donkers
With X-argument < 0 Excel returns an error; Calc now does too. Change-Id: I58a84436b2418bef824b6494c2cc5737932cc936 Reviewed-on: https://gerrit.libreoffice.org/34098 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>