summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)Author
2021-11-17ofz: Segv on unknown addressCaolán McNamara
Change-Id: I6c69375a89781fc0b87230203335c861efb562f9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113518 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 8de38977838d5a044271cb170730e3d557659f17)
2021-11-17ofz#29234 Integer-overflowCaolán McNamara
sc/source/core/tool/interpr1.cxx:9578:39: runtime error: signed integer overflow: 1 + 2147483647 cannot be represented in type 'int' Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108677 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 52de00024e84c063ab292890256cda59fe259ef5) Change-Id: I2975ae1daab826f10f0e52e7d7421ac8dcc9fffc
2021-03-16tdf#139804 Focus form controls inside document with Alt-<Mnemonic>Samuel Mehrbrodt
Change-Id: I710a23a53ca0eb256a477a78ce1b7ae01129f717 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111865 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de> (cherry picked from commit 67ad205404211a2ae17c430a17ede6e9d04d0b7e) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112555 Tested-by: Thorsten Behrens <thorsten.behrens@allotropia.de> Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2021-01-25Don't use uninitialized memory when reading from the stream failsStephan Bergmann
Flathub arm builds (but not other arches) had often (but not always) failed when processing sc/qa/unit/data/qpro/pass/ofz14090-1.wb2 in CppunitTest_sc_filters_test (e.g., <https://flathub.org/builds/#/builders/1/builds/724>: > Test name: ScFiltersTest::testCVEs > equality assertion failed > - Expected: 1 > - Actual : 0 > - file:///run/build/libreoffice/sc/qa/unit/data/qpro/pass/ofz14090-1.wb2 ) Valgrind revealed that this was due to using unintialized memory when the various maIn.Read... in QProToSc::Convert failed, starting with the use of uninitialized nFmla[i] after maIn.ReadUChar( nFmla[i] ); At least make things deterministic by setting the relevant variables to zero. (Another approach could be returning early with some ConvErr status.) Change-Id: I4c06aa8da5f777170cdc7bbe3ca1d61b23d3f326 Reviewed-on: https://gerrit.libreoffice.org/80947 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit 2704b9e3783aae9d8372f2e3ad3253a2cb49ae87)
2021-01-21Bring uno:RefreshView to CalcSamuel Mehrbrodt
Allow refreshing the document layout via UNO slot Change-Id: I956bb884b1fb4231b1f617c4aa5a80ff9a45ec92 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109269 Tested-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de> Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2020-09-12Check range before accessing Calc sort userlistThorsten Behrens
Change-Id: I74df0bc6db978e06e8014ac1bc0d76a66c7f4fe8
2020-06-04Cut down on -pthread/-lpthread proliferationStephan Bergmann
Building against libstdc++ effectively always requires -pthread anyway (as various standard C++ headers require it, see the comment added to solenv/gbuild/platform/unxgcc.mk), so many explicit uses of -pthread/-lpthread can be removed. Doing a (partial) test build on Linux with Clang -stdlib=libc++ suggests that libc++ indeed doesn't need -pthread as libstdc++ does. The remaining uses of -pthread/-lpthread are mostly in configure.ac for the various BSDs (which somebody else might want to clean up now), and related to external projects. I tried to be careful to remove -pthread/-lpthread from makefiles only when C++ object files are involved (so -pthread will now be included on the link command line by default). Reviewed-on: https://gerrit.libreoffice.org/71291 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit b1141fa61073b3f24e1a3574afa55a954e5a153d) Change-Id: I936e082839cb9a434bd273ce5a1f187a4245dfa1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95130 Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-02-04tdf#125440 When inserting TSV, consider quotes as field markersSamuel Mehrbrodt
The problem is that this is "plain text" from the clipboard format, but actually contains TSV (tab separated values). So treat them accordingly, so that each value gets its own cell. Change-Id: I0029e6ace90fc542c3269dd82bb7531654157a69 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87950 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-11-22If a SdrOle2Obj object is missing/broken show the preview set for itCaolán McNamara
if the object isn't valid, e.g. link to something that doesn't exist, set the fallback graphic as mxGraphic so SdrOle2Obj::GetGraphic will show the fallback, otherwise the failing mxObjRef.is test in SdrOle2Obj::GetGraphic means it doesn't get used Reviewed-on: https://gerrit.libreoffice.org/83329 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de> (cherry picked from commit 35300000346902db38f063b4427a07fdaf6240cd) Change-Id: I8f1aea6b25dc216e01a0f888a44d10876bb1bebd
2019-11-20warn on load when a document binds an event to a macroCaolán McNamara
a) treat shared/Scripts equivalently to document scripts This doesn't automatically warn/block running those scripts when used in a freshly loaded document on its own however because DocumentMacroMode::checkMacrosOnLoading will see at... if ( m_xData->m_rDocumentAccess.documentStorageHasMacros() || hasMacroLibrary() ) that the document contains no macros and flip the allow macros flag to true so that potentially new uses of macros added by the user during the edit are allowed to run b) so, add an additional flag to indicate existence of use of macros in a document c) for odf import, set it when a script:event-listener tag is encountered d) for html import when registerScriptEvents or SwFormatINetFormat::SetMacroTable is called e) for doc import when Read_F_Macro or StoreMacroCmds is called as well for good measure f) for xls import when registerScriptEvent or ScMacroInfo::SetMacro is called g) for oox import when VbaProject::attachMacros is called Reviewed-on: https://gerrit.libreoffice.org/77387 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> (cherry picked from commit 35fe064a67b54b0680b4845477c9b8751edda160) Change-Id: Ic1203d8ec7dfc217aa217135033ae9db2888e19b
2019-10-01Resolves: tdf#126928 allow link updates in an intermediate linked documentEike Rathke
... if link updates are allowed in the current document and that intermediate document resides in a trusted location. This works with both, the "Always (from trusted locations)" and the "On request" settings under Tools -> Options -> Calc -> General. It can't work with documents residing in a non-trusted location as there is no way to allow updates on demand for a such loaded document (hidden via formulas). Reviewed-on: https://gerrit.libreoffice.org/77588 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit 54bf84746a2a9a2e2aaf0df9e429b0cfd538f640) Reviewed-on: https://gerrit.libreoffice.org/77604 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> (cherry picked from commit 14825a8b7f00ee4c148f2583856e5102312cabbd) Change-Id: Ie483f7743db7c6d5cf947dc16a9c3660855f3423
2019-08-13tdf#123293 sfx2: fix metadata loss when loading from streamMichael Stahl
The problem is that when loading from a stream, there is no BaseURL and also no storage for the document. Due to the lack of BaseURL, the sfx2::createBaseURI() throws and loading RDF metadata fails, which also pops up an annoying warning dialog. Try to handle this in a similar way than a newly created document (see GetDMA()), by using the vnd.sun.star.tdoc scheme URL for the document; this however currently requires that the document has a XStorage, which is also not the case here. So add another UNO method to tdoc UCP's tdoc_ucp::ContentProvider, to split out the creation of the tdoc schema URL from the creation of the ucb Content, to get rid of the XStorage requirement. Change-Id: Ica62743f9d21db0b1464b70db1a62ebc61989ef8 Reviewed-on: https://gerrit.libreoffice.org/67882 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> (cherry picked from commit 0a5ca5768f56db481dd3b947b3dddaab7ed96450) Reviewed-on: https://gerrit.libreoffice.org/69101 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit 98b99ef61c6d725962cdbaa05ff90c9d1aa72d57) Reviewed-on: https://gerrit.libreoffice.org/75963 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-07-29Postpone loading of all external references, including INDIRECT()Eike Rathke
... which can be constructed with an arbitrary URI text string not an svExternal* token type, until link updates are allowed. Reviewed-on: https://gerrit.libreoffice.org/75422 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit b824b23860b2cf533d4f2428d4a750bd72576181) Reviewed-on: https://gerrit.libreoffice.org/76304 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Change-Id: I2ce4de415ff99ace04c083c36c1383d76a4ef40d
2019-07-29Postpone filter detection until link update is allowedMike Kaganski
Change-Id: I85b2185e550f2a133ceb485241ef513b40593e34 Reviewed-on: https://gerrit.libreoffice.org/75301 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit 03c708bf085f91480c014d7fa31e7a317b2c7b8f) Reviewed-on: https://gerrit.libreoffice.org/76303 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-06-17Remove Help menu donate entry for LTS versionThorsten Behrens
Change-Id: I78db5b1989dee9ab10d670f26d08237335ffcc29
2019-04-08Related tdf#124329 Handle shapes resizing with the cellSamuel Mehrbrodt
The same as shapes just anchored to the cell. Change-Id: I0ce03e4c650dd10bd89cee87aa26775c32703d06 Reviewed-on: https://gerrit.libreoffice.org/70065 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> (cherry picked from commit e587645f551c6c684f9f36606f8fa5e1b06004a1) Reviewed-on: https://gerrit.libreoffice.org/70402 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-04-03tdf#121103 ANOVA sum of squares formula correctionJaromir Wysoglad
The ANOVA sum of squares is now hardcoded to use '$Sheet?' in the source cell addless every time. Change-Id: I215b719be11ecfc2ae20c5df8e86876bc22d50f0 Reviewed-on: https://gerrit.libreoffice.org/69899 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 66c08a0d308fd6119460546a906434bbc9d23c2e) Reviewed-on: https://gerrit.libreoffice.org/70155 Reviewed-by: vyzigold <jaromirwysoglad@gmail.com>
2019-03-20tdf#120161 sc: pdf export unit testSerge Krot
Change-Id: I42579d4d61be43318f7e2b06b3465890dd624a12 Reviewed-on: https://gerrit.libreoffice.org/69035 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit 87bf5a930a72a12f88a21b450da0dd86348c3077) Reviewed-on: https://gerrit.libreoffice.org/69412
2019-03-19tdf#120161 sc: use selection to set required printed areaSerge Krot
Change-Id: Id0798cbff2d327e2bb955fbbc530a201975f6003 Reviewed-on: https://gerrit.libreoffice.org/68833 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit 03b6c20c66047af41ed2f78fe5dd229cd06392e8) Reviewed-on: https://gerrit.libreoffice.org/69118 Reviewed-by: Serge Krot (CIB) <Serge.Krot@cib.de> Tested-by: Serge Krot (CIB) <Serge.Krot@cib.de> (cherry picked from commit f0b71fafd3a2fd6158c5952d601092179cba21e5) Reviewed-on: https://gerrit.libreoffice.org/69263
2019-03-14do not access uninitialized values when printing (tdf#121439)Luboš Luňák
The assert in the bugreport is triggered by ScPrintFunc::CalcPages() passing uninitialized values of nEndRow (and others). These variables apparently get initialized only by constructors that take ScPrintState. These ctors also set (the somewhat poorly named) bState and the call to CalcPages() is guarded by this. However, GetPrintState() will simply create ScPrintState filled with these uninitialized values and later on this will be used with these ctors, so bState will be set, but nEndRow will be bogus. Although 5217a2a0bf27e496cc429ee45dff7c239b466ae6 introduced tdf#121439, this strange bState logic and unitialized variables has been these since the initial commit, and the code doesn't take any precautions to check whether the values are valid or not, so I assume this always was just lucky enough to work and 5217a2a0bf finally triggered a problem. Given that it's rather unclear to me how this is supposed to work properly, just add an extra flag to both ScPrintFunc and ScPrintState marking whether the values are set or not and make CalcPages() depends on this flag instead. Change-Id: I0620de6562865c24f5a0edca2566b01546bf2e2b Reviewed-on: https://gerrit.libreoffice.org/68739 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Jenkins (cherry picked from commit 9432bab9f8f4a246d205ff2a460f60aeedba8ce1) Reviewed-on: https://gerrit.libreoffice.org/69262 Reviewed-by: Luboš Luňák <l.lunak@collabora.com> Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org> Tested-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-02-28fix "doc will be saved" dialog messageNoel Grandin
looks like a copy/paste error in commit 942f05996bc287923cdbcae12c64e57adf8ec975 Author: Caolán McNamara <caolanm@redhat.com> convert remaining ErrorBox to weld::MessageDialog Change-Id: I52d38311b1e276fd799128e058ea0b9c902aef06 Reviewed-on: https://gerrit.libreoffice.org/68491 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit e76203f45a4c645447f8379ee2123f518a8aca77) Reviewed-on: https://gerrit.libreoffice.org/68503 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-27add missing responsesCaolán McNamara
Change-Id: I2c24ea46b6e81ed02ae53da5e9ae1b7df85e44a1 Reviewed-on: https://gerrit.libreoffice.org/68456 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2019-02-19tdf#122982 Remove image from cell when cutting the cellSamuel Mehrbrodt
Reviewed-on: https://gerrit.libreoffice.org/67844 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> (cherry picked from commit e756b6f310f309ac29bb2bce92309bb74edd788d) Change-Id: Idd73dcc88a8cd76eb4011bb26efdd5c712d16e5e Reviewed-on: https://gerrit.libreoffice.org/67854 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-02-09Resolves: tdf#121002 UpdateRefOnNonCopy::mbUpdated=true if references changeEike Rathke
... somewhere in a previous shared formula group, so for the new groups after split the column is added to sc::RefUpdateContext::maRegroupCols in ScColumn::UpdateReference() to setup new listeners later, and true returned there, which also results in ScTable::SetStreamValid(false) at the end, which in this constellation wasn't the case. It may have been a reason that some documents have individual unrecalculated results stored (i.e. values moved within ranges that a shared formula group pointed to) that can be corrected by recalculating after load. Said to be a regression from commit 2f6a06856ad8df0c11a112d1e457b408e9a7af1d CommitDate: Fri Jun 5 16:22:38 2015 +0200 tdf#90694 reset group area listeners when splitting group but that only uncovered this misbehaviour. Change-Id: I6b04b71898c3f1774452dd19790c208f3167d8eb Reviewed-on: https://gerrit.libreoffice.org/67461 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit cdfa8b27f28328612b6734533981c1b363ced0a0) Reviewed-on: https://gerrit.libreoffice.org/67466 Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2019-01-22Resetting all fields for all dims corrupts pivot cacheKatarina Behrens
test case is exporting ooo55266-3 (contains data grouped in numerical intervals) to xlsx and without closing the document, opening filter on 1st pivot table (kaboom!) ClearGroupFields corrupts the cache bc it resets Field.mpGroup items for all dimensions, not just the one present in ScDPDimensionSaveData (all this happening in ScDPCollection::SheetCaches::getCache). Consequently, accessing or rebuilding pivot cache may crash bc mpGroup now points nowhere. I split and renamed ScDPCache::ClearGroupFields into 2 parts, one of them clears maGroupFields, the other resets mpGroup ptrs in maFields. When adding data to cache, the former is used (bc group ptrs get reset almost immediately afterwards) Reviewed-on: https://gerrit.libreoffice.org/65329 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> (cherry picked from commit f70d29fd91d232f0b030f0f76bd23bd2919eb868) Change-Id: I96e8d234a17da0f3cc65c0625aa47b12284b98b8 Reviewed-on: https://gerrit.libreoffice.org/66622 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2019-01-08Resolves: tdf#114695 limit width of this comboCaolán McNamara
Change-Id: I3bcb880d05b9b2b6a7faf7b3646b169f3b11a46b Reviewed-on: https://gerrit.libreoffice.org/65509 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-12-31tdf#114919: fix ods export in ODF 1.2 strictJulien Nabet
See Valgrind trace here: https://bugs.documentfoundation.org/attachment.cgi?id=147891 which contains bt Due to a8b7c72425aabae87bfd2e141aa06f06319ae11c " add error to office:value-type for calc cells and fdo#51810 For cached value import we need the information which cells are error cells. For ODF 1.2 extended we therefore export now calcext:office-value with the additional value "error". " Change-Id: I13547ecc7ef8c1c4e1a236229d3b19d51f12470b Reviewed-on: https://gerrit.libreoffice.org/65728 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit 5534bfef6426128af2147de995224d7cdf43a2bf) Reviewed-on: https://gerrit.libreoffice.org/65738 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-12-31tdf#112484: repeat-item-labels is invalid in odf1.2 strictJulien Nabet
Change-Id: I23d204ef3d4e466876bb3416d616dc1f3682ad4c Reviewed-on: https://gerrit.libreoffice.org/65740 Tested-by: Jenkins (cherry picked from commit 40a7e9c93855ac6cceb4c4189587998e21581de5) Reviewed-on: https://gerrit.libreoffice.org/65749 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-12-20tdf#117332: select replaced text to properly replace it next timeMike Kaganski
... othervise the next drag event will insert the new range immediately after the just inserted, resulting in invalid reference. Regression after commit 42aece949ec96c775b31216bddd723aa5321e966 don't replace content of formula field when selecting range, tdf#58635 Change-Id: I7dfdc1ce041ebadf4406dbb605676d87cd489efa Reviewed-on: https://gerrit.libreoffice.org/64574 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit 6c5839d399c6277a7f2f0e214a20996761563525) Reviewed-on: https://gerrit.libreoffice.org/65027 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2018-12-19tdf#120859 bad column span in .ui leads to overlapping checkbuttonsCaolán McNamara
possibly(?) since... commit d999b55e28d0445df870f69b3a269964e3635def Date: Sun Dec 10 10:56:38 2017 +0530 tdf#114200 : added 'Trim space' feature in 'Text Import' made a checkbox to Trim extra white spaces from both ends while using seperators in 'Text Imort' Change-Id: I280c5daacdc823ea26d02890ddbc4685a5382e6c Reviewed-on: https://gerrit.libreoffice.org/65429 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2018-12-12Correct typed_flags<PivotFunc> mask is 0x1fffEike Rathke
This was wrong since commit 298ee50676b849020a8a5042e8612f71379ecf3b CommitDate: Sun Nov 20 00:14:28 2016 +0100 PivotMedian: Implement median as a new pivot table function and in fact in a debug build failed an assertion soffice.bin: include/o3tl/typed_flags_set.hxx:85: constexpr o3tl::is_typed_flags<E, M>::Wrap::Wrap(type name std::underlying_type<_Tp>::type) [with E = PivotFunc; typename std::underlying_type<_Tp>::type M = 4607; typename std::underlying_type<_Tp>::type = int]: Assertion `static_cast<typename std::underlying_type<E>::type>(~0) == M || (value & ~M) == 0' failed. when one of the functions (e.g. StdVar) not included in the mask was chosen as pivot table data function. Change-Id: I5b9efc7d2cbcf6fece3ef228db8f6e0ffa17b510 Reviewed-on: https://gerrit.libreoffice.org/64974 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit 639a401fbd910c1fede35f7106a5acf716ec5fea) Reviewed-on: https://gerrit.libreoffice.org/64986 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-12-11crashtesting: ooo55266-3.ods some members are nullptrKatarina Behrens
Crashes since commit 6481bda69ade61cb5420156272fcf17edd43d620 tdf#121612: update pivot caches during saving to XLSX without refresh, pivot cache export was skipped entirely Change-Id: Ic68d4974d5cb9278d61938a59aa8f1a01b920f1f Reviewed-on: https://gerrit.libreoffice.org/64903 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit 837a65cdc0bef4ef6c48f7b867c7948c70352f05) Reviewed-on: https://gerrit.libreoffice.org/64946 Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-12-09Resolves: tdf#80583 create range list string with proper delimiterEike Rathke
... which is the to be used function parameter separator here. The current document's grammar (from which the separator is obtained in ScRangeList::Format() if not specified) may differ from the forced English grammar later when compiling the formula, and all formula expressions to be inserted use the language independent ';' semicolon function parameter separator. Change-Id: I7a3deb6d50fc57ed434ede1f00bbe8c5c1361e0f Reviewed-on: https://gerrit.libreoffice.org/64819 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit 470a91cb041782e29664212d096bb16873ba57a0) Reviewed-on: https://gerrit.libreoffice.org/64824 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-12-05Resolves: tdf#121887 RowModel::mnRow is 1-based, alwaysEike Rathke
Basically this was always wrong. Original code didn't treat the r attribute as optional and resulted in an invalid -1 row for such cases, hence the RowModel wasn't applied later. Then commit af8e6f4f544ecd01d3eda5f38bbd4779d5e8b2c6 CommitDate: Wed May 29 22:05:02 2013 +0200 r is an optional attribute in c and r, fdo#65059 introduced a 0-based SheetDataContext::mnRow but assigned that to a 1-based RowModel::mnRow as well if r attribute was missing, and did not update SheetDataContext::mnRow if r attribute was given. commit ff56553e34dfed01b9226ce7a516dbeb6da32124 CommitDate: Thu Mar 13 18:39:22 2014 -0400 fdo#76032: This row index is 1-based whereas our own mnRow is 0-based. then correctly assigned the decremented r attribute to SheetDataContext::mnRow but did not touch the assignment to RowModel::mnRow if r was not given. Probably confused by the ++mnRow already there which is correct but not sufficient for the assignment. Which we now finally fix herewith.. Change-Id: Iae1563ed01b95e7852ddad4fd59374c07186b493 Reviewed-on: https://gerrit.libreoffice.org/64580 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 76fbe494785faee1313d1c0be8ed2ca7b0d74f68) Reviewed-on: https://gerrit.libreoffice.org/64639 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-11-30tdf#121612: update pivot caches during saving to XLSXVasily Melenchuk
Cache was empty so pivot table was not exported completely and pivot table filter were missing. Change-Id: Ib0b9e98a5588159c5c7de1e2e5d2bdcbfe986d8d Reviewed-on: https://gerrit.libreoffice.org/63785 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Reviewed-on: https://gerrit.libreoffice.org/64265 Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit 78457f7462aa3bf92839667a550451f0d434f48b) Reviewed-on: https://gerrit.libreoffice.org/64303 Reviewed-by: Vasily Melenchuk <vasily.melenchuk@cib.de>
2018-11-29tdf#105236, only take number format from numeric cellsMarkus Mohrhard
Change-Id: I55deaa1f0579582a45dc1e10bb578b680eb98647 Reviewed-on: https://gerrit.libreoffice.org/64200 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit fb04e7180cdf656dbbd3daa9c81615d9478229e0) Reviewed-on: https://gerrit.libreoffice.org/64204 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-26tdf#108027, add external ref string items to the data arrayMarkus Mohrhard
Change-Id: Iaf607fca6d7e88f2c529ab4a374f34164813331a Reviewed-on: https://gerrit.libreoffice.org/64009 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit 72e204da9a062282e52d5060e7f633e3b21414ff) Reviewed-on: https://gerrit.libreoffice.org/64012 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2018-11-26tdf#116931 Fix scale when calc cells move indirectlyArmin Le Grand
For the anchor mode 'To Cell (resize with cell)' there were errors e.g. when the cell the object is in does not scale but move. If that move went further than the object is, wrong offsets emerged. Also added full linear per-cell scale instead of only scale (no translation through scale). Overhauled to use liner transfomations, too. Change-Id: Icff0fad168476c68ea10fd5830bf53bd7294b89f Reviewed-on: https://gerrit.libreoffice.org/63803 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de> (cherry picked from commit 10a58ec15438d34a594437815882862c4576e2c0) Reviewed-on: https://gerrit.libreoffice.org/63852 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-11-22Resolves: tdf#113898 create JumpMatrix for svExternalDoubleRef scalar valuesEike Rathke
Change-Id: I45d2a1e573a7e4923aaaf5b69f3c4b39215aacc2 Reviewed-on: https://gerrit.libreoffice.org/63778 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit 266aab73a88ae5b62fcddaf383107d8e7edc51f2) Reviewed-on: https://gerrit.libreoffice.org/63797 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-17thread-safe ScGlobal::GetUnitConverter()Luboš Luňák
Triggered by sc/qa/unit/data/functions/mathematical/fods/convert_ooo.fods with SC_FORCE_CALCULATION=threads. Change-Id: Ibedb32ee03519911650a0deee67011efeda57c93 Reviewed-on: https://gerrit.libreoffice.org/63175 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com> (cherry picked from commit 9553f2afd0527ba435dae7bf4506c620a943b150) Reviewed-on: https://gerrit.libreoffice.org/63376 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-17Resolves: tdf#119700 save correct table:last-row-spannedEike Rathke
Regression from commit f6e6a6139e90d6e88fb65308e8592193ac602a8a CommitDate: Mon Nov 21 07:49:06 2016 +0000 tdf#48140 Replace uno CellRangeAddress and CellAddress with direct calls that calculated endrow-startcol instead of endrow-startrow. Change-Id: Ie576f9abdcdc23fc5f0a06735caadc24e975360f Reviewed-on: https://gerrit.libreoffice.org/63374 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit 6e566c2b2b23d457a9fd47c16df15ce11e84c8e8) Reviewed-on: https://gerrit.libreoffice.org/63382 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-17blacklist svMatrix for calc threaded calculationLuboš Luňák
If a formula contains a matrix, interpreting it will actually result in modifying it in some ways (e.g. ScInterpreter::PopRangeMatrix() calls SetErrorInterpreter() on the matrix). Testcase: rhbz#1645905 Change-Id: I63742449ba0e4e375d6e459dc7bccd7e6b62920e Reviewed-on: https://gerrit.libreoffice.org/63187 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins Reviewed-on: https://gerrit.libreoffice.org/63379 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-17blacklist svExternalName for calc threadingLuboš Luňák
It's the same like svExternal(Single|Double)Ref, there's a lot of thread-unsafe code involved. Change-Id: Ief8bbbd9393788c374215412ee5236ce6bb551fa Reviewed-on: https://gerrit.libreoffice.org/63176 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins (cherry picked from commit 3460e91ac853964015215ec75be7cf63361ca0e9) Reviewed-on: https://gerrit.libreoffice.org/63377 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-17don't access deleted cellsLuboš Luňák
This copy&pasted code that got fixed in 2926c9e40e17, so fix it as well. Change-Id: I0a038b57a428640dae8cdf17f33a2eab50b0187c Reviewed-on: https://gerrit.libreoffice.org/63177 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com> (cherry picked from commit f9026deba0581759146205237eb739f37463ba47) Reviewed-on: https://gerrit.libreoffice.org/63378 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-16tdf#107240 tdf#120432 Disable time/date entries in read-only/protected modeXisco Fauli
Change-Id: Ia3c757fa094f17be3b4aadaee65c4699bf0c1cb1 Reviewed-on: https://gerrit.libreoffice.org/61953 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 525ed5d1fcb89412f0b80be0b1e35410b048c337) Reviewed-on: https://gerrit.libreoffice.org/63452 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2018-11-08tdf#107586, import chart sheet colorMarkus Mohrhard
Change-Id: Ie7d728cd36c93d5f398266ee65be0e1bf14a0c97 Reviewed-on: https://gerrit.libreoffice.org/62974 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit 06e90234e402717e3ef04cf712d34c9165dbc08e) Reviewed-on: https://gerrit.libreoffice.org/62980 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-06tdf#115317 Fix empty url representationPaul Trojahn
ScTabEditEngine doesn't override CalcFieldValue, so the function in EditEngine returns a single space as representation. By inheriting from ScFieldEditEngine the representation is calculated correctly. Change-Id: I6f3be8bd2c3936acf9f3d082c25c080bd3cbee76 Reviewed-on: https://gerrit.libreoffice.org/62428 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Reviewed-on: https://gerrit.libreoffice.org/62967 Tested-by: Jenkins
2018-10-30tdf#118747 sc: use manual height for previous rows in TransferObjVasily Melenchuk
This can ensure, that visible area will not shift if autoheight will change height of previous rows. Change-Id: I66e013e9f3f27396f13b26fde37353cb63e47258 Reviewed-on: https://gerrit.libreoffice.org/62279 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit 1b9574ed8269f4ed9dde33856c1d74702a7fa4bb) Reviewed-on: https://gerrit.libreoffice.org/62518 Tested-by: Xisco Faulí <xiscofauli@libreoffice.org>
2018-10-26index validity check looks dubiousCaolán McNamara
Change-Id: I0952bbaabeb8353b27b478ad6b17bc9348c6f61a Reviewed-on: https://gerrit.libreoffice.org/61992 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2018-10-26index validity check looks dubiousCaolán McNamara
Change-Id: Ib57a26e51a69cc48f82b3474d11fe4f8c8398e07 Reviewed-on: https://gerrit.libreoffice.org/61995 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
generated by cgit (git 2.34.1) at 2024-06-07 07:14:18 +0000