summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)Author
2013-01-10handle shapes anchored to the wrong sheet without crash, fdo#58858Markus Mohrhard
Change-Id: I00d127dbb6151e3100be931079cbf8907ac69ddd
2013-01-09fdo#58539: Correctly set cached matrix formula result.Kohei Yoshida
During the import, a cached matrix value only has an empty matrix of correct geometry, plus the token type of the top-left cell. The rest of the elements are imported as hybrid values. For now, this seems to do the trick. In the future we may want to change it to fully populate the matrix cache value during the import, and skip setting the hybrid values for the non-top-left elements. This commit also make several other trivial changes: * Mark pRawToken mutable so that we can mark those IsFoo() methods const. * Move the ScCompiler instance from static instance to member of ScXMLImport. Since we don't need the instance to persist once the import is over, this is more appropriate. Change-Id: I1abde03c0fcd91b02ef4dbf8b5526f7965eaf19c
2013-01-09re-apply calc /tmp unit test file leakage.Michael Meeks
2013-01-09Some removal/replacement of the String/UniString with OUStringJean-Noël Rouvignac
2013-01-09turn some OSL_ENSURE into SAL_WARN_IF to avoid warnings about unused variablesMatúš Kukan
And one OSL_ASSERT too. Change-Id: I51f0083b9b9336e80c3b6a898c295173ad48f77c Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2013-01-09Revert "fix a few /tmp file leaks"Miklos Vajna
This reverts commit 92045e69dab8be60a1c84774f04c437066c3c2bf. Broke a unit test and made all tinderboxes red. Requested-by: Stephan Bergmann <sbergman@redhat.com>
2013-01-09accidently moved that line aroundMarkus Mohrhard
Change-Id: I8a6bbe161a91140e1ee2aca36ba848a02286108f
2013-01-09set the list box entry for 3 entry color scalesMarkus Mohrhard
Change-Id: I5718d22e0c31bd645998bcbb508b31370cf36250
2013-01-08fix a few /tmp file leaksMichael Meeks
Thanks to Jean-Baptiste Faure for digging for these.
2013-01-08Let's not have two variants of this getter. One is enough.Kohei Yoshida
And let's stick with the one that returns the data pointer. Change-Id: I931be0d73adcf6f3888d05ef58bc0f905f5a6958
2013-01-08Add new ods import test for rich-text cell contents.Kohei Yoshida
Change-Id: I23eb8d53b8a2c48514900a5ab07ed7ec71d3ef99
2013-01-08DynamicErrorInfo objects must be allocated on the heapStephan Bergmann
cf. "delete pInfo;" in ErrorHandler::HandleError_Impl (tools/source/ref/errinf.cxx). This reverts the remaining (non UNO related) changes from e48d47469508dee55ae6abcb3988222b5612e1e9 "fix some memory leaks in sc" and 5ea7e74c29f7279b6c31d38185ace576f68f4fb2 "fix some memory leaks in sd" that had not already been reverted. Whether any of these instantiations are really leaked (i.e., never deleted again in calls to ErrorHandler::HandleError_Impl) is unclear to me, but that would need to be fixed in a different way. Change-Id: I6d9e7a2f6fce6d6a4d5d390c09a5a12f593028a6
2013-01-08support new hyperlink cell attributeNoel Power
Allows a hyperlink attribute to be set for a cell, allows for import of say a hyperlink associated with a formula cell. Since this patch does not add any file format support it is not possible to save such an imported hyperlink to ods. Note: such a hyperlink would not have been imported in the past so this should not be an issue Change-Id: Ieb234bb6e98e4a2630b596a90972a75be12a92d4
2013-01-08correct label for data bar dialog, fdo#58608Markus Mohrhard
Change-Id: I91cdb23a25092f44ff76784b5347134a3c9a3528
2013-01-07Adjusted all test methods for loadDoc.Kohei Yoshida
There was already a method that did the same thing (loadDoc). Let's stick with loadDoc instead. Also took advantage of automatic literal to OUString conversion while I was at it. Change-Id: I184f6278dd4bf8e3f2f7e5eda1e5e293303df68c
2013-01-07Remove duplicated code blocks.Kohei Yoshida
Change-Id: I332a39fe86fee385bcd2cce33fe2096043111472 TODO: Do this in the other tests as well.
2013-01-07Append ODS to the test method name.Kohei Yoshida
Change-Id: I024d142b59ccceed944d641b6306f47dcf03ef9d
2013-01-07New test for pivot table with field references.Kohei Yoshida
Change-Id: I65d932d6c258b965a6084acb07298387b7274215
2013-01-07split out numbering position page to cui and adapt codeCaolán McNamara
and move SvxNumberingPreview from svx to cui where its ::Paint impl already lives Change-Id: I2b7bebeb9914d74d0f391d3b178b0ad3d778c479
2013-01-07Cleanup: #include <tools/gen.hxx>Matteo Casalin
Change-Id: Ic547b4a59102afc8bdbc85ec95ac312e32ef2530 Reviewed-on: https://gerrit.libreoffice.org/1484 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2013-01-07UNO objects must be allocated on the heapStephan Bergmann
This was a regression introduced with e48d47469508dee55ae6abcb3988222b5612e1e9 "fix some memory leaks in sc." Change-Id: I482516d31b857801c321ed252d19f06b4b11542e
2013-01-06fix some memory leaks in scMarkus Mohrhard
Change-Id: I1e3b9a55561f941346cb9f553f960dc2bafbb1b6
2013-01-06fdo#58671: Remove accelerators from Undo action textsKorrawit Pruegsanusak
These three texts appear in Undo dropdown list, so they don't need accelerators Change-Id: Icec8e199c7cc3990b6316937e49aacb7eb1015fb Reviewed-on: https://gerrit.libreoffice.org/1473 Reviewed-by: Ivan Timofeev <timofeev.i.s@gmail.com> Tested-by: Ivan Timofeev <timofeev.i.s@gmail.com>
2013-01-05don't set formula cells with possible error val clean, fdo#59039Markus Mohrhard
Change-Id: Ide96d7f052ee4c8f56b33629ae48c6425a8ca19f
2013-01-05enable the unit testMarkus Mohrhard
2013-01-05Revert "workaround problems with row import, fdo#58539"Markus Mohrhard
This reverts commit 119483d9b0af6b4830733161fcf56cea10ed01d7.
2013-01-04add unit test for dependency tree during ods importMarkus Mohrhard
Change-Id: I92bff38304959237042b9a0078be25948d642b25
2013-01-04New ods test document to check the import of row height values.Kohei Yoshida
Test disabled as it currently fails. Change-Id: I33ea3c95357fd7fdb9deaba30372567cfb69ebd6
2013-01-04Make LO buildable again after the GraphicFilter move.Jan Holesovsky
Change-Id: I3455a7294b136400f32163626d5a7a7f2bfa898c
2013-01-04don't forget the dependency tree during OOXML import, fdo#58863Markus Mohrhard
Change-Id: I8863faddd1bca0b55764d09c4ef9f959264b53ae
2013-01-04don't forget the dependency tree during formula importMarkus Mohrhard
Change-Id: I0a9137e4f72477c0cffde6056d8952aa08e13f35
2013-01-04remove unnecessary german commentMarkus Mohrhard
Change-Id: I954015fb76089ae7d83344e8d99f6bc04587016f
2013-01-04correct indentationMarkus Mohrhard
Change-Id: I9b57ac13a8d508c260666535ee60783dee889508
2013-01-04put the function in the anonymous namespaceMarkus Mohrhard
Change-Id: I8ee07fb9d6d9144ec981c2fabc17b4005ecc87bb
2013-01-04Remove the last use of SC_DP_MAX_FIELDS.Kohei Yoshida
Now the pivot table core no longer uses static array for result data storage. Change-Id: I70a44011e2c12a1739c0507b1723c21a4808758c
2013-01-04More on removing use of SC_DP_MAX_FIELDS.Kohei Yoshida
This time it's in ScDPSource::CreateRes_Impl(). Change-Id: Ie2657045aeb8770c083daa34dc1a7e60c9921b65
2013-01-04Remove SC_DP_MAX_FIELDS from ScDPRunningTotalState too.Kohei Yoshida
Change-Id: I60bf45fd5148692adafb050189247f211293a3d1
2013-01-04Remove hard-coded upper field limit from ScDPInitState.Kohei Yoshida
This was going to cause trouble sooner or later.... Change-Id: I5eea2ba7b1cc4e358a0192b4863d79596549bad9
2013-01-04OSL_ENSURE -> SAL_WARN_IF in xmlcelli.cxxMarkus Mohrhard
Change-Id: Ia60e07dca17cbc728385c411f67bd3d9041b15ee
2013-01-04don't overflow SCCOL during repeated cell import, fdo#58539Markus Mohrhard
This is the fix for the third and last crash with gnome#627150 Change-Id: Iaf8611500fdb485017814b35789332c6c89530c0
2013-01-04add some more safety checks for row and column import from ODSMarkus Mohrhard
Change-Id: Ic714c65cfe93198c462ba55752223f4e60e5aad9
2013-01-04workaround problems with row import, fdo#58539Markus Mohrhard
This fixes another crash with gnome#627150 Change-Id: Ibd259c77f8df04b52c9fee0699e0edd1ad30e94e
2013-01-04initialize it irectly in the constructorMarkus Mohrhard
Change-Id: If3ad494073d3fb491a0f8e981a28db5bbb917661
2013-01-03fdo#58004: Let's remove these upper bound truncation.Kohei Yoshida
We may still need to set an upper bound, but we shouldn't do these all over the place. Apparently we now allow more than 256 fields, so doing this would only break things for fields whose indices are greater than 255. Change-Id: Ic2e374ec01267044c2e40664775e7f62b1461f41
2013-01-03fdo#58004: Fix out-of-bound access to std::vector.Kohei Yoshida
Two things were wrong with the old code: 1) it didn't check for out-of-bound access, and 2) used SC_DP_MAX_FIELDS as the upper bound of dimension members, when in fact SC_DP_MAX_FIELDS was the upper bound of dimensions themselves,. not their members. We shouldn't impose such upper bounds actually, at least not in the core implementation. We should do that in the UI code if we really have to. Change-Id: I307d4f34d2b0be84f0fd2b93a6270ffce2448bdf
2013-01-03Let's first fix this horrible formatting.Kohei Yoshida
Change-Id: I562ad42818fa7a6bfc765b7484a28ff1800b2949
2013-01-03fdo#58004: Apply source number format over one specified by the style.Kohei Yoshida
Pivot table output applies several pre-defined styles, which also include number formats. But, the source number format, or one set by the pivot table should take precedence over the one specified by the style, or else it would lead to a very peculiar behavior. This is especially the case when the documnet has its 'Default' style specify a number format that's not 'General'. Also, we should take all number formats into account, including the ones that are 0. Change-Id: Ifa794314a2881c5146e24eb7be892585a823048d
2013-01-03make sure the column index is valid, fdo#58539Markus Mohrhard
This is the first part of the fix for gnome#627150 Change-Id: I02cd8c553dd6b9a026c0ea38d77c6831fef6498e
2013-01-03simplify this code a little bitMarkus Mohrhard
and restore some of the old optimizations Change-Id: I1b42ed135bd3f8dfb663740a1bd2dbfa1216a388
2013-01-03fdo#58539: Check for mxValueLink being NULL before dereferencing.Kohei Yoshida
Or else Calc would crash while loading the xls document from gnome519788. As an aside, this xls document appears to be corrupt. Trying to open it in Excel (XP and 2007) causes Excel to offer to repair it, while fails in both versions. Excel XP is somehow able to open it with some content preserved. No such luck with Excel 2007. Change-Id: I04616a4c926862461a2efdd99ccabe36122d6825
generated by cgit (git 2.34.1) at 2024-08-19 02:57:24 +0000