summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)Author
2021-08-09tdf#115520 sc UI: Define Database Range dialog disappearedTünde Tóth
if the name of the database range was invalid. Change-Id: If0eb08d35b2187f04ef93136acd6f7eafa3b588a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119652 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit a07351e8181353c0c0b6df5d2ccbad4615c6706b) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120234 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-08-09tdf#143619 validation circle anchor is specialRegina Henschel
For usual drawing objects, maStart in its Calc user data means the cell address of left/top of snapRect/logicRect. For validation circle it means 'address of cell to be validated'. Thus corrections might be needed, if a general method is used for validation circle. Here the method SetLogicRect() calls via broadcast ScDrawLayer::SetCellAnchoredFromPosition(), which calculates maStart from snapRect/logicRect. Because the circle is extended to cover a larger area than the to be validated cell, maStart got the cell address of the cell one left and one above of the to be validated cell. Now the old, correct address is backuped and restored. Change-Id: I9646da3f22fef45a6e47e59ef55a70307e2f9cc6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119715 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de> (cherry picked from commit 0cff1aa48453ee0c05bafcac5360329fb6bf9557) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120147 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-08-09tdf#64703 sc: fix regression of printing page breaksAttila Szűcs
After hidden rows or rows hidden by Autofilter, printing removed the page breaks between the visible rows, too. Now Calc supports WYSWYG: it prints all the visible page breaks, which includes the page breaks between the visible rows, and page breaks between the hidden rows (multiple page breaks of a hidden row sequence converted to a single page break). This was a regression since LO 3.6, introducing Autofilter with multichoice. Co-authored-by: Tibor Nagy (NISZ) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118984 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org> (cherry picked from commit 8b2a2de2481843502f0566e773ed11532520bc70) Check nNextPageBreak for ScRowBreakIterator::NOT_FOUND, tdf#64703 follow-up Ifa0fd1b53da70018d8d14abd4f8ba347908d5ea9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119732 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins Change-Id: I87858d36fc62b8a5952cfd5bc39dbe90f1452ac0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119620 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-08-09tdf#143582 - Clear return value of the method before calling itAndreas Heinisch
Otherwise the function keeps a copy of its return value, which may be used in an upcoming call. Change-Id: I4977c39e1ce48cfd5ab067a4df4783f10505a9ae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119905 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120197
2021-08-08Resolves: tdf#143759 Limit empty search's empty column to actual search rangeEike Rathke
... instead of the non-/filtered last row. Change-Id: I9b941af688a8083d472a793a6bc6b6dbb7b916ea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120176 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit 15960931988cfd898e14a12d6b9cddaf6d8b0ade) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120134 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-08-04Resolves: tdf#143714 only three of four of these buttons have always-show-imageCaolán McNamara
Change-Id: Ic4bb951d0a7800b5d920a3b40c2bb4b06ecbc629 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117203 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119971 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2021-08-03Consolidate link update handlingEike Rathke
Have it at one central place and identical for all document loading paths. Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119835 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit 55abc3eb93fb8314b413453e384261cb00fde087) Conflicts: sc/source/ui/docshell/docsh4.cxx Change-Id: Ib00153a9f5831e223d0129df0538353a7e20961e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119836 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-07-25Related: tdf#135762 Suppress cout if not command lineEike Rathke
Change-Id: I9431221aadf97739bb197871f25fa151ef4c391c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119294 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit 0cda081c9aa3b3dcb363f97bac60c845ce9a13e0) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119255 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-07-22Dereferencing uninitialized pointerMike Kaganski
SfxItemSet::GetItemState returns SfxItemState::DEFAULT without resetting the passed pointer. Regression after commit dd5bf12193471f064bf7f581dd1b21783390e735. Change-Id: I1e427a05f8e5b375f50d81b51d32e78fca83eb42 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119348 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit 0d4cbdbc9cd4ab06056cec66cffd292b41615b6e) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119259 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-07-21tdf#142854 XLSX import: fix grid visibility in headless modeAttila Szűcs
Fix regression from commit 759103fd65f82fc131679eba0de05f2ddc7294c8 (tdf#126541 XLSX import: fix View grid lines). Sheet based grid visibility shouldn't overwrite the global grid visibility, except for headless mode (i.e. for command line batch mode, see --convert-to in ./soffice --help, otherwise we could get a regression here: The sheet based grid visibility (bShowGrid) is stored in view settings. Headless mode means not to export view setting, including sheet based grid visibility. As the old workaround, use global visibility to keep the losing sheet visibility. FIXME: headless mode only works correctly if all sheets have the same grid visibility. The sheet based bShowGrid should be moved to another location, which is supported by the headless mode, too. Note: now the modified tdf#126541 unit test checks the fix for the regression of the headless mode, and the new Python UI test checks the (now improved) fix for tdf#126541 on the desktop. Co-authored-by: Tibor Nagy (NISZ) Change-Id: I93551d22cc5d858dc64f93a46cd8aa202b4b2df5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118599 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119314 Tested-by: Jenkins
2021-07-20tdf#46184 sc AutoFilter: reset filter options to default valuesTünde Tóth
when the old filter entries are removed in auto-filter rules, because these options are not visible from the AutoFilter. E.g. now using AutoFilter doesn't apply copying of the previous standard filtering, changing also the active sheet etc. This fixes regression from LibreOffice 3.5 or more. Change-Id: I26b272dc738f3918ff5b2ca7e8fee3481d21460a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118603 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119272 Tested-by: Jenkins
2021-07-20tdf#123598 sc UI: don't show autofilter dropdown arrowsTünde Tóth
on the result area when the "Copy results to:" option is true. Change-Id: I3da4a1098d8c7c0be6604451b7485312043c5ede Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118484 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org> (cherry picked from commit 15684e5d595289e0a94efd80bbe203ca133845f2) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119188 Tested-by: Jenkins
2021-07-19tdf#92796 ODF import: remove unused bitmap fillsMichael Stahl
With CWS impress64 a partial fix for this was implemented to drop unreferenced named items including all non-color fills after ODF import, but this is only done in sd so move the code that does that to svx and call it from sc and sw as well. Implement some UNO interface for this, it's at least better than a magic string, and not obvious how a better solution would look like since it's known only at the end of the import if a bitmap is used or not. Another problem: when the Area tab is used to change to a different kind of fill, the items with the details for the previous fill aren't cleared, and so they are written to ODF files. Hence bitmaps in the file can be referenced even if they aren't actually used, and bloat up the files. Fix this by dropping all unused draw:fill-image-name attributes in ODF import. Also do the same for Gradient and Hatch fills; Transparency gradients can be combined with anything so leave them as they are. Change-Id: I0b591fd9f963d974d0c3e7208b99621ad61dd93c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118950 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit 86c0f58b6f9f392865196606173d1b98a6897f32) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119036 Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2021-07-15Related: tdf#135762 Allow --convert-to csv to specify 1-based sheet numberEike Rathke
Same multifile mechanism as for -1 all sheets is used, so soffice --convert-to csv:"Text - txt - csv (StarCalc)":44,34,UTF8,1,,0,false,true,false,false,false,2 sample.ods writes a file sample-Sheet2.csv Change-Id: Ib9248c9561e4e340c88458ac5dfd159e443a4cfd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118971 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit fda91f8be16ba760e360940ebafd6244c648cb8c) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118920 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-07-15tdf#143068 XLSX: fix export of top10 filter conditionTünde Tóth
Top10 filter condition lost after XLSX export. Change-Id: I5f9974e7d73f9ada84e284790c2928547f9ec7e7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118291 Tested-by: Jenkins Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org> (cherry picked from commit d79de2a2975db6b34f47b7ccfe8d18692373d6f0) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118808 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-07-15rhbz#1980800 allow --convert-to csv to write each sheet to a separate fileCaolán McNamara
Related: tdf#135762 except only currently implemented for command line use sample usage: soffice --convert-to csv:"Text - txt - csv (StarCalc)":44,34,UTF8,1,,0,false,true,false,false,false,-1 sample.ods where the new (11th!) final token ("-1") enables writing each sheet to a new file based on the suggested target name so output in this example is files sample-Sheet1.csv and sample-Sheet2.csv Only -1 for 'all sheets' vs 0 for existing 'current sheet only' (which is always sheet 0 from the command line) are currently options but the token could be expanded in the future to select specific sheets to export. Change-Id: Ib99a120f1a2c8d1008a7a3c59a6b39f572fb346e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118850 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit b8903bc106dad036acb3d117e5c4fc955697fe02) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118915
2021-07-14tdf#142929 XLSX: fix import of "Less than" filter conditionTünde Tóth
"Less than" standard filter condition became <> instead of <. Change-Id: I53435590de3a03d9fcaf0359e8421ae3ef941316 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118227 Tested-by: Jenkins Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org> (cherry picked from commit 0d3398e5d141b79706653c04f1ab6dc9381a5cc1) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118809 Reviewed-by: Eike Rathke <erack@redhat.com>
2021-07-14move freeze/thaw so we don't select while frozenCaolán McNamara
Change-Id: I4f4b3e5ac3e7e842726780f9c773389f7c39ce7f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118793 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2021-07-13tdf#143101 sc UI: fix highlight of standard filter with logical ORTünde Tóth
The autofilter dropdown button didn't indicate that a standard filter in effect, when the criteria connected by a logical OR. Change-Id: I8f802ee3d0d03d654278693f0dcd06d7c3b67ba9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118274 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org> (cherry picked from commit 1115d4d5ac63394ca0f3f1b75dc81916cdbeebe9) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118805 Tested-by: Jenkins
2021-07-12editengine-columns: tdf#143258 Fix handling rotated textMike Kaganski
This reverts modifications to existing unit tests made in commit d0a1616ccad0dd5f5a02c1b0204f537b57d0b4b5. My idea that those changes were required because of more correct calculations was wrong, and in fact they were caused by off-by-1 error in height calculations. Change-Id: Ib94878a911238c977c35a8f8e3e5694cedc79a89 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118705 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118711 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-07-08tdf#142910 sc filter: fix "greater than" or "smaller than" etcBalazs Varga
Filter "greater than" or "smaller than" (>, <, >=, <=) conditions according to the cell number format. Regression from commit: d5c2584bf36d21580db677b231c57f99f49aa2cb (Related: tdf#140968 avoid duplicated filter values) Follow-up to commit: 1f755525189884e4b2824889a6b9dea8933402db (tdf#142402 sc UI: store formatted values in standard filter) Clean-up for commit: d5c2584bf36d21580db677b231c57f99f49aa2cb (Related: tdf#140968 avoid duplicated filter values) Change-Id: I1284892398c9964ca5407b4d617a617f20341107 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118272 Tested-by: Jenkins Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118593
2021-07-07tdf#142764 sc: import "Same content on first/left page"Daniel Arato (NISZ)
Different header of the first page was never imported (related to the missing UI support), despite its working ODF export. This commit sets the values of those options at ODS file load according to the "display" attribute used to hide or show a particular header/footer. Follow-up to commit 19fa853ce12136b5c14e0c5a0aa906c296b75388 "tdf#121715 XLSX: support custom first page header/footer". Change-Id: I3409ad94a4d3ff86fd7f6d8afede3e7603024515 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117788 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org> (cherry picked from commit 52beb3907dd3c7e6ae112e263def1005272cecd8) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118501 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-07-06speed up exporting very large spreadsheets to pdf(2)Noel Grandin
e.g. the one in tdf#102216 instead of copying the data we want back and forth, just share it via shared_ptr. takes it from 6min28s to 1m21 Change-Id: I44d174264baa875e1922d1d46ee07de0e8cbaf0b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118383 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 580b5f6a3bf671f6590f40795d7cb9e46d52cf9f) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118424
2021-07-05speed up exporting very large spreadsheets to pdfNoel Grandin
e.g. the one in tdf#102216 takes it from 27m16s to 6min28s Change-Id: If6cf7dd49cb43f1749da29da91dab6646d4a0626 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118382 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 8de4f0d77073a2a3850bbcdd09aa7f68c223da01) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118419 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-07-02uitest: LICENSE.html can be read-only, skip the 'ok' buttonXisco Fauli
Change-Id: Ib9c7547dac89715a4519a60d733ba03922a01231 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118328 Tested-by: Jenkins Tested-by: René Engelhard <rene@debian.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> (cherry picked from commit c3c31f4c6e3c658c05f5f6973ef54a03f2d12efe) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118300
2021-07-01Resolves: tdf#138432 Use locale's CharClass to parse numeric i18n contextEike Rathke
Change-Id: I1828f1b6f93228cd517a6a7bd9ae36584bd801a1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118226 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit d703131d063c41b8baca01830c4c9806f99ab7d2) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118185
2021-07-01sc: VclPtr, missing dispose (Page Style->Edit...->Header)László Németh
Test under Linux: 1) Open Format->Page Style; 2) disable checkbox "Same content on left and right pages"; 3) click on the button "Edit..." to open the Header dialog; 4) click on "Ok". Change-Id: I2ce403a7a37d71f8f6510b6ad00028bc9f7fc5a9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118221 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org> (cherry picked from commit 5976b54198d24dcf1d8d1684da4da2cf334abe5d) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118181
2021-06-30tdf#132421 - don't URL encode filename for the import ASCII dialog titleAndreas Heinisch
Change-Id: Ia2cb7b6b355f640a525c41606da25ba35771499b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118148 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de> (cherry picked from commit 6e8c9047f4bf6194bd1423422bd2dc9f92c50725) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118109 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-06-30tdf#140431 XLSX export: fix double file:// prefixTünde Tóth
Regression from commit: fc58d7d65b9683db7b7632137126680b8483f6c5 (tdf#129969 XLSX export: file URLs need IURI encoding) Change-Id: I5bfb0ef9ba7fe82cd3f4d0e0b3fdcf8f705cba64 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118090 Tested-by: Jenkins Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org> (cherry picked from commit 67e2cc17bad3fd7aacb94da47f9024b731434a84) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118173 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-06-30editengine-columns: add sidebar property panelMike Kaganski
Change-Id: I90aefc10f9ddddeb64a65799480777bc4287abae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117107 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit dd5bf12193471f064bf7f581dd1b21783390e735) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117217
2021-06-29tdf#121715 XLSX: support custom first page header/footerDaniel Arato (NISZ)
Add XLSX import/export support for a different header or footer (activated separately) on the first page. Print preview is also extended to support this. Note: only ODS export is supported, yet. Follow-up commits are going to add ODS import and UI support. Change-Id: Icd3a40131bdbcd5d5a42f98c86a71345a5745051 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116842 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org> (cherry picked from commit 19fa853ce12136b5c14e0c5a0aa906c296b75388) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118067 Tested-by: Jenkins
2021-06-29maShowPageBreaksTimer.Stop() in ScGridWindow::dispose(), tdf#124983 follow-upEike Rathke
Stop this timer when the ScGridWindow is to be deleted, together with the underlying document. See https://gerrit.libreoffice.org/c/core/+/90101 comments from Miklos Vajna on 2021-06-29 14:08/14:10 CEST Change-Id: Ia1f39c406d391abd78a57c1d92616dbff788ec63 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118112 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit 3d7007ef8784e92bb56a91c40e7bdff812251677) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118098
2021-06-28Revert "Revert "tdf#124983 In calc make printable page borders initially ↵Eike Rathke
visible"" This reverts commit 0be41797787622ebb5320acb6ec6cb65a7c8cdd4. Reason for revert: it turned out that the observed heap corruption on Windows (see late https://gerrit.libreoffice.org/c/core/+/90101 comments) was not due to this change, so the precautionary revert can be reverted again. Change-Id: I7a343f889fda601939381a8691e82dca147a40c3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117987 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2021-06-28tdf#58250 - Show custom unicode separator in the csv import dialogAndreas Heinisch
Change-Id: I5924ba3c5b0b96a744e2c2e63632b383b371e485 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117766 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de> (cherry picked from commit 8712d2cb78808bd17399605a70862d7920e63c9a) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117858 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-06-24tdf#69207 - Use selected text delimiter to parse the provided csv dataAndreas Heinisch
Change-Id: Ie260cb57956cd450398746c7f51629d37d14a324 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117750 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de> (cherry picked from commit 6d30c51f1f69d8c31b30b4e08a97222363852b17) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117724 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-06-24Revert "tdf#124983 In calc make printable page borders initially visible"Eike Rathke
This reverts commit ff3f749cd08851ee4eb0991eabee0327ca081a45. Reason for revert: reportedly causes crashes and heap corruption on Windows, see discussion in https://gerrit.libreoffice.org/c/core/+/90101 Change-Id: I84429b55b5fa2b26afd21ef104606ae2f30aad5d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117727 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2021-06-23Resolves: tdf#143008 Evaluate AM/PM for type date+time text-to-column and CSVEike Rathke
Change-Id: Ib760b9a103ab4b8ce7f5a158b09fbe11c6617f2a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117747 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit d81775f5b12080676ebaf659c5a4c10d64a9074b) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117719
2021-06-23tdf#124983 In calc make printable page borders initially visibleIlhan Yesil
If option "LibreOfficeDev Calc/View/Page breaks" is enabled, breaks should be visible. But if the document is opened the first time or a tab is opened the first time, the breaks are not calculated yet and therefore not visible. To avoid calculations during the load of the document, a timer will be triggered to calculate the breaks after loading is finished. Change-Id: I87219c62e20882b19d36042692efd2e6a8d8190a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90101 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 86e300df241312f6152da1cfa3cb2b8c668d1df5) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117718
2021-06-22tdf#142851 Chart UI: fix empty Chart Type dialogTünde Tóth
Chart Type dialog was empty, when the chart type of the chart was unsupported. Regression from commit: 4ff983b930dc15658aa531759d3f1e5b9586aeab (Related: tdf#142049 restore some elements default visibility in the ui) Change-Id: I057e6b9218edee398af8311c46b922ca76a9bcb5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117173 Tested-by: Jenkins Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org> (cherry picked from commit 1e7bf688967dc39540d24070c70c73b06bd1347f) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117640 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-06-22Resolves: tdf#140361 use the DisableEditHyperlink state as of menu launch timeCaolán McNamara
at context menu popup time set if the EditHyperlink entry should be disabled and use that state if queried about it if EditHyperlink is dispatched from the menu. So ignoring where the mouse currently happens to be when the menu was dismissed. The dispatch is done async, if at all, so also trigger an async Query with Invalidate so at least one Query is ensured to reset the stored state similar to tdf#137445 which was for impress/draw Change-Id: I43a144f1ac0a4db89cc5ab0ebeeae744719f5958 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117636 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-22tdf#142932: fix crash when pasting cells with comments+"skip empty cells"Julien Nabet
See bt here: https://bugs.documentfoundation.org/attachment.cgi?id=173011 4 0x00007fc4b0cdbb3d in ScColContainer::operator[](unsigned long) (this=0x872e1e0, nIndex=64) at sc/inc/colcontainer.hxx:43 5 0x00007fc4b120d82b in ScTable::DeleteBeforeCopyFromClip(sc::CopyFromClipContext&, ScTable const&, sc::ColumnSpanSet&) (this=0x872e1e0, rCxt=..., rClipTab=..., rBroadcastSpans=...) at sc/source/core/data/table7.cxx:118 6 0x00007fc4b0e42939 in ScDocument::DeleteBeforeCopyFromClip(sc::CopyFromClipContext&, ScMarkData const&, sc::ColumnSpanSet&) (this=0x3bffa60, rCxt=..., rMark=..., rBroadcastSpans=...) at sc/source/core/data/document10.cxx:75 7 0x00007fc4b0e0b67b in ScDocument::CopyFromClip(ScRange const&, ScMarkData const&, InsertDeleteFlags, ScDocument*, ScDocument*, bool, bool, bool, bool, ScRangeList const*) (this=0x3bffa60, rDestRange=..., rMark=..., nInsFlag=7, pRefUndoDoc=0x0, pClipDoc=0x7d3bb40, bResetCut=true, bAsLink=false, bIncludeFiltered=false, bSkipAttrForEmpty=true, pDestRanges=0x7fff4a3da4b0) at sc/source/core/data/document.cxx:2916 8 0x00007fc4b2412dc3 in ScViewFunc::PasteFromClip(InsertDeleteFlags, ScDocument*, ScPasteFunc, bool, bool, bool, InsCellCmd, InsertDeleteFlags, bool) (this= 0x41a29e0, nFlags=7, pClipDoc=0x7d3bb40, nFunction=ScPasteFunc::NONE, bSkipEmpty=true, bTranspose=false, bAsLink=false, eMoveMode=INS_NONE, nUndoExtraFlags=InsertDeleteFlags::NONE, bAllowDialogs=true) at sc/source/ui/view/viewfun3.cxx:1312 Change-Id: Ic119cb5d414a35a9ba18b0564d7adf83154eb9d7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117497 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit a6d269ed9478b20f611912bf9711c2683e7bc924) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117632 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-06-21tdf#142607 XLSX export: keep formatted dates in standard filterBalazs Varga
Do not convert the formatted string filter criteria values to 'double' if they are numbers (dates). Also export the equal relation criteria into XML_filters tag instead of XML_customFilters. Previously the formatted dates replaced with numbers in standard filter criteria, first during the export, and after the import, in the standard filter dialog window. Note: fix and optimize also filtering by formatted dates by allowing CanOptimizeQueryStringToNumber() to create double values for them. This unifies the same dates with different date formatting. Follow-up to commit 1f755525189884e4b2824889a6b9dea8933402db "tdf#142402 sc UI: store formatted values in standard filter". Change-Id: If4c22e8b0142720ccfda038f89367061058693aa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116566 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org> (cherry picked from commit 11cc770ad2af1f31c1e5c9512e5688dff38f009b) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117559 Tested-by: Jenkins
2021-06-20tdf#142873: Fix print preview zoom-out zoom-in buttonsJulien Nabet
.uno:ZoomOut has been renamed .uno:ZoomMinus .uno:ZoomIn has been renamed .uno:ZoomPlus Change-Id: I06e7e66550399e53032a0df39a98846982acba48 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117279 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com> (cherry picked from commit c21398066b6bf630070ed291456f2663e06d94b9) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117424
2021-06-19fix 32bit build of tiledrendering testsRene Engelhard
Squash of commits 49849a09e2823ac6edb42693daf7eac5312f2eb9 d7b9b9e8e02aefd61669e07543fc370b0c58207f Change-Id: I2f10b7bb37b05961f73fad9ee2e716ed8177d8ff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117474 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-16tidy up .uiCaolán McNamara
Change-Id: I7400a4994c57e4652daca6215385bfd8e4d46369 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117224 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-15Resolves tdf#142499 - Make fat cross cursor optionalHeiko Tietze
Change-Id: I9a9182f8783f951e49cdb8f897578f99281c25d1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116858 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> (cherry picked from commit 10ff27cc4f01693865599d24caf7ab80d95232e0) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117221 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-15button text should be Yes not yesCaolán McNamara
Change-Id: Ib92a1119046c79ce36968ad0814161ef7c4b0982 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117218 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-15ucalc_copypaste: improve readability and shortenscito
The tests are written in a simpler and shorter way. (The same, but 858 lines less.) I've transformed the code with several regex in VSCode. I've made a manual clean up at the end. The regex are listed below in the form *** search regex replace regex *** aString = m_pDoc->GetString\((\d+,\s*\d+,\s*\w+)\); \s*CPPUNIT_ASSERT_EQUAL\(OUString\("(.*)"\), aString\); CPPUNIT_ASSERT_EQUAL(OUString("$2"), m_pDoc->GetString($1)); *** m_pDoc->GetFormula\((\d+, \d+, \w+), \w+\); \s*CPPUNIT_ASSERT_EQUAL\(OUString\("(.*)"\), \w+\); CPPUNIT_ASSERT_EQUAL(OUString("$2"), getFormula($1)); *** m_pDoc->GetFormula\((\d+, \d+, \w+), \w+\); \s*CPPUNIT_ASSERT_EQUAL_MESSAGE\("(.+)", OUString\("(.+)"\), \w+\); CPPUNIT_ASSERT_EQUAL_MESSAGE("$2", OUString("$3"), getFormula($1)); *** ScAddress \w+\((\d+, \d+, \d+)\);(\s*//.+)? \s*ScPostIt\* \w+ = m_pDoc->GetOrCreateNote\(\w+\); \s*\w+->SetText\(\w+, "(.*)"\); setNote($1, "$3");$2 *** ScAddress (\w+)\((\d+, \d+, \d+)\);(\s*//.+)? \s*ScPostIt\* \w+ = m_pDoc->GetOrCreateNote\(\w+\); \s*\w+->SetText\(\w+, "(.*)"\); ScAddress $1 = setNote($2, "$4");$3 *** ScAddress (\w+)\((\d+, \d+, \w+)\);(\s*//.+)? \s*ScPostIt\* \w+ = m_pDoc->GetOrCreateNote\(\w+\); \s*\w+->SetText\(\w+, "(.*)"\); setNote($2, "$4");$3 *** m_pDoc->GetNote\(ScAddress\((\d+, \d+, (\d+|\w+))\)\) m_pDoc->GetNote($1) *** "There should be(\s+\w+) note on (\w+) "$2:$1 note *** HasNote\(ScAddress\((\d+, \d+, (\d+|\w+))\)\) HasNote($1) *** ASSERT_DOUBLES_EQUAL\((-?\d+), CPPUNIT_ASSERT_EQUAL($1.0, *** \w+ = m_pDoc->GetString\((\d+, \d+, (\d+|\w+))\); \s*CPPUNIT_ASSERT_EQUAL\(EMPTY_OUSTRING, \w+\); CPPUNIT_ASSERT_EQUAL(EMPTY_OUSTRING, m_pDoc->GetString()); *** \w+ = m_pDoc->GetString\((\d+, \d+, (\d+|\w+))\);(\s*//.*)? \s*CPPUNIT_ASSERT_EQUAL_MESSAGE\("(.+)", EMPTY_OUSTRING, \w+\); CPPUNIT_ASSERT_EQUAL_MESSAGE("$4", EMPTY_OUSTRING, m_pDoc->GetString($2));$3 *** fValue = m_pDoc->GetValue\((\d+, \d+, (\d+|\w+))\);(\s*//.*)? \s*ASSERT_DOUBLES_EQUAL_MESSAGE\("(.*)", (-?\d+), fValue\); CPPUNIT_ASSERT_EQUAL_MESSAGE("$4", $5.0, m_pDoc->GetValue($1)); *** fValue = m_pDoc->GetValue\((\d+, \d+, (\d+|\w+))\);(\s*//.*)? \s*CPPUNIT_ASSERT_EQUAL\((-?\d+(\.0)?), fValue\); CPPUNIT_ASSERT_EQUAL($4, m_pDoc->GetValue($1));$3 *** m_pDoc->GetFormula\((\d+, \d+, \w+), \w+\);(\s*//.*)? \s*CPPUNIT_ASSERT_EQUAL_MESSAGE\("(.+)", OUString\("(.+)"\), \w+\); CPPUNIT_ASSERT_EQUAL_MESSAGE("$3", OUString("$4"), getFormula($1)); *** aStr = m_pDoc->GetString\((\d+, \d+, \w+)\);(\s*//.*)? \s*CPPUNIT_ASSERT_EQUAL_MESSAGE\("(.*)", OUString\("(.*)"\), aStr\); CPPUNIT_ASSERT_EQUAL_MESSAGE("$3", OUString("$4"), m_pDoc->GetString($1)); *** m_pDoc->GetNote\((\d+, \d+, (\d+|\w+))\)->GetText\(\) getNote($1) *** Change-Id: I4000b7f89a0bee1d2d52abfd6c1b055470e39d02 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117174 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-06-14Assert on valid order of which ids in ranges on SfxItemSet creationMike Kaganski
This allows to make sure we actually use sorted which ranges, and then it's safe to call SfxItemSet::MergeRange when needed. Also this change relaxes the previous requirement that ranges must be separated by at least one; this allows to have adjacent ranges, like in RES_FRMATR_BEGIN, RES_FRMATR_END-1, RES_GRFATR_BEGIN, RES_GRFATR_END-1, where RES_FRMATR_END is equal to RES_GRFATR_BEGIN. Allowing this makes possible to (1) self-document the ranges, so it's clear which ranges are included; and (2) be safe in case when these constants would change, so that the one merged range would not unexpectedly contain everything inserted between RES_FRMATR_END and RES_GRFATR_BEGIN. Change-Id: Iaad0f099b85059b3aa318a347aa7fbd3f6d455c7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116909 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit 8aaa28ed43978a9a4a20d62368410a57ec05c23f) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117114
2021-06-12tdf#128018 - Add column/row labels to the descriptive statisticsAndreas Heinisch
Change-Id: I22840433954a217ef5b5c1d3ea20e935d322e767 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116852 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
generated by cgit (git 2.34.1) at 2024-06-25 16:13:13 +0000