summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)Author
2015-01-24coverity#265794 Dereference null return valueCaolán McNamara
Change-Id: Id0762974d12cd7bc7c2bb1ba64b3bf369418bedb
2015-01-23Resolves: fdo#75565 reduce block on pasting rtf like we do for htmlCaolán McNamara
Change-Id: I74a9748a2e4981dc5d1677f06db7eceed9e4b108
2015-01-23Hold ScHeaderFooterContentObj by rtl::ReferenceStephan Bergmann
...there appears to be no good reason not to (it's a UNO implementation, deriving from WeakImplHelper), and witnessed at least one JunitTest_sc_unoapi failure where an incoming URP call on ScHeaderFooterTextObj::getString obtained an apparently dangling ScHeaderFooterContentObj& rContentObj = aTextData.GetContentObj() that pointed to garbage. Change-Id: I51a2a03ded18509ee61488d96bd30a6d364825d7
2015-01-23Resolves: fdo#88735 crash after calling sort after subtotal removalCaolán McNamara
Change-Id: Ia30271426ea47b7bf5af85d16591a02e6d52b3d9
2015-01-23sal: try to avoid abuse of OUStringBuffer(int) ctorMichael Stahl
... to avoid bugs like commit f0d6e0e1e21afd0adf5bd01d771b2d83d8f13a48. Change-Id: I1e41d421609e09bf62a7a04ba34f3a8e8d118fd3
2015-01-23Use symbolic (not numeric) opcodes in the registry for the OpenCL use subsetTor Lillqvist
Makes it easier to edit them manually directly in the registry files. (Something end-users are of course not expected to do, but admins or hackers may want to do.) Also guards against the possibility of the numeric values of the opcodes being changed. I figured out how to do the mapping from symbolic names to enum values and back without an ScDocument, turned out it was not complicated after all. Change-Id: I8bd97f256f7d777162c1b629bf82285544e86d70
2015-01-22Resolves: fdo#88721 correct negated condition in range name validationEike Rathke
Fallout of 72b9dd277bab328c4d9227439e27e8c29b43fa7d String to OUString conversion. Change-Id: I89a90da11790efba9e8ce4c9464dfca50b08c3ce
2015-01-22Resolves: fdo#88455 delete in empty data field crashesCaolán McNamara
Change-Id: I399bf576fe89283f839842959f06b8fe83f13b2b
2015-01-22Forgot theseTor Lillqvist
Change-Id: Ie4ecb334666587d25b94d8bf2b1a9fe60d03d232
2015-01-22Make it obvious that this functions is for a very specific use onlyTor Lillqvist
Change-Id: I53ad45fef0e17ce15a500959206b9b042e550e49
2015-01-22Make FormulaGroupInterpreter::enableOpenCL() enable it as eagerly as possibleTor Lillqvist
It is only called from sc/qa/unit/opencl-test.cxx anyway, and there it is presumably intended to make OpenCL be used whenever at all possible, with no requirements on which opcodes are used in a formula or the size of the formula group. Change-Id: Ib8a28dfa15794374e849aa1cdcc5288ef8aa017e
2015-01-22Bin useless AMLOEXT commentsTor Lillqvist
Change-Id: Ia9af98d580a694c2b8c5dae213d443d94c143091
2015-01-22Don't output idiotic comments in the generated OpenCLTor Lillqvist
We don't want silly non-informative comments in our C++ code. It is even more pointless to put them into generated OpenCL code. Change-Id: I89afc7234807a3ec5379c5d55a2ea8d52bde7600
2015-01-21add has-focus .ui supportCaolán McNamara
Change-Id: Ifd95d9fa74f6cbba989c05aae2a225a85b78c9f1
2015-01-21fdo #88578: Focus on first checkbox when showing calc paste special dialogThomas Viehmann
Change-Id: Ic0d82c710c09a099329fa76e2fb81c6c8613b334 Reviewed-on: https://gerrit.libreoffice.org/14071 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-01-21callcatcher: update unused codeCaolán McNamara
Change-Id: I225cbb3a4a66a8f20bec91c4770ad78e72b663b1
2015-01-20it's unnecessary to obtain the marked object in move mode, fdo#88339 followupEike Rathke
... just to determine there's nothing to do in that case. Change-Id: Ic962a5420afc5216e750b7fb578a4844ab6fc54a
2015-01-20change assert() to SAL_WARN_IF()Eike Rathke
It's a valid condition in some cases. Change-Id: I9c9bbcf0b506a88f89e4a420dd544e4bc6502e58
2015-01-20Make the RAND() and RANDBETWEEN() Calc functions non-random when requestedTor Lillqvist
We don't want such a mode to affect other uses of randomness, though. Thus use a separate random number generator object for these two functions, and use a fixed seed for it if the SC_RAND_REPEATABLE environment variable is set. As RAND() is implemented in sc, and RANDBETWEEN() is implemented in scaddins, it was a bit hard to figure out where to add the new functions needed, without having to over-engineer things with UNO. (This functionality is totally Calc-specific, but neither sc nor scaddins has any public (non-UNO) API.) Caolan suggested the formula module, which seems like a good enough place to me. Change-Id: I4b0cb327392e51a18bce28478af91b0174d6b726
2015-01-20fdo#88547 allow inline date-arrays for array functionsWinfried Donkers
Change-Id: I090633944f6514964949566ffe94038b565abff4 Reviewed-on: https://gerrit.libreoffice.org/14019 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2015-01-20fdo#88623 replace std::deque with std::vector in xlsx savingLászló Németh
Change-Id: I0b9c44b405e2c617c60e11a1a15eaeb867cba57e
2015-01-20Drop unused comphelper::service_decl::component_getFactoryHelper paramsStephan Bergmann
Change-Id: Ia47c0bc3539ddf8f925cd053a2431c742c46d337
2015-01-20Some more loplugin:cstylecast: scStephan Bergmann
Change-Id: I75adf1973083a6f4519133f9e97ad83fd7d8658a
2015-01-19in COUNT() use ConvertStringToValue() for literal string argumentsEike Rathke
... to evaluate the string conversion configuration, instead of the hard coded locale dependent IsNumberFormat() This only for literals, not referenced cell values. Change-Id: I774b52f1e258294014d8ea6a62374dd1d262f022
2015-01-19add a comment about string conversion configurationEike Rathke
Change-Id: I7d939088a433e07195935ac7b8350b0030eb29b2
2015-01-19fdo#88339 Fixed Calc constrained image movementTrent MacAlpine
Change-Id: Id4143e0a8410e6a9589f941c2bda83074eaf4844 Reviewed-on: https://gerrit.libreoffice.org/13975 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-01-18rename AddRange to SetRangeMarkus Mohrhard
Change-Id: I696fcbd2896aefda38314457b6838874262ad111
2015-01-18remove duplicated codeMarkus Mohrhard
Change-Id: I7c125bd27f5662b2f5bbcafb51aebdac9e272d08
2015-01-18add warning for empty conditional format rangesMarkus Mohrhard
Change-Id: I54a87b8cf6ffc48f8e850379aebb4abba7a327b5
2015-01-17rhbz#1136013: svx: try to make the ExternalToolEdit not crash all the timeMichael Stahl
This thing was starting a timer that re-starts itself forever, and when the file it was watching changed, it would just assume the drawing objects were still there (and the document, for that matter...) Change-Id: I35f187f0828097a05618dc1733dce819fc6bffc6
2015-01-16Use 1/100mm map mode for rendering edit text objects.Kohei Yoshida
Change-Id: I0c82088342085c1b7d9aa3c6009684bc58a9fd21
2015-01-16Get texts to scale correctly with zoom.Kohei Yoshida
We need to set scaling factors to device's map mode *only* for the texts. Calc handles scaling for all the rest. Interesting how it works. Change-Id: Ia6aa122961ea5ddc2e31eacb28392f3e355a5ebf
2015-01-16Multiply tile position by the zoom level.Kohei Yoshida
With this, the tiles get rendered correctly at varying zoom levels. Change-Id: Id5ca18e363dfdb143af1685be96af2f3c3514ea9
2015-01-16don't access empty range list, could be rhbz#1180312Eike Rathke
ScRangeList::DeleteArea() may remove an entire range, if it was the last range a subsequent call to ScConditionalFormat::DeleteArea() would attempt to access an invalid first element. Change-Id: I8d68c27963dc8561d61a94980093c271bd3aaffb
2015-01-16replace decrementing loop with -=Eike Rathke
This could save a million iterations ... Change-Id: I44fb228b951580bbeb5df5f6ec7be933077776ff
2015-01-16Correctly offset based on tile position.Kohei Yoshida
This works well at 100% zoom, but the offsets are still not correct at zoom levels other than 100%. Change-Id: I301362b00ca916410b69f39aa58ed871ce177d88
2015-01-16Add SAL_INFO messages for OpenCL buffers createdTor Lillqvist
Change-Id: Ib226d7ec13bc64ee6d32fab3c3f6cecc4eb8b151
2015-01-16Explain what the function doesTor Lillqvist
Change-Id: I2179a81b5ce83beea491b86469c5b8ba232fdd15
2015-01-16remove unnecessary parenthesesNoel Grandin
left over from "SVStream operator>> to Write method" conversion Change-Id: I619eb743d7890d5c70d0a94e51ce263567fa6f3b
2015-01-15fdo#88398: Handle group listeners correctly when splitting formula group.Kohei Yoshida
It's basically the same thing we do in ScDocument::DeleteArea(), implemented in ScDocument::SetValue() and SetString(). Change-Id: Ifcae31aaef0e00ed8659aa5e2b9b8e206dc1a099
2015-01-15fdo#88398: Re-enable formula group listeners.Kohei Yoshida
Change-Id: I1e5e9d50af471bc0e63f0d39478d96bf479583d5
2015-01-15silence -Werror,-Wunused-variableCaolán McNamara
Change-Id: Iaea31af5b7e41367b59fe02d523bcb7e08a8e0fc
2015-01-15add unit test for fdo#88398Eike Rathke
Check that grouped area listeners aren't discarded when unsharing a grouped formula. Change-Id: Ic3d3e9acb5b97d927a85ca433de127dd3b74a30c
2015-01-15fdo#88398 disable grouped listeners for nowEike Rathke
Further implementation is needed to re-establish grouped listeners after unshare and split. Change-Id: I861b3f9d63a611ab0e32918ce1b272121bf12988
2015-01-15Revert "fdo#88157 Remove misused frames from 4 of n dialogs"Caolán McNamara
This reverts commit 8c291bb13335fc73785eab2bba81b37a5161d6b4 because a pile of stuff then crashes, its not sufficient to remove things from .ui files if there are still used but the cxx. e.g. opencl options page Change-Id: Ice608af7e4a3f7798183a45602715ab04afbc87a
2015-01-14Comment these out for now. We'll use them later.Kohei Yoshida
Change-Id: I7e6afeea9368241bea8af141726e73c557475317
2015-01-14Add TODO. Text rendering is still weird.Kohei Yoshida
Change-Id: I2da98a82f2d2407f48960a4e53643cee63b4844d
2015-01-14Adjust zoom level for different output tile size.Kohei Yoshida
Change-Id: I54b9f3ca66035b66509c960ca79391446ecf8778
2015-01-14Set correct grid color.Kohei Yoshida
Change-Id: Ie8ccf61f0b04b718c930b14374843e3858c6278b
2015-01-14Tiled rendering, first cut.Kohei Yoshida
Very simple, without zooming. Change-Id: Ia5bd5c02dab3eedbaad07ebd81c4d7fe3c6a00c1